* Re: [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 9:40 [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase Chris Wilson
@ 2018-06-01 10:05 ` Mika Kuoppala
2018-06-01 10:09 ` Chris Wilson
2018-06-01 10:47 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Mika Kuoppala @ 2018-06-01 10:05 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> As we store the intel_context on the request (rq->hw_context), we can
> simply compare that against the local intel_context for the
> i915->kernel_context rather than using the rq->gem_context.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 81f086397d10..94e4db1870aa 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -610,7 +610,7 @@ static bool engine_has_kernel_context_barrier(struct intel_engine_cs *engine)
>
> any_active = true;
>
> - if (rq->gem_context == i915->kernel_context)
> + if (rq->hw_context == ce)
We lose a little bit of readability due to that 'ce'.
But the function is compact enough so that it shows it's
nature in one eyeful. Tho you could introduce 'kec' :)
With or without,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> continue;
>
> /*
> --
> 2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 10:05 ` Mika Kuoppala
@ 2018-06-01 10:09 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-06-01 10:09 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-06-01 11:05:18)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > As we store the intel_context on the request (rq->hw_context), we can
> > simply compare that against the local intel_context for the
> > i915->kernel_context rather than using the rq->gem_context.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> > index 81f086397d10..94e4db1870aa 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> > @@ -610,7 +610,7 @@ static bool engine_has_kernel_context_barrier(struct intel_engine_cs *engine)
> >
> > any_active = true;
> >
> > - if (rq->gem_context == i915->kernel_context)
> > + if (rq->hw_context == ce)
>
> We lose a little bit of readability due to that 'ce'.
> But the function is compact enough so that it shows it's
> nature in one eyeful. Tho you could introduce 'kec' :)
kce; almost but ce is being used everywhere else so I hope the
familiarity will make it easier.
Not that ce is a great shorthand for intel_context; so if you have a
good idea for that, as I plan to make them more prevalent that would be
useful.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 9:40 [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase Chris Wilson
2018-06-01 10:05 ` Mika Kuoppala
@ 2018-06-01 10:47 ` Patchwork
2018-06-01 11:54 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-01 10:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check intel_contexts to avoid one extra pointer chase
URL : https://patchwork.freedesktop.org/series/44077/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4269 -> Patchwork_9168 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9168 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9168, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44077/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9168:
=== IGT changes ===
==== Possible regressions ====
igt@debugfs_test@read_all_entries:
fi-bdw-gvtdvm: PASS -> DMESG-WARN +2
== Known issues ==
Here are the changes found in Patchwork_9168 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@drv_module_reload@basic-reload-inject:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-skl-6700k2: INCOMPLETE (fdo#104108, fdo#105524, k.org#199541) -> PASS
igt@kms_busy@basic-flip-c:
fi-glk-j4005: FAIL (fdo#103182) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106097, fdo#106000) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: FAIL (fdo#104724, fdo#103191) -> PASS
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103182 https://bugs.freedesktop.org/show_bug.cgi?id=103182
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541
== Participating hosts (43 -> 39) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-skl-gvtdvm fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4269 -> Patchwork_9168
CI_DRM_4269: 25dda01a94cbf70d599be9b0f74c61f310858fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4503: ae0ea2a0cff1cf8516d18ada5b9db01c56b73ed9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9168: 8b45013b3f3400b2d567b583dde377485e0c45a9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8b45013b3f34 drm/i915: Check intel_contexts to avoid one extra pointer chase
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9168/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 9:40 [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase Chris Wilson
2018-06-01 10:05 ` Mika Kuoppala
2018-06-01 10:47 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-06-01 11:54 ` Patchwork
2018-06-01 12:54 ` [PATCH] " Chris Wilson
2018-06-01 13:19 ` ✗ Fi.CI.IGT: failure for " Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-01 11:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check intel_contexts to avoid one extra pointer chase
URL : https://patchwork.freedesktop.org/series/44077/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4269 -> Patchwork_9170 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44077/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9170 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
fi-bdw-gvtdvm: PASS -> DMESG-WARN (fdo#105600) +2
igt@drv_module_reload@basic-reload:
fi-ilk-650: PASS -> DMESG-WARN (fdo#106387) +2
igt@gem_exec_reloc@basic-cpu-read-active:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#105719)
igt@gem_exec_suspend@basic-s3:
fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-skl-gvtdvm: PASS -> INCOMPLETE (fdo#105600, fdo#104108)
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)
igt@kms_frontbuffer_tracking@basic:
fi-bsw-n3050: PASS -> INCOMPLETE (fdo#106729)
==== Possible fixes ====
igt@drv_module_reload@basic-reload-inject:
fi-glk-j4005: DMESG-WARN (fdo#106248, fdo#106725) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-skl-6700k2: INCOMPLETE (fdo#104108, k.org#199541, fdo#105524) -> PASS
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106000, fdo#106097) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-kbl-7567u: FAIL (fdo#103191, fdo#104724) -> PASS
==== Warnings ====
igt@kms_busy@basic-flip-c:
fi-glk-j4005: FAIL (fdo#103182) -> DMESG-WARN (fdo#106000)
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103182 https://bugs.freedesktop.org/show_bug.cgi?id=103182
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106729 https://bugs.freedesktop.org/show_bug.cgi?id=106729
k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541
== Participating hosts (43 -> 39) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-bxt-dsi fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4269 -> Patchwork_9170
CI_DRM_4269: 25dda01a94cbf70d599be9b0f74c61f310858fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4503: ae0ea2a0cff1cf8516d18ada5b9db01c56b73ed9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9170: e91b5b041f618c914f044faa582fb5e4e7b70cc7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e91b5b041f61 drm/i915: Check intel_contexts to avoid one extra pointer chase
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9170/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 9:40 [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase Chris Wilson
` (2 preceding siblings ...)
2018-06-01 11:54 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-06-01 12:54 ` Chris Wilson
2018-06-01 13:19 ` ✗ Fi.CI.IGT: failure for " Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-06-01 12:54 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2018-06-01 10:40:02)
> As we store the intel_context on the request (rq->hw_context), we can
> simply compare that against the local intel_context for the
> i915->kernel_context rather than using the rq->gem_context.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Pushed the pair of switch-to-kernel-context related patches, thanks for
the review.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: Check intel_contexts to avoid one extra pointer chase
2018-06-01 9:40 [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase Chris Wilson
` (3 preceding siblings ...)
2018-06-01 12:54 ` [PATCH] " Chris Wilson
@ 2018-06-01 13:19 ` Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-01 13:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check intel_contexts to avoid one extra pointer chase
URL : https://patchwork.freedesktop.org/series/44077/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4269_full -> Patchwork_9168_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9168_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9168_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44077/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9168_full:
=== IGT changes ===
==== Possible regressions ====
igt@drv_missed_irq:
shard-glk: PASS -> FAIL
==== Warnings ====
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: PASS -> SKIP +1
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9168_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@drv_selftest@live_hangcheck:
shard-apl: PASS -> DMESG-FAIL (fdo#106560)
igt@gem_eio@suspend:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-glk: PASS -> FAIL (fdo#105703)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: PASS -> FAIL (fdo#102887)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103822)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL (fdo#105347) -> PASS
igt@kms_cursor_legacy@flip-vs-cursor-legacy:
shard-hsw: FAIL (fdo#102670) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
shard-hsw: FAIL (fdo#103060) -> PASS
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: FAIL (fdo#104724, fdo#103822) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
==== Warnings ====
igt@gem_eio@hibernate:
shard-snb: INCOMPLETE (fdo#105411) -> FAIL (fdo#105957)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4269 -> Patchwork_9168
CI_DRM_4269: 25dda01a94cbf70d599be9b0f74c61f310858fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4503: ae0ea2a0cff1cf8516d18ada5b9db01c56b73ed9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9168: 8b45013b3f3400b2d567b583dde377485e0c45a9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9168/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread