[PATCH] ASoC: twl6040: remove duplicated remove callback

[PATCH] ASoC: twl6040: remove duplicated remove callback

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

We don't need 2 .remove callback

Fixes: 7480389fb0d8 ("ASoC: twl6040: replace codec to component")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/codecs/twl6040.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index b56a647..bfd1abd 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -1158,7 +1158,6 @@ static void twl6040_remove(struct snd_soc_component *component)
 	.remove			= twl6040_remove,
 	.read			= twl6040_read,
 	.write			= twl6040_write,
-	.remove			= twl6040_remove,
 	.set_bias_level		= twl6040_set_bias_level,
 	.controls		= twl6040_snd_controls,
 	.num_controls		= ARRAY_SIZE(twl6040_snd_controls),
-- 
1.9.1

Re: [PATCH] ASoC: twl6040: remove duplicated remove callback

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 1090 bytes --]

On Mon, Mar 19, 2018 at 07:50:48AM +0000, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> We don't need 2 .remove callback

Copying in Peter.

> 
> Fixes: 7480389fb0d8 ("ASoC: twl6040: replace codec to component")
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/codecs/twl6040.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
> index b56a647..bfd1abd 100644
> --- a/sound/soc/codecs/twl6040.c
> +++ b/sound/soc/codecs/twl6040.c
> @@ -1158,7 +1158,6 @@ static void twl6040_remove(struct snd_soc_component *component)
>  	.remove			= twl6040_remove,
>  	.read			= twl6040_read,
>  	.write			= twl6040_write,
> -	.remove			= twl6040_remove,
>  	.set_bias_level		= twl6040_set_bias_level,
>  	.controls		= twl6040_snd_controls,
>  	.num_controls		= ARRAY_SIZE(twl6040_snd_controls),
> -- 
> 1.9.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: twl6040: remove duplicated remove callback

[Peter Ujfalusi]

On 2018-03-19 09:50, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> We don't need 2 .remove callback
> 
> Fixes: 7480389fb0d8 ("ASoC: twl6040: replace codec to component")
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
>  sound/soc/codecs/twl6040.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
> index b56a647..bfd1abd 100644
> --- a/sound/soc/codecs/twl6040.c
> +++ b/sound/soc/codecs/twl6040.c
> @@ -1158,7 +1158,6 @@ static void twl6040_remove(struct snd_soc_component *component)
>  	.remove			= twl6040_remove,
>  	.read			= twl6040_read,
>  	.write			= twl6040_write,
> -	.remove			= twl6040_remove,
>  	.set_bias_level		= twl6040_set_bias_level,
>  	.controls		= twl6040_snd_controls,
>  	.num_controls		= ARRAY_SIZE(twl6040_snd_controls),
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Applied "ASoC: twl6040: remove duplicated remove callback" to the asoc tree

[Mark Brown]

The patch

   ASoC: twl6040: remove duplicated remove callback

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 83eca9f5eda6efff71515cb9c1a373b26d2d4c5b Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Mon, 19 Mar 2018 07:50:48 +0000
Subject: [PATCH] ASoC: twl6040: remove duplicated remove callback

We don't need 2 .remove callback

Fixes: 7480389fb0d8 ("ASoC: twl6040: replace codec to component")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/twl6040.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index b56a6471f9c4..bfd1abd72253 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -1158,7 +1158,6 @@ static const struct snd_soc_component_driver soc_component_dev_twl6040 = {
 	.remove			= twl6040_remove,
 	.read			= twl6040_read,
 	.write			= twl6040_write,
-	.remove			= twl6040_remove,
 	.set_bias_level		= twl6040_set_bias_level,
 	.controls		= twl6040_snd_controls,
 	.num_controls		= ARRAY_SIZE(twl6040_snd_controls),
-- 
2.16.2