ath6kl: Remove old 802.11a-only channels

ath6kl: Remove old 802.11a-only channels

[Rostyslav Khudolii]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hi Kalle,

Following our conversation ("AR6003 5.2GHz AP on channel 38") on the
mailing list, sending a patch which removes channels 34/38/42/46 from
ath6kl driver.

Regards,
Rostyslav

[-- Attachment #2: 0001-ath6kl-Remove-old-802.11a-only-channels.patch --]
[-- Type: application/octet-stream, Size: 1315 bytes --]

From 43b0a03e41913919046e72e8d7d7ba3d928e1987 Mon Sep 17 00:00:00 2001
From: Rostyslav Khudolii <rkhudolii@airtame.com>
Date: Tue, 7 Mar 2017 11:10:31 +0100
Subject: [PATCH] ath6kl: Remove old 802.11a-only channels

Channels 34/38/42/46 can only be used for compatibility with
old devices sold in Japan. Modern products, such as AR6003/AR6004
don't support these channels.
Keeping them in the upstream is error prone and requires full
network stack support.
A custom patch should be used in case such compatibility is required.
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 363b30a..aae65ce 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -102,10 +102,8 @@ static struct ieee80211_channel ath6kl_2ghz_channels[] = {
 };
 
 static struct ieee80211_channel ath6kl_5ghz_a_channels[] = {
-	CHAN5G(34, 0), CHAN5G(36, 0),
-	CHAN5G(38, 0), CHAN5G(40, 0),
-	CHAN5G(42, 0), CHAN5G(44, 0),
-	CHAN5G(46, 0), CHAN5G(48, 0),
+	CHAN5G(36, 0), CHAN5G(40, 0),
+	CHAN5G(44, 0), CHAN5G(48, 0),
 	CHAN5G(52, 0), CHAN5G(56, 0),
 	CHAN5G(60, 0), CHAN5G(64, 0),
 	CHAN5G(100, 0), CHAN5G(104, 0),
-- 
2.9.3

Re: ath6kl: Remove old 802.11a-only channels

[Valo, Kalle]

Rostyslav Khudolii <rkhudolii@airtame.com> writes:

> Following our conversation ("AR6003 5.2GHz AP on channel 38") on the
> mailing list, sending a patch which removes channels 34/38/42/46 from
> ath6kl driver.

No attachments, please. The best is to use 'git send-email' to submit
patches.

Also read the documentation as Signed-off-by line is missing.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes

--=20
Kalle Valo=

Re: ath6kl: Remove old 802.11a-only channels

[Kalle Valo]

Rostyslav Khudolii <rkhudolii@airtame.com> wrote:
> Channels 34/38/42/46 can only be used for compatibility with old devices sold
> in Japan. Modern products, such as AR6003/AR6004 don't support these channels.
> Keeping them in the upstream is error prone and requires full network stack
> support.  A custom patch should be used in case such compatibility is required.
> 
> Without this one, a user is able to start an AP using wpa_supplicant, for
> example, on one of these channels (34/38/42/46), without getting any
> warning/error from the cfg80211 or ath6kl - which is correct (since these
> channels match regdom rules). However, the AR6003 and its firmware (we're using
> v3.4.0.225) will fail and return "WMI_CMDERROR_EVENTID" with "INVALID_PARAM"
> error code.
> 
> Signed-off-by: Rostyslav Khudolii <rkhudolii@airtame.com>
> Cc: Attila Sukosd <attila@airtame.com>

Patch applied to ath-next branch of ath.git, thanks.

b51040fc375c ath6kl: Remove old 802.11a-only channels

-- 
https://patchwork.kernel.org/patch/9615199/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: ath6kl: Remove old 802.11a-only channels

[Rostyslav Khudolii]

On 16 March 2017 at 10:36, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Rostyslav Khudolii <rkhudolii@airtame.com> wrote:
>> Channels 34/38/42/46 can only be used for compatibility with
>> old devices sold in Japan. Modern products, such as AR6003/AR6004
>> don't support these channels.
>> Keeping them in the upstream is error prone and requires full
>> network stack support.
>> A custom patch should be used in case such compatibility is required.
>>
>> Signed-off-by: Rostyslav Khudolii <rkhudolii@airtame.com>
>> Cc: Attila Sukosd <attila@airtame.com>
>
> For some reason the patch didn't apply to ath.git, I had manually recreate it.
> Please review carefully that the patch is correct now:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cd63adf640e39c2ba013cba91b29700f3f593b9c
>
> Also I added your description of the bug to the commit log.
>
> --
> https://patchwork.kernel.org/patch/9615199/
>
> Documentation about submitting wireless patches and checking status
> from patchwork:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

It's correct.

Re: ath6kl: Remove old 802.11a-only channels

[Kalle Valo]

Rostyslav Khudolii <rkhudolii@airtame.com> wrote:
> Channels 34/38/42/46 can only be used for compatibility with
> old devices sold in Japan. Modern products, such as AR6003/AR6004
> don't support these channels.
> Keeping them in the upstream is error prone and requires full
> network stack support.
> A custom patch should be used in case such compatibility is required.
> 
> Signed-off-by: Rostyslav Khudolii <rkhudolii@airtame.com>
> Cc: Attila Sukosd <attila@airtame.com>

For some reason the patch didn't apply to ath.git, I had manually recreate it.
Please review carefully that the patch is correct now:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cd63adf640e39c2ba013cba91b29700f3f593b9c

Also I added your description of the bug to the commit log.

-- 
https://patchwork.kernel.org/patch/9615199/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches