* [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
@ 2017-02-06 7:46 ` changbin.du
2017-02-06 12:00 ` Jani Nikula
2017-02-06 7:46 ` [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du
` (3 subsequent siblings)
4 siblings, 1 reply; 17+ messages in thread
From: changbin.du @ 2017-02-06 7:46 UTC (permalink / raw)
To: mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel, Changbin Du
From: Changbin Du <changbin.du@intel.com>
Prompt user how to quickly jump to the item he/she is interested in.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
scripts/kconfig/mconf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 315ce2c..23d5681 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -443,10 +443,10 @@ static void search_conf(void)
res = get_relations_str(sym_arr, &head);
set_subtitle();
- dres = show_textbox_ext(_("Search Results"), (char *)
- str_get(&res), 0, 0, keys, &vscroll,
- &hscroll, &update_text, (void *)
- &data);
+ dres = show_textbox_ext(
+ _("Search Results (type the number to jump)"),
+ (char *)str_get(&res), 0, 0, keys, &vscroll,
+ &hscroll, &update_text, (void *)&data);
again = false;
for (i = 0; i < JUMP_NB && keys[i]; i++)
if (dres == keys[i]) {
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
2017-02-06 7:46 ` [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
@ 2017-02-06 12:00 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-02-06 12:00 UTC (permalink / raw)
To: changbin.du, mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel, Changbin Du
On Mon, 06 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
:o
All these years. I... I didn't know. Thanks!
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
It would be even better and discoverable if this could be turned into a
dialog menu, so that you could navigate the search results using arrow
keys and hit enter to choose. But this is already an improvement.
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
@ 2017-02-06 12:00 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-02-06 12:00 UTC (permalink / raw)
To: changbin.du, mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel
On Mon, 06 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
:o
All these years. I... I didn't know. Thanks!
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
It would be even better and discoverable if this could be turned into a
dialog menu, so that you could navigate the search results using arrow
keys and hit enter to choose. But this is already an improvement.
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
2017-02-06 12:00 ` Jani Nikula
(?)
@ 2017-02-07 3:10 ` Du, Changbin
-1 siblings, 0 replies; 17+ messages in thread
From: Du, Changbin @ 2017-02-07 3:10 UTC (permalink / raw)
To: Jani Nikula
Cc: mmarek, corbet, yann.morin.1998, linux-kbuild, linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Mon, Feb 06, 2017 at 02:00:51PM +0200, Jani Nikula wrote:
> On Mon, 06 Feb 2017, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > Prompt user how to quickly jump to the item he/she is interested in.
>
> :o
>
> All these years. I... I didn't know. Thanks!
>
aha, me too! You know, back to the top menu then look into step by
step...
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> > scripts/kconfig/mconf.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> > index 315ce2c..23d5681 100644
> > --- a/scripts/kconfig/mconf.c
> > +++ b/scripts/kconfig/mconf.c
> > @@ -443,10 +443,10 @@ static void search_conf(void)
> >
> > res = get_relations_str(sym_arr, &head);
> > set_subtitle();
> > - dres = show_textbox_ext(_("Search Results"), (char *)
> > - str_get(&res), 0, 0, keys, &vscroll,
> > - &hscroll, &update_text, (void *)
> > - &data);
> > + dres = show_textbox_ext(
> > + _("Search Results (type the number to jump)"),
> > + (char *)str_get(&res), 0, 0, keys, &vscroll,
> > + &hscroll, &update_text, (void *)&data);
>
> It would be even better and discoverable if this could be turned into a
> dialog menu, so that you could navigate the search results using arrow
> keys and hit enter to choose. But this is already an improvement.
>
Yes, that will have a better experience. :)
> > again = false;
> > for (i = 0; i < JUMP_NB && keys[i]; i++)
> > if (dres == keys[i]) {
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Thanks,
Changbin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/2] Documentation/kconfig: add search jump feature description
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
2017-02-06 7:46 ` [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
@ 2017-02-06 7:46 ` changbin.du
2017-02-06 14:42 ` Jim Davis
2017-02-08 3:09 ` [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
` (2 subsequent siblings)
4 siblings, 1 reply; 17+ messages in thread
From: changbin.du @ 2017-02-06 7:46 UTC (permalink / raw)
To: mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel, Changbin Du
From: Changbin Du <changbin.du@intel.com>
Kernel menuconfig support direct jumping function from the search
result. This is a very convenient feature but not documented. So
add a short description to the kconfig documentation to let more
developer know it.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
Documentation/kbuild/kconfig.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
index bbc99c0..9916318 100644
--- a/Documentation/kbuild/kconfig.txt
+++ b/Documentation/kbuild/kconfig.txt
@@ -178,6 +178,10 @@ Searching in menuconfig:
first (and in alphabetical order), then come all other symbols,
sorted in alphabetical order.
+ In the search result textbox, each symbol has a jump number on
+ left side if the symbol is jumpable. You can type the nubmer
+ to jump to target menu to configurate that symbol.
+
______________________________________________________________________
User interface options for 'menuconfig'
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description
2017-02-06 7:46 ` [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du
@ 2017-02-06 14:42 ` Jim Davis
2017-02-07 3:06 ` Du, Changbin
0 siblings, 1 reply; 17+ messages in thread
From: Jim Davis @ 2017-02-06 14:42 UTC (permalink / raw)
To: changbin.du
Cc: Michal Marek, Jonathan Corbet, yann.morin.1998, linux-kbuild,
linux-doc, linux-kernel
On Mon, Feb 6, 2017 at 12:46 AM, <changbin.du@intel.com> wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Kernel menuconfig support direct jumping function from the search
> result. This is a very convenient feature but not documented. So
> add a short description to the kconfig documentation to let more
> developer know it.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> Documentation/kbuild/kconfig.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
> index bbc99c0..9916318 100644
> --- a/Documentation/kbuild/kconfig.txt
> +++ b/Documentation/kbuild/kconfig.txt
> @@ -178,6 +178,10 @@ Searching in menuconfig:
> first (and in alphabetical order), then come all other symbols,
> sorted in alphabetical order.
>
> + In the search result textbox, each symbol has a jump number on
> + left side if the symbol is jumpable. You can type the nubmer
number ("jumpable" reads a bit oddly, but it is understandable.)
> + to jump to target menu to configurate that symbol.
configure?
--
Jim
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description
2017-02-06 14:42 ` Jim Davis
@ 2017-02-07 3:06 ` Du, Changbin
0 siblings, 0 replies; 17+ messages in thread
From: Du, Changbin @ 2017-02-07 3:06 UTC (permalink / raw)
To: Jim Davis
Cc: Michal Marek, Jonathan Corbet, yann.morin.1998, linux-kbuild,
linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
On Mon, Feb 06, 2017 at 07:42:11AM -0700, Jim Davis wrote:
> On Mon, Feb 6, 2017 at 12:46 AM, <changbin.du@intel.com> wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > Kernel menuconfig support direct jumping function from the search
> > result. This is a very convenient feature but not documented. So
> > add a short description to the kconfig documentation to let more
> > developer know it.
> >
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> > Documentation/kbuild/kconfig.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
> > index bbc99c0..9916318 100644
> > --- a/Documentation/kbuild/kconfig.txt
> > +++ b/Documentation/kbuild/kconfig.txt
> > @@ -178,6 +178,10 @@ Searching in menuconfig:
> > first (and in alphabetical order), then come all other symbols,
> > sorted in alphabetical order.
> >
> > + In the search result textbox, each symbol has a jump number on
> > + left side if the symbol is jumpable. You can type the nubmer
>
> number ("jumpable" reads a bit oddly, but it is understandable.)
>
How about 'if the symbol is visible'?
> > + to jump to target menu to configurate that symbol.
>
> configure?
>
Thanks, I will correct them.
> --
> Jim
--
Thanks,
Changbin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
2017-02-06 7:46 ` [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
2017-02-06 7:46 ` [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du
@ 2017-02-08 3:09 ` changbin.du
2017-03-06 10:28 ` Du, Changbin
2017-02-08 3:09 ` [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
2017-02-08 3:09 ` [PATCH v2 2/2] Documentation/kconfig: add search jump feature description changbin.du
4 siblings, 1 reply; 17+ messages in thread
From: changbin.du @ 2017-02-08 3:09 UTC (permalink / raw)
To: mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel,
jim.epost, jani.nikula, Changbin Du
From: Changbin Du <changbin.du@intel.com>
While I am searching something in menuconfig, I hope if I can jump to interested
items directly. I even try to add this feature. When I check the code just found
it has already been there but not documented. So why let more developers know it?
v2: correct spell (Jim)
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textbox
Documentation/kconfig: add search jump feature description
Documentation/kbuild/kconfig.txt | 4 ++++
scripts/kconfig/mconf.c | 8 ++++----
2 files changed, 8 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
2017-02-08 3:09 ` [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
@ 2017-03-06 10:28 ` Du, Changbin
2017-03-23 5:35 ` Du, Changbin
0 siblings, 1 reply; 17+ messages in thread
From: Du, Changbin @ 2017-03-06 10:28 UTC (permalink / raw)
To: changbin.du
Cc: mmarek, corbet, yann.morin.1998, linux-kbuild, linux-doc,
linux-kernel, jim.epost, jani.nikula
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Hello, any new update need for this or new comments? :)
On Wed, Feb 08, 2017 at 11:09:37AM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> While I am searching something in menuconfig, I hope if I can jump to interested
> items directly. I even try to add this feature. When I check the code just found
> it has already been there but not documented. So why let more developers know it?
>
> v2: correct spell (Jim)
>
> Changbin Du (2):
> kconfig/mconf: add jumping tip in title of search result textbox
> Documentation/kconfig: add search jump feature description
>
> Documentation/kbuild/kconfig.txt | 4 ++++
> scripts/kconfig/mconf.c | 8 ++++----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.7.4
>
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
2017-03-06 10:28 ` Du, Changbin
@ 2017-03-23 5:35 ` Du, Changbin
2017-03-23 10:17 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Du, Changbin @ 2017-03-23 5:35 UTC (permalink / raw)
To: mmarek, corbet, yann.morin.1998, linux-kbuild, linux-doc,
linux-kernel, jim.epost, jani.nikula
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
Sencond ping... if this is realy not necessary I give up.
On Mon, Mar 06, 2017 at 06:28:50PM +0800, Du, Changbin wrote:
> Hello, any new update need for this or new comments? :)
>
> On Wed, Feb 08, 2017 at 11:09:37AM +0800, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > While I am searching something in menuconfig, I hope if I can jump to interested
> > items directly. I even try to add this feature. When I check the code just found
> > it has already been there but not documented. So why let more developers know it?
> >
> > v2: correct spell (Jim)
> >
> > Changbin Du (2):
> > kconfig/mconf: add jumping tip in title of search result textbox
> > Documentation/kconfig: add search jump feature description
> >
> > Documentation/kbuild/kconfig.txt | 4 ++++
> > scripts/kconfig/mconf.c | 8 ++++----
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > --
> > 2.7.4
> >
>
> --
> Thanks,
> Changbin Du
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
2017-03-23 5:35 ` Du, Changbin
@ 2017-03-23 10:17 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-03-23 10:17 UTC (permalink / raw)
To: Du, Changbin, mmarek, corbet, yann.morin.1998, linux-kbuild,
linux-doc, linux-kernel, jim.epost
Yann?
I'd like to have both of these merged, I think they are worthwhile and
simple additions, and they look good to me.
BR,
Jani.
On Thu, 23 Mar 2017, "Du, Changbin" <changbin.du@intel.com> wrote:
> Sencond ping... if this is realy not necessary I give up.
>
> On Mon, Mar 06, 2017 at 06:28:50PM +0800, Du, Changbin wrote:
>> Hello, any new update need for this or new comments? :)
>>
>> On Wed, Feb 08, 2017 at 11:09:37AM +0800, changbin.du@intel.com wrote:
>> > From: Changbin Du <changbin.du@intel.com>
>> >
>> > While I am searching something in menuconfig, I hope if I can jump to interested
>> > items directly. I even try to add this feature. When I check the code just found
>> > it has already been there but not documented. So why let more developers know it?
>> >
>> > v2: correct spell (Jim)
>> >
>> > Changbin Du (2):
>> > kconfig/mconf: add jumping tip in title of search result textbox
>> > Documentation/kconfig: add search jump feature description
>> >
>> > Documentation/kbuild/kconfig.txt | 4 ++++
>> > scripts/kconfig/mconf.c | 8 ++++----
>> > 2 files changed, 8 insertions(+), 4 deletions(-)
>> >
>> > --
>> > 2.7.4
>> >
>>
>> --
>> Thanks,
>> Changbin Du
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
@ 2017-03-23 10:17 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-03-23 10:17 UTC (permalink / raw)
To: Du, Changbin, mmarek, corbet, yann.morin.1998, linux-kbuild,
linux-doc, linux-kernel, jim.epost
Yann?
I'd like to have both of these merged, I think they are worthwhile and
simple additions, and they look good to me.
BR,
Jani.
On Thu, 23 Mar 2017, "Du, Changbin" <changbin.du@intel.com> wrote:
> Sencond ping... if this is realy not necessary I give up.
>
> On Mon, Mar 06, 2017 at 06:28:50PM +0800, Du, Changbin wrote:
>> Hello, any new update need for this or new comments? :)
>>
>> On Wed, Feb 08, 2017 at 11:09:37AM +0800, changbin.du@intel.com wrote:
>> > From: Changbin Du <changbin.du@intel.com>
>> >
>> > While I am searching something in menuconfig, I hope if I can jump to interested
>> > items directly. I even try to add this feature. When I check the code just found
>> > it has already been there but not documented. So why let more developers know it?
>> >
>> > v2: correct spell (Jim)
>> >
>> > Changbin Du (2):
>> > kconfig/mconf: add jumping tip in title of search result textbox
>> > Documentation/kconfig: add search jump feature description
>> >
>> > Documentation/kbuild/kconfig.txt | 4 ++++
>> > scripts/kconfig/mconf.c | 8 ++++----
>> > 2 files changed, 8 insertions(+), 4 deletions(-)
>> >
>> > --
>> > 2.7.4
>> >
>>
>> --
>> Thanks,
>> Changbin Du
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
` (2 preceding siblings ...)
2017-02-08 3:09 ` [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
@ 2017-02-08 3:09 ` changbin.du
2017-02-08 8:07 ` Jani Nikula
2017-02-08 3:09 ` [PATCH v2 2/2] Documentation/kconfig: add search jump feature description changbin.du
4 siblings, 1 reply; 17+ messages in thread
From: changbin.du @ 2017-02-08 3:09 UTC (permalink / raw)
To: mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel,
jim.epost, jani.nikula, Changbin Du
From: Changbin Du <changbin.du@intel.com>
Prompt user how to quickly jump to the item he/she is interested in.
Signed-off-by: Changbin Du <changbin.du@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
---
scripts/kconfig/mconf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 315ce2c..23d5681 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -443,10 +443,10 @@ static void search_conf(void)
res = get_relations_str(sym_arr, &head);
set_subtitle();
- dres = show_textbox_ext(_("Search Results"), (char *)
- str_get(&res), 0, 0, keys, &vscroll,
- &hscroll, &update_text, (void *)
- &data);
+ dres = show_textbox_ext(
+ _("Search Results (type the number to jump)"),
+ (char *)str_get(&res), 0, 0, keys, &vscroll,
+ &hscroll, &update_text, (void *)&data);
again = false;
for (i = 0; i < JUMP_NB && keys[i]; i++)
if (dres == keys[i]) {
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
2017-02-08 3:09 ` [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
@ 2017-02-08 8:07 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-02-08 8:07 UTC (permalink / raw)
To: changbin.du, mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel,
jim.epost, Changbin Du
On Wed, 08 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
This is assuming too much... but I looked at it now, and it looks good
to me.
Thanks,
Jani.
> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
@ 2017-02-08 8:07 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2017-02-08 8:07 UTC (permalink / raw)
To: changbin.du, mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel, jim.epost
On Wed, 08 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
This is assuming too much... but I looked at it now, and it looks good
to me.
Thanks,
Jani.
> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/2] Documentation/kconfig: add search jump feature description
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
` (3 preceding siblings ...)
2017-02-08 3:09 ` [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
@ 2017-02-08 3:09 ` changbin.du
4 siblings, 0 replies; 17+ messages in thread
From: changbin.du @ 2017-02-08 3:09 UTC (permalink / raw)
To: mmarek, corbet
Cc: yann.morin.1998, linux-kbuild, linux-doc, linux-kernel,
jim.epost, jani.nikula, Changbin Du
From: Changbin Du <changbin.du@intel.com>
Kernel menuconfig support direct jumping function from the search
result. This is a very convenient feature but not documented. So
add a short description to the kconfig documentation to let more
developers know it.
v2: correct spell (Jim)
Signed-off-by: Changbin Du <changbin.du@intel.com>
Reviewed-by: Jim Davis <jim.epost@gmail.com>
---
Documentation/kbuild/kconfig.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
index bbc99c0..fdac2cd 100644
--- a/Documentation/kbuild/kconfig.txt
+++ b/Documentation/kbuild/kconfig.txt
@@ -178,6 +178,10 @@ Searching in menuconfig:
first (and in alphabetical order), then come all other symbols,
sorted in alphabetical order.
+ In the search result textbox, each symbol has a jump number on
+ left side if the symbol is visible. You can type the number
+ to jump to target menu to configure that symbol.
+
______________________________________________________________________
User interface options for 'menuconfig'
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread