* [PATCH] ath10k: disable burst mode
@ 2015-03-25 8:14 ` Janusz Dziedzic
0 siblings, 0 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2015-03-25 8:14 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Janusz Dziedzic
Firmwares that indicate BURST_SERVICE as enabled
could overwrite some wmm parameters (eg. txop).
This could lead IOT and balancing issues.
Hence disable this by default.
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 75dcd3a..b0d550b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3079,6 +3079,7 @@ static int ath10k_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant)
static int ath10k_start(struct ieee80211_hw *hw)
{
struct ath10k *ar = hw->priv;
+ u32 burst_enable;
int ret = 0;
/*
@@ -3133,6 +3134,15 @@ static int ath10k_start(struct ieee80211_hw *hw)
goto err_core_stop;
}
+ if (test_bit(WMI_SERVICE_BURST, ar->wmi.svc_map)) {
+ burst_enable = ar->wmi.pdev_param->burst_enable;
+ ret = ath10k_wmi_pdev_set_param(ar, burst_enable, 0);
+ if (ret) {
+ ath10k_warn(ar, "failed to disable burst: %d\n", ret);
+ goto err_core_stop;
+ }
+ }
+
if (ar->cfg_tx_chainmask)
__ath10k_set_antenna(ar, ar->cfg_tx_chainmask,
ar->cfg_rx_chainmask);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ath10k: disable burst mode
@ 2015-03-25 8:14 ` Janusz Dziedzic
0 siblings, 0 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2015-03-25 8:14 UTC (permalink / raw)
To: ath10k; +Cc: Janusz Dziedzic, linux-wireless
Firmwares that indicate BURST_SERVICE as enabled
could overwrite some wmm parameters (eg. txop).
This could lead IOT and balancing issues.
Hence disable this by default.
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 75dcd3a..b0d550b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3079,6 +3079,7 @@ static int ath10k_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant)
static int ath10k_start(struct ieee80211_hw *hw)
{
struct ath10k *ar = hw->priv;
+ u32 burst_enable;
int ret = 0;
/*
@@ -3133,6 +3134,15 @@ static int ath10k_start(struct ieee80211_hw *hw)
goto err_core_stop;
}
+ if (test_bit(WMI_SERVICE_BURST, ar->wmi.svc_map)) {
+ burst_enable = ar->wmi.pdev_param->burst_enable;
+ ret = ath10k_wmi_pdev_set_param(ar, burst_enable, 0);
+ if (ret) {
+ ath10k_warn(ar, "failed to disable burst: %d\n", ret);
+ goto err_core_stop;
+ }
+ }
+
if (ar->cfg_tx_chainmask)
__ath10k_set_antenna(ar, ar->cfg_tx_chainmask,
ar->cfg_rx_chainmask);
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
2015-03-25 8:14 ` Janusz Dziedzic
@ 2015-03-30 13:15 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-30 13:15 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: ath10k, linux-wireless
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Firmwares that indicate BURST_SERVICE as enabled
> could overwrite some wmm parameters (eg. txop).
> This could lead IOT and balancing issues.
> Hence disable this by default.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
There was a trivial conflict, please check my resolution in the pending
branch.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
@ 2015-03-30 13:15 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-30 13:15 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: linux-wireless, ath10k
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Firmwares that indicate BURST_SERVICE as enabled
> could overwrite some wmm parameters (eg. txop).
> This could lead IOT and balancing issues.
> Hence disable this by default.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
There was a trivial conflict, please check my resolution in the pending
branch.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
2015-03-30 13:15 ` Kalle Valo
@ 2015-03-31 11:22 ` Janusz Dziedzic
-1 siblings, 0 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2015-03-31 11:22 UTC (permalink / raw)
To: Kalle Valo; +Cc: Janusz Dziedzic, linux-wireless, ath10k
2015-03-30 15:15 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Firmwares that indicate BURST_SERVICE as enabled
>> could overwrite some wmm parameters (eg. txop).
>> This could lead IOT and balancing issues.
>> Hence disable this by default.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> There was a trivial conflict, please check my resolution in the pending
> branch.
>
Looks good. Thanks
BR
Janusz
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
@ 2015-03-31 11:22 ` Janusz Dziedzic
0 siblings, 0 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2015-03-31 11:22 UTC (permalink / raw)
To: Kalle Valo; +Cc: Janusz Dziedzic, linux-wireless, ath10k
2015-03-30 15:15 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Firmwares that indicate BURST_SERVICE as enabled
>> could overwrite some wmm parameters (eg. txop).
>> This could lead IOT and balancing issues.
>> Hence disable this by default.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> There was a trivial conflict, please check my resolution in the pending
> branch.
>
Looks good. Thanks
BR
Janusz
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
2015-03-25 8:14 ` Janusz Dziedzic
@ 2015-04-09 11:56 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-04-09 11:56 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: ath10k, linux-wireless
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Firmwares that indicate BURST_SERVICE as enabled
> could overwrite some wmm parameters (eg. txop).
> This could lead IOT and balancing issues.
> Hence disable this by default.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ath10k: disable burst mode
@ 2015-04-09 11:56 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-04-09 11:56 UTC (permalink / raw)
To: Janusz Dziedzic; +Cc: linux-wireless, ath10k
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Firmwares that indicate BURST_SERVICE as enabled
> could overwrite some wmm parameters (eg. txop).
> This could lead IOT and balancing issues.
> Hence disable this by default.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Thanks, applied.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-04-09 11:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 8:14 [PATCH] ath10k: disable burst mode Janusz Dziedzic
2015-03-25 8:14 ` Janusz Dziedzic
2015-03-30 13:15 ` Kalle Valo
2015-03-30 13:15 ` Kalle Valo
2015-03-31 11:22 ` Janusz Dziedzic
2015-03-31 11:22 ` Janusz Dziedzic
2015-04-09 11:56 ` Kalle Valo
2015-04-09 11:56 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.