* [Buildroot] [PATCH 1/1] webp: new package
@ 2013-01-16 22:14 gilles.talis at gmail.com
2013-01-20 20:56 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: gilles.talis at gmail.com @ 2013-01-16 22:14 UTC (permalink / raw)
To: buildroot
From: Gilles Talis <gilles.talis@gmail.com>
WebP is a new image format that provides lossless
and lossy compression for images on the web
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
package/Config.in | 1 +
package/webp/Config.in | 7 +++++++
package/webp/webp.mk | 22 ++++++++++++++++++++++
3 files changed, 30 insertions(+), 0 deletions(-)
create mode 100644 package/webp/Config.in
create mode 100644 package/webp/webp.mk
diff --git a/package/Config.in b/package/Config.in
index ba03b3c..1e8c4da 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -433,6 +433,7 @@ source "package/pango/Config.in"
source "package/pixman/Config.in"
source "package/tiff/Config.in"
source "package/webkit/Config.in"
+source "package/webp/Config.in"
source "package/zxing/Config.in"
endmenu
diff --git a/package/webp/Config.in b/package/webp/Config.in
new file mode 100644
index 0000000..a2acdff
--- /dev/null
+++ b/package/webp/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_WEBP
+ bool "webp"
+ help
+ WebP is a new image format that provides lossless and
+ lossy compression for images on the web
+
+ https://developers.google.com/speed/webp/
diff --git a/package/webp/webp.mk b/package/webp/webp.mk
new file mode 100644
index 0000000..3dcb13c
--- /dev/null
+++ b/package/webp/webp.mk
@@ -0,0 +1,22 @@
+#####################################################################
+#
+# webp
+#
+#####################################################################
+
+WEBP_VERSION = 0.2.1
+WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
+WEBP_SITE = https://webp.googlecode.com/files
+WEBP_LICENSE = BSD-3c
+WEBP_LICENSE_FILES = COPYING
+WEBP_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_LIBPNG),y)
+WEBP_DEPENDENCIES += libpng
+WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
+endif
+
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
+
+$(eval $(autotools-package))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
2013-01-16 22:14 [Buildroot] [PATCH 1/1] webp: new package gilles.talis at gmail.com
@ 2013-01-20 20:56 ` Peter Korsgaard
2013-01-21 23:45 ` Gilles Talis
0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2013-01-20 20:56 UTC (permalink / raw)
To: buildroot
>>>>> "gilles" == gilles talis <gilles.talis@gmail.com> writes:
gilles> From: Gilles Talis <gilles.talis@gmail.com>
gilles> WebP is a new image format that provides lossless
gilles> and lossy compression for images on the web
gilles> +#####################################################################
gilles> +#
gilles> +# webp
gilles> +#
gilles> +#####################################################################
gilles> +
gilles> +WEBP_VERSION = 0.2.1
gilles> +WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
gilles> +WEBP_SITE = https://webp.googlecode.com/files
gilles> +WEBP_LICENSE = BSD-3c
gilles> +WEBP_LICENSE_FILES = COPYING
gilles> +WEBP_INSTALL_STAGING = YES
gilles> +
gilles> +ifeq ($(BR2_PACKAGE_LIBPNG),y)
gilles> +WEBP_DEPENDENCIES += libpng
gilles> +WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
gilles> +endif
So what happens when you don't have libpng enabled but do have
libpng-config on the host? Is there no explicit configure options to
turn off png support (alternatively, point LIBPNG_CONFIG to /bin/false
or similar).
gilles> +
gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
Same here. You don't depend on host-pkgconf, so it presumably doesn't
use that to figure out availability of jpeg/tiff.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
2013-01-20 20:56 ` Peter Korsgaard
@ 2013-01-21 23:45 ` Gilles Talis
2013-01-22 9:48 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Gilles Talis @ 2013-01-21 23:45 UTC (permalink / raw)
To: buildroot
Dear Peter,
On Jan 20, 2013 12:56 PM, "Peter Korsgaard" <jacmet@uclibc.org> wrote:
>
> >>>>> "gilles" == gilles talis <gilles.talis@gmail.com> writes:
>
> gilles> From: Gilles Talis <gilles.talis@gmail.com>
> gilles> WebP is a new image format that provides lossless
> gilles> and lossy compression for images on the web
>
> gilles>
+#####################################################################
> gilles> +#
> gilles> +# webp
> gilles> +#
> gilles>
+#####################################################################
> gilles> +
> gilles> +WEBP_VERSION = 0.2.1
> gilles> +WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
> gilles> +WEBP_SITE = https://webp.googlecode.com/files
> gilles> +WEBP_LICENSE = BSD-3c
> gilles> +WEBP_LICENSE_FILES = COPYING
> gilles> +WEBP_INSTALL_STAGING = YES
> gilles> +
> gilles> +ifeq ($(BR2_PACKAGE_LIBPNG),y)
> gilles> +WEBP_DEPENDENCIES += libpng
> gilles> +WEBP_CONF_ENV +=
ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
> gilles> +endif
>
> So what happens when you don't have libpng enabled but do have
> libpng-config on the host? Is there no explicit configure options to
> turn off png support (alternatively, point LIBPNG_CONFIG to /bin/false
> or similar).
There's no way to disable any of the options mentioned in that patch (PNG,
JPEG, TIFF).
in my setup, the "configure" step returns cross-compilation errors, thus
removes PNG from the available options.
I hesitated quite a bit before embedding LIBPNG_CONFIG within
BR2_PACKAGE_LIBPNG flag. My first intention was to force this config to
always point to the staging dir. Is that what you are suggesting?
>
> gilles> +
> gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
> gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
>
> Same here. You don't depend on host-pkgconf, so it presumably doesn't
> use that to figure out availability of jpeg/tiff.
Same here. I can force the paths to JPEG and TIFF include and lib to always
point to staging dir. Was my first intention, but it seemed to work out
fine without doing that. Do you think it would be preferrable to force
these paths?
thanks
Gilles.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130121/8ce93d4d/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
2013-01-21 23:45 ` Gilles Talis
@ 2013-01-22 9:48 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2013-01-22 9:48 UTC (permalink / raw)
To: buildroot
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:
Hi,
>> ?gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
>> ?gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
>>
>> Same here. You don't depend on host-pkgconf, so it presumably doesn't
>> use that to figure out availability of jpeg/tiff.
Gilles> Same here. I can force the paths to JPEG and TIFF include and
Gilles> lib to always point to staging dir. Was my first intention, but
Gilles> it seemed to work out fine without doing that. Do you think it
Gilles> would be preferrable to force these paths?
I'm concerned it will fail if you build for the same architecture as
your host (E.G. for a PC), haven't enabled png/tiff/jpeg in buildroot
but DO have the development libraries installed on the host.
I'll give it a test later today.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
2013-01-25 4:35 Gilles Talis
2013-01-25 4:37 ` Gilles Talis
@ 2013-05-05 20:42 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2013-05-05 20:42 UTC (permalink / raw)
To: buildroot
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:
Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
Gilles> ---
Gilles> package/Config.in | 1 +
Gilles> package/webp/Config.in | 7 +++++++
Gilles> package/webp/webp.mk | 30 ++++++++++++++++++++++++++++++
Gilles> 3 files changed, 38 insertions(+), 0 deletions(-)
Gilles> create mode 100644 package/webp/Config.in
Gilles> create mode 100644 package/webp/webp.mk
Gilles> diff --git a/package/Config.in b/package/Config.in
Gilles> index ebd9817..95d51fb 100644
Gilles> --- a/package/Config.in
Gilles> +++ b/package/Config.in
Gilles> @@ -437,6 +437,7 @@ source "package/pango/Config.in"
Gilles> source "package/pixman/Config.in"
Gilles> source "package/tiff/Config.in"
Gilles> source "package/webkit/Config.in"
Gilles> +source "package/webp/Config.in"
Gilles> source "package/zxing/Config.in"
Gilles> endmenu
Gilles> diff --git a/package/webp/Config.in b/package/webp/Config.in
Gilles> new file mode 100644
Gilles> index 0000000..dcee8aa
Gilles> --- /dev/null
Gilles> +++ b/package/webp/Config.in
Gilles> @@ -0,0 +1,7 @@
Gilles> +config BR2_PACKAGE_WEBP
Gilles> + bool "webp"
Gilles> + help
Gilles> + WebP is a new image format that provides lossless and
Gilles> + lossy compression for images on the web
Gilles> +
Gilles> + https://developers.google.com/speed/webp/
Config.in files should be indented with <tab> (and help lines with
<tab><space><space>).
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
2013-01-25 4:35 Gilles Talis
@ 2013-01-25 4:37 ` Gilles Talis
2013-05-05 20:42 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Gilles Talis @ 2013-01-25 4:37 UTC (permalink / raw)
To: buildroot
Peter,
This is a version where all paths are hardcoded. Let me know what you think.
Gilles.
2013/1/24 Gilles Talis <gilles.talis@gmail.com>
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
> package/Config.in | 1 +
> package/webp/Config.in | 7 +++++++
> package/webp/webp.mk | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 38 insertions(+), 0 deletions(-)
> create mode 100644 package/webp/Config.in
> create mode 100644 package/webp/webp.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index ebd9817..95d51fb 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -437,6 +437,7 @@ source "package/pango/Config.in"
> source "package/pixman/Config.in"
> source "package/tiff/Config.in"
> source "package/webkit/Config.in"
> +source "package/webp/Config.in"
> source "package/zxing/Config.in"
> endmenu
>
> diff --git a/package/webp/Config.in b/package/webp/Config.in
> new file mode 100644
> index 0000000..dcee8aa
> --- /dev/null
> +++ b/package/webp/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_WEBP
> + bool "webp"
> + help
> + WebP is a new image format that provides lossless and
> + lossy compression for images on the web
> +
> + https://developers.google.com/speed/webp/
> diff --git a/package/webp/webp.mk b/package/webp/webp.mk
> new file mode 100644
> index 0000000..d6d7509
> --- /dev/null
> +++ b/package/webp/webp.mk
> @@ -0,0 +1,30 @@
> +#####################################################################
> +#
> +# webp
> +#
> +#####################################################################
> +
> +WEBP_VERSION = 0.2.1
> +WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
> +WEBP_SITE = https://webp.googlecode.com/files
> +WEBP_LICENSE = BSD-3c
> +WEBP_LICENSE_FILES = COPYING
> +WEBP_INSTALL_STAGING = YES
> +
> +WEBP_CONF_OPT += \
> + --with-jpegincludedir=$(STAGING_DIR)/usr/include \
> + --with-jpeglibdir=$(STAGING_DIR)/usr/lib \
> + --with-tiffincludedir=$(STAGING_DIR)/usr/include \
> + --with-tifflibdir=$(STAGING_DIR)/usr/lib
> +
> +ifeq ($(BR2_PACKAGE_LIBPNG),y)
> +WEBP_DEPENDENCIES += libpng
> +WEBP_CONF_ENV +=
> ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
> +else
> +WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=/bin/false
> +endif
> +
> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
> +
> +$(eval $(autotools-package))
> --
> 1.7.4.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130124/89123be7/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] webp: new package
@ 2013-01-25 4:35 Gilles Talis
2013-01-25 4:37 ` Gilles Talis
2013-05-05 20:42 ` Peter Korsgaard
0 siblings, 2 replies; 7+ messages in thread
From: Gilles Talis @ 2013-01-25 4:35 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
package/Config.in | 1 +
package/webp/Config.in | 7 +++++++
package/webp/webp.mk | 30 ++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+), 0 deletions(-)
create mode 100644 package/webp/Config.in
create mode 100644 package/webp/webp.mk
diff --git a/package/Config.in b/package/Config.in
index ebd9817..95d51fb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -437,6 +437,7 @@ source "package/pango/Config.in"
source "package/pixman/Config.in"
source "package/tiff/Config.in"
source "package/webkit/Config.in"
+source "package/webp/Config.in"
source "package/zxing/Config.in"
endmenu
diff --git a/package/webp/Config.in b/package/webp/Config.in
new file mode 100644
index 0000000..dcee8aa
--- /dev/null
+++ b/package/webp/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_WEBP
+ bool "webp"
+ help
+ WebP is a new image format that provides lossless and
+ lossy compression for images on the web
+
+ https://developers.google.com/speed/webp/
diff --git a/package/webp/webp.mk b/package/webp/webp.mk
new file mode 100644
index 0000000..d6d7509
--- /dev/null
+++ b/package/webp/webp.mk
@@ -0,0 +1,30 @@
+#####################################################################
+#
+# webp
+#
+#####################################################################
+
+WEBP_VERSION = 0.2.1
+WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
+WEBP_SITE = https://webp.googlecode.com/files
+WEBP_LICENSE = BSD-3c
+WEBP_LICENSE_FILES = COPYING
+WEBP_INSTALL_STAGING = YES
+
+WEBP_CONF_OPT += \
+ --with-jpegincludedir=$(STAGING_DIR)/usr/include \
+ --with-jpeglibdir=$(STAGING_DIR)/usr/lib \
+ --with-tiffincludedir=$(STAGING_DIR)/usr/include \
+ --with-tifflibdir=$(STAGING_DIR)/usr/lib
+
+ifeq ($(BR2_PACKAGE_LIBPNG),y)
+WEBP_DEPENDENCIES += libpng
+WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
+else
+WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=/bin/false
+endif
+
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
+
+$(eval $(autotools-package))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-05 20:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-16 22:14 [Buildroot] [PATCH 1/1] webp: new package gilles.talis at gmail.com
2013-01-20 20:56 ` Peter Korsgaard
2013-01-21 23:45 ` Gilles Talis
2013-01-22 9:48 ` Peter Korsgaard
2013-01-25 4:35 Gilles Talis
2013-01-25 4:37 ` Gilles Talis
2013-05-05 20:42 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.