From: Frank Oltmanns <frank@oltmanns.dev> To: Maxime Ripard <mripard@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Andre Przywara <andre.przywara@arm.com>, Roman Beranek <me@crly.cz>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/11] clk: sunxi-ng: nm: Support finding closest rate Date: Sun, 23 Jul 2023 09:26:27 +0200 [thread overview] Message-ID: <87edkzqeak.fsf@oltmanns.dev> (raw) In-Reply-To: <htxtcpqimrloxvebm5iadqzybj3rt5c532smtm62kxeuaejaqw@syknyzrhgf7f> On 2023-07-17 at 16:12:30 +0200, Maxime Ripard <mripard@kernel.org> wrote: > [[PGP Signed Part:Undecided]] > On Mon, Jul 17, 2023 at 03:34:31PM +0200, Frank Oltmanns wrote: >> Use the helper function ccu_is_better_rate() to determine the rate that >> is closest to the requested rate, thereby supporting rates that are >> higher than the requested rate if the clock uses the >> CCU_FEATURE_CLOSEST_RATE. >> >> Add the macro SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST which >> sets CCU_FEATURE_CLOSEST_RATE. >> >> To avoid code duplication, add the macros >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT that allows selecting >> arbitrary features and use it in the original >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX as well as the newly introduced >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST macros. >> >> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev> >> --- >> drivers/clk/sunxi-ng/ccu_nm.c | 11 ++++------ >> drivers/clk/sunxi-ng/ccu_nm.h | 48 ++++++++++++++++++++++++++++++++++++++++--- >> 2 files changed, 49 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu_nm.c b/drivers/clk/sunxi-ng/ccu_nm.c >> index c1fd11542c45..35d00783d748 100644 >> --- a/drivers/clk/sunxi-ng/ccu_nm.c >> +++ b/drivers/clk/sunxi-ng/ccu_nm.c >> @@ -28,7 +28,7 @@ static unsigned long ccu_nm_calc_rate(unsigned long parent, >> } >> >> static unsigned long ccu_nm_find_best(unsigned long parent, unsigned long rate, >> - struct _ccu_nm *nm) >> + struct _ccu_nm *nm, struct ccu_common *common) > > The common pointer must be the first argument. > Same question as for patch 08: Should I also pull *nm to the beginning? If so, do you have a preference on the order of *nm and *common? Thanks, Frank > > Once fixed, > Acked-by: Maxime Ripard <mripard@kernel.org> > > Maxime > > [[End of PGP Signed Part]]
WARNING: multiple messages have this Message-ID (diff)
From: Frank Oltmanns <frank@oltmanns.dev> To: Maxime Ripard <mripard@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Andre Przywara <andre.przywara@arm.com>, Roman Beranek <me@crly.cz>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/11] clk: sunxi-ng: nm: Support finding closest rate Date: Sun, 23 Jul 2023 09:26:27 +0200 [thread overview] Message-ID: <87edkzqeak.fsf@oltmanns.dev> (raw) In-Reply-To: <htxtcpqimrloxvebm5iadqzybj3rt5c532smtm62kxeuaejaqw@syknyzrhgf7f> On 2023-07-17 at 16:12:30 +0200, Maxime Ripard <mripard@kernel.org> wrote: > [[PGP Signed Part:Undecided]] > On Mon, Jul 17, 2023 at 03:34:31PM +0200, Frank Oltmanns wrote: >> Use the helper function ccu_is_better_rate() to determine the rate that >> is closest to the requested rate, thereby supporting rates that are >> higher than the requested rate if the clock uses the >> CCU_FEATURE_CLOSEST_RATE. >> >> Add the macro SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST which >> sets CCU_FEATURE_CLOSEST_RATE. >> >> To avoid code duplication, add the macros >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT that allows selecting >> arbitrary features and use it in the original >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX as well as the newly introduced >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST macros. >> >> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev> >> --- >> drivers/clk/sunxi-ng/ccu_nm.c | 11 ++++------ >> drivers/clk/sunxi-ng/ccu_nm.h | 48 ++++++++++++++++++++++++++++++++++++++++--- >> 2 files changed, 49 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu_nm.c b/drivers/clk/sunxi-ng/ccu_nm.c >> index c1fd11542c45..35d00783d748 100644 >> --- a/drivers/clk/sunxi-ng/ccu_nm.c >> +++ b/drivers/clk/sunxi-ng/ccu_nm.c >> @@ -28,7 +28,7 @@ static unsigned long ccu_nm_calc_rate(unsigned long parent, >> } >> >> static unsigned long ccu_nm_find_best(unsigned long parent, unsigned long rate, >> - struct _ccu_nm *nm) >> + struct _ccu_nm *nm, struct ccu_common *common) > > The common pointer must be the first argument. > Same question as for patch 08: Should I also pull *nm to the beginning? If so, do you have a preference on the order of *nm and *common? Thanks, Frank > > Once fixed, > Acked-by: Maxime Ripard <mripard@kernel.org> > > Maxime > > [[End of PGP Signed Part]] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-23 7:26 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-17 13:34 [PATCH v4 00/11] clk: sunxi-ng: Consider alternative parent rates when determining NKM clock rate Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 13:34 ` [PATCH v4 01/11] clk: sunxi-ng: nkm: Use correct parameter name for parent HW Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:07 ` Maxime Ripard 2023-07-17 14:07 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 02/11] clk: sunxi-ng: nkm: consider alternative parent rates when determining rate Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:07 ` Maxime Ripard 2023-07-17 14:07 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 03/11] clk: sunxi-ng: nkm: Improve determine rate when setting parent Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:10 ` Maxime Ripard 2023-07-17 14:10 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 04/11] clk: sunxi-ng: a64: allow pll-mipi to set parent's rate Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 13:34 ` [PATCH v4 05/11] clk: sunxi-ng: Add feature to find closest rate Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 13:34 ` [PATCH v4 06/11] clk: sunxi-ng: Add helper function " Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:08 ` Maxime Ripard 2023-07-17 14:08 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 07/11] clk: sunxi-ng: nm: Support finding " Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:12 ` Maxime Ripard 2023-07-17 14:12 ` Maxime Ripard 2023-07-23 7:26 ` Frank Oltmanns [this message] 2023-07-23 7:26 ` Frank Oltmanns 2023-07-17 13:34 ` [PATCH v4 08/11] clk: sunxi-ng: nkm: " Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:14 ` Maxime Ripard 2023-07-17 14:14 ` Maxime Ripard 2023-07-23 7:25 ` Frank Oltmanns 2023-07-23 7:25 ` Frank Oltmanns 2023-07-24 13:19 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 09/11] clk: sunxi-ng: mux: " Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:15 ` Maxime Ripard 2023-07-17 14:15 ` Maxime Ripard 2023-07-17 13:34 ` [PATCH v4 10/11] clk: sunxi-ng: div: " Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 13:34 ` [PATCH v4 11/11] clk: sunxi-ng: a64: select closest rate for pll-video0 Frank Oltmanns 2023-07-17 13:34 ` Frank Oltmanns 2023-07-17 14:16 ` Maxime Ripard 2023-07-17 14:16 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87edkzqeak.fsf@oltmanns.dev \ --to=frank@oltmanns.dev \ --cc=andre.przywara@arm.com \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=me@crly.cz \ --cc=mripard@kernel.org \ --cc=mturquette@baylibre.com \ --cc=samuel@sholland.org \ --cc=sboyd@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.