* [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform
@ 2021-11-25 20:27 Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/xelpd: Enable Pipe color support for " Uma Shankar
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Uma Shankar @ 2021-11-25 20:27 UTC (permalink / raw)
To: intel-gfx
Enable pipe color support for Display 13 platform. This series
enables just the 10bit gamma mode. More advanced logarithmic
gamma mode will be enable with the new enhanced UAPI. It will
be extended once the UAPI is agreed in community. This series
just adds the basic support in the interim.
v2: Addressed Ville's review comments.
Uma Shankar (3):
drm/i915/xelpd: Enable Pipe color support for D13 platform
drm/i915/xelpd: Enable Pipe Degamma
drm/i915/xelpd: Add Pipe Color Lut caps to platform config
drivers/gpu/drm/i915/display/intel_color.c | 23 +++++++++++++++++++---
drivers/gpu/drm/i915/i915_pci.c | 6 +++++-
2 files changed, 25 insertions(+), 4 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 1/3] drm/i915/xelpd: Enable Pipe color support for D13 platform
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
@ 2021-11-25 20:27 ` Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar
` (3 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Uma Shankar @ 2021-11-25 20:27 UTC (permalink / raw)
To: intel-gfx
Enable pipe color support for Display 13 platforms. Currently
limit to just 10bit gamma and later extend it for logarithmic
gamma, once the new UAPI is agreed by community and implemented
by a userspace consumer.
v2: Updated dev_priv to i915 (Ville)
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_color.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index 840f13b75492..42fe549ef6fe 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -1574,6 +1574,8 @@ static int glk_color_check(struct intel_crtc_state *crtc_state)
static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct drm_i915_private *i915 = to_i915(crtc->base.dev);
u32 gamma_mode = 0;
if (crtc_state->hw.degamma_lut)
@@ -1586,6 +1588,13 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
if (!crtc_state->hw.gamma_lut ||
crtc_state_is_legacy_gamma(crtc_state))
gamma_mode |= GAMMA_MODE_MODE_8BIT;
+ /*
+ * Enable 10bit gamma for D13
+ * ToDo: Extend to Logarithmic Gamma once the new UAPI
+ * is acccepted and implemented by a userspace consumer
+ */
+ else if (DISPLAY_VER(i915) >= 13)
+ gamma_mode |= GAMMA_MODE_MODE_10BIT;
else
gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/xelpd: Enable Pipe color support for " Uma Shankar
@ 2021-11-25 20:27 ` Uma Shankar
2021-11-29 16:19 ` Jani Nikula
2021-11-30 10:04 ` Ville Syrjälä
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config Uma Shankar
` (2 subsequent siblings)
4 siblings, 2 replies; 13+ messages in thread
From: Uma Shankar @ 2021-11-25 20:27 UTC (permalink / raw)
To: intel-gfx
Enable Pipe Degamma for XE_LPD. Extend the legacy implementation
to incorparate the extended lut size for XE_LPD.
v2: Added a helper for degamma lut size (Ville)
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index 42fe549ef6fe..de3ded1e327a 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state)
}
}
+static int glk_degamma_lut_size(struct drm_i915_private *i915)
+{
+ if (DISPLAY_VER(i915) >= 13)
+ return 131;
+ else
+ return 35;
+}
+
static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
{
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
@@ -827,8 +835,8 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
for (i = 0; i < lut_size; i++) {
/*
- * First 33 entries represent range from 0 to 1.0
- * 34th and 35th entry will represent extended range
+ * First lut_size entries represent range from 0 to 1.0
+ * 3 additional lut entries will represent extended range
* inputs 3.0 and 7.0 respectively, currently clamped
* at 1.0. Since the precision is 16bit, the user
* value can be directly filled to register.
@@ -844,7 +852,7 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
}
/* Clamp values > 1.0. */
- while (i++ < 35)
+ while (i++ < glk_degamma_lut_size(dev_priv))
intel_de_write_fw(dev_priv, PRE_CSC_GAMC_DATA(pipe), 1 << 16);
intel_de_write_fw(dev_priv, PRE_CSC_GAMC_INDEX(pipe), 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/xelpd: Enable Pipe color support for " Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar
@ 2021-11-25 20:27 ` Uma Shankar
2021-11-30 10:03 ` Ville Syrjälä
2021-11-25 21:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Enable pipe color support on D13 platform (rev2) Patchwork
2021-11-26 4:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 13+ messages in thread
From: Uma Shankar @ 2021-11-25 20:27 UTC (permalink / raw)
To: intel-gfx
XE_LPD has 128 Lut entries for Degamma, with additional 3 entries for
extended range. It has 511 entries for gamma with additional 2 entries
for extended range.
v2: Updated lut size for 10bit gamma, added lut_tests (Ville)
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index f01cba4ec283..22eae330f075 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -938,7 +938,11 @@ static const struct intel_device_info adl_s_info = {
#define XE_LPD_FEATURES \
.abox_mask = GENMASK(1, 0), \
- .color = { .degamma_lut_size = 0, .gamma_lut_size = 0 }, \
+ .color = { .degamma_lut_size = 128, .gamma_lut_size = 1024, \
+ .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING | \
+ DRM_COLOR_LUT_EQUAL_CHANNELS, \
+ .gamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING, \
+ }, \
.dbuf.size = 4096, \
.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2) | BIT(DBUF_S3) | \
BIT(DBUF_S4), \
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Enable pipe color support on D13 platform (rev2)
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
` (2 preceding siblings ...)
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config Uma Shankar
@ 2021-11-25 21:37 ` Patchwork
2021-11-26 4:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-11-25 21:37 UTC (permalink / raw)
To: Shankar, Uma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8508 bytes --]
== Series Details ==
Series: Enable pipe color support on D13 platform (rev2)
URL : https://patchwork.freedesktop.org/series/97219/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10928 -> Patchwork_21683
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/index.html
Participating hosts (41 -> 34)
------------------------------
Additional (1): fi-tgl-u2
Missing (8): bat-dg1-6 bat-dg1-5 fi-icl-u2 fi-bsw-cyan bat-adlp-6 fi-bdw-samus bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21683 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][2] -> [INCOMPLETE][3] ([i915#146])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@verify-random:
- fi-tgl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@gem_lmem_swapping@verify-random.html
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [PASS][6] -> [INCOMPLETE][7] ([i915#4432])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@gt_mocs:
- fi-tgl-1115g4: [PASS][8] -> [DMESG-WARN][9] ([i915#2867]) +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-tgl-1115g4/igt@i915_selftest@live@gt_mocs.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-1115g4/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#1886] / [i915#2291])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-u2: NOTRUN -> [SKIP][11] ([fdo#109284] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-u2: NOTRUN -> [SKIP][12] ([i915#4103]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [PASS][15] -> [FAIL][16] ([i915#4547])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-u2: NOTRUN -> [SKIP][17] ([i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-tgl-u2/igt@prime_vgem@basic-userptr.html
- fi-kbl-soraka: NOTRUN -> [SKIP][18] ([fdo#109271])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-kbl-soraka/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][19] ([i915#3363] / [i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-skl-6600u/igt@runner@aborted.html
- fi-rkl-guc: NOTRUN -> [FAIL][20] ([i915#3928] / [i915#4312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-rkl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][21] ([i915#3921]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][23] ([i915#4269]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][25] ([i915#295]) -> [PASS][26] +12 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-soraka: [INCOMPLETE][27] -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10928 -> Patchwork_21683
CI-20190529: 20190529
CI_DRM_10928: 3bf56d24d381c492c14d093554d975b6a529784b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6291: 9ff3844d8c1fee8d8736d888f16223c4789fb69f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21683: b0aac7cede66677e2fbc50c0adc846cac8fb13b7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b0aac7cede66 drm/i915/xelpd: Add Pipe Color Lut caps to platform config
f08387d27e0a drm/i915/xelpd: Enable Pipe Degamma
375b5bdd31c1 drm/i915/xelpd: Enable Pipe color support for D13 platform
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/index.html
[-- Attachment #2: Type: text/html, Size: 9812 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Enable pipe color support on D13 platform (rev2)
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
` (3 preceding siblings ...)
2021-11-25 21:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Enable pipe color support on D13 platform (rev2) Patchwork
@ 2021-11-26 4:51 ` Patchwork
4 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-11-26 4:51 UTC (permalink / raw)
To: Shankar, Uma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30271 bytes --]
== Series Details ==
Series: Enable pipe color support on D13 platform (rev2)
URL : https://patchwork.freedesktop.org/series/97219/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10928_full -> Patchwork_21683_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_21683_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [FAIL][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4386]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl4/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl4/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl2/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl2/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl6/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][51] -> [DMESG-WARN][52] ([i915#180]) +6 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#1099])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-snb6/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html
* igt@gem_eio@in-flight-10ms:
- shard-skl: [PASS][54] -> [TIMEOUT][55] ([i915#3063])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-skl4/igt@gem_eio@in-flight-10ms.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl1/igt@gem_eio@in-flight-10ms.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][56] -> [INCOMPLETE][57] ([i915#4547])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-skl4/igt@gem_exec_capture@pi@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl1/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][58] ([i915#2846])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][59] -> [FAIL][60] ([i915#2842]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][61] -> [FAIL][62] ([i915#2842]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][63] -> [FAIL][64] ([i915#2842]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-apl: [PASS][67] -> [DMESG-WARN][68] ([i915#180])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl6/igt@gem_exec_suspend@basic-s3.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][69] -> [SKIP][70] ([i915#2190])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-random:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#4613]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][73] ([i915#2658])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@gem_pread@exhaustion.html
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271]) +75 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: [PASS][75] -> [TIMEOUT][76] ([i915#4639])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl8/igt@gen9_exec_parse@bb-large.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/igt@gen9_exec_parse@bb-large.html
* igt@i915_hangman@hangcheck-unterminated:
- shard-snb: NOTRUN -> [SKIP][77] ([fdo#109271]) +42 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-snb6/igt@i915_hangman@hangcheck-unterminated.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][78] -> [FAIL][79] ([i915#454])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@debugfs-reader:
- shard-skl: [PASS][80] -> [INCOMPLETE][81] ([i915#198]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-skl1/igt@i915_suspend@debugfs-reader.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@i915_suspend@debugfs-reader.html
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][82] ([i915#4272])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@kms_async_flips@crc.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3777])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][84] ([i915#3743]) +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#3777]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#3886]) +14 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl4/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3886]) +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109278] / [i915#3886])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb3/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [fdo#111827])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-kbl6/igt@kms_chamelium@dp-hpd.html
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109284] / [fdo#111827])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb2/igt@kms_chamelium@dp-hpd.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [fdo#111827]) +6 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [fdo#111827]) +22 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][93] ([i915#1319])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-glk: [PASS][94] -> [DMESG-WARN][95] ([i915#118])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-glk9/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-glk3/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278] / [fdo#109279])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb3/igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#426])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb3/igt@kms_dp_tiled_display@basic-test-pattern.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [PASS][98] -> [INCOMPLETE][99] ([i915#456])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-tglb6/igt@kms_fbcon_fbt@psr-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb7/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#111825]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb2/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][101] ([i915#180])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][102] -> [FAIL][103] ([i915#2122]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [INCOMPLETE][104] ([i915#3699])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271]) +315 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][106] ([fdo#109271]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-kbl6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch:
- shard-skl: NOTRUN -> [FAIL][107] ([i915#1188])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl8/igt@kms_hdr@bpc-switch.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][108] ([fdo#108145] / [i915#265]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-apl: NOTRUN -> [FAIL][109] ([fdo#108145] / [i915#265])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2733])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: NOTRUN -> [SKIP][111] ([i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb3/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#658])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl7/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +6 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][114] -> [SKIP][115] ([fdo#109441]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][116] ([i915#180] / [i915#295])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][117] -> [INCOMPLETE][118] ([i915#2828] / [i915#456])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-tglb3/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-tglb7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#533]) +3 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2437])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl7/igt@kms_writeback@writeback-pixel-formats.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) +5 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl4/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_exec_capture@pi@vcs0:
- shard-iclb: [INCOMPLETE][123] ([i915#3371]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-iclb2/igt@gem_exec_capture@pi@vcs0.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb3/igt@gem_exec_capture@pi@vcs0.html
* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-snb: [INCOMPLETE][125] -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-snb6/igt@gem_fenced_exec_thrash@no-spare-fences.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-snb4/igt@gem_fenced_exec_thrash@no-spare-fences.html
* igt@i915_pm_dc@dc6-psr:
- {shard-rkl}: [SKIP][127] ([i915#658]) -> [PASS][128] +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-1/igt@i915_pm_dc@dc6-psr.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: ([SKIP][129], [SKIP][130]) ([i915#1397]) -> [PASS][131]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-4/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@fences:
- {shard-rkl}: ([SKIP][132], [SKIP][133]) ([i915#1849]) -> [PASS][134]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@i915_pm_rpm@fences.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-4/igt@i915_pm_rpm@fences.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@i915_pm_rpm@fences.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][135] ([i915#3921]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-snb6/igt@i915_selftest@live@hangcheck.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][137] ([i915#118]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-glk7/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-glk2/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][139] ([i915#1845]) -> [PASS][140] +25 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-a-ctm-0-75:
- {shard-rkl}: [SKIP][141] ([i915#1149] / [i915#1849] / [i915#4070]) -> [PASS][142] +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_color@pipe-a-ctm-0-75.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_concurrent@pipe-a:
- {shard-rkl}: [SKIP][143] ([i915#1845] / [i915#4070]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_concurrent@pipe-a.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_concurrent@pipe-a.html
* igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding:
- {shard-rkl}: [SKIP][145] ([fdo#112022] / [i915#4070]) -> [PASS][146] +10 similar issues
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
- {shard-rkl}: ([SKIP][147], [SKIP][148]) ([fdo#112022] / [i915#4070]) -> [PASS][149]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-4/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-1/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
* igt@kms_cursor_legacy@cursora-vs-flipa-legacy:
- {shard-rkl}: ([SKIP][150], [SKIP][151]) ([fdo#111825] / [i915#4070]) -> [PASS][152]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-1/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-4/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [FAIL][153] ([i915#2346]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-iclb5/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- {shard-rkl}: [SKIP][155] ([fdo#111825] / [i915#4070]) -> [PASS][156] +4 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
- {shard-rkl}: [SKIP][157] ([fdo#111314]) -> [PASS][158] +4 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
* igt@kms_fbcon_fbt@psr-suspend:
- {shard-rkl}: [SKIP][159] ([fdo#110189] / [i915#3955]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_fence_pin_leak:
- {shard-rkl}: ([SKIP][161], [SKIP][162]) ([i915#1845] / [i915#4098]) -> [PASS][163]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-4/igt@kms_fence_pin_leak.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-rkl-2/igt@kms_fence_pin_leak.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-rkl-6/igt@kms_fence_pin_leak.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][164] ([i915#79]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][166] ([i915#2122]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][168] ([i915#79]) -> [PASS][169]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [FAIL][170] ([i915#79]) -> [PASS][171]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10928/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21683/index.html
[-- Attachment #2: Type: text/html, Size: 33339 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar
@ 2021-11-29 16:19 ` Jani Nikula
2021-11-30 10:01 ` Ville Syrjälä
2021-11-30 10:04 ` Ville Syrjälä
1 sibling, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2021-11-29 16:19 UTC (permalink / raw)
To: Uma Shankar, intel-gfx
On Fri, 26 Nov 2021, Uma Shankar <uma.shankar@intel.com> wrote:
> Enable Pipe Degamma for XE_LPD. Extend the legacy implementation
> to incorparate the extended lut size for XE_LPD.
>
> v2: Added a helper for degamma lut size (Ville)
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index 42fe549ef6fe..de3ded1e327a 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state)
> }
> }
>
> +static int glk_degamma_lut_size(struct drm_i915_private *i915)
> +{
> + if (DISPLAY_VER(i915) >= 13)
> + return 131;
> + else
> + return 35;
> +}
> +
Why do we have both a function with hardcoded values and device info
members for this?
BR,
Jani.
> static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
> {
> struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
> @@ -827,8 +835,8 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
>
> for (i = 0; i < lut_size; i++) {
> /*
> - * First 33 entries represent range from 0 to 1.0
> - * 34th and 35th entry will represent extended range
> + * First lut_size entries represent range from 0 to 1.0
> + * 3 additional lut entries will represent extended range
> * inputs 3.0 and 7.0 respectively, currently clamped
> * at 1.0. Since the precision is 16bit, the user
> * value can be directly filled to register.
> @@ -844,7 +852,7 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
> }
>
> /* Clamp values > 1.0. */
> - while (i++ < 35)
> + while (i++ < glk_degamma_lut_size(dev_priv))
> intel_de_write_fw(dev_priv, PRE_CSC_GAMC_DATA(pipe), 1 << 16);
>
> intel_de_write_fw(dev_priv, PRE_CSC_GAMC_INDEX(pipe), 0);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-29 16:19 ` Jani Nikula
@ 2021-11-30 10:01 ` Ville Syrjälä
2021-11-30 10:06 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Ville Syrjälä @ 2021-11-30 10:01 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Nov 29, 2021 at 06:19:52PM +0200, Jani Nikula wrote:
> On Fri, 26 Nov 2021, Uma Shankar <uma.shankar@intel.com> wrote:
> > Enable Pipe Degamma for XE_LPD. Extend the legacy implementation
> > to incorparate the extended lut size for XE_LPD.
> >
> > v2: Added a helper for degamma lut size (Ville)
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
> > 1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> > index 42fe549ef6fe..de3ded1e327a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_color.c
> > +++ b/drivers/gpu/drm/i915/display/intel_color.c
> > @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state)
> > }
> > }
> >
> > +static int glk_degamma_lut_size(struct drm_i915_private *i915)
> > +{
> > + if (DISPLAY_VER(i915) >= 13)
> > + return 131;
> > + else
> > + return 35;
> > +}
> > +
>
> Why do we have both a function with hardcoded values and device info
> members for this?
The device info stuff just needs to get nuked. The size of the LUTs
depends on the gamma mode which we already select dynamically (and
if/when we get thre new uapi ironed out it'll become even more
dynamic), so trying to represent it with a single number in device
info is futile.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config Uma Shankar
@ 2021-11-30 10:03 ` Ville Syrjälä
2021-12-07 6:46 ` Shankar, Uma
0 siblings, 1 reply; 13+ messages in thread
From: Ville Syrjälä @ 2021-11-30 10:03 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-gfx
On Fri, Nov 26, 2021 at 01:57:50AM +0530, Uma Shankar wrote:
> XE_LPD has 128 Lut entries for Degamma, with additional 3 entries for
> extended range. It has 511 entries for gamma with additional 2 entries
> for extended range.
>
> v2: Updated lut size for 10bit gamma, added lut_tests (Ville)
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index f01cba4ec283..22eae330f075 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -938,7 +938,11 @@ static const struct intel_device_info adl_s_info = {
>
> #define XE_LPD_FEATURES \
> .abox_mask = GENMASK(1, 0), \
> - .color = { .degamma_lut_size = 0, .gamma_lut_size = 0 }, \
> + .color = { .degamma_lut_size = 128, .gamma_lut_size = 1024, \
> + .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING | \
> + DRM_COLOR_LUT_EQUAL_CHANNELS, \
> + .gamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING, \
The 10bit mode doesn't interpolate so it can handle non-decreasing
values just fine.
With the gamma_lut_tests part dropped this is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + }, \
> .dbuf.size = 4096, \
> .dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2) | BIT(DBUF_S3) | \
> BIT(DBUF_S4), \
> --
> 2.25.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar
2021-11-29 16:19 ` Jani Nikula
@ 2021-11-30 10:04 ` Ville Syrjälä
1 sibling, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2021-11-30 10:04 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-gfx
On Fri, Nov 26, 2021 at 01:57:49AM +0530, Uma Shankar wrote:
> Enable Pipe Degamma for XE_LPD. Extend the legacy implementation
> to incorparate the extended lut size for XE_LPD.
>
> v2: Added a helper for degamma lut size (Ville)
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index 42fe549ef6fe..de3ded1e327a 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state)
> }
> }
>
> +static int glk_degamma_lut_size(struct drm_i915_private *i915)
> +{
> + if (DISPLAY_VER(i915) >= 13)
> + return 131;
> + else
> + return 35;
> +}
> +
> static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
> {
> struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
> @@ -827,8 +835,8 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
>
> for (i = 0; i < lut_size; i++) {
> /*
> - * First 33 entries represent range from 0 to 1.0
> - * 34th and 35th entry will represent extended range
> + * First lut_size entries represent range from 0 to 1.0
> + * 3 additional lut entries will represent extended range
> * inputs 3.0 and 7.0 respectively, currently clamped
> * at 1.0. Since the precision is 16bit, the user
> * value can be directly filled to register.
> @@ -844,7 +852,7 @@ static void glk_load_degamma_lut(const struct intel_crtc_state *crtc_state)
> }
>
> /* Clamp values > 1.0. */
> - while (i++ < 35)
> + while (i++ < glk_degamma_lut_size(dev_priv))
> intel_de_write_fw(dev_priv, PRE_CSC_GAMC_DATA(pipe), 1 << 16);
>
> intel_de_write_fw(dev_priv, PRE_CSC_GAMC_INDEX(pipe), 0);
> --
> 2.25.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-30 10:01 ` Ville Syrjälä
@ 2021-11-30 10:06 ` Jani Nikula
2021-12-07 6:45 ` Shankar, Uma
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2021-11-30 10:06 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Tue, 30 Nov 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Nov 29, 2021 at 06:19:52PM +0200, Jani Nikula wrote:
>> On Fri, 26 Nov 2021, Uma Shankar <uma.shankar@intel.com> wrote:
>> > Enable Pipe Degamma for XE_LPD. Extend the legacy implementation
>> > to incorparate the extended lut size for XE_LPD.
>> >
>> > v2: Added a helper for degamma lut size (Ville)
>> >
>> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
>> > 1 file changed, 11 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
>> > index 42fe549ef6fe..de3ded1e327a 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_color.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_color.c
>> > @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state *crtc_state)
>> > }
>> > }
>> >
>> > +static int glk_degamma_lut_size(struct drm_i915_private *i915)
>> > +{
>> > + if (DISPLAY_VER(i915) >= 13)
>> > + return 131;
>> > + else
>> > + return 35;
>> > +}
>> > +
>>
>> Why do we have both a function with hardcoded values and device info
>> members for this?
>
> The device info stuff just needs to get nuked. The size of the LUTs
> depends on the gamma mode which we already select dynamically (and
> if/when we get thre new uapi ironed out it'll become even more
> dynamic), so trying to represent it with a single number in device
> info is futile.
Works for me, I just like to have the single point of truth instead of
split all over the place. Not against adding this now, but let's not
forget to follow up with the cleanup.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
2021-11-30 10:06 ` Jani Nikula
@ 2021-12-07 6:45 ` Shankar, Uma
0 siblings, 0 replies; 13+ messages in thread
From: Shankar, Uma @ 2021-12-07 6:45 UTC (permalink / raw)
To: Jani Nikula, Ville Syrjälä; +Cc: intel-gfx
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, November 30, 2021 3:36 PM
> To: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma
>
> On Tue, 30 Nov 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Nov 29, 2021 at 06:19:52PM +0200, Jani Nikula wrote:
> >> On Fri, 26 Nov 2021, Uma Shankar <uma.shankar@intel.com> wrote:
> >> > Enable Pipe Degamma for XE_LPD. Extend the legacy implementation to
> >> > incorparate the extended lut size for XE_LPD.
> >> >
> >> > v2: Added a helper for degamma lut size (Ville)
> >> >
> >> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> >> > ---
> >> > drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++++---
> >> > 1 file changed, 11 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_color.c
> >> > b/drivers/gpu/drm/i915/display/intel_color.c
> >> > index 42fe549ef6fe..de3ded1e327a 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_color.c
> >> > +++ b/drivers/gpu/drm/i915/display/intel_color.c
> >> > @@ -808,6 +808,14 @@ static void bdw_load_luts(const struct intel_crtc_state
> *crtc_state)
> >> > }
> >> > }
> >> >
> >> > +static int glk_degamma_lut_size(struct drm_i915_private *i915) {
> >> > + if (DISPLAY_VER(i915) >= 13)
> >> > + return 131;
> >> > + else
> >> > + return 35;
> >> > +}
> >> > +
> >>
> >> Why do we have both a function with hardcoded values and device info
> >> members for this?
> >
> > The device info stuff just needs to get nuked. The size of the LUTs
> > depends on the gamma mode which we already select dynamically (and
> > if/when we get thre new uapi ironed out it'll become even more
> > dynamic), so trying to represent it with a single number in device
> > info is futile.
>
> Works for me, I just like to have the single point of truth instead of split all over the
> place. Not against adding this now, but let's not forget to follow up with the
> cleanup.
Yeah, device info may not be needed once we have the new UAPI's. Will clean it up,
once we get that closed.
Thanks Jani and Ville for the review and feedbacks.
Regards,
Uma Shankar
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config
2021-11-30 10:03 ` Ville Syrjälä
@ 2021-12-07 6:46 ` Shankar, Uma
0 siblings, 0 replies; 13+ messages in thread
From: Shankar, Uma @ 2021-12-07 6:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Tuesday, November 30, 2021 3:33 PM
> To: Shankar, Uma <uma.shankar@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>
> Subject: Re: [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform
> config
>
> On Fri, Nov 26, 2021 at 01:57:50AM +0530, Uma Shankar wrote:
> > XE_LPD has 128 Lut entries for Degamma, with additional 3 entries for
> > extended range. It has 511 entries for gamma with additional 2 entries
> > for extended range.
> >
> > v2: Updated lut size for 10bit gamma, added lut_tests (Ville)
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_pci.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c index f01cba4ec283..22eae330f075
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -938,7 +938,11 @@ static const struct intel_device_info adl_s_info
> > = {
> >
> > #define XE_LPD_FEATURES \
> > .abox_mask = GENMASK(1, 0), \
> > - .color = { .degamma_lut_size = 0, .gamma_lut_size = 0 }, \
> > + .color = { .degamma_lut_size = 128, .gamma_lut_size = 1024, \
> > + .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING |
> \
> > + DRM_COLOR_LUT_EQUAL_CHANNELS,
> \
> > + .gamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING,
> \
>
> The 10bit mode doesn't interpolate so it can handle non-decreasing values just fine.
>
> With the gamma_lut_tests part dropped this is
Will drop this, refloat and merge.
Thanks Ville for the review and all the inputs.
Regards,
Uma Shankar
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > + }, \
> > .dbuf.size = 4096, \
> > .dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2) | BIT(DBUF_S3) |
> \
> > BIT(DBUF_S4), \
> > --
> > 2.25.1
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-12-07 6:46 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 20:27 [Intel-gfx] [PATCH v2 0/3] Enable pipe color support on D13 platform Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 1/3] drm/i915/xelpd: Enable Pipe color support for " Uma Shankar
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar
2021-11-29 16:19 ` Jani Nikula
2021-11-30 10:01 ` Ville Syrjälä
2021-11-30 10:06 ` Jani Nikula
2021-12-07 6:45 ` Shankar, Uma
2021-11-30 10:04 ` Ville Syrjälä
2021-11-25 20:27 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/xelpd: Add Pipe Color Lut caps to platform config Uma Shankar
2021-11-30 10:03 ` Ville Syrjälä
2021-12-07 6:46 ` Shankar, Uma
2021-11-25 21:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Enable pipe color support on D13 platform (rev2) Patchwork
2021-11-26 4:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.