All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP
@ 2021-05-21  9:14 Heiko Thiery
  2021-05-21  9:35 ` Yann E. MORIN
  2021-06-07 21:19 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Heiko Thiery @ 2021-05-21  9:14 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/waylandpp/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
index 3d7362b3c0..86ca965056 100644
--- a/package/waylandpp/Config.in
+++ b/package/waylandpp/Config.in
@@ -3,14 +3,16 @@ config BR2_PACKAGE_WAYLANDPP
 	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 	depends on BR2_HOST_GCC_AT_LEAST_4_9
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_WAYLAND
 	help
 	  Wayland C++ bindings
 
 	  https://github.com/NilsBrause/waylandpp
 
-comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9"
+comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9, C++ support"
 	depends on BR2_PACKAGE_WAYLAND
 	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
 		!BR2_HOST_GCC_AT_LEAST_4_9 || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+		!BR2_INSTALL_LIBSTDCPP
-- 
2.30.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP
  2021-05-21  9:14 [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP Heiko Thiery
@ 2021-05-21  9:35 ` Yann E. MORIN
  2021-06-07 21:19 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-05-21  9:35 UTC (permalink / raw)
  To: buildroot

Heiko, All,

On 2021-05-21 11:14 +0200, Heiko Thiery spake thusly:
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/waylandpp/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
> index 3d7362b3c0..86ca965056 100644
> --- a/package/waylandpp/Config.in
> +++ b/package/waylandpp/Config.in
> @@ -3,14 +3,16 @@ config BR2_PACKAGE_WAYLANDPP
>  	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>  	depends on BR2_HOST_GCC_AT_LEAST_4_9
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +	depends on BR2_INSTALL_LIBSTDCPP

You forgot to propagate that dependency to packages that select
waylandpp, namely kodi, so I've done that and applied to master,
thanks.

Regards,
Yann E. MORIN.

>  	depends on BR2_PACKAGE_WAYLAND
>  	help
>  	  Wayland C++ bindings
>  
>  	  https://github.com/NilsBrause/waylandpp
>  
> -comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9"
> +comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9, C++ support"
>  	depends on BR2_PACKAGE_WAYLAND
>  	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
>  		!BR2_HOST_GCC_AT_LEAST_4_9 || \
> -		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> +		!BR2_INSTALL_LIBSTDCPP
> -- 
> 2.30.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP
  2021-05-21  9:14 [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP Heiko Thiery
  2021-05-21  9:35 ` Yann E. MORIN
@ 2021-06-07 21:19 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-06-07 21:19 UTC (permalink / raw)
  To: buildroot

>>>>> "Heiko" == Heiko Thiery <heiko.thiery@gmail.com> writes:

 > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-07 21:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21  9:14 [Buildroot] [PATCH] package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP Heiko Thiery
2021-05-21  9:35 ` Yann E. MORIN
2021-06-07 21:19 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.