All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libjpeg: switch to s.b.o. as source site
@ 2021-03-06  9:04 Yann E. MORIN
  2021-03-06 10:12 ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2021-03-06  9:04 UTC (permalink / raw)
  To: buildroot

The tarball for version 9d, released 2020-01-12, has been silently
replaced upstream (a kinfd of BOM was removed from a few files),
causing hash mismatch.

This means that all our versions since 2020.02 will fail the hash
check, and fallback to using s.b.o. so we can't update the copy we
have on s.b.o.

As a consequence, we can't update the hash in master (soon 2021.02)
otherwise it would not match what we have on s.b.o.

This means that users will see hash mismatch by default, which is not
very nice. Although we can't do anything for all previous releases,
we can still try to paper over the problem for the future ones, like
2021.02, by switching the upstream to be s.b.o.

Sigh... :-(

Reported-by: Nick Shaforostov <mshaforostov@airmusictech.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
---
 package/libjpeg/libjpeg.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/package/libjpeg/libjpeg.mk b/package/libjpeg/libjpeg.mk
index 389ecb6299..bd463ad40a 100644
--- a/package/libjpeg/libjpeg.mk
+++ b/package/libjpeg/libjpeg.mk
@@ -5,7 +5,11 @@
 ################################################################################
 
 LIBJPEG_VERSION = 9d
-LIBJPEG_SITE = http://www.ijg.org/files
+# 9d was released 2020-01-12, but the tarball was replaced upstream circa
+# 2021-03, causing hash mismatch. Until there is a new version released,
+# use our cached copy from s.b.o.
+#LIBJPEG_SITE = http://www.ijg.org/files
+LIBJPEG_SITE = http://sources.buildroot.org/libjpeg/
 LIBJPEG_SOURCE = jpegsrc.v$(LIBJPEG_VERSION).tar.gz
 LIBJPEG_LICENSE = IJG
 LIBJPEG_LICENSE_FILES = README
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/libjpeg: switch to s.b.o. as source site
  2021-03-06  9:04 [Buildroot] [PATCH] package/libjpeg: switch to s.b.o. as source site Yann E. MORIN
@ 2021-03-06 10:12 ` Peter Korsgaard
  2021-03-16 21:37   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2021-03-06 10:12 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The tarball for version 9d, released 2020-01-12, has been silently
 > replaced upstream (a kinfd of BOM was removed from a few files),

Ahh, the Windows-style unicode byte order mark:

https://en.wikipedia.org/wiki/Byte_order_mark

Committed after adding the bugzilla reference, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/libjpeg: switch to s.b.o. as source site
  2021-03-06 10:12 ` Peter Korsgaard
@ 2021-03-16 21:37   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-03-16 21:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
 >> The tarball for version 9d, released 2020-01-12, has been silently
 >> replaced upstream (a kinfd of BOM was removed from a few files),

 > Ahh, the Windows-style unicode byte order mark:

 > https://en.wikipedia.org/wiki/Byte_order_mark

 > Committed after adding the bugzilla reference, thanks.

Committed to 2020.02.x and 2020.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-16 21:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06  9:04 [Buildroot] [PATCH] package/libjpeg: switch to s.b.o. as source site Yann E. MORIN
2021-03-06 10:12 ` Peter Korsgaard
2021-03-16 21:37   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.