[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/assimp/assimp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk
index 4d447487ba..1316720423 100644
--- a/package/assimp/assimp.mk
+++ b/package/assimp/assimp.mk
@@ -19,7 +19,7 @@ endif
 # workaround SuperH compiler failure when static linking (i.e -fPIC is
 # not passed) in gcc versions 5.x or older. The -Os optimization level
 # causes a "unable to find a register to spill in class
-# ?GENERAL_REGS?" error. -O2 works fine.
+# 'GENERAL_REGS'" error. -O2 works fine.
 ifeq ($(BR2_sh):$(BR2_STATIC_LIBS):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:y:)
 ASSIMP_CXXFLAGS += -O2
 endif
--
2.21.0

[Buildroot] [PATCH v1 02/28] package/ffmpeg: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/ffmpeg/ffmpeg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
index 9a5a178a48..8c91b149f4 100644
--- a/package/ffmpeg/ffmpeg.mk
+++ b/package/ffmpeg/ffmpeg.mk
@@ -490,7 +490,7 @@ else
 FFMPEG_CONF_OPTS += --enable-mipsfpu
 endif

-#?Fix build failure on "addi opcode not supported"
+# Fix build failure on "addi opcode not supported"
 ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
 FFMPEG_CONF_OPTS += --disable-asm
 endif
--
2.21.0

[Buildroot] [PATCH v1 03/28] package/libglu: replace utf-8 apostrophe by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libglu/libglu.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libglu/libglu.mk b/package/libglu/libglu.mk
index 0e5242f85e..604045c225 100644
--- a/package/libglu/libglu.mk
+++ b/package/libglu/libglu.mk
@@ -10,7 +10,7 @@ LIBGLU_SOURCE = glu-$(LIBGLU_VERSION).tar.gz
 LIBGLU_LICENSE = SGI-B-2.0
 LIBGLU_LICENSE_FILES = include/GL/glu.h
 LIBGLU_INSTALL_STAGING = YES
-# upstream does not distribute a autoconf?ed configure script
+# upstream does not distribute a autoconf'ed configure script
 LIBGLU_AUTORECONF = YES
 LIBGLU_DEPENDENCIES = libgl host-pkgconf

--
2.21.0

[Buildroot] [PATCH v1 04/28] package/libopenssl: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libopenssl/libopenssl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
index 36623fa85f..b7eff06c80 100644
--- a/package/libopenssl/libopenssl.mk
+++ b/package/libopenssl/libopenssl.mk
@@ -39,7 +39,7 @@ endif
 #   ./libcrypto.so: undefined reference to `makecontext'
 #
 # - uclibc:
-#   crypto/async/arch/../arch/async_posix.h:32:5: error: unknown type name ?ucontext_t?
+#   crypto/async/arch/../arch/async_posix.h:32:5: error: unknown type name 'ucontext_t'
 #

 ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
--
2.21.0

[Buildroot] [PATCH v1 05/28] package/qemu: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/qemu/qemu.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 19bcafa62f..025c322b98 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -9,7 +9,7 @@ QEMU_SOURCE = qemu-$(QEMU_VERSION).tar.xz
 QEMU_SITE = http://download.qemu.org
 QEMU_LICENSE = GPL-2.0, LGPL-2.1, MIT, BSD-3-Clause, BSD-2-Clause, Others/BSD-1c
 QEMU_LICENSE_FILES = COPYING COPYING.LIB
-#?NOTE: there is no top-level license file for non-(L)GPL licenses;
+# NOTE: there is no top-level license file for non-(L)GPL licenses;
 #       the non-(L)GPL license texts are specified in the affected
 #       individual source files.

--
2.21.0

[Buildroot] [PATCH v1 06/28] package/reaver: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/reaver/reaver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/reaver/reaver.mk b/package/reaver/reaver.mk
index 328a5c76a3..42b2aaa955 100644
--- a/package/reaver/reaver.mk
+++ b/package/reaver/reaver.mk
@@ -5,7 +5,7 @@
 ################################################################################

 # Older repos for this project will not cross-compile easily
-#?while this one works right away
+# while this one works right away
 REAVER_VERSION = v1.6.5
 REAVER_SITE = $(call github,t6x,reaver-wps-fork-t6x,$(REAVER_VERSION))
 REAVER_LICENSE = GPL-2.0+
--
2.21.0

[Buildroot] [PATCH v1 07/28] package/sysklogd: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/sysklogd/sysklogd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sysklogd/sysklogd.mk b/package/sysklogd/sysklogd.mk
index 8cd7f9573c..266c171170 100644
--- a/package/sysklogd/sysklogd.mk
+++ b/package/sysklogd/sysklogd.mk
@@ -8,7 +8,7 @@ SYSKLOGD_VERSION = 1.6
 SYSKLOGD_SITE = $(call github,troglobit,sysklogd,v$(SYSKLOGD_VERSION))
 SYSKLOGD_LICENSE = GPL-2.0+
 SYSKLOGD_LICENSE_FILES = COPYING
-#?From git
+# From git
 SYSKLOGD_AUTORECONF = YES

 define SYSKLOGD_INSTALL_SAMPLE_CONFIG
--
2.21.0

[Buildroot] [PATCH v1 08/28] package/tekui: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/tekui/tekui.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/tekui/tekui.mk b/package/tekui/tekui.mk
index 3f39072527..13000edd3e 100644
--- a/package/tekui/tekui.mk
+++ b/package/tekui/tekui.mk
@@ -11,7 +11,7 @@ TEKUI_LICENSE = MIT
 TEKUI_LICENSE_FILES = COPYRIGHT
 TEKUI_DEPENDENCIES = freetype luainterpreter

-#?Package does not build in parallel due to improper make rules
+# Package does not build in parallel due to improper make rules
 TEKUI_MAKE = $(MAKE1)

 TEKUI_MAKE_OPTS = \
--
2.21.0

[Buildroot] [PATCH v1 09/28] package/vde2: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/vde2/vde2.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/vde2/vde2.mk b/package/vde2/vde2.mk
index e2ec12416e..29337601c4 100644
--- a/package/vde2/vde2.mk
+++ b/package/vde2/vde2.mk
@@ -15,7 +15,7 @@ VDE2_INSTALL_STAGING = YES
 VDE2_AUTORECONF = YES

 # Reasons for enabling/disabling stuff:
-#?- tuntap is enabled in the hope we're using a recent-enough toolchain
+# - tuntap is enabled in the hope we're using a recent-enough toolchain
 #   that does have if_tun.h (virtually everything these days)
 # - kvde_switch is disabled because it requires a patched kernel
 # - cryptcab is disabled to not depend on openSSL
@@ -34,7 +34,7 @@ VDE2_CONF_OPTS = \
 	--disable-python \
 	--enable-tuntap

-#?Package does not build in parallel due to improper make rules
+# Package does not build in parallel due to improper make rules
 VDE2_MAKE = $(MAKE1)

 HOST_VDE2_CONF_OPTS = \
--
2.21.0

[Buildroot] [PATCH v1 10/28] package/capnproto: replace utf-8 apostrophe by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/capnproto/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/capnproto/Config.in b/package/capnproto/Config.in
index 00328fa6ce..a979a334ff 100644
--- a/package/capnproto/Config.in
+++ b/package/capnproto/Config.in
@@ -10,7 +10,7 @@ config BR2_PACKAGE_CAPNPROTO
 	  Cap'n Proto is an insanely fast data interchange format
 	  and capability-based RPC system. Think JSON, except
 	  binary. Or think Protocol Buffers, except faster. In
-	  fact, in benchmarks, Cap?n Proto is INFINITY TIMES
+	  fact, in benchmarks, Cap'n Proto is INFINITY TIMES
 	  faster than Protocol Buffers.

 	  https://capnproto.org/index.html
--
2.21.0

[Buildroot] [PATCH v1 11/28] package/collectd: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/collectd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/collectd/Config.in b/package/collectd/Config.in
index 3222547b68..0cf04b5180 100644
--- a/package/collectd/Config.in
+++ b/package/collectd/Config.in
@@ -389,7 +389,7 @@ config BR2_PACKAGE_COLLECTD_POSTGRESQL
 	  Connects to and executes SQL statements on a PostgreSQL
 	  database. It then reads back the results and, depending on the
 	  configuration, the returned values are then converted into
-	  collectd ?value lists?.
+	  collectd 'value lists'.

 comment "postgresql support needs a toolchain w/ wchar"
 	depends on !BR2_USE_WCHAR
--
2.21.0

[Buildroot] [PATCH v1 12/28] package/jemalloc: eplace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/jemalloc/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/jemalloc/Config.in b/package/jemalloc/Config.in
index 2bf762903d..c272d4522c 100644
--- a/package/jemalloc/Config.in
+++ b/package/jemalloc/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS
 	bool
-	#?see include/jemalloc/internal/quantum.h
+	# see include/jemalloc/internal/quantum.h
 	default y if BR2_arm || BR2_armeb
 	default y if BR2_aarch64 || BR2_aarch64_be
 	default y if BR2_i386 || BR2_x86_64
--
2.21.0

[Buildroot] [PATCH v1 13/28] package/libunwind: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libunwind/libunwind.hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libunwind/libunwind.hash b/package/libunwind/libunwind.hash
index 394bef1287..c8d44b44ac 100644
--- a/package/libunwind/libunwind.hash
+++ b/package/libunwind/libunwind.hash
@@ -1,5 +1,5 @@
 # Locally calculated after checking pgp signature
 sha256 43997a3939b6ccdf2f669b50fdb8a4d3205374728c2923ddc2354c65260214f8  libunwind-1.3.1.tar.gz

-#?Hash for license file
+# Hash for license file
 sha256 6a0dbbdaec2b3136b7bf045586f4212bdf74e7af688bf9dfe9154607cf5ec156  COPYING
--
2.21.0

[Buildroot] [PATCH v1 14/28] package/madplay: replace utf-8 hyphen by ascii hyphen

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/madplay/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/madplay/Config.in b/package/madplay/Config.in
index 922460e0c2..a3373057a1 100644
--- a/package/madplay/Config.in
+++ b/package/madplay/Config.in
@@ -6,8 +6,8 @@ config BR2_PACKAGE_MADPLAY
 	  Command-line front-end to libmad, a high-quality MPEG audio
 	  decoder.  It currently supports MPEG-1 and the MPEG-2
 	  extension to lower sampling frequencies, as well as the de
-	  facto MPEG 2.5 format. All three audio layers ? Layer I,
-	  Layer II, and Layer III (i.e. MP3) ? are fully implemented.
+	  facto MPEG 2.5 format. All three audio layers - Layer I,
+	  Layer II, and Layer III (i.e. MP3) - are fully implemented.

 	  http://www.underbit.com/products/mad/

--
2.21.0

[Buildroot] [PATCH v1 15/28] package/mksh: replace utf-8 apostrophe by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/mksh/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mksh/Config.in b/package/mksh/Config.in
index 55d1cc15ed..e6ccc90646 100644
--- a/package/mksh/Config.in
+++ b/package/mksh/Config.in
@@ -14,7 +14,7 @@ config BR2_PACKAGE_MKSH
 	  secure shell not cut off modern extensions; a shell with
 	  Unicode support; an actively developed, current, and
 	  portable product; one with developers that listen to
-	  their users? requests and implement them if they
+	  their users' requests and implement them if they
 	  actually make sense.

 	  mksh aims to replace pdksh in all but very rare use cases
--
2.21.0

[Buildroot] [PATCH v1 16/28] package/mpfr: replace utf-8 space by ascii character

[Peter Seiderer]

Replace utf-8 NO-BREAK-SPACE (c2 a0) in comment line by simple
ascii space character.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/mpfr/mpfr.hash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mpfr/mpfr.hash b/package/mpfr/mpfr.hash
index 593c97d774..ea44b8c20a 100644
--- a/package/mpfr/mpfr.hash
+++ b/package/mpfr/mpfr.hash
@@ -1,5 +1,5 @@
 # From http://lists.gnu.org/archive/html/info-gnu/2019-01/msg00019.html
 sha256 1d3be708604eae0e42d578ba93b390c2a145f17743a744d8f3f8c2ad5855a38a  mpfr-4.0.2.tar.xz

-#?Hash for license file
+# Hash for license file
 sha256 e3a994d82e644b03a792a930f574002658412f62407f5fee083f2555c5f23118  COPYING.LESSER
--
2.21.0

[Buildroot] [PATCH v1 17/28] package/pngquant: replace utf-8 hyphen by ascii hyphen

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/pngquant/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pngquant/Config.in b/package/pngquant/Config.in
index c63f0f9d09..5fc93f60a2 100644
--- a/package/pngquant/Config.in
+++ b/package/pngquant/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PNGQUANT
 	select BR2_PACKAGE_LIBPNG
 	select BR2_PACKAGE_ZLIB
 	help
-	  Lossy PNG compressor ? pngquant command and libimagequant
+	  Lossy PNG compressor - pngquant command and libimagequant
 	  library

 	  https://pngquant.org
--
2.21.0

[Buildroot] [PATCH v1 18/28] package/python-gunicorn: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/python-gunicorn/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/python-gunicorn/Config.in b/package/python-gunicorn/Config.in
index 098c3fa6b0..518157bf93 100644
--- a/package/python-gunicorn/Config.in
+++ b/package/python-gunicorn/Config.in
@@ -3,8 +3,8 @@ config BR2_PACKAGE_PYTHON_GUNICORN
 	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
 	help
-	  Gunicorn ?Green Unicorn? is a Python WSGI HTTP Server for
-	  UNIX. It?s a pre-fork worker model ported from Ruby?s
+	  Gunicorn 'Green Unicorn' is a Python WSGI HTTP Server for
+	  UNIX. It's a pre-fork worker model ported from Ruby's
 	  Unicorn project. The Gunicorn server is broadly compatible
 	  with various web frameworks, simply implemented, light on
 	  server resource usage, and fairly speedy.
--
2.21.0

[Buildroot] [PATCH v1 19/28] package/python-idna: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/python-idna/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
index 4ff4581d53..1fd56ceaf6 100644
--- a/package/python-idna/Config.in
+++ b/package/python-idna/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PYTHON_IDNA
 	help
 	  A library to support the Internationalised Domain Names in
 	  Applications (IDNA) protocol as specified in RFC 5891. This
-	  version of the protocol is often referred to as ?IDNA2008?
+	  version of the protocol is often referred to as 'IDNA2008'
 	  and can produce different results from the earlier standard
 	  from 2003.

--
2.21.0

[Buildroot] [PATCH v1 20/28] package/python-mutagen: replace utf-8 apostrophe by ascii single quote

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/python-mutagen/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/python-mutagen/Config.in b/package/python-mutagen/Config.in
index 470cd996a7..3c95e37447 100644
--- a/package/python-mutagen/Config.in
+++ b/package/python-mutagen/Config.in
@@ -6,7 +6,7 @@ config BR2_PACKAGE_PYTHON_MUTAGEN
 	select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 # runtime
 	help
 	  Mutagen is a Python module to handle audio metadata.  It
-	  supports ASF, FLAC, MP4, Monkey?s Audio, MP3, Musepack, Ogg
+	  supports ASF, FLAC, MP4, Monkey's Audio, MP3, Musepack, Ogg
 	  Opus, Ogg FLAC, Ogg Speex, Ogg Theora, Ogg Vorbis, True
 	  Audio, WavPack, OptimFROG, and AIFF audio files. All
 	  versions of ID3v2 are supported, and all standard ID3v2.4
--
2.21.0

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Thomas Petazzoni]

Hello Peter,

On Tue,  7 May 2019 22:35:21 +0200
Peter Seiderer <ps.report@gmx.net> wrote:

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/assimp/assimp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for all those patches. I think it would be useful to extend the
check-package logic to check that such UTF-8 quotes/spaces don't get
re-added.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello Peter,
 > On Tue,  7 May 2019 22:35:21 +0200
 > Peter Seiderer <ps.report@gmx.net> wrote:

 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 >> ---
 >> package/assimp/assimp.mk | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Thanks for all those patches. I think it would be useful to extend the
 > check-package logic to check that such UTF-8 quotes/spaces don't get
 > re-added.

Agreed!

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed pacth 1..20 (21..28 haven't made it to patchwork or my mailbox
yet?), thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Arnout Vandecappelle]

On 07/05/2019 23:02, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> 
>  > Hello Peter,
>  > On Tue,  7 May 2019 22:35:21 +0200
>  > Peter Seiderer <ps.report@gmx.net> wrote:
> 
>  >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>  >> ---
>  >> package/assimp/assimp.mk | 2 +-
>  >> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
>  > Thanks for all those patches. I think it would be useful to extend the
>  > check-package logic to check that such UTF-8 quotes/spaces don't get
>  > re-added.
> 
> Agreed!

 I think in Config.in, *.mk and *.hash we should never need any non-ascii
character, so that check would be easy.

 In patches, there may be non-ascii characters in the From, Sob and other tags,
and in the patch contents itself. So that will be tricky to check.

 Regards,
 Arnout

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 07/05/2019 23:02, Peter Korsgaard wrote:
 >>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
 >> 
 >> > Hello Peter,
 >> > On Tue,  7 May 2019 22:35:21 +0200
 >> > Peter Seiderer <ps.report@gmx.net> wrote:
 >> 
 >> >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 >> >> ---
 >> >> package/assimp/assimp.mk | 2 +-
 >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> > Thanks for all those patches. I think it would be useful to extend the
 >> > check-package logic to check that such UTF-8 quotes/spaces don't get
 >> > re-added.
 >> 
 >> Agreed!

 >  I think in Config.in, *.mk and *.hash we should never need any non-ascii
 > character, so that check would be easy.

I am not so sure about Config.in. If you look at:

package/intel-mediasdk/Config.in
package/imagemagick/Config.in
package/zeromq/Config.in
package/directfb/Config.in

They have UTF-8 copyright characters, a funny e in bezier and the OE in
zeromq.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote

[Peter Seiderer]

Hello *,

On Wed, 08 May 2019 09:26:09 +0200, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
>  > On 07/05/2019 23:02, Peter Korsgaard wrote:
>  >>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>  >>
>  >> > Hello Peter,
>  >> > On Tue,  7 May 2019 22:35:21 +0200
>  >> > Peter Seiderer <ps.report@gmx.net> wrote:
>  >>
>  >> >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>  >> >> ---
>  >> >> package/assimp/assimp.mk | 2 +-
>  >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>  >>
>  >> > Thanks for all those patches. I think it would be useful to extend the
>  >> > check-package logic to check that such UTF-8 quotes/spaces don't get
>  >> > re-added.
>  >>
>  >> Agreed!
>
>  >  I think in Config.in, *.mk and *.hash we should never need any non-ascii
>  > character, so that check would be easy.

First draft, checking only the .mk files, just sent out, see [1]...

>
> I am not so sure about Config.in. If you look at:
>
> package/intel-mediasdk/Config.in
> package/imagemagick/Config.in
> package/zeromq/Config.in
> package/directfb/Config.in
>
> They have UTF-8 copyright characters, a funny e in bezier and the OE in
> zeromq.
>

- do not check (and keep as is)
- whitelist for some special characters (per file?)
- convert to plain ascii, e.g: (R), bezier, zeromq (without the specail zero)...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/1097166/