* [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
@ 2019-03-13 17:44 Markus Armbruster
2019-03-13 18:22 ` [Qemu-devel] " Eric Blake
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Markus Armbruster @ 2019-03-13 17:44 UTC (permalink / raw)
To: qemu-devel
Cc: anthony.perard, xen-devel, sstabellini, qemu-block, paul.durrant
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir hw/block --in-place
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/block/xen-block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 70fc2455e8..9c722b9b95 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -771,7 +771,7 @@ static XenBlockDrive *xen_block_drive_create(const char *id,
QDict *cache_qdict = qdict_new();
qdict_put_bool(cache_qdict, "direct", true);
- qdict_put_obj(file_layer, "cache", QOBJECT(cache_qdict));
+ qdict_put(file_layer, "cache", cache_qdict);
qdict_put_str(file_layer, "aio", "native");
}
@@ -796,7 +796,7 @@ static XenBlockDrive *xen_block_drive_create(const char *id,
qdict_put_str(driver_layer, "driver", driver);
g_free(driver);
- qdict_put_obj(driver_layer, "file", QOBJECT(file_layer));
+ qdict_put(driver_layer, "file", file_layer);
g_assert(!drive->node_name);
drive->node_name = xen_block_blockdev_add(drive->id, driver_layer,
--
2.17.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-13 17:44 [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate Markus Armbruster
@ 2019-03-13 18:22 ` Eric Blake
2019-03-14 9:30 ` Paul Durrant
2019-03-14 14:38 ` [Qemu-block] " Kevin Wolf
2 siblings, 0 replies; 7+ messages in thread
From: Eric Blake @ 2019-03-13 18:22 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: anthony.perard, xen-devel, sstabellini, qemu-block, paul.durrant
[-- Attachment #1.1.1: Type: text/plain, Size: 672 bytes --]
On 3/13/19 12:44 PM, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir hw/block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/block/xen-block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
Safe for 4.0 softfreeze in my opinion, but also harmless if it slips to 4.1.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-13 17:44 [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate Markus Armbruster
2019-03-13 18:22 ` [Qemu-devel] " Eric Blake
@ 2019-03-14 9:30 ` Paul Durrant
2019-03-14 14:38 ` [Qemu-block] " Kevin Wolf
2 siblings, 0 replies; 7+ messages in thread
From: Paul Durrant @ 2019-03-14 9:30 UTC (permalink / raw)
To: 'Markus Armbruster', qemu-devel
Cc: Anthony Perard, xen-devel, sstabellini, qemu-block
> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: 13 March 2019 17:45
> To: qemu-devel@nongnu.org
> Cc: sstabellini@kernel.org; Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org; qemu-block@nongnu.org
> Subject: [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
>
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir hw/block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> hw/block/xen-block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
> index 70fc2455e8..9c722b9b95 100644
> --- a/hw/block/xen-block.c
> +++ b/hw/block/xen-block.c
> @@ -771,7 +771,7 @@ static XenBlockDrive *xen_block_drive_create(const char *id,
> QDict *cache_qdict = qdict_new();
>
> qdict_put_bool(cache_qdict, "direct", true);
> - qdict_put_obj(file_layer, "cache", QOBJECT(cache_qdict));
> + qdict_put(file_layer, "cache", cache_qdict);
>
> qdict_put_str(file_layer, "aio", "native");
> }
> @@ -796,7 +796,7 @@ static XenBlockDrive *xen_block_drive_create(const char *id,
> qdict_put_str(driver_layer, "driver", driver);
> g_free(driver);
>
> - qdict_put_obj(driver_layer, "file", QOBJECT(file_layer));
> + qdict_put(driver_layer, "file", file_layer);
>
> g_assert(!drive->node_name);
> drive->node_name = xen_block_blockdev_add(drive->id, driver_layer,
> --
> 2.17.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-13 17:44 [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate Markus Armbruster
2019-03-13 18:22 ` [Qemu-devel] " Eric Blake
2019-03-14 9:30 ` Paul Durrant
@ 2019-03-14 14:38 ` Kevin Wolf
2019-03-14 19:04 ` [Qemu-devel] " Markus Armbruster
2 siblings, 1 reply; 7+ messages in thread
From: Kevin Wolf @ 2019-03-14 14:38 UTC (permalink / raw)
To: Markus Armbruster
Cc: sstabellini, qemu-block, qemu-devel, paul.durrant,
anthony.perard, xen-devel
Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir hw/block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Which tree should this go through? The Xen one?
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-14 14:38 ` [Qemu-block] " Kevin Wolf
@ 2019-03-14 19:04 ` Markus Armbruster
2019-03-15 10:53 ` Anthony PERARD
0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2019-03-14 19:04 UTC (permalink / raw)
To: Kevin Wolf
Cc: sstabellini, qemu-block, qemu-devel, paul.durrant,
anthony.perard, xen-devel
Kevin Wolf <kwolf@redhat.com> writes:
> Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
>> Patch created mechanically by rerunning:
>>
>> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
>> --macro-file scripts/cocci-macro-file.h \
>> --dir hw/block --in-place
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Thanks!
> Which tree should this go through? The Xen one?
Fine with me. I could also include it in a "miscellaneous cleanup" pull
request along with other cleanup patches I got in flight.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-14 19:04 ` [Qemu-devel] " Markus Armbruster
@ 2019-03-15 10:53 ` Anthony PERARD
2019-03-15 14:46 ` Markus Armbruster
0 siblings, 1 reply; 7+ messages in thread
From: Anthony PERARD @ 2019-03-15 10:53 UTC (permalink / raw)
To: Markus Armbruster
Cc: Kevin Wolf, sstabellini, qemu-block, qemu-devel, paul.durrant, xen-devel
On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote:
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
> >> Patch created mechanically by rerunning:
> >>
> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> >> --macro-file scripts/cocci-macro-file.h \
> >> --dir hw/block --in-place
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >
> > Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> Thanks!
>
> > Which tree should this go through? The Xen one?
>
> Fine with me. I could also include it in a "miscellaneous cleanup" pull
> request along with other cleanup patches I got in flight.
Markus, I don't have any other Xen patches, so could you include this
one in your pull request?
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate
2019-03-15 10:53 ` Anthony PERARD
@ 2019-03-15 14:46 ` Markus Armbruster
0 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2019-03-15 14:46 UTC (permalink / raw)
To: Anthony PERARD
Cc: Kevin Wolf, sstabellini, qemu-block, qemu-devel, paul.durrant, xen-devel
Anthony PERARD <anthony.perard@citrix.com> writes:
> On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote:
>> Kevin Wolf <kwolf@redhat.com> writes:
>>
>> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
>> >> Patch created mechanically by rerunning:
>> >>
>> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
>> >> --macro-file scripts/cocci-macro-file.h \
>> >> --dir hw/block --in-place
>> >>
>> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> >
>> > Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>>
>> Thanks!
>>
>> > Which tree should this go through? The Xen one?
>>
>> Fine with me. I could also include it in a "miscellaneous cleanup" pull
>> request along with other cleanup patches I got in flight.
>
> Markus, I don't have any other Xen patches, so could you include this
> one in your pull request?
Sure!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-15 14:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 17:44 [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate Markus Armbruster
2019-03-13 18:22 ` [Qemu-devel] " Eric Blake
2019-03-14 9:30 ` Paul Durrant
2019-03-14 14:38 ` [Qemu-block] " Kevin Wolf
2019-03-14 19:04 ` [Qemu-devel] " Markus Armbruster
2019-03-15 10:53 ` Anthony PERARD
2019-03-15 14:46 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.