All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-14 11:56 ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-14 11:56 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm, Simon Horman

Enable the scu-simple-card which is used by
the R-Car E3 (r8a77990) based Ebisu board.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f88190463481..b521159f5f33 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
 CONFIG_SND_SOC_RT5514_SPI=m
 CONFIG_SND_SOC_RT5645=m
 CONFIG_SND_SIMPLE_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=m
 CONFIG_SND_AUDIO_GRAPH_CARD=m
 CONFIG_I2C_HID=m
 CONFIG_USB=y
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-14 11:56 ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-14 11:56 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Simon Horman, Magnus Damm, linux-arm-kernel

Enable the scu-simple-card which is used by
the R-Car E3 (r8a77990) based Ebisu board.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f88190463481..b521159f5f33 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
 CONFIG_SND_SOC_RT5514_SPI=m
 CONFIG_SND_SOC_RT5645=m
 CONFIG_SND_SIMPLE_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=m
 CONFIG_SND_AUDIO_GRAPH_CARD=m
 CONFIG_I2C_HID=m
 CONFIG_USB=y
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-14 11:56 ` Simon Horman
@ 2018-12-17  0:29   ` Kuninori Morimoto
  -1 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17  0:29 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm


Hi Simon

> Enable the scu-simple-card which is used by
> the R-Car E3 (r8a77990) based Ebisu board.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index f88190463481..b521159f5f33 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
>  CONFIG_SND_SOC_RT5514_SPI=m
>  CONFIG_SND_SOC_RT5645=m
>  CONFIG_SND_SIMPLE_CARD=m
> +CONFIG_SND_SIMPLE_SCU_CARD=m
>  CONFIG_SND_AUDIO_GRAPH_CARD=m
>  CONFIG_I2C_HID=m
>  CONFIG_USB=y

Is Ebisu board using SIMPLE_SCU_CARD ?
I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD.


^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-17  0:29   ` Kuninori Morimoto
  0 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17  0:29 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel


Hi Simon

> Enable the scu-simple-card which is used by
> the R-Car E3 (r8a77990) based Ebisu board.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index f88190463481..b521159f5f33 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
>  CONFIG_SND_SOC_RT5514_SPI=m
>  CONFIG_SND_SOC_RT5645=m
>  CONFIG_SND_SIMPLE_CARD=m
> +CONFIG_SND_SIMPLE_SCU_CARD=m
>  CONFIG_SND_AUDIO_GRAPH_CARD=m
>  CONFIG_I2C_HID=m
>  CONFIG_USB=y

Is Ebisu board using SIMPLE_SCU_CARD ?
I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-17  0:29   ` Kuninori Morimoto
@ 2018-12-17  8:36     ` Simon Horman
  -1 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-17  8:36 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm

On Mon, Dec 17, 2018 at 09:29:25AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Enable the scu-simple-card which is used by
> > the R-Car E3 (r8a77990) based Ebisu board.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index f88190463481..b521159f5f33 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
> >  CONFIG_SND_SOC_RT5514_SPI=m
> >  CONFIG_SND_SOC_RT5645=m
> >  CONFIG_SND_SIMPLE_CARD=m
> > +CONFIG_SND_SIMPLE_SCU_CARD=m
> >  CONFIG_SND_AUDIO_GRAPH_CARD=m
> >  CONFIG_I2C_HID=m
> >  CONFIG_USB=y
> 
> Is Ebisu board using SIMPLE_SCU_CARD ?
> I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD.
> 

Hi Morimoto-san,

Using renesas_defconfig as a base I find that without enabling
CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:

   CONFIG_SND_AUDIO_GRAPH_CARD
   CONFIG_SND_SIMPLE_CARD

But I see:

[   12.209793] ALSA device list:
[   12.212799]   No soundcards found.

With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:

[   14.087191] ALSA device list:
[   14.090195]   #0: rsnd-ak4613



The above tested using renesas-drivers-2018-12-04-v4.20-rc5

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-17  8:36     ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-17  8:36 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Mon, Dec 17, 2018 at 09:29:25AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Enable the scu-simple-card which is used by
> > the R-Car E3 (r8a77990) based Ebisu board.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index f88190463481..b521159f5f33 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
> >  CONFIG_SND_SOC_RT5514_SPI=m
> >  CONFIG_SND_SOC_RT5645=m
> >  CONFIG_SND_SIMPLE_CARD=m
> > +CONFIG_SND_SIMPLE_SCU_CARD=m
> >  CONFIG_SND_AUDIO_GRAPH_CARD=m
> >  CONFIG_I2C_HID=m
> >  CONFIG_USB=y
> 
> Is Ebisu board using SIMPLE_SCU_CARD ?
> I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD.
> 

Hi Morimoto-san,

Using renesas_defconfig as a base I find that without enabling
CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:

   CONFIG_SND_AUDIO_GRAPH_CARD
   CONFIG_SND_SIMPLE_CARD

But I see:

[   12.209793] ALSA device list:
[   12.212799]   No soundcards found.

With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:

[   14.087191] ALSA device list:
[   14.090195]   #0: rsnd-ak4613



The above tested using renesas-drivers-2018-12-04-v4.20-rc5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-17  8:36     ` Simon Horman
@ 2018-12-17  8:49       ` Kuninori Morimoto
  -1 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17  8:49 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm


Hi Simon

> Using renesas_defconfig as a base I find that without enabling
> CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:
> 
>    CONFIG_SND_AUDIO_GRAPH_CARD
>    CONFIG_SND_SIMPLE_CARD
> 
> But I see:
> 
> [   12.209793] ALSA device list:
> [   12.212799]   No soundcards found.
> 
> With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:
> 
> [   14.087191] ALSA device list:
> [   14.090195]   #0: rsnd-ak4613

Thanks.
56629fcba94c698d8c5be3413981506479566869
("arm64: dts: renesas: ebisu: Enable Audio")
is using "simple-scu-audio-card", but it should be "simple-audio-card".
Can you add and test this patch ?
CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.

--------------
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddc..649d3fd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -159,16 +159,13 @@
 	};
 
 	rsnd_ak4613: sound {
-		compatible = "simple-scu-audio-card";
+		compatible = "simple-audio-card";
 
 		simple-audio-card,name = "rsnd-ak4613";
 		simple-audio-card,format = "left_j";
 		simple-audio-card,bitclock-master = <&sndcpu>;
 		simple-audio-card,frame-master = <&sndcpu>;
 
-		simple-audio-card,prefix = "ak4613";
-		simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback",
-		"DAI0 Capture", "ak4613 Capture";
 		sndcpu: simple-audio-card,cpu {
 			sound-dai = <&rcar_sound>;
 		};
--------------


Best regards
---
Kuninori Morimoto

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-17  8:49       ` Kuninori Morimoto
  0 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17  8:49 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel


Hi Simon

> Using renesas_defconfig as a base I find that without enabling
> CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:
> 
>    CONFIG_SND_AUDIO_GRAPH_CARD
>    CONFIG_SND_SIMPLE_CARD
> 
> But I see:
> 
> [   12.209793] ALSA device list:
> [   12.212799]   No soundcards found.
> 
> With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:
> 
> [   14.087191] ALSA device list:
> [   14.090195]   #0: rsnd-ak4613

Thanks.
56629fcba94c698d8c5be3413981506479566869
("arm64: dts: renesas: ebisu: Enable Audio")
is using "simple-scu-audio-card", but it should be "simple-audio-card".
Can you add and test this patch ?
CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.

--------------
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddc..649d3fd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -159,16 +159,13 @@
 	};
 
 	rsnd_ak4613: sound {
-		compatible = "simple-scu-audio-card";
+		compatible = "simple-audio-card";
 
 		simple-audio-card,name = "rsnd-ak4613";
 		simple-audio-card,format = "left_j";
 		simple-audio-card,bitclock-master = <&sndcpu>;
 		simple-audio-card,frame-master = <&sndcpu>;
 
-		simple-audio-card,prefix = "ak4613";
-		simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback",
-		"DAI0 Capture", "ak4613 Capture";
 		sndcpu: simple-audio-card,cpu {
 			sound-dai = <&rcar_sound>;
 		};
--------------


Best regards
---
Kuninori Morimoto

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-17  8:49       ` Kuninori Morimoto
@ 2018-12-17  9:21         ` Simon Horman
  -1 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-17  9:21 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Mon, Dec 17, 2018 at 05:49:34PM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Using renesas_defconfig as a base I find that without enabling
> > CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:
> > 
> >    CONFIG_SND_AUDIO_GRAPH_CARD
> >    CONFIG_SND_SIMPLE_CARD
> > 
> > But I see:
> > 
> > [   12.209793] ALSA device list:
> > [   12.212799]   No soundcards found.
> > 
> > With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:
> > 
> > [   14.087191] ALSA device list:
> > [   14.090195]   #0: rsnd-ak4613
> 
> Thanks.
> 56629fcba94c698d8c5be3413981506479566869
> ("arm64: dts: renesas: ebisu: Enable Audio")
> is using "simple-scu-audio-card", but it should be "simple-audio-card".
> Can you add and test this patch ?
> CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.


Thanks Morimoto-san,

I confirm that Sound on Ebisu-4D appears to work with a)
CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.

> 
> --------------
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddc..649d3fd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -159,16 +159,13 @@
>  	};
>  
>  	rsnd_ak4613: sound {
> -		compatible = "simple-scu-audio-card";
> +		compatible = "simple-audio-card";
>  
>  		simple-audio-card,name = "rsnd-ak4613";
>  		simple-audio-card,format = "left_j";
>  		simple-audio-card,bitclock-master = <&sndcpu>;
>  		simple-audio-card,frame-master = <&sndcpu>;
>  
> -		simple-audio-card,prefix = "ak4613";
> -		simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback",
> -		"DAI0 Capture", "ak4613 Capture";
>  		sndcpu: simple-audio-card,cpu {
>  			sound-dai = <&rcar_sound>;
>  		};
> --------------
> 
> 
> Best regards
> ---
> Kuninori Morimoto
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-17  9:21         ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-17  9:21 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Mon, Dec 17, 2018 at 05:49:34PM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Using renesas_defconfig as a base I find that without enabling
> > CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:
> > 
> >    CONFIG_SND_AUDIO_GRAPH_CARD
> >    CONFIG_SND_SIMPLE_CARD
> > 
> > But I see:
> > 
> > [   12.209793] ALSA device list:
> > [   12.212799]   No soundcards found.
> > 
> > With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:
> > 
> > [   14.087191] ALSA device list:
> > [   14.090195]   #0: rsnd-ak4613
> 
> Thanks.
> 56629fcba94c698d8c5be3413981506479566869
> ("arm64: dts: renesas: ebisu: Enable Audio")
> is using "simple-scu-audio-card", but it should be "simple-audio-card".
> Can you add and test this patch ?
> CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.


Thanks Morimoto-san,

I confirm that Sound on Ebisu-4D appears to work with a)
CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.

> 
> --------------
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddc..649d3fd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -159,16 +159,13 @@
>  	};
>  
>  	rsnd_ak4613: sound {
> -		compatible = "simple-scu-audio-card";
> +		compatible = "simple-audio-card";
>  
>  		simple-audio-card,name = "rsnd-ak4613";
>  		simple-audio-card,format = "left_j";
>  		simple-audio-card,bitclock-master = <&sndcpu>;
>  		simple-audio-card,frame-master = <&sndcpu>;
>  
> -		simple-audio-card,prefix = "ak4613";
> -		simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback",
> -		"DAI0 Capture", "ak4613 Capture";
>  		sndcpu: simple-audio-card,cpu {
>  			sound-dai = <&rcar_sound>;
>  		};
> --------------
> 
> 
> Best regards
> ---
> Kuninori Morimoto
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-17  9:21         ` Simon Horman
@ 2018-12-17 23:01           ` Kuninori Morimoto
  -1 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17 23:01 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel


Hi Simon

> > Thanks.
> > 56629fcba94c698d8c5be3413981506479566869
> > ("arm64: dts: renesas: ebisu: Enable Audio")
> > is using "simple-scu-audio-card", but it should be "simple-audio-card".
> > Can you add and test this patch ?
> > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.
> 
> 
> Thanks Morimoto-san,
> 
> I confirm that Sound on Ebisu-4D appears to work with a)
> CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.

Thank you for your test.
OK, I will post patch for Ebisu.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-17 23:01           ` Kuninori Morimoto
  0 siblings, 0 replies; 20+ messages in thread
From: Kuninori Morimoto @ 2018-12-17 23:01 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel


Hi Simon

> > Thanks.
> > 56629fcba94c698d8c5be3413981506479566869
> > ("arm64: dts: renesas: ebisu: Enable Audio")
> > is using "simple-scu-audio-card", but it should be "simple-audio-card".
> > Can you add and test this patch ?
> > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.
> 
> 
> Thanks Morimoto-san,
> 
> I confirm that Sound on Ebisu-4D appears to work with a)
> CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.

Thank you for your test.
OK, I will post patch for Ebisu.

Best regards
---
Kuninori Morimoto

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-17 23:01           ` Kuninori Morimoto
@ 2018-12-18 11:07             ` Simon Horman
  -1 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-18 11:07 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Tue, Dec 18, 2018 at 08:01:13AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > Thanks.
> > > 56629fcba94c698d8c5be3413981506479566869
> > > ("arm64: dts: renesas: ebisu: Enable Audio")
> > > is using "simple-scu-audio-card", but it should be "simple-audio-card".
> > > Can you add and test this patch ?
> > > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.
> > 
> > 
> > Thanks Morimoto-san,
> > 
> > I confirm that Sound on Ebisu-4D appears to work with a)
> > CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.
> 
> Thank you for your test.
> OK, I will post patch for Ebisu.

Thanks!

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-18 11:07             ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-18 11:07 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Tue, Dec 18, 2018 at 08:01:13AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > Thanks.
> > > 56629fcba94c698d8c5be3413981506479566869
> > > ("arm64: dts: renesas: ebisu: Enable Audio")
> > > is using "simple-scu-audio-card", but it should be "simple-audio-card".
> > > Can you add and test this patch ?
> > > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.
> > 
> > 
> > Thanks Morimoto-san,
> > 
> > I confirm that Sound on Ebisu-4D appears to work with a)
> > CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.
> 
> Thank you for your test.
> OK, I will post patch for Ebisu.

Thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-07  8:28     ` Geert Uytterhoeven
@ 2018-12-07 22:06       ` Simon Horman
  -1 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-07 22:06 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux-Renesas, Magnus Damm, Linux ARM

On Fri, Dec 07, 2018 at 09:28:22AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Dec 6, 2018 at 10:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > Enable the scu-simple-card which is used by
> > the R-Car E3 (r8a77990) based Ebisu board.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index f88190463481..9d0b42d96f03 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
> >  CONFIG_SND_SOC_RT5514_SPI=m
> >  CONFIG_SND_SOC_RT5645=m
> >  CONFIG_SND_SIMPLE_CARD=m
> > +CONFIG_SND_SIMPLE_SCU_CARD=y
> 
> Shouldn't this be "m"?

Thanks Geert,

I'll look into an incremental update for that.

> 
> >  CONFIG_SND_AUDIO_GRAPH_CARD=m
> >  CONFIG_I2C_HID=m
> >  CONFIG_USB=y
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-07 22:06       ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-07 22:06 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux-Renesas, Magnus Damm, Linux ARM

On Fri, Dec 07, 2018 at 09:28:22AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Dec 6, 2018 at 10:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > Enable the scu-simple-card which is used by
> > the R-Car E3 (r8a77990) based Ebisu board.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index f88190463481..9d0b42d96f03 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
> >  CONFIG_SND_SOC_RT5514_SPI=m
> >  CONFIG_SND_SOC_RT5645=m
> >  CONFIG_SND_SIMPLE_CARD=m
> > +CONFIG_SND_SIMPLE_SCU_CARD=y
> 
> Shouldn't this be "m"?

Thanks Geert,

I'll look into an incremental update for that.

> 
> >  CONFIG_SND_AUDIO_GRAPH_CARD=m
> >  CONFIG_I2C_HID=m
> >  CONFIG_USB=y
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-06 21:57   ` Simon Horman
@ 2018-12-07  8:28     ` Geert Uytterhoeven
  -1 siblings, 0 replies; 20+ messages in thread
From: Geert Uytterhoeven @ 2018-12-07  8:28 UTC (permalink / raw)
  To: Simon Horman; +Cc: Linux-Renesas, Magnus Damm, Linux ARM

Hi Simon,

On Thu, Dec 6, 2018 at 10:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> Enable the scu-simple-card which is used by
> the R-Car E3 (r8a77990) based Ebisu board.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index f88190463481..9d0b42d96f03 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
>  CONFIG_SND_SOC_RT5514_SPI=m
>  CONFIG_SND_SOC_RT5645=m
>  CONFIG_SND_SIMPLE_CARD=m
> +CONFIG_SND_SIMPLE_SCU_CARD=y

Shouldn't this be "m"?

>  CONFIG_SND_AUDIO_GRAPH_CARD=m
>  CONFIG_I2C_HID=m
>  CONFIG_USB=y

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-07  8:28     ` Geert Uytterhoeven
  0 siblings, 0 replies; 20+ messages in thread
From: Geert Uytterhoeven @ 2018-12-07  8:28 UTC (permalink / raw)
  To: Simon Horman; +Cc: Linux-Renesas, Magnus Damm, Linux ARM

Hi Simon,

On Thu, Dec 6, 2018 at 10:58 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> Enable the scu-simple-card which is used by
> the R-Car E3 (r8a77990) based Ebisu board.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index f88190463481..9d0b42d96f03 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
>  CONFIG_SND_SOC_RT5514_SPI=m
>  CONFIG_SND_SOC_RT5645=m
>  CONFIG_SND_SIMPLE_CARD=m
> +CONFIG_SND_SIMPLE_SCU_CARD=y

Shouldn't this be "m"?

>  CONFIG_SND_AUDIO_GRAPH_CARD=m
>  CONFIG_I2C_HID=m
>  CONFIG_USB=y

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
  2018-12-06 21:57 [GIT PULL] Renesas ARM64 Based SoC Defconfig Updates for v4.21 Simon Horman
@ 2018-12-06 21:57   ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-06 21:57 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm, Simon Horman

Enable the scu-simple-card which is used by
the R-Car E3 (r8a77990) based Ebisu board.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f88190463481..9d0b42d96f03 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
 CONFIG_SND_SOC_RT5514_SPI=m
 CONFIG_SND_SOC_RT5645=m
 CONFIG_SND_SIMPLE_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=y
 CONFIG_SND_AUDIO_GRAPH_CARD=m
 CONFIG_I2C_HID=m
 CONFIG_USB=y
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
@ 2018-12-06 21:57   ` Simon Horman
  0 siblings, 0 replies; 20+ messages in thread
From: Simon Horman @ 2018-12-06 21:57 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Simon Horman, Magnus Damm, linux-arm-kernel

Enable the scu-simple-card which is used by
the R-Car E3 (r8a77990) based Ebisu board.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index f88190463481..9d0b42d96f03 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m
 CONFIG_SND_SOC_RT5514_SPI=m
 CONFIG_SND_SOC_RT5645=m
 CONFIG_SND_SIMPLE_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=y
 CONFIG_SND_AUDIO_GRAPH_CARD=m
 CONFIG_I2C_HID=m
 CONFIG_USB=y
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2018-12-18 11:07 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 11:56 [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver Simon Horman
2018-12-14 11:56 ` Simon Horman
2018-12-17  0:29 ` Kuninori Morimoto
2018-12-17  0:29   ` Kuninori Morimoto
2018-12-17  8:36   ` Simon Horman
2018-12-17  8:36     ` Simon Horman
2018-12-17  8:49     ` Kuninori Morimoto
2018-12-17  8:49       ` Kuninori Morimoto
2018-12-17  9:21       ` Simon Horman
2018-12-17  9:21         ` Simon Horman
2018-12-17 23:01         ` Kuninori Morimoto
2018-12-17 23:01           ` Kuninori Morimoto
2018-12-18 11:07           ` Simon Horman
2018-12-18 11:07             ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2018-12-06 21:57 [GIT PULL] Renesas ARM64 Based SoC Defconfig Updates for v4.21 Simon Horman
2018-12-06 21:57 ` [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver Simon Horman
2018-12-06 21:57   ` Simon Horman
2018-12-07  8:28   ` Geert Uytterhoeven
2018-12-07  8:28     ` Geert Uytterhoeven
2018-12-07 22:06     ` Simon Horman
2018-12-07 22:06       ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.