[v4,02/15] usb: core: urb: Check SSP isoc ep comp descriptor

[v4,02/15] usb: core: urb: Check SSP isoc ep comp descriptor

[Felipe Balbi]

Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> The maximum bytes per interval for USB SuperSpeed Plus can be set by
> isoc endpoint companion descriptor when it is above 48K. If the
> descriptor is provided, then use its value.
>
> USB 3.1 spec 9.6.8
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>

you should have Cc:ed Greg for this one. FWIW:

"This descriptor shall be returned for each Isochronous endpoint that
requires more than 48K bytes per Service Interval."

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

> ---
>  drivers/usb/core/urb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
> index 9fdf137c4865..0ab4b896e3f3 100644
> --- a/drivers/usb/core/urb.c
> +++ b/drivers/usb/core/urb.c
> @@ -433,6 +433,14 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
>  			max *= mult;
>  		}
>  
> +		if (dev->speed == USB_SPEED_SUPER_PLUS &&
> +		    USB_SS_SSP_ISOC_COMP(ep->ss_ep_comp.bmAttributes)) {
> +			struct usb_ssp_isoc_ep_comp_descriptor *isoc_ep_comp;
> +
> +			isoc_ep_comp = &ep->ssp_isoc_ep_comp;
> +			max = le32_to_cpu(isoc_ep_comp->dwBytesPerInterval);
> +		}
> +
>  		/* "high bandwidth" mode, 1-3 packets/uframe? */
>  		if (dev->speed == USB_SPEED_HIGH)
>  			max *= usb_endpoint_maxp_mult(&ep->desc);
> -- 
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v4,02/15] usb: core: urb: Check SSP isoc ep comp descriptor

[Thinh Nguyen]

Hi,

On 3/13/2018 1:31 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> The maximum bytes per interval for USB SuperSpeed Plus can be set by
>> isoc endpoint companion descriptor when it is above 48K. If the
>> descriptor is provided, then use its value.
>>
>> USB 3.1 spec 9.6.8
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> 
> you should have Cc:ed Greg for this one. FWIW:

Will do next time.

> 
> "This descriptor shall be returned for each Isochronous endpoint that
> requires more than 48K bytes per Service Interval."
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> 
>> ---
>>   drivers/usb/core/urb.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
>> index 9fdf137c4865..0ab4b896e3f3 100644
>> --- a/drivers/usb/core/urb.c
>> +++ b/drivers/usb/core/urb.c
>> @@ -433,6 +433,14 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
>>   			max *= mult;
>>   		}
>>   
>> +		if (dev->speed == USB_SPEED_SUPER_PLUS &&
>> +		    USB_SS_SSP_ISOC_COMP(ep->ss_ep_comp.bmAttributes)) {
>> +			struct usb_ssp_isoc_ep_comp_descriptor *isoc_ep_comp;
>> +
>> +			isoc_ep_comp = &ep->ssp_isoc_ep_comp;
>> +			max = le32_to_cpu(isoc_ep_comp->dwBytesPerInterval);
>> +		}
>> +
>>   		/* "high bandwidth" mode, 1-3 packets/uframe? */
>>   		if (dev->speed == USB_SPEED_HIGH)
>>   			max *= usb_endpoint_maxp_mult(&ep->desc);
>> -- 
>> 2.11.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Thanks,
Thinh
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[v4,02/15] usb: core: urb: Check SSP isoc ep comp descriptor

[Thinh Nguyen]

The maximum bytes per interval for USB SuperSpeed Plus can be set by
isoc endpoint companion descriptor when it is above 48K. If the
descriptor is provided, then use its value.

USB 3.1 spec 9.6.8

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
 drivers/usb/core/urb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index 9fdf137c4865..0ab4b896e3f3 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -433,6 +433,14 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
 			max *= mult;
 		}
 
+		if (dev->speed == USB_SPEED_SUPER_PLUS &&
+		    USB_SS_SSP_ISOC_COMP(ep->ss_ep_comp.bmAttributes)) {
+			struct usb_ssp_isoc_ep_comp_descriptor *isoc_ep_comp;
+
+			isoc_ep_comp = &ep->ssp_isoc_ep_comp;
+			max = le32_to_cpu(isoc_ep_comp->dwBytesPerInterval);
+		}
+
 		/* "high bandwidth" mode, 1-3 packets/uframe? */
 		if (dev->speed == USB_SPEED_HIGH)
 			max *= usb_endpoint_maxp_mult(&ep->desc);