[bug report] ASoC: soc-core: add snd_soc_rtdcom_xxx()

[bug report] ASoC: soc-core: add snd_soc_rtdcom_xxx()

[Dan Carpenter]

Hello Kuninori Morimoto,

This is a semi-automatic email about new static checker warnings.

The patch a0ac44115223: "ASoC: soc-core: add snd_soc_rtdcom_xxx()" 
from Aug 8, 2017, leads to the following Smatch complaint:

sound/soc/soc-core.c:644 soc_free_pcm_runtime()
	 error: we previously assumed 'rtd' could be null (see line 642)

sound/soc/soc-core.c
   641	{
   642		if (rtd && rtd->codec_dais)
                    ^^^
Check for NULL.

   643			kfree(rtd->codec_dais);
   644		snd_soc_rtdcom_del_all(rtd);
                                       ^^^
The check adds a new unchecked dereference inside the function.  It's
weird that we call INIT_LIST_HEAD(&rtd->component_list), btw.  Don't we
need to free the elements in the list?

   645		kfree(rtd);
   646	}

regards,
dan carpenter

Re: [bug report] ASoC: soc-core: add snd_soc_rtdcom_xxx()

[Kuninori Morimoto]

Hi Dan

> sound/soc/soc-core.c:644 soc_free_pcm_runtime()
> 	 error: we previously assumed 'rtd' could be null (see line 642)
> 
> sound/soc/soc-core.c
>    641	{
>    642		if (rtd && rtd->codec_dais)
>                     ^^^
> Check for NULL.
> 
>    643			kfree(rtd->codec_dais);
>    644		snd_soc_rtdcom_del_all(rtd);
>                                        ^^^
> The check adds a new unchecked dereference inside the function.  It's
> weird that we call INIT_LIST_HEAD(&rtd->component_list), btw.  Don't we
> need to free the elements in the list?

Yes, indeed.
Thank you for your report.
I will fix it soon

Best regards
---
Kuninori Morimoto

[PATCH] ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

static soc_free_pcm_runtime() is never called with rtd==NULL.
This patch removes unnecessary rtd == NULL check from
soc_free_pcm_runtime().
Otherwise it logically inconsistent.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 19f6d07..ee29d7c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -407,7 +407,7 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
 
 static void soc_free_pcm_runtime(struct snd_soc_pcm_runtime *rtd)
 {
-	if (rtd && rtd->codec_dais)
+	if (rtd->codec_dais)
 		kfree(rtd->codec_dais);
 	snd_soc_rtdcom_del_all(rtd);
 	kfree(rtd);
-- 
1.9.1

Re: [PATCH] ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()

[kbuild test robot]

Hi Kuninori,

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v4.13 next-20170913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-soc-core-remove-rtd-NULL-check-from-soc_free_pcm_runtime/20170914-072344
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next


coccinelle warnings: (new ones prefixed by >>)

>> sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings

[kbuild test robot]

sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 7e74acb4fc31 ("ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()")
CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 soc-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -639,8 +639,7 @@ static struct snd_soc_pcm_runtime *soc_n
 
 static void soc_free_pcm_runtime(struct snd_soc_pcm_runtime *rtd)
 {
-	if (rtd->codec_dais)
-		kfree(rtd->codec_dais);
+	kfree(rtd->codec_dais);
 	snd_soc_rtdcom_del_all(rtd);
 	kfree(rtd);
 }

Re: [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings

[Kuninori Morimoto]

Hi

> sound/soc/soc-core.c:643:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> Fixes: 7e74acb4fc31 ("ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()")
> CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Re: [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

On Thu, May 30, 2019 at 07:06:11PM -0400, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.
> 
>  NULL check before some freeing functions is not needed.

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 341 bytes --]

On Thu, May 30, 2019 at 07:06:11PM -0400, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.
> 
>  NULL check before some freeing functions is not needed.

This doesn't apply against current code, please check and resend.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

[PATCH] ASoC: soc-core: fix ifnullfree.cocci warnings

[Julia Lawall]

From: kbuild test robot <lkp@intel.com>

sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 8e144273005d ("ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://github.com/morimoto/linux fw-cleanup-2019-05-30-v3
head:   7f2c61a9097fcf25dac44865db31e7eab5c8fc9d
commit: 8e144273005d3caf8b9978e407e3d00b6180dd49 [96/103] ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago

Please take the patch only if it's a positive warning. Thanks!

 soc-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -387,8 +387,7 @@ static void soc_free_pcm_runtime(struct

 	snd_soc_rtdcom_del_all(rtd);

-	if (rtd->codec_dais)
-		kfree(rtd->codec_dais);
+	kfree(rtd->codec_dais);

 	list_del(&rtd->list);
 	kfree(rtd);