* Re: [PATCH 1/5 v7] dt/bindings: Add binding for the DA8xx MUSB driver
[not found] ` <1456327573-16421-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
@ 2016-02-24 15:40 ` Felipe Balbi
2016-02-24 17:29 ` Sergei Shtylyov
2016-03-02 17:26 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2016-02-24 15:40 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA, Bin Liu
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, petr-Qh/3xLP0EvwAvxtiuMwx3w,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8
[-- Attachment #1: Type: text/plain, Size: 3256 bytes --]
Hi,
Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org> writes:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
>
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
Bin, another one to take a look.
> ---
> v1: <initial>
>
> v2:
> - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits"
> - using "ti," prefix instead of "da8xx," for specific property names
> - no wildcards in compatibility string
>
> v3:
> - added "reg", "interrupts" and "interrupt-names" properties
> - wildcards in compatibility string
>
> v4:
> - compatibility string set to "ti,da830-musb"
> - "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" properties removed and hardcoded
> - "ti,phy20-clkmux-cfg" renamed to "ti,phy20-clkmux-pll" and changed to boolean
> - removed "ti,hwmods"
>
> v5:
> - "ti,phy20-refclock-frequency" property made mandatory
>
> v6:
> - using "ti,usb2-phy-" prefix instead of "ti,phy20-" for the specific properties
>
> v7:
> - removed the "mentor,power" property; hard coded to 500mA in the code
>
> .../devicetree/bindings/usb/da8xx-usb.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> new file mode 100644
> index 0000000..e281829
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -0,0 +1,43 @@
> +TI DA8xx MUSB
> +~~~~~~~~~~~~~
> +For DA8xx/OMAP-L1x/AM17xx/AM18xx platforms.
> +
> +Required properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - compatible : Should be set to "ti,da830-musb".
> +
> + - reg: Offset and length of the USB controller register set.
> +
> + - interrupts: The USB interrupt number.
> +
> + - interrupt-names: Should be set to "mc".
> +
> + - dr_mode: The USB operation mode. Should be one of "host", "peripheral" or "otg".
> +
> + - ti,usb2-phy-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input
> + frequency in Hz in case the clock is generated by the internal PLL.
> + Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz
> +
> +
> +Optional properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - ti,usb2-phy-clkmux-pll: Boolean. Defines the USB 2.0 PHY reference clock source.
> + If present the internal PLL is used as a clock source, otherwise the external
> + USB_REFCLKIN pin is used.
> +
> +Example:
> +
> + usb20: usb@1e00000 {
> + compatible = "ti,da830-musb";
> + reg = <0x00200000 0x10000>;
> + interrupt-parent = <&intc>;
> + interrupts = <58>;
> + interrupt-names = "mc";
> +
> + dr_mode = "host";
> +
> + ti,usb2-phy-clkmux-pll;
> + ti,usb2-phy-refclock-frequency = <24000000>;
> +
> + status = "okay";
> + };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5 v7] dt/bindings: Add binding for the DA8xx MUSB driver
[not found] ` <1456327573-16421-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
2016-02-24 15:40 ` Felipe Balbi
@ 2016-02-24 17:29 ` Sergei Shtylyov
2016-03-02 17:26 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2016-02-24 17:29 UTC (permalink / raw)
To: Petr Kulhavy, devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-usb-u79uwXL29TY76Z2rM5mHXA
On 02/24/2016 06:26 PM, Petr Kulhavy wrote:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
>
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
> ---
> v1: <initial>
>
> v2:
> - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits"
> - using "ti," prefix instead of "da8xx," for specific property names
> - no wildcards in compatibility string
>
> v3:
> - added "reg", "interrupts" and "interrupt-names" properties
> - wildcards in compatibility string
>
> v4:
> - compatibility string set to "ti,da830-musb"
> - "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" properties removed and hardcoded
> - "ti,phy20-clkmux-cfg" renamed to "ti,phy20-clkmux-pll" and changed to boolean
> - removed "ti,hwmods"
>
> v5:
> - "ti,phy20-refclock-frequency" property made mandatory
>
> v6:
> - using "ti,usb2-phy-" prefix instead of "ti,phy20-" for the specific properties
>
> v7:
> - removed the "mentor,power" property; hard coded to 500mA in the code
>
> .../devicetree/bindings/usb/da8xx-usb.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> new file mode 100644
> index 0000000..e281829
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -0,0 +1,43 @@
> +TI DA8xx MUSB
> +~~~~~~~~~~~~~
> +For DA8xx/OMAP-L1x/AM17xx/AM18xx platforms.
> +
> +Required properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - compatible : Should be set to "ti,da830-musb".
> +
> + - reg: Offset and length of the USB controller register set.
> +
> + - interrupts: The USB interrupt number.
> +
> + - interrupt-names: Should be set to "mc".
> +
> + - dr_mode: The USB operation mode. Should be one of "host", "peripheral" or "otg".
> +
> + - ti,usb2-phy-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input
> + frequency in Hz in case the clock is generated by the internal PLL.
Didn't you say it's needed in the case of external clock anyway?
> + Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5 v7] dt/bindings: Add binding for the DA8xx MUSB driver
[not found] ` <1456327573-16421-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
2016-02-24 15:40 ` Felipe Balbi
2016-02-24 17:29 ` Sergei Shtylyov
@ 2016-03-02 17:26 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2016-03-02 17:26 UTC (permalink / raw)
To: Petr Kulhavy
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-usb-u79uwXL29TY76Z2rM5mHXA,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8
On Wed, Feb 24, 2016 at 04:26:13PM +0100, Petr Kulhavy wrote:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
>
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
> ---
> v1: <initial>
>
> v2:
> - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits"
> - using "ti," prefix instead of "da8xx," for specific property names
> - no wildcards in compatibility string
>
> v3:
> - added "reg", "interrupts" and "interrupt-names" properties
> - wildcards in compatibility string
>
> v4:
> - compatibility string set to "ti,da830-musb"
> - "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" properties removed and hardcoded
> - "ti,phy20-clkmux-cfg" renamed to "ti,phy20-clkmux-pll" and changed to boolean
> - removed "ti,hwmods"
>
> v5:
> - "ti,phy20-refclock-frequency" property made mandatory
>
> v6:
> - using "ti,usb2-phy-" prefix instead of "ti,phy20-" for the specific properties
>
> v7:
> - removed the "mentor,power" property; hard coded to 500mA in the code
>
> .../devicetree/bindings/usb/da8xx-usb.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> new file mode 100644
> index 0000000..e281829
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -0,0 +1,43 @@
> +TI DA8xx MUSB
> +~~~~~~~~~~~~~
> +For DA8xx/OMAP-L1x/AM17xx/AM18xx platforms.
> +
> +Required properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - compatible : Should be set to "ti,da830-musb".
> +
> + - reg: Offset and length of the USB controller register set.
> +
> + - interrupts: The USB interrupt number.
> +
> + - interrupt-names: Should be set to "mc".
> +
> + - dr_mode: The USB operation mode. Should be one of "host", "peripheral" or "otg".
> +
> + - ti,usb2-phy-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input
> + frequency in Hz in case the clock is generated by the internal PLL.
> + Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz
Shouldn't this be optional if it only applies for the internal PLL? I'd
prefer "ti,usb2-phy-refclock-hz" so the units are clear.
> +Optional properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - ti,usb2-phy-clkmux-pll: Boolean. Defines the USB 2.0 PHY reference clock source.
> + If present the internal PLL is used as a clock source, otherwise the external
> + USB_REFCLKIN pin is used.
External is the more common case? The property should be present for the
less common case.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread