From: Kalle Valo <kvalo@codeaurora.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
Date: Thu, 31 Dec 2015 15:12:46 +0200 [thread overview]
Message-ID: <87ege2oj75.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> (Andrzej Hajda's message of "Mon, 14 Dec 2015 11:06:01 +0100")
Andrzej Hajda <a.hajda@samsung.com> writes:
> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Applied to ath.git, thanks.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
Date: Thu, 31 Dec 2015 15:12:46 +0200 [thread overview]
Message-ID: <87ege2oj75.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> (Andrzej Hajda's message of "Mon, 14 Dec 2015 11:06:01 +0100")
Andrzej Hajda <a.hajda@samsung.com> writes:
> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Applied to ath.git, thanks.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: QCA ath9k Development
<ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Marek Szyprowski
<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
Date: Thu, 31 Dec 2015 15:12:46 +0200 [thread overview]
Message-ID: <87ege2oj75.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1450087564-28441-4-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> (Andrzej Hajda's message of "Mon, 14 Dec 2015 11:06:01 +0100")
Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> writes:
> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Applied to ath.git, thanks.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
Date: Thu, 31 Dec 2015 15:12:46 +0200 [thread overview]
Message-ID: <87ege2oj75.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> (Andrzej Hajda's message of "Mon, 14 Dec 2015 11:06:01 +0100")
Andrzej Hajda <a.hajda@samsung.com> writes:
> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Applied to ath.git, thanks.
--
Kalle Valo
next prev parent reply other threads:[~2015-12-31 13:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
2015-12-14 10:05 ` [PATCH] doc: mei: fix handling return value of mei_recv_msg Andrzej Hajda
2015-12-14 12:04 ` Winkler, Tomas
2015-12-14 10:06 ` [PATCH] clk: sunxi: fix handling return value of of_property_match_string Andrzej Hajda
2015-12-14 10:06 ` Andrzej Hajda
2015-12-14 13:05 ` Maxime Ripard
2015-12-14 13:05 ` Maxime Ripard
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
2015-12-14 10:06 ` [ath9k-devel] " Andrzej Hajda
2015-12-14 10:06 ` Andrzej Hajda
2015-12-31 13:12 ` Kalle Valo [this message]
2015-12-31 13:12 ` [ath9k-devel] " Kalle Valo
2015-12-31 13:12 ` Kalle Valo
2015-12-31 13:12 ` Kalle Valo
2015-12-14 10:06 ` [PATCH] extcon: max14577: fix handling return value of regmap_irq_get_virq Andrzej Hajda
2015-12-14 10:31 ` Krzysztof Kozlowski
2015-12-14 11:12 ` [PATCH] extcon: max77693: " Andrzej Hajda
2015-12-15 0:22 ` Krzysztof Kozlowski
2015-12-15 1:08 ` Chanwoo Choi
2015-12-15 1:08 ` [PATCH] extcon: max14577: " Chanwoo Choi
2015-12-14 10:06 ` [PATCH] extcon: max77843: " Andrzej Hajda
2015-12-14 10:30 ` Krzysztof Kozlowski
2015-12-15 1:08 ` Chanwoo Choi
2015-12-14 10:06 ` [PATCH] be2iscsi: fix handling return value of mgmt_open_connection Andrzej Hajda
2015-12-15 9:09 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Or Gerlitz
2015-12-15 16:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ege2oj75.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=a.hajda@samsung.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.