All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/28] package: fix patching procedure for host packages
Date: Thu, 07 Jul 2011 23:50:06 +0200	[thread overview]
Message-ID: <87ei21pxpt.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <04a4534f698a676c73be6f4ca82235cb1cce69c8.1309895466.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue, 5 Jul 2011 21:53:57 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The patching procedure was using $($(NOHOSTPKG)_NAME) to find the name
 Thomas> of the package without the host- prefix for host packages, which is
 Thomas> needed to find the package directory and the prefix of the patches.

 Thomas> However, this $($(NOHOSTPKG)_NAME) variable is empty when there is
 Thomas> only an host variant for the package and no target variant for it.

 Thomas> Therefore, instead of using this $($(NOHOSTPKG)_NAME) variable, we now
 Thomas> use a new $(RAWNAME) variable, which is always the name of the package
 Thomas> without the host- prefix, even for host packages.

 Thomas> Thanks to Yann E. Morin for providing the tip on using patsubst
 Thomas> instead of subst.

RAWNAME does fall a bit outside the "namespace" used by the other
variables here, but ok - Committed, thanks.


 Thomas> -$$($(2)_TARGET_PATCH):			NOHOSTPKG=$(3)
 Thomas> +$$($(2)_TARGET_PATCH):			RAWNAME=$(patsubst host-%,%,$(1))

Here's to hoping we'll never have a package called 'host' ;)

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-07-07 21:50 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 19:53 [Buildroot] [pull request v3] Pull request for branch for-2011.08/bootloaders Thomas Petazzoni
2011-07-05 19:53 ` [Buildroot] [PATCH 01/28] Makefile.package.in: Makes it possible to override the default extract commands Thomas Petazzoni
2011-07-07 21:00   ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 02/28] Fix quoting in default extract command Thomas Petazzoni
2011-07-07 21:05   ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 03/28] linux: make it possible to install the kernel in /boot Thomas Petazzoni
2011-07-07 19:08   ` Sven Neumann
2011-07-07 21:17   ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 04/28] linux: use the defconfig mechanism after tuning the config Thomas Petazzoni
2011-07-07 21:46   ` Peter Korsgaard
2011-07-08 17:08     ` Thomas Petazzoni
2011-07-08 18:11       ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 05/28] package: add infrastructure to install things in images/ Thomas Petazzoni
2011-07-07 21:47   ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 06/28] package: fix patching procedure for host packages Thomas Petazzoni
2011-07-07 21:50   ` Peter Korsgaard [this message]
2011-07-07 21:55     ` Yann E. MORIN
2011-07-07 21:59       ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 07/28] barebox: re-indent variable definitions Thomas Petazzoni
2011-07-10  8:57   ` Peter Korsgaard
2011-07-10 10:25     ` Thomas Petazzoni
2011-07-10 12:00       ` Peter Korsgaard
2011-07-05 19:53 ` [Buildroot] [PATCH 08/28] barebox: convert to GENTARGETS Thomas Petazzoni
2011-07-10 13:03   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 09/28] at91bootstrap: indent properly variable definitions Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 10/28] at91bootstrap: convert to GENTARGETS Thomas Petazzoni
2011-07-10 13:10   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 11/28] at91dataflashboot: indent properly variable definitions Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 12/28] at91dataflashboot: convert to GENTARGETS Thomas Petazzoni
2011-07-10 13:16   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 13/28] syslinux: " Thomas Petazzoni
2011-07-10 13:27   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 14/28] grub: convert to AUTOTARGETS Thomas Petazzoni
2011-07-10 13:30   ` Peter Korsgaard
2011-08-20  9:22   ` Darius Augulis
2011-08-26 12:02     ` Peter Korsgaard
2011-08-29 17:22       ` Darius Augulis
2011-07-05 19:54 ` [Buildroot] [PATCH 15/28] grub2: remove package Thomas Petazzoni
2011-07-10 13:31   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 16/28] u-boot: convert to GENTARGETS Thomas Petazzoni
2011-07-10 20:07   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 17/28] uboot-mkimage: new package Thomas Petazzoni
2011-07-10 20:10   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 18/28] linux: rename LINUX26 to LINUX Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 19/28] linux: indent and align some definitions Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 20/28] package: add support for post-download hooks Thomas Petazzoni
2011-07-10 20:25   ` Peter Korsgaard
2011-07-05 19:54 ` [Buildroot] [PATCH 21/28] linux: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 22/28] boot: rename BR2_TARGET_* to BR2_BOOT_* Thomas Petazzoni
2011-07-10 20:27   ` Peter Korsgaard
2011-07-10 21:27     ` Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 23/28] u-boot: rename options BR2_BOOT_UBOOT* to BR2_BOOT_U_BOOT* Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 24/28] Improve TARGETS handling for bootloaders and kernel Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 25/28] linux: allow specification of a custom Git repository as a source Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 26/28] u-boot: allow specification of custom Git repo as source Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 27/28] Add x-loader bootloader Thomas Petazzoni
2011-07-05 19:54 ` [Buildroot] [PATCH 28/28] barebox: bump version Thomas Petazzoni
2011-07-07 10:25 ` [Buildroot] [pull request v3] Pull request for branch for-2011.08/bootloaders Luca Ceresoli
  -- strict thread matches above, loose matches on Subject: below --
2011-07-04 21:33 [Buildroot] [pull request v2] " Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 06/28] package: fix patching procedure for host packages Thomas Petazzoni
2011-07-04 22:01   ` Yann E. MORIN
2011-07-05  7:28     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei21pxpt.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.