* [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-16 15:23 ` Maxime Bizon
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Bizon @ 2022-05-16 15:23 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
Because of this missing switch case, 160Mhz transmit was reported as
20Mhz, leading to wrong airtime calculation and AQL limiting max
throughput.
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 771252dd6d4e..e8727c0b0171 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -3884,6 +3884,10 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar,
arsta->tx_info.status.rates[0].flags |=
IEEE80211_TX_RC_80_MHZ_WIDTH;
break;
+ case RATE_INFO_BW_160:
+ arsta->tx_info.status.rates[0].flags |=
+ IEEE80211_TX_RC_160_MHZ_WIDTH;
+ break;
}
if (peer_stats->succ_pkts) {
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-16 15:23 ` Maxime Bizon
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Bizon @ 2022-05-16 15:23 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
Because of this missing switch case, 160Mhz transmit was reported as
20Mhz, leading to wrong airtime calculation and AQL limiting max
throughput.
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 771252dd6d4e..e8727c0b0171 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -3884,6 +3884,10 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar,
arsta->tx_info.status.rates[0].flags |=
IEEE80211_TX_RC_80_MHZ_WIDTH;
break;
+ case RATE_INFO_BW_160:
+ arsta->tx_info.status.rates[0].flags |=
+ IEEE80211_TX_RC_160_MHZ_WIDTH;
+ break;
}
if (peer_stats->succ_pkts) {
--
2.17.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
2022-05-16 15:23 ` Maxime Bizon
@ 2022-05-16 16:11 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-16 16:11 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> writes:
> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
On what ath10k hardware and afirmware version did you test this? I can
add that to the commit log.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-16 16:11 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-16 16:11 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> writes:
> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
On what ath10k hardware and afirmware version did you test this? I can
add that to the commit log.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
2022-05-16 16:11 ` Kalle Valo
@ 2022-05-16 16:23 ` Maxime Bizon
-1 siblings, 0 replies; 10+ messages in thread
From: Maxime Bizon @ 2022-05-16 16:23 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:
Hello Kalle,
> On what ath10k hardware and afirmware version did you test this? I
> can add that to the commit log.
>
QCA9984
10.4-3.10-00047
--
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-16 16:23 ` Maxime Bizon
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Bizon @ 2022-05-16 16:23 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:
Hello Kalle,
> On what ath10k hardware and afirmware version did you test this? I
> can add that to the commit log.
>
QCA9984
10.4-3.10-00047
--
Maxime
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
2022-05-16 16:23 ` Maxime Bizon
@ 2022-05-16 16:35 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-16 16:35 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> writes:
> On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:
>
>> On what ath10k hardware and afirmware version did you test this? I
>> can add that to the commit log.
>>
>
> QCA9984
> 10.4-3.10-00047
Thanks, I added that in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-16 16:35 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-16 16:35 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> writes:
> On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:
>
>> On what ath10k hardware and afirmware version did you test this? I
>> can add that to the commit log.
>>
>
> QCA9984
> 10.4-3.10-00047
Thanks, I added that in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
2022-05-16 15:23 ` Maxime Bizon
@ 2022-05-22 12:28 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-22 12:28 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> wrote:
> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Tested-on: QCA9984 hw2.0 PCI 10.4-3.10-00047
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
75a7062e533e ath10k: fix misreported tx bandwidth for 160Mhz
--
https://patchwork.kernel.org/project/linux-wireless/patch/cd2735a40da7f4fcc5323e3fca3775e7b5402ece.camel@freebox.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz
@ 2022-05-22 12:28 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2022-05-22 12:28 UTC (permalink / raw)
To: Maxime Bizon; +Cc: ath10k, linux-wireless
Maxime Bizon <mbizon@freebox.fr> wrote:
> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Tested-on: QCA9984 hw2.0 PCI 10.4-3.10-00047
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
75a7062e533e ath10k: fix misreported tx bandwidth for 160Mhz
--
https://patchwork.kernel.org/project/linux-wireless/patch/cd2735a40da7f4fcc5323e3fca3775e7b5402ece.camel@freebox.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-22 12:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 15:23 [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz Maxime Bizon
2022-05-16 15:23 ` Maxime Bizon
2022-05-16 16:11 ` Kalle Valo
2022-05-16 16:11 ` Kalle Valo
2022-05-16 16:23 ` Maxime Bizon
2022-05-16 16:23 ` Maxime Bizon
2022-05-16 16:35 ` Kalle Valo
2022-05-16 16:35 ` Kalle Valo
2022-05-22 12:28 ` Kalle Valo
2022-05-22 12:28 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.