* [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+
@ 2022-05-11 22:47 Manasi Navare
2022-05-12 0:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Manasi Navare @ 2022-05-11 22:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Currently we reuse hsw_crtc_enable for SKL+ platforms.
But this has added a lot of platform checks for SKL+ platforms.
So its time to move the code to a separate crtc_enable hook
for SKL+ platforms.
No functional changes here.
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 74 +++++++++++++++++++-
1 file changed, 73 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 806d50b302ab..e2e228073e2e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1895,6 +1895,78 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
hsw_set_transconf(crtc_state);
}
+static void skl_crtc_enable(struct intel_atomic_state *state,
+ struct intel_crtc *crtc)
+{
+ const struct intel_crtc_state *new_crtc_state =
+ intel_atomic_get_new_crtc_state(state, crtc);
+ struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+ enum pipe pipe = crtc->pipe;
+ enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
+ bool psl_clkgate_wa;
+
+ if (drm_WARN_ON(&dev_priv->drm, crtc->active))
+ return;
+
+ if (!new_crtc_state->bigjoiner_pipes) {
+ intel_encoders_pre_pll_enable(state, crtc);
+
+ if (new_crtc_state->shared_dpll)
+ intel_enable_shared_dpll(new_crtc_state);
+
+ intel_encoders_pre_enable(state, crtc);
+ } else {
+ icl_ddi_bigjoiner_pre_enable(state, new_crtc_state);
+ }
+
+ intel_dsc_enable(new_crtc_state);
+
+ if (DISPLAY_VER(dev_priv) >= 13)
+ intel_uncompressed_joiner_enable(new_crtc_state);
+
+ intel_set_pipe_src_size(new_crtc_state);
+ bdw_set_pipemisc(new_crtc_state);
+
+ if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
+ !transcoder_is_dsi(cpu_transcoder))
+ hsw_configure_cpu_transcoder(new_crtc_state);
+
+ crtc->active = true;
+
+ /* Display WA #1180: WaDisableScalarClockGating: glk */
+ psl_clkgate_wa = DISPLAY_VER(dev_priv) == 10 &&
+ new_crtc_state->pch_pfit.enabled;
+ if (psl_clkgate_wa)
+ glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
+
+ skl_pfit_enable(new_crtc_state);
+
+ /*
+ * On ILK+ LUT must be loaded before the pipe is running but with
+ * clocks enabled
+ */
+ intel_color_load_luts(new_crtc_state);
+ intel_color_commit_noarm(new_crtc_state);
+ intel_color_commit_arm(new_crtc_state);
+
+ hsw_set_linetime_wm(new_crtc_state);
+
+ if (DISPLAY_VER(dev_priv) >= 11)
+ icl_set_pipe_chicken(new_crtc_state);
+
+ intel_initial_watermarks(state, crtc);
+
+ if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
+ intel_crtc_vblank_on(new_crtc_state);
+
+ intel_encoders_enable(state, crtc);
+
+ if (psl_clkgate_wa) {
+ intel_crtc_wait_for_next_vblank(crtc);
+ glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, false);
+ }
+}
+
static void hsw_crtc_enable(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
@@ -9231,7 +9303,7 @@ static const struct drm_mode_config_funcs intel_mode_funcs = {
static const struct drm_i915_display_funcs skl_display_funcs = {
.get_pipe_config = hsw_get_pipe_config,
- .crtc_enable = hsw_crtc_enable,
+ .crtc_enable = skl_crtc_enable,
.crtc_disable = hsw_crtc_disable,
.commit_modeset_enables = skl_commit_modeset_enables,
.get_initial_plane_config = skl_get_initial_plane_config,
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Add a separate crtc_enable hook for SKL+
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
@ 2022-05-12 0:12 ` Patchwork
2022-05-12 9:45 ` [Intel-gfx] [PATCH] " Jani Nikula
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-05-12 0:12 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14239 bytes --]
== Series Details ==
Series: drm/i915/display: Add a separate crtc_enable hook for SKL+
URL : https://patchwork.freedesktop.org/series/103896/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11638 -> Patchwork_103896v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_103896v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_103896v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/index.html
Participating hosts (36 -> 43)
------------------------------
Additional (9): fi-rkl-11600 bat-dg2-8 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-hsw-4770 bat-rpls-2 bat-jsl-2 bat-jsl-1
Missing (2): fi-bsw-cyan fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_103896v1:
### IGT changes ###
#### Possible regressions ####
* igt@prime_vgem@basic-read:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-kbl-soraka/igt@prime_vgem@basic-read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-kbl-soraka/igt@prime_vgem@basic-read.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-pci-d3-state:
- {bat-dg2-8}: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-dg2-8/igt@i915_pm_rpm@basic-pci-d3-state.html
Known issues
------------
Here are the changes found in Patchwork_103896v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271]) +9 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-hsw-4770/igt@gem_huc_copy@huc-copy.html
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@gem_lmem_swapping@basic.html
* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][8] ([i915#3282])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@gem_tiled_pread_basic.html
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([i915#3282])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3012])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#3012])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][12] -> [DMESG-FAIL][13] ([i915#62])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][14] -> [DMESG-FAIL][15] ([i915#3428])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_selftest@live@memory_region:
- fi-cfl-8109u: [PASS][16] -> [DMESG-WARN][17] ([i915#5904]) +11 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][18] -> [DMESG-FAIL][19] ([i915#4528])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-blb-e6850/igt@i915_selftest@live@requests.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-pnv-d510: NOTRUN -> [SKIP][21] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][22] ([fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([fdo#111827]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-rkl-11600: NOTRUN -> [SKIP][24] ([i915#4070] / [i915#4103]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-4: NOTRUN -> [SKIP][25] ([i915#4103]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- bat-adlp-4: NOTRUN -> [DMESG-WARN][26] ([i915#3576]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([fdo#109285] / [i915#4098])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][28] ([i915#4093]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [PASS][29] -> [DMESG-WARN][30] ([i915#62]) +15 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#533])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-rkl-11600: NOTRUN -> [SKIP][32] ([i915#4070] / [i915#533])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-rkl-11600: NOTRUN -> [SKIP][33] ([i915#1072]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_psr@primary_mmap_gtt.html
- fi-hsw-4770: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#1072]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-4: NOTRUN -> [SKIP][35] ([i915#3555] / [i915#4579])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
- fi-rkl-11600: NOTRUN -> [SKIP][36] ([i915#3555] / [i915#4098])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][37] ([i915#3291] / [i915#3708]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][38] ([i915#3301] / [i915#3708])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
- bat-adlp-4: NOTRUN -> [SKIP][39] ([i915#3301] / [i915#3708])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/bat-adlp-4/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- fi-rkl-11600: NOTRUN -> [SKIP][40] ([i915#3291] / [i915#3708]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-rkl-11600/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][41] ([fdo#109271] / [i915#3428] / [i915#4312])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][42] ([i915#4528]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11638/fi-pnv-d510/igt@i915_selftest@live@requests.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
[i915#5885]: https://gitlab.freedesktop.org/drm/intel/issues/5885
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Build changes
-------------
* Linux: CI_DRM_11638 -> Patchwork_103896v1
CI-20190529: 20190529
CI_DRM_11638: cbc8debff0e9aa1c100f5523aff24e0115a77a27 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6471: 1d6816f1200520f936a799b7b0ef2e6f396abb16 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103896v1: cbc8debff0e9aa1c100f5523aff24e0115a77a27 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
adc5aada0455 drm/i915/display: Add a separate crtc_enable hook for SKL+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v1/index.html
[-- Attachment #2: Type: text/html, Size: 16088 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
2022-05-12 0:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-05-12 9:45 ` Jani Nikula
2022-05-12 19:36 ` Navare, Manasi
2022-05-12 19:52 ` [Intel-gfx] [PATCH v2] " Manasi Navare
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2022-05-12 9:45 UTC (permalink / raw)
To: Manasi Navare, intel-gfx
On Wed, 11 May 2022, Manasi Navare <manasi.d.navare@intel.com> wrote:
> Currently we reuse hsw_crtc_enable for SKL+ platforms.
> But this has added a lot of platform checks for SKL+ platforms.
> So its time to move the code to a separate crtc_enable hook
> for SKL+ platforms.
This leaves behind a ton of unused code paths in hsw_crtc_enable, which
needs cleanup.
BR,
Jani.
>
> No functional changes here.
>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 74 +++++++++++++++++++-
> 1 file changed, 73 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 806d50b302ab..e2e228073e2e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1895,6 +1895,78 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
> hsw_set_transconf(crtc_state);
> }
>
> +static void skl_crtc_enable(struct intel_atomic_state *state,
> + struct intel_crtc *crtc)
> +{
> + const struct intel_crtc_state *new_crtc_state =
> + intel_atomic_get_new_crtc_state(state, crtc);
> + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> + enum pipe pipe = crtc->pipe;
> + enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
> + bool psl_clkgate_wa;
> +
> + if (drm_WARN_ON(&dev_priv->drm, crtc->active))
> + return;
> +
> + if (!new_crtc_state->bigjoiner_pipes) {
> + intel_encoders_pre_pll_enable(state, crtc);
> +
> + if (new_crtc_state->shared_dpll)
> + intel_enable_shared_dpll(new_crtc_state);
> +
> + intel_encoders_pre_enable(state, crtc);
> + } else {
> + icl_ddi_bigjoiner_pre_enable(state, new_crtc_state);
> + }
> +
> + intel_dsc_enable(new_crtc_state);
> +
> + if (DISPLAY_VER(dev_priv) >= 13)
> + intel_uncompressed_joiner_enable(new_crtc_state);
> +
> + intel_set_pipe_src_size(new_crtc_state);
> + bdw_set_pipemisc(new_crtc_state);
> +
> + if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> + !transcoder_is_dsi(cpu_transcoder))
> + hsw_configure_cpu_transcoder(new_crtc_state);
> +
> + crtc->active = true;
> +
> + /* Display WA #1180: WaDisableScalarClockGating: glk */
> + psl_clkgate_wa = DISPLAY_VER(dev_priv) == 10 &&
> + new_crtc_state->pch_pfit.enabled;
> + if (psl_clkgate_wa)
> + glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
> +
> + skl_pfit_enable(new_crtc_state);
> +
> + /*
> + * On ILK+ LUT must be loaded before the pipe is running but with
> + * clocks enabled
> + */
> + intel_color_load_luts(new_crtc_state);
> + intel_color_commit_noarm(new_crtc_state);
> + intel_color_commit_arm(new_crtc_state);
> +
> + hsw_set_linetime_wm(new_crtc_state);
> +
> + if (DISPLAY_VER(dev_priv) >= 11)
> + icl_set_pipe_chicken(new_crtc_state);
> +
> + intel_initial_watermarks(state, crtc);
> +
> + if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
> + intel_crtc_vblank_on(new_crtc_state);
> +
> + intel_encoders_enable(state, crtc);
> +
> + if (psl_clkgate_wa) {
> + intel_crtc_wait_for_next_vblank(crtc);
> + glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, false);
> + }
> +}
> +
> static void hsw_crtc_enable(struct intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> @@ -9231,7 +9303,7 @@ static const struct drm_mode_config_funcs intel_mode_funcs = {
>
> static const struct drm_i915_display_funcs skl_display_funcs = {
> .get_pipe_config = hsw_get_pipe_config,
> - .crtc_enable = hsw_crtc_enable,
> + .crtc_enable = skl_crtc_enable,
> .crtc_disable = hsw_crtc_disable,
> .commit_modeset_enables = skl_commit_modeset_enables,
> .get_initial_plane_config = skl_get_initial_plane_config,
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+
2022-05-12 9:45 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2022-05-12 19:36 ` Navare, Manasi
0 siblings, 0 replies; 8+ messages in thread
From: Navare, Manasi @ 2022-05-12 19:36 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, May 12, 2022 at 12:45:09PM +0300, Jani Nikula wrote:
> On Wed, 11 May 2022, Manasi Navare <manasi.d.navare@intel.com> wrote:
> > Currently we reuse hsw_crtc_enable for SKL+ platforms.
> > But this has added a lot of platform checks for SKL+ platforms.
> > So its time to move the code to a separate crtc_enable hook
> > for SKL+ platforms.
>
> This leaves behind a ton of unused code paths in hsw_crtc_enable, which
> needs cleanup.
Oh yes, I can get rid of all the ?9 checks now from hsw_crtc_enable
I will clean that up and send a v2
Manasi
>
> BR,
> Jani.
>
> >
> > No functional changes here.
> >
> > Suggested-by: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 74 +++++++++++++++++++-
> > 1 file changed, 73 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 806d50b302ab..e2e228073e2e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -1895,6 +1895,78 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
> > hsw_set_transconf(crtc_state);
> > }
> >
> > +static void skl_crtc_enable(struct intel_atomic_state *state,
> > + struct intel_crtc *crtc)
> > +{
> > + const struct intel_crtc_state *new_crtc_state =
> > + intel_atomic_get_new_crtc_state(state, crtc);
> > + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> > + enum pipe pipe = crtc->pipe;
> > + enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
> > + bool psl_clkgate_wa;
> > +
> > + if (drm_WARN_ON(&dev_priv->drm, crtc->active))
> > + return;
> > +
> > + if (!new_crtc_state->bigjoiner_pipes) {
> > + intel_encoders_pre_pll_enable(state, crtc);
> > +
> > + if (new_crtc_state->shared_dpll)
> > + intel_enable_shared_dpll(new_crtc_state);
> > +
> > + intel_encoders_pre_enable(state, crtc);
> > + } else {
> > + icl_ddi_bigjoiner_pre_enable(state, new_crtc_state);
> > + }
> > +
> > + intel_dsc_enable(new_crtc_state);
> > +
> > + if (DISPLAY_VER(dev_priv) >= 13)
> > + intel_uncompressed_joiner_enable(new_crtc_state);
> > +
> > + intel_set_pipe_src_size(new_crtc_state);
> > + bdw_set_pipemisc(new_crtc_state);
> > +
> > + if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> > + !transcoder_is_dsi(cpu_transcoder))
> > + hsw_configure_cpu_transcoder(new_crtc_state);
> > +
> > + crtc->active = true;
> > +
> > + /* Display WA #1180: WaDisableScalarClockGating: glk */
> > + psl_clkgate_wa = DISPLAY_VER(dev_priv) == 10 &&
> > + new_crtc_state->pch_pfit.enabled;
> > + if (psl_clkgate_wa)
> > + glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
> > +
> > + skl_pfit_enable(new_crtc_state);
> > +
> > + /*
> > + * On ILK+ LUT must be loaded before the pipe is running but with
> > + * clocks enabled
> > + */
> > + intel_color_load_luts(new_crtc_state);
> > + intel_color_commit_noarm(new_crtc_state);
> > + intel_color_commit_arm(new_crtc_state);
> > +
> > + hsw_set_linetime_wm(new_crtc_state);
> > +
> > + if (DISPLAY_VER(dev_priv) >= 11)
> > + icl_set_pipe_chicken(new_crtc_state);
> > +
> > + intel_initial_watermarks(state, crtc);
> > +
> > + if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
> > + intel_crtc_vblank_on(new_crtc_state);
> > +
> > + intel_encoders_enable(state, crtc);
> > +
> > + if (psl_clkgate_wa) {
> > + intel_crtc_wait_for_next_vblank(crtc);
> > + glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, false);
> > + }
> > +}
> > +
> > static void hsw_crtc_enable(struct intel_atomic_state *state,
> > struct intel_crtc *crtc)
> > {
> > @@ -9231,7 +9303,7 @@ static const struct drm_mode_config_funcs intel_mode_funcs = {
> >
> > static const struct drm_i915_display_funcs skl_display_funcs = {
> > .get_pipe_config = hsw_get_pipe_config,
> > - .crtc_enable = hsw_crtc_enable,
> > + .crtc_enable = skl_crtc_enable,
> > .crtc_disable = hsw_crtc_disable,
> > .commit_modeset_enables = skl_commit_modeset_enables,
> > .get_initial_plane_config = skl_get_initial_plane_config,
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/display: Add a separate crtc_enable hook for SKL+
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
2022-05-12 0:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-05-12 9:45 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2022-05-12 19:52 ` Manasi Navare
2022-05-17 18:31 ` Navare, Manasi
2022-05-12 21:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2) Patchwork
2022-05-13 1:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 8+ messages in thread
From: Manasi Navare @ 2022-05-12 19:52 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Currently we reuse hsw_crtc_enable for SKL+ platforms.
But this has added a lot of platform checks for SKL+ platforms.
So its time to move the code to a separate crtc_enable hook
for SKL+ platforms.
No functional changes here.
v2: Cleanup hsw_crtc_enable (Jani N)
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 64 ++++++++++++++++----
1 file changed, 52 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 806d50b302ab..70cde34aca10 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1895,13 +1895,13 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
hsw_set_transconf(crtc_state);
}
-static void hsw_crtc_enable(struct intel_atomic_state *state,
+static void skl_crtc_enable(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
const struct intel_crtc_state *new_crtc_state =
intel_atomic_get_new_crtc_state(state, crtc);
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
- enum pipe pipe = crtc->pipe, hsw_workaround_pipe;
+ enum pipe pipe = crtc->pipe;
enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
bool psl_clkgate_wa;
@@ -1925,8 +1925,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
intel_uncompressed_joiner_enable(new_crtc_state);
intel_set_pipe_src_size(new_crtc_state);
- if (DISPLAY_VER(dev_priv) >= 9 || IS_BROADWELL(dev_priv))
- bdw_set_pipemisc(new_crtc_state);
+ bdw_set_pipemisc(new_crtc_state);
if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
!transcoder_is_dsi(cpu_transcoder))
@@ -1940,10 +1939,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
if (psl_clkgate_wa)
glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
- if (DISPLAY_VER(dev_priv) >= 9)
- skl_pfit_enable(new_crtc_state);
- else
- ilk_pfit_enable(new_crtc_state);
+ skl_pfit_enable(new_crtc_state);
/*
* On ILK+ LUT must be loaded before the pipe is running but with
@@ -1952,9 +1948,6 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
intel_color_load_luts(new_crtc_state);
intel_color_commit_noarm(new_crtc_state);
intel_color_commit_arm(new_crtc_state);
- /* update DSPCNTR to configure gamma/csc for pipe bottom color */
- if (DISPLAY_VER(dev_priv) < 9)
- intel_disable_primary_plane(new_crtc_state);
hsw_set_linetime_wm(new_crtc_state);
@@ -1972,6 +1965,53 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
intel_crtc_wait_for_next_vblank(crtc);
glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, false);
}
+}
+
+static void hsw_crtc_enable(struct intel_atomic_state *state,
+ struct intel_crtc *crtc)
+{
+ const struct intel_crtc_state *new_crtc_state =
+ intel_atomic_get_new_crtc_state(state, crtc);
+ struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+ enum pipe hsw_workaround_pipe;
+ enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
+
+ if (drm_WARN_ON(&dev_priv->drm, crtc->active))
+ return;
+
+ intel_encoders_pre_pll_enable(state, crtc);
+
+ if (new_crtc_state->shared_dpll)
+ intel_enable_shared_dpll(new_crtc_state);
+
+ intel_encoders_pre_enable(state, crtc);
+
+ intel_set_pipe_src_size(new_crtc_state);
+ if (IS_BROADWELL(dev_priv))
+ bdw_set_pipemisc(new_crtc_state);
+
+ if (!transcoder_is_dsi(cpu_transcoder))
+ hsw_configure_cpu_transcoder(new_crtc_state);
+
+ crtc->active = true;
+
+ ilk_pfit_enable(new_crtc_state);
+
+ /*
+ * On ILK+ LUT must be loaded before the pipe is running but with
+ * clocks enabled
+ */
+ intel_color_load_luts(new_crtc_state);
+ intel_color_commit_noarm(new_crtc_state);
+ intel_color_commit_arm(new_crtc_state);
+ /* update DSPCNTR to configure gamma/csc for pipe bottom color */
+ intel_disable_primary_plane(new_crtc_state);
+
+ hsw_set_linetime_wm(new_crtc_state);
+
+ intel_initial_watermarks(state, crtc);
+
+ intel_encoders_enable(state, crtc);
/* If we change the relative order between pipe/planes enabling, we need
* to change the workaround. */
@@ -9231,7 +9271,7 @@ static const struct drm_mode_config_funcs intel_mode_funcs = {
static const struct drm_i915_display_funcs skl_display_funcs = {
.get_pipe_config = hsw_get_pipe_config,
- .crtc_enable = hsw_crtc_enable,
+ .crtc_enable = skl_crtc_enable,
.crtc_disable = hsw_crtc_disable,
.commit_modeset_enables = skl_commit_modeset_enables,
.get_initial_plane_config = skl_get_initial_plane_config,
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
` (2 preceding siblings ...)
2022-05-12 19:52 ` [Intel-gfx] [PATCH v2] " Manasi Navare
@ 2022-05-12 21:33 ` Patchwork
2022-05-13 1:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-05-12 21:33 UTC (permalink / raw)
To: Navare, Manasi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14295 bytes --]
== Series Details ==
Series: drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
URL : https://patchwork.freedesktop.org/series/103896/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11644 -> Patchwork_103896v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/index.html
Participating hosts (42 -> 43)
------------------------------
Additional (4): fi-rkl-11600 bat-jsl-2 fi-apl-guc bat-dg1-5
Missing (3): fi-bdw-samus fi-bsw-cyan bat-adlp-4
Known issues
------------
Here are the changes found in Patchwork_103896v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][1] ([i915#5595])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-apl-guc/igt@debugfs_test@read_all_entries.html
* igt@fbdev@write:
- bat-dg1-5: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@fbdev@write.html
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@gem_tiled_pread_basic.html
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#3282])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#1155])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#3012])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][11] -> [INCOMPLETE][12] ([i915#5801] / [i915#5847])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][13] ([i915#4418])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][14] -> [DMESG-FAIL][15] ([i915#4528])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/fi-pnv-d510/igt@i915_selftest@live@requests.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#4215])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#4212]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4303])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_busy@basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([fdo#111827]) +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([i915#4070] / [i915#4103]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#4103] / [i915#4213]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#4078]) +23 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#109285] / [i915#4098])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-5: NOTRUN -> [SKIP][26] ([fdo#109285])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([i915#4070] / [i915#533])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-rkl-11600: NOTRUN -> [SKIP][28] ([i915#1072]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][29] ([i915#1072] / [i915#4078]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][30] ([i915#3555] / [i915#4098])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg1-5: NOTRUN -> [SKIP][31] ([i915#3555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg1-5: NOTRUN -> [SKIP][32] ([i915#3708] / [i915#4077]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][33] ([i915#3301] / [i915#3708])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][34] ([i915#3708] / [i915#4873])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-dg1-5: NOTRUN -> [SKIP][35] ([i915#3708]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@prime_vgem@basic-write.html
- fi-rkl-11600: NOTRUN -> [SKIP][36] ([i915#3291] / [i915#3708]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-rkl-11600/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][37] ([i915#4312] / [i915#5257])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg1-5/igt@runner@aborted.html
- fi-apl-guc: NOTRUN -> [FAIL][38] ([i915#4312])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-apl-guc/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][39] ([fdo#109271] / [i915#3428] / [i915#4312])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][40] ([i915#5122]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][42] ([i915#4785]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [INCOMPLETE][44] ([i915#4116]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/fi-kbl-soraka/igt@i915_selftest@live@requests.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/fi-kbl-soraka/igt@i915_selftest@live@requests.html
- {bat-dg2-9}: [DMESG-WARN][46] ([i915#5763]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/bat-dg2-9/igt@i915_selftest@live@requests.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/bat-dg2-9/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4116]: https://gitlab.freedesktop.org/drm/intel/issues/4116
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5595]: https://gitlab.freedesktop.org/drm/intel/issues/5595
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5801]: https://gitlab.freedesktop.org/drm/intel/issues/5801
[i915#5847]: https://gitlab.freedesktop.org/drm/intel/issues/5847
[i915#5885]: https://gitlab.freedesktop.org/drm/intel/issues/5885
Build changes
-------------
* Linux: CI_DRM_11644 -> Patchwork_103896v2
CI-20190529: 20190529
CI_DRM_11644: 90e6a0545613b90072812e79662597eeb13fa0c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6471: 1d6816f1200520f936a799b7b0ef2e6f396abb16 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103896v2: 90e6a0545613b90072812e79662597eeb13fa0c1 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
bc10124d620f drm/i915/display: Add a separate crtc_enable hook for SKL+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/index.html
[-- Attachment #2: Type: text/html, Size: 16808 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
` (3 preceding siblings ...)
2022-05-12 21:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2) Patchwork
@ 2022-05-13 1:45 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-05-13 1:45 UTC (permalink / raw)
To: Navare, Manasi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30266 bytes --]
== Series Details ==
Series: drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2)
URL : https://patchwork.freedesktop.org/series/103896/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11644_full -> Patchwork_103896v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_103896v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb7/igt@gem_ctx_persistence@legacy-engines-cleanup.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][2] ([i915#5076] / [i915#5614])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: NOTRUN -> [FAIL][5] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk2/igt@gem_exec_fair@basic-pace@vecs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [PASS][8] -> [SKIP][9] ([fdo#109271]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-snb5/igt@gem_exec_flush@basic-uc-set-default.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb6/igt@gem_exec_flush@basic-uc-set-default.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-kbl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_lmem_swapping@random-engines:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@gem_lmem_swapping@random-engines.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: NOTRUN -> [DMESG-WARN][12] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][13] ([i915#3318])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@gem_userptr_blits@vma-merge.html
* igt@i915_suspend@forcewake:
- shard-snb: [PASS][14] -> [INCOMPLETE][15] ([i915#4817] / [i915#5693])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-snb5/igt@i915_suspend@forcewake.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb6/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][16] ([i915#3743])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl7/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3886])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-frame-dump:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_chamelium@hdmi-frame-dump.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb7/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +4 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl7/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][26] -> [INCOMPLETE][27] ([i915#5713])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271]) +38 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-random:
- shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271]) +44 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@kms_cursor_crc@pipe-d-cursor-256x256-random.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#533])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][31] -> [FAIL][32] ([i915#4767])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([i915#4839])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl4/igt@kms_flip@flip-vs-suspend@a-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl8/igt@kms_flip@flip-vs-suspend@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271]) +100 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl7/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#533])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: NOTRUN -> [DMESG-WARN][43] ([i915#180])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][44] ([i915#265])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][45] ([fdo#108145] / [i915#265])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][46] ([i915#265])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-apl: [PASS][47] -> [FAIL][48] ([fdo#108145] / [i915#265])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][49] -> [FAIL][50] ([fdo#108145] / [i915#265]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-b-tiling-4:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271]) +52 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb7/igt@kms_plane_lowres@pipe-b-tiling-4.html
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-5@pipe-a-dp-1-downscale-with-rotation:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271]) +33 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@kms_plane_scaling@downscale-with-rotation-factor-0-5@pipe-a-dp-1-downscale-with-rotation.html
* igt@kms_psr2_su@page_flip-p010:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl7/igt@kms_psr2_su@page_flip-p010.html
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl7/igt@kms_psr2_su@page_flip-p010.html
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#658])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl2/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][56] -> [SKIP][57] ([fdo#109441]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][58] -> [SKIP][59] ([i915#5519])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-tglb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2437])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl2/igt@kms_writeback@writeback-check-output.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][61] -> [FAIL][62] ([i915#5639])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl6/igt@perf@polling-parameterized.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl9/igt@perf@polling-parameterized.html
* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2994])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@split-25:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2994])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk3/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][65] ([i915#3063]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-tglu-5/igt@gem_eio@unwedge-stress.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-tglu-2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][69] ([i915#2842]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-glk: [FAIL][71] ([i915#2842]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][73] ([i915#2842]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-kbl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_flush@basic-uc-prw-default:
- shard-snb: [SKIP][75] ([fdo#109271]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-snb6/igt@gem_exec_flush@basic-uc-prw-default.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb5/igt@gem_exec_flush@basic-uc-prw-default.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-tglu}: [FAIL][77] ([i915#3825]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-tglu-3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-tglu-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][79] ([i915#3921]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-snb6/igt@i915_selftest@live@hangcheck.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-tglb: [INCOMPLETE][81] -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-tglb6/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-tglb2/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][83] ([i915#180]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][85] ([i915#2346]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][87] ([i915#79]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][89] ([i915#79]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][91] ([i915#180]) -> [PASS][92] +4 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [FAIL][93] ([i915#4911]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-kbl: [INCOMPLETE][95] ([i915#3614]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale:
- shard-iclb: [SKIP][97] ([i915#5235]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][99] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb3/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][101] ([fdo#109441]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@syncobj_timeline@host-signal-ordered:
- shard-skl: [DMESG-WARN][103] ([i915#1982]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-skl7/igt@syncobj_timeline@host-signal-ordered.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-skl6/igt@syncobj_timeline@host-signal-ordered.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][105] ([i915#4525]) -> [DMESG-WARN][106] ([i915#5614])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb3/igt@gem_exec_balancer@parallel-keep-in-fence.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][107] ([i915#2852]) -> [FAIL][108] ([i915#2842])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][109] ([i915#2842]) -> [FAIL][110] ([i915#2851])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([fdo#111068] / [i915#658])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl8/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl4/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl6/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl3/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11644/shard-apl7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl7/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl6/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl8/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl1/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/shard-apl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5693]: https://gitlab.freedesktop.org/drm/intel/issues/5693
[i915#5713]: https://gitlab.freedesktop.org/drm/intel/issues/5713
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11644 -> Patchwork_103896v2
CI-20190529: 20190529
CI_DRM_11644: 90e6a0545613b90072812e79662597eeb13fa0c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6471: 1d6816f1200520f936a799b7b0ef2e6f396abb16 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103896v2: 90e6a0545613b90072812e79662597eeb13fa0c1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103896v2/index.html
[-- Attachment #2: Type: text/html, Size: 37463 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/display: Add a separate crtc_enable hook for SKL+
2022-05-12 19:52 ` [Intel-gfx] [PATCH v2] " Manasi Navare
@ 2022-05-17 18:31 ` Navare, Manasi
0 siblings, 0 replies; 8+ messages in thread
From: Navare, Manasi @ 2022-05-17 18:31 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
Jani, I have cleaned up the hsw_crtc_enable now removing the unused
function calls.
Could you please take a look?
Regards
Manasi
On Thu, May 12, 2022 at 12:52:04PM -0700, Manasi Navare wrote:
> Currently we reuse hsw_crtc_enable for SKL+ platforms.
> But this has added a lot of platform checks for SKL+ platforms.
> So its time to move the code to a separate crtc_enable hook
> for SKL+ platforms.
>
> No functional changes here.
>
> v2: Cleanup hsw_crtc_enable (Jani N)
>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 64 ++++++++++++++++----
> 1 file changed, 52 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 806d50b302ab..70cde34aca10 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1895,13 +1895,13 @@ static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_sta
> hsw_set_transconf(crtc_state);
> }
>
> -static void hsw_crtc_enable(struct intel_atomic_state *state,
> +static void skl_crtc_enable(struct intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> const struct intel_crtc_state *new_crtc_state =
> intel_atomic_get_new_crtc_state(state, crtc);
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> - enum pipe pipe = crtc->pipe, hsw_workaround_pipe;
> + enum pipe pipe = crtc->pipe;
> enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
> bool psl_clkgate_wa;
>
> @@ -1925,8 +1925,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
> intel_uncompressed_joiner_enable(new_crtc_state);
>
> intel_set_pipe_src_size(new_crtc_state);
> - if (DISPLAY_VER(dev_priv) >= 9 || IS_BROADWELL(dev_priv))
> - bdw_set_pipemisc(new_crtc_state);
> + bdw_set_pipemisc(new_crtc_state);
>
> if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> !transcoder_is_dsi(cpu_transcoder))
> @@ -1940,10 +1939,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
> if (psl_clkgate_wa)
> glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
>
> - if (DISPLAY_VER(dev_priv) >= 9)
> - skl_pfit_enable(new_crtc_state);
> - else
> - ilk_pfit_enable(new_crtc_state);
> + skl_pfit_enable(new_crtc_state);
>
> /*
> * On ILK+ LUT must be loaded before the pipe is running but with
> @@ -1952,9 +1948,6 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
> intel_color_load_luts(new_crtc_state);
> intel_color_commit_noarm(new_crtc_state);
> intel_color_commit_arm(new_crtc_state);
> - /* update DSPCNTR to configure gamma/csc for pipe bottom color */
> - if (DISPLAY_VER(dev_priv) < 9)
> - intel_disable_primary_plane(new_crtc_state);
>
> hsw_set_linetime_wm(new_crtc_state);
>
> @@ -1972,6 +1965,53 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
> intel_crtc_wait_for_next_vblank(crtc);
> glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, false);
> }
> +}
> +
> +static void hsw_crtc_enable(struct intel_atomic_state *state,
> + struct intel_crtc *crtc)
> +{
> + const struct intel_crtc_state *new_crtc_state =
> + intel_atomic_get_new_crtc_state(state, crtc);
> + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> + enum pipe hsw_workaround_pipe;
> + enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
> +
> + if (drm_WARN_ON(&dev_priv->drm, crtc->active))
> + return;
> +
> + intel_encoders_pre_pll_enable(state, crtc);
> +
> + if (new_crtc_state->shared_dpll)
> + intel_enable_shared_dpll(new_crtc_state);
> +
> + intel_encoders_pre_enable(state, crtc);
> +
> + intel_set_pipe_src_size(new_crtc_state);
> + if (IS_BROADWELL(dev_priv))
> + bdw_set_pipemisc(new_crtc_state);
> +
> + if (!transcoder_is_dsi(cpu_transcoder))
> + hsw_configure_cpu_transcoder(new_crtc_state);
> +
> + crtc->active = true;
> +
> + ilk_pfit_enable(new_crtc_state);
> +
> + /*
> + * On ILK+ LUT must be loaded before the pipe is running but with
> + * clocks enabled
> + */
> + intel_color_load_luts(new_crtc_state);
> + intel_color_commit_noarm(new_crtc_state);
> + intel_color_commit_arm(new_crtc_state);
> + /* update DSPCNTR to configure gamma/csc for pipe bottom color */
> + intel_disable_primary_plane(new_crtc_state);
> +
> + hsw_set_linetime_wm(new_crtc_state);
> +
> + intel_initial_watermarks(state, crtc);
> +
> + intel_encoders_enable(state, crtc);
>
> /* If we change the relative order between pipe/planes enabling, we need
> * to change the workaround. */
> @@ -9231,7 +9271,7 @@ static const struct drm_mode_config_funcs intel_mode_funcs = {
>
> static const struct drm_i915_display_funcs skl_display_funcs = {
> .get_pipe_config = hsw_get_pipe_config,
> - .crtc_enable = hsw_crtc_enable,
> + .crtc_enable = skl_crtc_enable,
> .crtc_disable = hsw_crtc_disable,
> .commit_modeset_enables = skl_commit_modeset_enables,
> .get_initial_plane_config = skl_get_initial_plane_config,
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-17 18:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 22:47 [Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+ Manasi Navare
2022-05-12 0:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-05-12 9:45 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-05-12 19:36 ` Navare, Manasi
2022-05-12 19:52 ` [Intel-gfx] [PATCH v2] " Manasi Navare
2022-05-17 18:31 ` Navare, Manasi
2022-05-12 21:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add a separate crtc_enable hook for SKL+ (rev2) Patchwork
2022-05-13 1:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.