All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chandan Babu R <chandanrlinux@gmail.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v16 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
Date: Mon, 29 Mar 2021 20:12:02 +0530	[thread overview]
Message-ID: <87ft0eauo5.fsf@garuda> (raw)
In-Reply-To: <20210326003308.32753-6-allison.henderson@oracle.com>

On 26 Mar 2021 at 06:03, Allison Henderson wrote:
> This patch separate xfs_attr_node_addname into two functions.  This will
> help to make it easier to hoist parts of xfs_attr_node_addname that need
> state management
>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
> ---
>  fs/xfs/libxfs/xfs_attr.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index d46324a..531ff56 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -54,6 +54,7 @@ STATIC int xfs_attr_leaf_hasname(struct xfs_da_args *args, struct xfs_buf **bp);
>  STATIC int xfs_attr_node_get(xfs_da_args_t *args);
>  STATIC int xfs_attr_node_addname(xfs_da_args_t *args);
>  STATIC int xfs_attr_node_removename(xfs_da_args_t *args);
> +STATIC int xfs_attr_node_addname_clear_incomplete(struct xfs_da_args *args);
>  STATIC int xfs_attr_node_hasname(xfs_da_args_t *args,
>  				 struct xfs_da_state **state);
>  STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
> @@ -1061,6 +1062,25 @@ xfs_attr_node_addname(
>  			return error;
>  	}
>
> +	error = xfs_attr_node_addname_clear_incomplete(args);
> +out:
> +	if (state)
> +		xfs_da_state_free(state);
> +	if (error)
> +		return error;
> +	return retval;

Lets say the user is performing a xattr rename operation and the call to
xfs_attr3_leaf_add() resulted in returning -ENOSPC. xfs_attr_node_addname()
would later allocate a new leaf and insert the new instance of xattr
name/value into this leaf. However, 'retval' will continue to have -ENOSPC as
its value which is incorrectly returned by the above return statement.

--
chandan

  reply	other threads:[~2021-03-29 14:42 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  0:32 [PATCH v16 00/11] xfs: Delay Ready Attributes Allison Henderson
2021-03-26  0:32 ` [PATCH v16 01/11] xfs: Reverse apply 72b97ea40d Allison Henderson
2021-03-29  8:44   ` Chandan Babu R
2021-04-02  9:47     ` Allison Henderson
2021-04-01 15:43   ` Brian Foster
2021-04-02  9:49     ` Allison Henderson
2021-03-26  0:32 ` [PATCH v16 02/11] xfs: Add xfs_attr_node_remove_cleanup Allison Henderson
2021-03-26  0:33 ` [PATCH v16 03/11] xfs: Hoist xfs_attr_set_shortform Allison Henderson
2021-03-29  9:21   ` Chandan Babu R
2021-04-02  9:47     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 04/11] xfs: Add helper xfs_attr_set_fmt Allison Henderson
2021-03-29  9:37   ` Chandan Babu R
2021-04-02  9:47     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-03-29 14:42   ` Chandan Babu R [this message]
2021-04-02  9:00     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 06/11] xfs: Add helper xfs_attr_node_addname_find_attr Allison Henderson
2021-04-02  4:05   ` Chandan Babu R
2021-04-02  9:50     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 07/11] xfs: Hoist xfs_attr_node_addname Allison Henderson
2021-04-02  4:26   ` Chandan Babu R
2021-04-02  9:01     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 08/11] xfs: Hoist xfs_attr_leaf_addname Allison Henderson
2021-04-01 15:43   ` Brian Foster
2021-04-02  9:01     ` Allison Henderson
2021-04-05 13:15       ` Brian Foster
2021-04-02  4:40   ` Chandan Babu R
2021-04-02  9:50     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 09/11] xfs: Hoist node transaction handling Allison Henderson
2021-04-02  5:04   ` Chandan Babu R
2021-04-02  9:51     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 10/11] xfs: Add delay ready attr remove routines Allison Henderson
2021-04-01 16:55   ` Brian Foster
2021-04-02  9:42     ` Allison Henderson
2021-04-05 13:15       ` Brian Foster
2021-04-02  7:59   ` Chandan Babu R
2021-04-02  9:45     ` Allison Henderson
2021-03-26  0:33 ` [PATCH v16 11/11] xfs: Add delay ready attr set routines Allison Henderson
2021-04-01 16:57   ` Brian Foster
2021-04-02  9:01     ` Allison Henderson
2021-04-05 13:17       ` Brian Foster
2021-04-14 18:14         ` Allison Henderson
2021-03-29 21:59 ` [PATCH v16 00/11] xfs: Delay Ready Attributes Darrick J. Wong
2021-04-02  9:49   ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft0eauo5.fsf@garuda \
    --to=chandanrlinux@gmail.com \
    --cc=allison.henderson@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.