* cscope redundant chars
@ 2020-04-14 14:35 Toe Dev
2020-04-14 19:31 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Toe Dev @ 2020-04-14 14:35 UTC (permalink / raw)
To: qemu-devel
add cscope phony(ctags have one) and remove redundancy
diff --git a/Makefile b/Makefile
index 84ef881600..9cf62532f9 100644
--- a/Makefile
+++ b/Makefile
@@ -1005,16 +1005,18 @@ ctags:
rm -f tags
find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
+.PHONY: cscope
+
+cscope:
+ rm -f cscope.*
+ find $(SRC_PATH) -name "*.[chsS]" -print | sed 's,^\./,,' >
"$(SRC_PATH)/cscope.files"
+ cscope -b -q -k cscope.files
+
.PHONY: TAGS
TAGS:
rm -f TAGS
find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
-cscope:
- rm -f "$(SRC_PATH)"/cscope.*
- find "$(SRC_PATH)/" -name "*.[chsS]" -print | sed 's,^\./,,' >
"$(SRC_PATH)/cscope.files"
- cscope -b -i"$(SRC_PATH)/cscope.files"
-
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: cscope redundant chars
2020-04-14 14:35 cscope redundant chars Toe Dev
@ 2020-04-14 19:31 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2020-04-14 19:31 UTC (permalink / raw)
To: Toe Dev; +Cc: qemu-devel
Toe Dev <devtoe82@gmail.com> writes:
> add cscope phony(ctags have one) and remove redundancy
>
> diff --git a/Makefile b/Makefile
> index 84ef881600..9cf62532f9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1005,16 +1005,18 @@ ctags:
> rm -f tags
> find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
>
> +.PHONY: cscope
> +
> +cscope:
> + rm -f cscope.*
> + find $(SRC_PATH) -name "*.[chsS]" -print | sed 's,^\./,,' >
> "$(SRC_PATH)/cscope.files"
> + cscope -b -q -k cscope.files
> +
> .PHONY: TAGS
> TAGS:
> rm -f TAGS
> find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
>
> -cscope:
> - rm -f "$(SRC_PATH)"/cscope.*
> - find "$(SRC_PATH)/" -name "*.[chsS]" -print | sed 's,^\./,,' >
> "$(SRC_PATH)/cscope.files"
> - cscope -b -i"$(SRC_PATH)/cscope.files"
> -
Can you explain why you drop $(SRC_PATH)/ before cscope.* and
cscope.files?
You also de-quote $(SRC_PATH). Breaks when $(SRC_PATH) contains funny
characters like space. I'm not having funny characters there is a good
idea, let alone that it works. Still, I can't see why we should strip
quotes here.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-14 19:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 14:35 cscope redundant chars Toe Dev
2020-04-14 19:31 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.