* [PATCH] mac80211: Always show airtime debugfs file when TXQs are enabled
@ 2019-12-10 14:34 Toke Høiland-Jørgensen
2019-12-11 14:53 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-12-10 14:34 UTC (permalink / raw)
To: linux-wireless; +Cc: Toke Høiland-Jørgensen
The AQL statistics are displayed in the 'airtime' station debugfs file, but
that file was only shown if a driver has enabled the airtime fairness
feature flag. Since AQL can be enabled without airtime fairness, let's
expose the airtime file whenever TXQs are enabled, so the AQL data can be
read.
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
net/mac80211/debugfs_sta.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index b3c9001d1f43..c190c29fe0dd 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -989,12 +989,10 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
DEBUGFS_ADD_COUNTER(rx_fragments, rx_stats.fragments);
DEBUGFS_ADD_COUNTER(tx_filtered, status_stats.filtered);
- if (local->ops->wake_tx_queue)
+ if (local->ops->wake_tx_queue) {
DEBUGFS_ADD(aqm);
-
- if (wiphy_ext_feature_isset(local->hw.wiphy,
- NL80211_EXT_FEATURE_AIRTIME_FAIRNESS))
DEBUGFS_ADD(airtime);
+ }
debugfs_create_xul("driver_buffered_tids", 0400, sta->debugfs_dir,
&sta->driver_buffered_tids);
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: Always show airtime debugfs file when TXQs are enabled
2019-12-10 14:34 [PATCH] mac80211: Always show airtime debugfs file when TXQs are enabled Toke Høiland-Jørgensen
@ 2019-12-11 14:53 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-12-11 14:53 UTC (permalink / raw)
To: linux-wireless
Toke Høiland-Jørgensen <toke@redhat.com> writes:
> The AQL statistics are displayed in the 'airtime' station debugfs file, but
> that file was only shown if a driver has enabled the airtime fairness
> feature flag. Since AQL can be enabled without airtime fairness, let's
> expose the airtime file whenever TXQs are enabled, so the AQL data can be
> read.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
With the change to an NL80211_EXT_FEATURE for AQL, this is no longer
needed, so please drop this patch.
-Toke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-11 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 14:34 [PATCH] mac80211: Always show airtime debugfs file when TXQs are enabled Toke Høiland-Jørgensen
2019-12-11 14:53 ` Toke Høiland-Jørgensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.