* [Buildroot] [PATCH] check-package: support symlinks to the script
@ 2018-04-01 20:05 Arnout Vandecappelle
2018-04-01 20:40 ` Ricardo Martincoski
2018-04-01 20:42 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2018-04-01 20:05 UTC (permalink / raw)
To: buildroot
The check-package script finds base_dir (= the Buildroot directory) and
cd's into it. To be able to support relative paths as arguments, it
first recalculates the arguments relative to base_dir.
However, if there is a symlink anywhere on the path to the
check-package script, the relative paths will be wrong. To solve this,
use realpath() instead of abspath(), so symlinks are resolved before
calculating the relative path.
Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
utils/check-package | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/check-package b/utils/check-package
index d9b719783d..3dbc28b0a2 100755
--- a/utils/check-package
+++ b/utils/check-package
@@ -143,7 +143,7 @@ def __main__():
if flags.intree_only:
# change all paths received to be relative to the base dir
- base_dir = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+ base_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
files_to_check = [os.path.relpath(os.path.abspath(f), base_dir) for f in flags.files]
# move current dir so the script find the files
os.chdir(base_dir)
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] check-package: support symlinks to the script
2018-04-01 20:05 [Buildroot] [PATCH] check-package: support symlinks to the script Arnout Vandecappelle
@ 2018-04-01 20:40 ` Ricardo Martincoski
2018-04-01 20:42 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Martincoski @ 2018-04-01 20:40 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, Apr 01, 2018 at 05:05 PM, Arnout Vandecappelle (Essensium/Mind) wrote:
> The check-package script finds base_dir (= the Buildroot directory) and
> cd's into it. To be able to support relative paths as arguments, it
> first recalculates the arguments relative to base_dir.
>
> However, if there is a symlink anywhere on the path to the
> check-package script, the relative paths will be wrong. To solve this,
> use realpath() instead of abspath(), so symlinks are resolved before
> calculating the relative path.
>
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Sorry. I forgot about this use case.
Thank you for fixing it.
Regards,
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] check-package: support symlinks to the script
2018-04-01 20:05 [Buildroot] [PATCH] check-package: support symlinks to the script Arnout Vandecappelle
2018-04-01 20:40 ` Ricardo Martincoski
@ 2018-04-01 20:42 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-04-01 20:42 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> The check-package script finds base_dir (= the Buildroot directory) and
> cd's into it. To be able to support relative paths as arguments, it
> first recalculates the arguments relative to base_dir.
> However, if there is a symlink anywhere on the path to the
> check-package script, the relative paths will be wrong. To solve this,
> use realpath() instead of abspath(), so symlinks are resolved before
> calculating the relative path.
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-01 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-01 20:05 [Buildroot] [PATCH] check-package: support symlinks to the script Arnout Vandecappelle
2018-04-01 20:40 ` Ricardo Martincoski
2018-04-01 20:42 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.