From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()
Date: Mon, 16 Jan 2017 16:37:53 +0200 [thread overview]
Message-ID: <87fukjcbpa.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170116141844.GH6680@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Mon, Jan 16, 2017 at 04:03:16PM +0200, Mika Kuoppala wrote:
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Now that we have prepare/finish routines for the GEM reset, move the
>> > disabling of the engine->irq_tasklet into them to reduce repetition. The
>> > device irq enable/disable is split out to ensure it is run first and
>> > last always (even if the GPU reset fails).
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>>
>> As discussed briefly in irc, the disabling could be part of
>> reset and enabling part of init_hw, that way we could wedge
>> also with irq's off, even if it breaks the symmetry.
>
> We can't leave the irq off when wedged. It's the device IRQ, so hotplug,
> gmbus and all sorts of transactions, not just our own user +
> context-switch interrupts. Did you have something else in mind?
Ah yes indeed that would be nasty for the display side. I was thinking
that reset and whole hw init while irqs are off would be safer or
more controlled.
-Mika
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-16 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 9:42 [PATCH 1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() Chris Wilson
2017-01-16 9:42 ` [PATCH 2/2] drm/i915: Detect a failed GPU reset+recovery Chris Wilson
2017-01-16 11:18 ` Chris Wilson
2017-01-16 15:00 ` [PATCH] " Chris Wilson
2017-01-16 11:54 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() Patchwork
2017-01-16 14:03 ` [PATCH 1/2] " Mika Kuoppala
2017-01-16 14:18 ` Chris Wilson
2017-01-16 14:37 ` Mika Kuoppala [this message]
2017-01-16 15:54 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fukjcbpa.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.