Re: [Qemu-devel] [PATCH v6 2/7] trace: Make trace_get_vcpu_event_count() inlinable

From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/7] trace: Make trace_get_vcpu_event_count() inlinable
Date: Thu, 12 Jan 2017 19:14:19 +0100	[thread overview]
Message-ID: <87fukoywlg.fsf@ac.upc.edu> (raw)
In-Reply-To: <6c1d8806-bb65-8be6-fb95-faf2f0633e21@twiddle.net> (Richard Henderson's message of "Tue, 10 Jan 2017 12:08:33 -0800")

Richard Henderson writes:

> On 12/28/2016 10:41 AM, Lluís Vilanova wrote:
>> @@ -82,6 +83,10 @@ static inline bool trace_event_get_vcpu_state_dynamic(CPUState *vcpu,
>> return trace_event_get_vcpu_state_dynamic_by_vcpu_id(vcpu, vcpu_id);
>> }
>> 
>> +static inline uint32_t trace_get_vcpu_event_count(void)
>> +{
>> +    return trace_next_vcpu_id;
>> +}
> ...
>> @@ -237,7 +237,7 @@ char *trace_opt_parse(const char *optarg);
>> *
>> * Return the number of known vcpu-specific events
>> */
>> -uint32_t trace_get_vcpu_event_count(void);
>> +static uint32_t trace_get_vcpu_event_count(void);

> This second declaration should be removed.

I don't think so. "trace/control.h" contains declarations and documentation,
while "trace/control-internal.h" contains inlined implementations (something
followed by many other functions there).

Thanks,
  Lluis