All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: hvaibhav@ti.com
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org,
	Afzal Mohammed <afzal@ti.com>
Subject: Re: [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources
Date: Mon, 26 Sep 2011 11:45:58 -0700	[thread overview]
Message-ID: <87fwjjcfbt.fsf@ti.com> (raw)
In-Reply-To: <1316529142-27564-3-git-send-email-hvaibhav@ti.com> (hvaibhav@ti.com's message of "Tue, 20 Sep 2011 20:02:20 +0530")

<hvaibhav@ti.com> writes:

> From: Afzal Mohammed <afzal@ti.com>
>
> This patch updates the common machine specific source files for
> support for AM33XX/AM335x with cpu type, macros for identification of
> AM33XX/AM335X device.
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

[...]

> @@ -3576,7 +3579,8 @@ int __init omap3xxx_clk_init(void)
>  	 * Lock DPLL5 -- here only until other device init code can
>  	 * handle this
>  	 */
> -	if (!cpu_is_ti816x() && (omap_rev() >= OMAP3430_REV_ES2_0))
> +	if (!cpu_is_ti816x() && !cpu_is_am33xx() &&
> +			(omap_rev() >= OMAP3430_REV_ES2_0))
>  		omap3_clk_lock_dpll5();

This is getting ugly.  

Instead of continuing to expand this if-list, I think it's time for a
new feature-flag for whether or not an SoC has DPLL5 instead.

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources
Date: Mon, 26 Sep 2011 11:45:58 -0700	[thread overview]
Message-ID: <87fwjjcfbt.fsf@ti.com> (raw)
In-Reply-To: <1316529142-27564-3-git-send-email-hvaibhav@ti.com> (hvaibhav@ti.com's message of "Tue, 20 Sep 2011 20:02:20 +0530")

<hvaibhav@ti.com> writes:

> From: Afzal Mohammed <afzal@ti.com>
>
> This patch updates the common machine specific source files for
> support for AM33XX/AM335x with cpu type, macros for identification of
> AM33XX/AM335X device.
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

[...]

> @@ -3576,7 +3579,8 @@ int __init omap3xxx_clk_init(void)
>  	 * Lock DPLL5 -- here only until other device init code can
>  	 * handle this
>  	 */
> -	if (!cpu_is_ti816x() && (omap_rev() >= OMAP3430_REV_ES2_0))
> +	if (!cpu_is_ti816x() && !cpu_is_am33xx() &&
> +			(omap_rev() >= OMAP3430_REV_ES2_0))
>  		omap3_clk_lock_dpll5();

This is getting ugly.  

Instead of continuing to expand this if-list, I think it's time for a
new feature-flag for whether or not an SoC has DPLL5 instead.

Kevin

  reply	other threads:[~2011-09-26 18:46 UTC|newest]

Thread overview: 263+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20 14:32 [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources hvaibhav
2011-09-20 14:32 ` hvaibhav at ti.com
2011-09-26 18:45 ` Kevin Hilman [this message]
2011-09-26 18:45   ` Kevin Hilman
2011-09-30 12:09   ` Premi, Sanjeev
2011-09-30 12:09     ` Premi, Sanjeev
2011-09-30 17:09     ` Kevin Hilman
2011-09-30 17:09       ` Kevin Hilman
2011-10-06 23:03       ` Tony Lindgren
2011-10-06 23:03         ` Tony Lindgren
2011-11-03 13:48         ` Hiremath, Vaibhav
2011-11-03 13:48           ` Hiremath, Vaibhav
2011-11-05  9:41 ` Hiremath, Vaibhav
2011-11-05  9:41   ` Hiremath, Vaibhav
2011-11-05 10:29   ` Hiremath, Vaibhav
2011-11-05 10:29     ` Hiremath, Vaibhav
  -- strict thread matches above, loose matches on Subject: below --
2013-03-04 11:35 [RFC PATCH 3/3] ARM: OMAP2+: Add command line parameter for debugSS module control hvaibhav
2013-03-04 11:35 ` hvaibhav at ti.com
2013-04-08 17:29 ` Tony Lindgren
2013-04-08 17:29   ` Tony Lindgren
2013-04-09  8:07   ` Hiremath, Vaibhav
2013-04-09  8:07     ` Hiremath, Vaibhav
2013-04-09 16:34     ` Tony Lindgren
2013-04-09 16:34       ` Tony Lindgren
2013-04-10  5:11       ` Hiremath, Vaibhav
2013-04-10  5:11         ` Hiremath, Vaibhav
2013-04-10 17:07         ` Tony Lindgren
2013-04-10 17:07           ` Tony Lindgren
2013-03-04 11:35 [RFC PATCH 1/3] ARM: AM33XX: clock: Add debugSS clock nodes to clock tree hvaibhav
2013-03-04 11:35 ` hvaibhav at ti.com
2013-05-29 19:07 ` Paul Walmsley
2013-05-29 19:07   ` Paul Walmsley
2013-03-04 11:35 [RFC PATCH 0/3] ARM: OMAP2+: Add command line parameter for debugSS module control hvaibhav
2013-03-04 11:35 ` hvaibhav at ti.com
2013-03-14 11:29 ` Hiremath, Vaibhav
2013-03-14 11:29   ` Hiremath, Vaibhav
2013-04-08 17:30   ` Tony Lindgren
2013-04-08 17:30     ` Tony Lindgren
2013-04-09  8:11     ` Hiremath, Vaibhav
2013-04-09  8:11       ` Hiremath, Vaibhav
2011-12-02  6:43 [PATCH-V5 2/3] arm:omap:am33xx: Add AM335XEVM machine support hvaibhav
2011-12-02  6:43 ` hvaibhav at ti.com
2012-05-02  9:23 ` Paul Walmsley
2012-05-02  9:23   ` Paul Walmsley
2012-05-02  9:34   ` Hiremath, Vaibhav
2012-05-02  9:34     ` Hiremath, Vaibhav
2012-05-03 15:57     ` Tony Lindgren
2012-05-03 15:57       ` Tony Lindgren
2012-05-03 16:41       ` Hiremath, Vaibhav
2012-05-03 16:41         ` Hiremath, Vaibhav
2012-05-03 19:37         ` Tony Lindgren
2012-05-03 19:37           ` Tony Lindgren
2012-05-04  6:14           ` Hiremath, Vaibhav
2012-05-04  6:14             ` Hiremath, Vaibhav
2012-05-03 21:17         ` Kevin Hilman
2012-05-03 21:17           ` Kevin Hilman
2012-05-04  6:00           ` Hiremath, Vaibhav
2012-05-04  6:00             ` Hiremath, Vaibhav
2012-05-04 20:05             ` Tony Lindgren
2012-05-04 20:05               ` Tony Lindgren
2012-05-07 14:38               ` Hiremath, Vaibhav
2012-05-07 14:38                 ` Hiremath, Vaibhav
2012-05-07 17:32                 ` Tony Lindgren
2012-05-07 17:32                   ` Tony Lindgren
2012-05-07 18:55                   ` Hiremath, Vaibhav
2012-05-07 18:55                     ` Hiremath, Vaibhav
2012-05-08 19:06                     ` Tony Lindgren
2012-05-08 19:06                       ` Tony Lindgren
2012-05-08 19:57                       ` Hiremath, Vaibhav
2012-05-08 19:57                         ` Hiremath, Vaibhav
2012-05-04  6:28       ` Hiremath, Vaibhav
2012-05-04  6:28         ` Hiremath, Vaibhav
2012-05-04 20:00         ` Tony Lindgren
2012-05-04 20:00           ` Tony Lindgren
2011-12-02  6:43 [PATCH-V5 1/3] arm:omap:am33xx: Update common OMAP machine specific sources hvaibhav
2011-12-02  6:43 ` hvaibhav at ti.com
2011-12-07 21:09 ` Tony Lindgren
2011-12-07 21:09   ` Tony Lindgren
2011-12-02  6:43 [PATCH-V5 0/3] Introducing TI's New SoC/board AM335XEVM hvaibhav
2011-12-02  6:43 ` hvaibhav at ti.com
2011-12-07  0:24 ` Kevin Hilman
2011-12-07  0:24   ` Kevin Hilman
2011-12-07 21:10   ` Tony Lindgren
2011-12-07 21:10     ` Tony Lindgren
2011-12-08 13:45     ` Hiremath, Vaibhav
2011-12-08 13:45       ` Hiremath, Vaibhav
2011-12-08 17:18       ` Tony Lindgren
2011-12-08 17:18         ` Tony Lindgren
2012-02-01  6:53         ` Hiremath, Vaibhav
2012-02-01  6:53           ` Hiremath, Vaibhav
2012-01-18  8:47     ` Hiremath, Vaibhav
2012-01-18  8:47       ` Hiremath, Vaibhav
2011-09-20 14:32 [PATCH-V3 4/4] arm:omap:am33xx: Add low level debugging support hvaibhav
2011-09-20 14:32 ` hvaibhav at ti.com
2011-10-06 23:09 ` Tony Lindgren
2011-10-06 23:09   ` Tony Lindgren
2011-11-07 15:17   ` Hiremath, Vaibhav
2011-11-07 15:17     ` Hiremath, Vaibhav
2011-11-07 18:16     ` Tony Lindgren
2011-11-07 18:16       ` Tony Lindgren
2011-09-20 14:32 [PATCH-V3 3/4] arm:omap:am33xx: Create board support and enable build for AM335XEVM hvaibhav
2011-09-20 14:32 ` hvaibhav at ti.com
2011-10-06 23:07 ` Tony Lindgren
2011-10-06 23:07   ` Tony Lindgren
2011-09-20 14:32 [PATCH-V3 1/4] arm:omap:am33xx: Update common omap platform files hvaibhav
2011-09-20 14:32 ` hvaibhav at ti.com
2011-10-06 23:03 ` Tony Lindgren
2011-10-06 23:03   ` Tony Lindgren
2011-08-29 12:46 [RFC PATCH-V2 0/4] Introducing TI's New SoC/board AM335XEVM hvaibhav
2011-08-29 12:46 ` hvaibhav at ti.com
2011-09-15  0:32 ` Tony Lindgren
2011-09-15  0:32   ` Tony Lindgren
2011-09-15  7:13   ` Hiremath, Vaibhav
2011-09-15  7:13     ` Hiremath, Vaibhav
     [not found] <hvaibhav@ti.com>
2008-11-21 15:22 ` [PATCH 2/2] TVP514x V4L int device driver support hvaibhav
2008-11-21 16:16   ` Hans Verkuil
2008-11-21 18:12   ` Trilok Soni
2008-11-21 18:12     ` Trilok Soni
2008-11-21 19:07     ` Hiremath, Vaibhav
2008-11-21 19:07       ` Hiremath, Vaibhav
2008-11-21 19:11     ` David Brownell
2008-11-23 22:00   ` Hans Verkuil
2008-11-23 22:04     ` Koen Kooi
2008-11-24  6:16     ` Trilok Soni
2008-11-24  6:16       ` Trilok Soni
2008-11-24  6:32       ` David Brownell
2008-11-24  7:53         ` Hans Verkuil
2008-11-24  8:53           ` Hiremath, Vaibhav
2008-11-24  8:53             ` Hiremath, Vaibhav
2008-11-24  8:04       ` Hans Verkuil
2008-11-24  8:04         ` Hans Verkuil
2008-11-24  8:43         ` Trilok Soni
2008-11-24  8:43           ` Trilok Soni
2008-11-24  8:59           ` Hiremath, Vaibhav
2008-11-24  8:59             ` Hiremath, Vaibhav
2008-11-24 10:06   ` David Brownell
2008-11-26 17:04 ` [PATCH 1/2] Add Input/Output related ioctl support hvaibhav
2008-11-26 17:15   ` Hans Verkuil
2008-11-26 17:15     ` Hans Verkuil
2008-11-26 17:05 ` [PATCH 2/2] TVP514x Driver with Review comments fixed hvaibhav
2008-11-26 17:05   ` hvaibhav
2008-11-26 17:48   ` Hans Verkuil
2008-12-02 15:35 ` [PATCH 2/2] TVP514x Driver with Review comments fixed [V4] hvaibhav
2008-12-02 15:35   ` hvaibhav
2008-12-02 17:20   ` Hans Verkuil
2008-12-03  3:58     ` Hiremath, Vaibhav
2008-12-03  3:58       ` Hiremath, Vaibhav
2008-12-03 13:43     ` V4L2 PIXEL buffer conversion Jonathan Lafontaine
2008-12-02 19:29   ` [PATCH 2/2] TVP514x Driver with Review comments fixed [V4] David Brownell
2008-12-02 19:44   ` David Brownell
2009-11-18  6:58 ` [U-Boot] [PATCH] OMAP3EVM: Added NAND support hvaibhav at ti.com
2009-11-18  7:30   ` Dirk Behme
2009-11-18  8:25     ` Hiremath, Vaibhav
2009-11-18 18:07   ` Nishanth Menon
2009-11-18 18:18     ` Scott Wood
2009-11-18 18:40     ` Hiremath, Vaibhav
2009-11-18  8:26 ` hvaibhav at ti.com
2009-11-18  8:36   ` Dirk Behme
2009-11-18 14:40     ` Hiremath, Vaibhav
2009-11-23 11:05 ` [U-Boot] [PATCH V4] " hvaibhav at ti.com
2009-11-27 15:51   ` Tom
2009-11-30 17:49     ` Hiremath, Vaibhav
2009-11-23 11:06 ` [U-Boot] [PATCH] omap3_mmc: Encapsulate twl4030 under option CONFIG_TWL4030_POWER hvaibhav at ti.com
2009-11-27 14:03   ` Tom
2009-11-30 17:43     ` Hiremath, Vaibhav
2009-11-23 11:06 ` [U-Boot] [PATCH 1/5] Introducing AM3517EVM support hvaibhav at ti.com
2009-11-23 19:43   ` Wolfgang Denk
2009-11-26  4:24     ` Hiremath, Vaibhav
2009-11-23 11:08 ` [U-Boot] [PATCH 0/5] Introducing TI's New SoC/board AM3517EVM hvaibhav at ti.com
2009-11-23 13:50   ` Paulraj, Sandeep
2009-11-23 14:16     ` Hiremath, Vaibhav
2009-11-23 20:03     ` Wolfgang Denk
2009-11-26  4:49       ` Hiremath, Vaibhav
2009-11-25 20:24   ` Tom
2009-11-23 11:08 ` [U-Boot] [PATCH 2/5] am3517_evm_config options added to Makfile hvaibhav at ti.com
2009-11-23 19:44   ` Wolfgang Denk
2009-11-26  4:25     ` Hiremath, Vaibhav
2009-11-23 11:08 ` [U-Boot] [PATCH 3/5] Added configuration file for AM3517EVM hvaibhav at ti.com
2009-11-23 19:46   ` Wolfgang Denk
2009-11-26  4:43     ` Hiremath, Vaibhav
2009-11-26 16:04       ` Tom
2009-11-30 17:01         ` Hiremath, Vaibhav
2009-12-05  0:20       ` Wolfgang Denk
2009-11-23 11:08 ` [U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration hvaibhav at ti.com
2009-11-23 19:49   ` Wolfgang Denk
2009-11-26  4:45     ` Hiremath, Vaibhav
2009-11-26 16:07       ` Tom
2009-12-05  0:23       ` Wolfgang Denk
2009-11-23 11:09 ` [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4 hvaibhav at ti.com
2009-11-23 19:50   ` Wolfgang Denk
2009-11-26  4:48     ` Hiremath, Vaibhav
2009-11-26 16:14       ` Tom
2009-11-30 17:03         ` Hiremath, Vaibhav
2010-01-30 10:16 ` [U-Boot] [PATCH 0/3] Add Support for AM3517EVM with EMIF4 hvaibhav at ti.com
2010-02-02 18:40   ` Hiremath, Vaibhav
2010-02-03 13:24     ` Tom
2010-02-03 13:26       ` Hiremath, Vaibhav
2010-01-30 10:16 ` [U-Boot] [PATCH 1/3] OMAP3: Consolidate SDRC related operations hvaibhav at ti.com
2010-02-07 16:13   ` Tom
2010-02-10  9:35     ` Hiremath, Vaibhav
2010-04-23 14:55 ` [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support hvaibhav at ti.com
2010-05-05 20:01   ` Wolfgang Denk
2010-05-06  5:36     ` Hiremath, Vaibhav
2010-05-06 10:40       ` Nishanth Menon
2010-05-06 10:50         ` Wolfgang Denk
2010-05-06 10:54           ` Nishanth Menon
2010-05-06 11:03             ` Wolfgang Denk
2010-05-06 11:11               ` Nishanth Menon
2010-05-06 11:28                 ` Wolfgang Denk
2010-05-06 11:04           ` Hiremath, Vaibhav
2010-05-06 10:59       ` Wolfgang Denk
2010-04-23 14:55 ` [U-Boot] [PATCH-V2 2/4] omap3: Consolidate SDRC related operations hvaibhav at ti.com
2010-05-05 20:07   ` Wolfgang Denk
2010-05-06  6:49     ` Hiremath, Vaibhav
2010-05-06 10:55       ` Wolfgang Denk
2010-04-23 14:55 ` [U-Boot] [PATCH-V2 3/4] AM35x: Add support for AM3517EVM hvaibhav at ti.com
2010-05-05 20:12   ` Wolfgang Denk
2010-05-06  6:52     ` Hiremath, Vaibhav
2010-05-06 10:52       ` Wolfgang Denk
2010-04-23 14:55 ` [U-Boot] [PATCH-V2 4/4] AM35x: Add support for EMIF4 hvaibhav at ti.com
2010-05-05 20:14   ` Wolfgang Denk
2010-05-06  6:56     ` Hiremath, Vaibhav
2010-05-06 10:56       ` Wolfgang Denk
2010-05-06 17:19 ` [U-Boot] [PATCH-V5] OMAP3EVM: Added NAND support hvaibhav at ti.com
2010-05-11  4:59   ` Hiremath, Vaibhav
2010-05-11  8:59     ` Wolfgang Denk
2010-05-11  9:01       ` Hiremath, Vaibhav
2010-05-11 20:11       ` Scott Wood
2010-05-06 17:23 ` [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM hvaibhav at ti.com
2010-05-11  5:00   ` Hiremath, Vaibhav
2010-05-31  9:40   ` Wolfgang Denk
2010-06-03 17:27     ` Hiremath, Vaibhav
2010-06-07  8:56     ` Hiremath, Vaibhav
2010-06-07 12:24       ` Wolfgang Denk
2010-06-07 14:23         ` Hiremath, Vaibhav
2010-05-06 17:23 ` [U-Boot] [PATCH-V3 2/2] AM35x: Add support for EMIF4 hvaibhav at ti.com
2010-05-31  9:43   ` Wolfgang Denk
2010-06-03 17:28     ` Hiremath, Vaibhav
2010-06-07 14:59 ` [U-Boot] [PATCH-V4 1/2] AM35x: Add support for AM3517EVM hvaibhav at ti.com
2010-06-07 21:20   ` Paulraj, Sandeep
2010-11-29 16:21 ` [U-Boot] [PATCH] AM3517:Fix for ARM Relocation support hvaibhav at ti.com
2010-11-29 16:24   ` Hiremath, Vaibhav
2010-11-29 16:32     ` Paulraj, Sandeep
2010-11-29 16:22 ` [U-Boot] [PATCH] AM3517:Build FIX: undef CONFIG_CMD_NFS support hvaibhav at ti.com
2010-11-29 21:36   ` Paulraj, Sandeep
2010-11-29 16:23 ` [U-Boot] [PATCH] AM3517:EMIF4: fix SDRAM size to 256Mb hvaibhav at ti.com
2010-11-29 21:36   ` Paulraj, Sandeep
2010-11-29 21:37   ` Paulraj, Sandeep
2011-08-01 14:21 ` [U-Boot] [PATCH] omap3evm: Use generic MMC driver hvaibhav at ti.com
2011-08-17  2:32   ` Andy Fleming
2011-08-01 14:21 ` [U-Boot] [PATCH] am3517evm: " hvaibhav at ti.com
2011-08-17  2:33   ` Andy Fleming
2013-03-15  7:11 ` [U-Boot] [PATCH] am335x: Enable DDR PHY dynamic power down bit for DDR3 boards Vaibhav Hiremath
2013-03-15 15:05   ` Tom Rini
2013-03-15 15:56     ` Lars Poeschel
2013-03-26 14:53   ` [U-Boot] " Tom Rini
2009-05-06 18:31 [PATCH (V2)] TVP514x: Migration to sub-device framework hvaibhav
2009-06-14 10:14 ` Hans Verkuil
2009-06-14 12:44   ` Hans Verkuil
2009-06-14 14:32     ` tcm825x.c: migrating to sub-device framework? (was: TVP514x: Migration to sub-device framework) Hans Verkuil
2009-06-15  8:45       ` tcm825x.c: migrating to sub-device framework? Sakari Ailus
2009-06-14 19:50   ` [PATCH (V2)] TVP514x: Migration to sub-device framework David Brownell
2009-06-14 19:50     ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwjjcfbt.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=afzal@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.