[Buildroot] [PATCH 1/2] package/jack2: fix build with libexecinfo

[Buildroot] [PATCH 1/2] package/jack2: fix build with libexecinfo

[Fabrice Fontaine]

Fix the following build failure raised on uclibc and musl since the
addition of libexecinfo package in commit
eea8ba446c10701a273432552108d80fb2224ef4:

/home/peko/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: dbus/sigsegv.c.17.o: in function `signal_segv':
sigsegv.c:(.text+0x98): undefined reference to `backtrace'

Fixes:
 - http://autobuild.buildroot.org/results/dca49cb9b3e66fac921601560e9358bcce9acffc

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/jack2/jack2.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
index 2e55169984..127c99eed1 100644
--- a/package/jack2/jack2.mk
+++ b/package/jack2/jack2.mk
@@ -14,6 +14,11 @@ JACK2_INSTALL_STAGING = YES
 
 JACK2_CONF_OPTS = --alsa
 
+ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
+JACK2_DEPENDENCIES += libexecinfo
+JACK2_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lexecinfo"
+endif
+
 ifeq ($(BR2_PACKAGE_OPUS),y)
 JACK2_DEPENDENCIES += opus
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/jack2: explicitly {dis, en}able opus and readline

[Fabrice Fontaine]

Explicitly disable or enable opus and readline which have been added by
commits 055cf588427b40533da74d16df1830e483c5618e and
f658b1934f91e8c416fd7519c9f7e3ab86dca076

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/jack2/jack2.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
index 127c99eed1..6939aac9a6 100644
--- a/package/jack2/jack2.mk
+++ b/package/jack2/jack2.mk
@@ -21,10 +21,16 @@ endif
 
 ifeq ($(BR2_PACKAGE_OPUS),y)
 JACK2_DEPENDENCIES += opus
+JACK2_CONF_OPTS += --opus=yes
+else
+JACK2_CONF_OPTS += --opus=no
 endif
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
 JACK2_DEPENDENCIES += readline
+JACK2_CONF_OPTS += --readline=yes
+else
+JACK2_CONF_OPTS += --readline=no
 endif
 
 ifeq ($(BR2_PACKAGE_JACK2_LEGACY),y)
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/jack2: fix build with libexecinfo

[Arnout Vandecappelle]

On 22/03/2022 18:48, Fabrice Fontaine wrote:
> Fix the following build failure raised on uclibc and musl since the
> addition of libexecinfo package in commit
> eea8ba446c10701a273432552108d80fb2224ef4:
> 
> /home/peko/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: dbus/sigsegv.c.17.o: in function `signal_segv':
> sigsegv.c:(.text+0x98): undefined reference to `backtrace'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/dca49cb9b3e66fac921601560e9358bcce9acffc
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied both to master, thanks.

  Regards,
  Arnout

> ---
>   package/jack2/jack2.mk | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
> index 2e55169984..127c99eed1 100644
> --- a/package/jack2/jack2.mk
> +++ b/package/jack2/jack2.mk
> @@ -14,6 +14,11 @@ JACK2_INSTALL_STAGING = YES
>   
>   JACK2_CONF_OPTS = --alsa
>   
> +ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
> +JACK2_DEPENDENCIES += libexecinfo
> +JACK2_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lexecinfo"
> +endif
> +
>   ifeq ($(BR2_PACKAGE_OPUS),y)
>   JACK2_DEPENDENCIES += opus
>   endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/jack2: fix build with libexecinfo

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure raised on uclibc and musl since the
 > addition of libexecinfo package in commit
 > eea8ba446c10701a273432552108d80fb2224ef4:

 > /home/peko/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld:
 > dbus/sigsegv.c.17.o: in function `signal_segv':
 > sigsegv.c:(.text+0x98): undefined reference to `backtrace'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/dca49cb9b3e66fac921601560e9358bcce9acffc

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/jack2: explicitly {dis, en}able opus and readline

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Explicitly disable or enable opus and readline which have been added by
 > commits 055cf588427b40533da74d16df1830e483c5618e and
 > f658b1934f91e8c416fd7519c9f7e3ab86dca076

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot