[Buildroot] [git commit] fs/ext2: fir (again) namespace for variables

[Buildroot] [git commit] fs/ext2: fir (again) namespace for variables

[Yann E. MORIN]

commit: https://git.buildroot.net/buildroot/commit/?id=5ece6be60b8147d05c7c51fd49f64e0140399727
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

As reported by Jens [0], commit db7d78614098 (fs/ext2: fix namespace for
variables) forgot to rename one variable expansion, resulting in the
ext2 label as set by the user to be ignored, with an empty label set.

[0] https://github.com/buildroot/buildroot/commit/db7d78614098#commitcomment-57918423

Reported-by: Jens Maus <mail@jens-maus.de>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 fs/ext2/ext2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
index 0b797f315f..5b5393f092 100644
--- a/fs/ext2/ext2.mk
+++ b/fs/ext2/ext2.mk
@@ -21,7 +21,7 @@ ROOTFS_EXT2_OPTS = \
 	-r $(BR2_TARGET_ROOTFS_EXT2_REV) \
 	-N $(BR2_TARGET_ROOTFS_EXT2_INODES) \
 	-m $(BR2_TARGET_ROOTFS_EXT2_RESBLKS) \
-	-L "$(EXT2_LABEL)" \
+	-L "$(ROOTFS_EXT2_LABEL)" \
 	$(ROOTFS_EXT2_MKFS_OPTS)
 
 ROOTFS_EXT2_DEPENDENCIES = host-e2fsprogs
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] fs/ext2: fir (again) namespace for variables

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=5ece6be60b8147d05c7c51fd49f64e0140399727
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > As reported by Jens [0], commit db7d78614098 (fs/ext2: fix namespace for
 > variables) forgot to rename one variable expansion, resulting in the
 > ext2 label as set by the user to be ignored, with an empty label set.

 > [0] https://github.com/buildroot/buildroot/commit/db7d78614098#commitcomment-57918423

 > Reported-by: Jens Maus <mail@jens-maus.de>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

fir? ;)

Committed to 2021.02.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot