All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com,
	andre.guedes@intel.com, anthony.l.nguyen@intel.com,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private"
Date: Mon, 28 Sep 2020 15:32:23 -0700	[thread overview]
Message-ID: <87h7rhv8g8.fsf@intel.com> (raw)
In-Reply-To: <20200928215432.GA2499272@bjorn-Precision-5520>

Hi,

Bjorn Helgaas <helgaas@kernel.org> writes:

> On Fri, Sep 25, 2020 at 04:28:32PM -0700, Vinicius Costa Gomes wrote:
>> Make pci_enable_ptm() accessible from the drivers.
>> 
>> Even if PTM still works on the platform I am using without calling
>> this this function, it might be possible that it's not always the
>> case.
>
> *Does* PTM work on your system without calling pci_enable_ptm()?  If
> so, I think that would mean the BIOS enabled PTM, and that seems
> slightly surprising.
>

At least it seems to work, yeah, the PTM related registers that I need
for cross timestamping still return valid results when I don't call
pci_enable_ptm().

Btw, I just noticed a typo in the commit message, will fix it for the
v2.

>> Exposing this to the driver enables the driver to use the
>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>> 
>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>> 
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>
> AFAICT we just never had any callers at all for pci_enable_ptm().  I
> probably shouldn't have merged it in the first place.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>

Thanks.

-- 
Vinicius

WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private"
Date: Mon, 28 Sep 2020 15:32:23 -0700	[thread overview]
Message-ID: <87h7rhv8g8.fsf@intel.com> (raw)
In-Reply-To: <20200928215432.GA2499272@bjorn-Precision-5520>

Hi,

Bjorn Helgaas <helgaas@kernel.org> writes:

> On Fri, Sep 25, 2020 at 04:28:32PM -0700, Vinicius Costa Gomes wrote:
>> Make pci_enable_ptm() accessible from the drivers.
>> 
>> Even if PTM still works on the platform I am using without calling
>> this this function, it might be possible that it's not always the
>> case.
>
> *Does* PTM work on your system without calling pci_enable_ptm()?  If
> so, I think that would mean the BIOS enabled PTM, and that seems
> slightly surprising.
>

At least it seems to work, yeah, the PTM related registers that I need
for cross timestamping still return valid results when I don't call
pci_enable_ptm().

Btw, I just noticed a typo in the commit message, will fix it for the
v2.

>> Exposing this to the driver enables the driver to use the
>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>> 
>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>> 
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>
> AFAICT we just never had any callers at all for pci_enable_ptm().  I
> probably shouldn't have merged it in the first place.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>

Thanks.

-- 
Vinicius

  reply	other threads:[~2020-09-28 23:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 23:28 [PATCH next-queue v1 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2020-09-25 23:28   ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-28 21:54   ` Bjorn Helgaas
2020-09-28 21:54     ` [Intel-wired-lan] " Bjorn Helgaas
2020-09-28 22:32     ` Vinicius Costa Gomes [this message]
2020-09-28 22:32       ` Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes
2020-09-25 23:28   ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-25 23:28 ` [PATCH next-queue v1 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2020-09-25 23:28   ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-09-26  4:11   ` kernel test robot
2020-09-26  4:11     ` kernel test robot
2020-09-26  4:11     ` [Intel-wired-lan] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7rhv8g8.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=andre.guedes@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sasha.neftin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.