All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] New search features on autobuild.buildroot.org
@ 2019-08-20 13:11 Thomas Petazzoni
  2019-08-20 18:04 ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-08-20 13:11 UTC (permalink / raw)
  To: buildroot

Hello,

As part of his internship at Bootlin working on Buildroot, Victor
Huesca (in Cc) has implemented improvements to autobuild.buildroot.org,
with new search capabilities. These allow more powerful filtering of
autobuild results, which is sometimes useful to understand in which
situations a build failure occurs or does not occur.

You all probably knew that you could already add GET parameters to
filter out build results. For example:

  http://autobuild.buildroot.org/?arch=arm&reason=strace%

Would give you all the build results happening on the ARM architecture,
where the failure reason starts with "strace". This of course could be
expanded with more criteria:

  http://autobuild.buildroot.org/?arch=arm&reason=strace%&libc=uclibc&static=1

To further filter only the results with the uClibc C library, and
static linking configurations.

Victor has added support for two new filters:

 - The first one, "symbols" is by far the most important and powerful
   one, as it allows to filter build results using the values of
   Config.in options in the configuration that was built.

   http://autobuild.buildroot.org/?symbols[BR2_PACKAGE_STRACE]=y&symbols[BR2_PACKAGE_BUSYBOX]=

   will list all build results that had BR2_PACKAGE_STRACE enabled, but
   BR2_PACKAGE_BUSYBOX disabled.

   Note that the queries involving "symbols" will be slower than other
   queries, so please give some time for the server to reply. It
   typically takes 10-20 seconds.

 - The second one "date", allows to filter the build results by date.
   You can use date=FROMDATE or date[from]=FROMDATE&date[to]=TODATE.

Since all of these arguments were a bit difficult to remember, Victor
also created a "search page" at:

  http://autobuild.buildroot.net/search.php

You fill in the criteria, and it will redirect you to the right
address, which you can share with others if needed.

Kudos to Victor for completing this!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] New search features on autobuild.buildroot.org
  2019-08-20 13:11 [Buildroot] New search features on autobuild.buildroot.org Thomas Petazzoni
@ 2019-08-20 18:04 ` Peter Korsgaard
  2019-08-26  7:49   ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2019-08-20 18:04 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

Hi,

 > Since all of these arguments were a bit difficult to remember, Victor
 > also created a "search page" at:

 >   http://autobuild.buildroot.net/search.php

 > You fill in the criteria, and it will redirect you to the right
 > address, which you can share with others if needed.

Cool, thanks!

 > Kudos to Victor for completing this!

Yes indeed!

One improvement could be to only pass the arguments if they have been
filled in so you can ignore everything you don't care about rather than
having to edit the URL afterwards.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] New search features on autobuild.buildroot.org
  2019-08-20 18:04 ` Peter Korsgaard
@ 2019-08-26  7:49   ` Thomas Petazzoni
  2019-08-26  9:36     ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-08-26  7:49 UTC (permalink / raw)
  To: buildroot

Hello Peter,

On Tue, 20 Aug 2019 20:04:05 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> One improvement could be to only pass the arguments if they have been
> filled in so you can ignore everything you don't care about rather than
> having to edit the URL afterwards.

Hm, this is exactly was it does, i.e if I do a search filtering only on
the architecture and one symbol, it redirects to the following URL:

  http://autobuild.buildroot.net/index.php?arch=arm&symbols%5BBR2_PACKAGE_STRACE%5D=y

This is all done by the submitForm() function in
http://autobuild.buildroot.net/search.js.

Could you confirm that it works for you (or not) ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] New search features on autobuild.buildroot.org
  2019-08-26  7:49   ` Thomas Petazzoni
@ 2019-08-26  9:36     ` Peter Korsgaard
  2019-08-26  9:47       ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2019-08-26  9:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello Peter,
 > On Tue, 20 Aug 2019 20:04:05 +0200
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> One improvement could be to only pass the arguments if they have been
 >> filled in so you can ignore everything you don't care about rather than
 >> having to edit the URL afterwards.

 > Hm, this is exactly was it does, i.e if I do a search filtering only on
 > the architecture and one symbol, it redirects to the following URL:

 >   http://autobuild.buildroot.net/index.php?arch=arm&symbols%5BBR2_PACKAGE_STRACE%5D=y

 > This is all done by the submitForm() function in
 > http://autobuild.buildroot.net/search.js.

 > Could you confirm that it works for you (or not) ?

It doesn't (firefox-esr 60.8.0esr-1~deb9u1), it ends up redirecting to:

http://autobuild.buildroot.net/index.php?submitter=&reason=&arch=arm&subarch=&date%5Bfrom%5D=&symbols=BR2_PACKAGE_STRACE%3Dy&libc=&date%5Bto%5D=

Retrying on chrome I do see that it works:

http://autobuild.buildroot.org/index.php?arch=arm&symbols%5BBR2_PACKAGE_STRACE%5D=y

It would be great if we could get it to work under Firefox as
well. I know next to nothing about Javascript, but shouldn't the
submitForm() function take an event argument? In the debugger console I
see:

ReferenceError: event is not defined              search.js:3:5

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] New search features on autobuild.buildroot.org
  2019-08-26  9:36     ` Peter Korsgaard
@ 2019-08-26  9:47       ` Thomas Petazzoni
  2019-08-26 12:14         ` Victor Huesca
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-08-26  9:47 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 26 Aug 2019 11:36:53 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> It doesn't (firefox-esr 60.8.0esr-1~deb9u1), it ends up redirecting to:
> 
> http://autobuild.buildroot.net/index.php?submitter=&reason=&arch=arm&subarch=&date%5Bfrom%5D=&symbols=BR2_PACKAGE_STRACE%3Dy&libc=&date%5Bto%5D=
> 
> Retrying on chrome I do see that it works:
> 
> http://autobuild.buildroot.org/index.php?arch=arm&symbols%5BBR2_PACKAGE_STRACE%5D=y
> 
> It would be great if we could get it to work under Firefox as
> well. I know next to nothing about Javascript, but shouldn't the
> submitForm() function take an event argument? In the debugger console I
> see:
> 
> ReferenceError: event is not defined              search.js:3:5

It works here under Firefox 68.0 (64-bit), provided by Fedora.

Victor, do you think you could have a look ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] New search features on autobuild.buildroot.org
  2019-08-26  9:47       ` Thomas Petazzoni
@ 2019-08-26 12:14         ` Victor Huesca
  0 siblings, 0 replies; 6+ messages in thread
From: Victor Huesca @ 2019-08-26 12:14 UTC (permalink / raw)
  To: buildroot

Hello,

Le 26/08/2019 ? 11:47, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Mon, 26 Aug 2019 11:36:53 +0200
> Peter Korsgaard <peter@korsgaard.com> wrote:
> 
>> It doesn't (firefox-esr 60.8.0esr-1~deb9u1), it ends up redirecting to:
>>
>> http://autobuild.buildroot.net/index.php?submitter=&reason=&arch=arm&subarch=&date%5Bfrom%5D=&symbols=BR2_PACKAGE_STRACE%3Dy&libc=&date%5Bto%5D=
>>
>> Retrying on chrome I do see that it works:
>>
>> http://autobuild.buildroot.org/index.php?arch=arm&symbols%5BBR2_PACKAGE_STRACE%5D=y
>>
>> It would be great if we could get it to work under Firefox as
>> well. I know next to nothing about Javascript, but shouldn't the
>> submitForm() function take an event argument? In the debugger console I
>> see:
>>
>> ReferenceError: event is not defined              search.js:3:5
> 
> It works here under Firefox 68.0 (64-bit), provided by Fedora.
> 
> Victor, do you think you could have a look ?
> 

I quickly looked at it looks like and passing the global 'event' object
to the function makes it work on the last est build of firefox. I've
send a patch.

Thanks for this feedback!

> Thanks,
> 
> Thomas
> 

-- 
Victor Huesca, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-26 12:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 13:11 [Buildroot] New search features on autobuild.buildroot.org Thomas Petazzoni
2019-08-20 18:04 ` Peter Korsgaard
2019-08-26  7:49   ` Thomas Petazzoni
2019-08-26  9:36     ` Peter Korsgaard
2019-08-26  9:47       ` Thomas Petazzoni
2019-08-26 12:14         ` Victor Huesca

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.