From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen
Date: Tue, 6 Nov 2018 04:36:55 +0000 [thread overview]
Message-ID: <87h8gux221.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87lg66x23x.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Current driver is checking situation that can not happen.
This patch removes over-kill check
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/generic/audio-graph-scu-card.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c
index ba7b0cf..2ba35bd 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -250,9 +250,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv)
of_node_put(codec_port);
if (codec) {
- if (!codec_port)
- continue;
-
if (codec_port_old == codec_port)
continue;
@@ -308,11 +305,7 @@ static int asoc_graph_get_dais_count(struct device *dev)
of_node_put(codec_ep);
of_node_put(codec_port);
- if (cpu_ep)
- count++;
-
- if (!codec_port)
- continue;
+ count++;
if (codec_port_old == codec_port)
continue;
--
2.7.4
next prev parent reply other threads:[~2018-11-06 4:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 4:35 [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check Kuninori Morimoto
2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto
2018-11-06 17:54 ` Applied "ASoC: audio-graph-card: remove endpoint bidirectional check" to the asoc tree Mark Brown
2018-11-06 4:36 ` [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check Kuninori Morimoto
2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove endpoint bidirectional check" to the asoc tree Mark Brown
2018-11-06 4:36 ` Kuninori Morimoto [this message]
2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove error check which never happen" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8gux221.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.