* [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check @ 2018-11-06 4:35 Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Kuninori Morimoto @ 2018-11-06 4:35 UTC (permalink / raw) To: Mark Brown; +Cc: Linux-ALSA Hi Mark These are cleanup for audio-graph-card. It removes unneeded error check code Kuninori Morimoto (3): ASoC: audio-graph-card: remove endpoint bidirectional check ASoC: audio-graph-scu-card: remove endpoint bidirectional check ASoC: audio-graph-scu-card: remove error check which never happen sound/soc/generic/audio-graph-card.c | 9 --------- sound/soc/generic/audio-graph-scu-card.c | 19 +------------------ 2 files changed, 1 insertion(+), 27 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] ASoC: audio-graph-card: remove endpoint bidirectional check 2018-11-06 4:35 [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check Kuninori Morimoto @ 2018-11-06 4:36 ` Kuninori Morimoto 2018-11-06 17:54 ` Applied "ASoC: audio-graph-card: remove endpoint bidirectional check" to the asoc tree Mark Brown 2018-11-06 4:36 ` [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen Kuninori Morimoto 2 siblings, 1 reply; 7+ messages in thread From: Kuninori Morimoto @ 2018-11-06 4:36 UTC (permalink / raw) To: Mark Brown; +Cc: Linux-ALSA From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> DTC commit df536831d02c ("checks: add graph binding checks") is checking endpoint bidirectional, and it is upstreamed to linux by commit 50aafd60898a ("scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc"). Let's remove own bidirectional check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- sound/soc/generic/audio-graph-card.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 25c819e..26eb6ff 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -167,16 +167,8 @@ static int asoc_graph_card_dai_link_of(struct device_node *cpu_port, struct asoc_simple_dai *codec_dai = &dai_props->codec_dai; struct device_node *cpu_ep = of_get_next_child(cpu_port, NULL); struct device_node *codec_ep = of_graph_get_remote_endpoint(cpu_ep); - struct device_node *rcpu_ep = of_graph_get_remote_endpoint(codec_ep); int ret; - if (rcpu_ep != cpu_ep) { - dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n", - cpu_ep->name, codec_ep->name, rcpu_ep->name); - ret = -EINVAL; - goto dai_link_of_err; - } - ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, NULL, &dai_link->dai_fmt); if (ret < 0) @@ -228,7 +220,6 @@ static int asoc_graph_card_dai_link_of(struct device_node *cpu_port, dai_link_of_err: of_node_put(cpu_ep); - of_node_put(rcpu_ep); of_node_put(codec_ep); return ret; -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Applied "ASoC: audio-graph-card: remove endpoint bidirectional check" to the asoc tree 2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto @ 2018-11-06 17:54 ` Mark Brown 0 siblings, 0 replies; 7+ messages in thread From: Mark Brown @ 2018-11-06 17:54 UTC (permalink / raw) To: Kuninori Morimoto; +Cc: alsa-devel, Mark Brown The patch ASoC: audio-graph-card: remove endpoint bidirectional check has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 39ee0b3401feac5932dca6a98d538438aa5f6236 Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Date: Tue, 6 Nov 2018 04:36:27 +0000 Subject: [PATCH] ASoC: audio-graph-card: remove endpoint bidirectional check DTC commit df536831d02c ("checks: add graph binding checks") is checking endpoint bidirectional, and it is upstreamed to linux by commit 50aafd60898a ("scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc"). Let's remove own bidirectional check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/generic/audio-graph-card.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 25c819e402e1..26eb6ff9b9f3 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -167,16 +167,8 @@ static int asoc_graph_card_dai_link_of(struct device_node *cpu_port, struct asoc_simple_dai *codec_dai = &dai_props->codec_dai; struct device_node *cpu_ep = of_get_next_child(cpu_port, NULL); struct device_node *codec_ep = of_graph_get_remote_endpoint(cpu_ep); - struct device_node *rcpu_ep = of_graph_get_remote_endpoint(codec_ep); int ret; - if (rcpu_ep != cpu_ep) { - dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n", - cpu_ep->name, codec_ep->name, rcpu_ep->name); - ret = -EINVAL; - goto dai_link_of_err; - } - ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, NULL, &dai_link->dai_fmt); if (ret < 0) @@ -228,7 +220,6 @@ static int asoc_graph_card_dai_link_of(struct device_node *cpu_port, dai_link_of_err: of_node_put(cpu_ep); - of_node_put(rcpu_ep); of_node_put(codec_ep); return ret; -- 2.19.0.rc2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check 2018-11-06 4:35 [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto @ 2018-11-06 4:36 ` Kuninori Morimoto 2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove endpoint bidirectional check" to the asoc tree Mark Brown 2018-11-06 4:36 ` [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen Kuninori Morimoto 2 siblings, 1 reply; 7+ messages in thread From: Kuninori Morimoto @ 2018-11-06 4:36 UTC (permalink / raw) To: Mark Brown; +Cc: Linux-ALSA From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> DTC commit df536831d02c ("checks: add graph binding checks") is checking endpoint bidirectional, and it is upstreamed to linux by commit 50aafd60898a ("scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc"). Let's remove own bidirectional check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- sound/soc/generic/audio-graph-scu-card.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index b83bb31..ba7b0cf 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -186,7 +186,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) struct device_node *cpu_port; struct device_node *cpu_ep; struct device_node *codec_ep; - struct device_node *rcpu_ep; struct device_node *codec_port; struct device_node *codec_port_old; unsigned int daifmt = 0; @@ -217,22 +216,13 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) cpu_port = it.node; cpu_ep = of_get_next_child(cpu_port, NULL); codec_ep = of_graph_get_remote_endpoint(cpu_ep); - rcpu_ep = of_graph_get_remote_endpoint(codec_ep); of_node_put(cpu_ep); of_node_put(codec_ep); - of_node_put(rcpu_ep); if (!codec_ep) continue; - if (rcpu_ep != cpu_ep) { - dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n", - cpu_ep->name, codec_ep->name, rcpu_ep->name); - ret = -EINVAL; - goto parse_of_err; - } - ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, NULL, &daifmt); if (ret < 0) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Applied "ASoC: audio-graph-scu-card: remove endpoint bidirectional check" to the asoc tree 2018-11-06 4:36 ` [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check Kuninori Morimoto @ 2018-11-06 17:53 ` Mark Brown 0 siblings, 0 replies; 7+ messages in thread From: Mark Brown @ 2018-11-06 17:53 UTC (permalink / raw) To: Kuninori Morimoto; +Cc: alsa-devel, Mark Brown The patch ASoC: audio-graph-scu-card: remove endpoint bidirectional check has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 1a115f3a5418459aabc10628eb25dff1bae64bca Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Date: Tue, 6 Nov 2018 04:36:41 +0000 Subject: [PATCH] ASoC: audio-graph-scu-card: remove endpoint bidirectional check DTC commit df536831d02c ("checks: add graph binding checks") is checking endpoint bidirectional, and it is upstreamed to linux by commit 50aafd60898a ("scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc"). Let's remove own bidirectional check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/generic/audio-graph-scu-card.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index b83bb31021a9..ba7b0cf028b7 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -186,7 +186,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) struct device_node *cpu_port; struct device_node *cpu_ep; struct device_node *codec_ep; - struct device_node *rcpu_ep; struct device_node *codec_port; struct device_node *codec_port_old; unsigned int daifmt = 0; @@ -217,22 +216,13 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) cpu_port = it.node; cpu_ep = of_get_next_child(cpu_port, NULL); codec_ep = of_graph_get_remote_endpoint(cpu_ep); - rcpu_ep = of_graph_get_remote_endpoint(codec_ep); of_node_put(cpu_ep); of_node_put(codec_ep); - of_node_put(rcpu_ep); if (!codec_ep) continue; - if (rcpu_ep != cpu_ep) { - dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n", - cpu_ep->name, codec_ep->name, rcpu_ep->name); - ret = -EINVAL; - goto parse_of_err; - } - ret = asoc_simple_card_parse_daifmt(dev, cpu_ep, codec_ep, NULL, &daifmt); if (ret < 0) { -- 2.19.0.rc2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen 2018-11-06 4:35 [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check Kuninori Morimoto @ 2018-11-06 4:36 ` Kuninori Morimoto 2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove error check which never happen" to the asoc tree Mark Brown 2 siblings, 1 reply; 7+ messages in thread From: Kuninori Morimoto @ 2018-11-06 4:36 UTC (permalink / raw) To: Mark Brown; +Cc: Linux-ALSA From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current driver is checking situation that can not happen. This patch removes over-kill check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- sound/soc/generic/audio-graph-scu-card.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index ba7b0cf..2ba35bd 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -250,9 +250,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) of_node_put(codec_port); if (codec) { - if (!codec_port) - continue; - if (codec_port_old == codec_port) continue; @@ -308,11 +305,7 @@ static int asoc_graph_get_dais_count(struct device *dev) of_node_put(codec_ep); of_node_put(codec_port); - if (cpu_ep) - count++; - - if (!codec_port) - continue; + count++; if (codec_port_old == codec_port) continue; -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Applied "ASoC: audio-graph-scu-card: remove error check which never happen" to the asoc tree 2018-11-06 4:36 ` [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen Kuninori Morimoto @ 2018-11-06 17:53 ` Mark Brown 0 siblings, 0 replies; 7+ messages in thread From: Mark Brown @ 2018-11-06 17:53 UTC (permalink / raw) To: Kuninori Morimoto; +Cc: alsa-devel, Mark Brown The patch ASoC: audio-graph-scu-card: remove error check which never happen has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 5049a6e7316cdbf4370d5479e9628d8f5e906635 Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Date: Tue, 6 Nov 2018 04:36:55 +0000 Subject: [PATCH] ASoC: audio-graph-scu-card: remove error check which never happen Current driver is checking situation that can not happen. This patch removes over-kill check Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/generic/audio-graph-scu-card.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index ba7b0cf028b7..2ba35bdd3b38 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -250,9 +250,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) of_node_put(codec_port); if (codec) { - if (!codec_port) - continue; - if (codec_port_old == codec_port) continue; @@ -308,11 +305,7 @@ static int asoc_graph_get_dais_count(struct device *dev) of_node_put(codec_ep); of_node_put(codec_port); - if (cpu_ep) - count++; - - if (!codec_port) - continue; + count++; if (codec_port_old == codec_port) continue; -- 2.19.0.rc2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-06 17:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-11-06 4:35 [PATCH 0/3] audio-graph-card: remove endpoint bidirectional check Kuninori Morimoto 2018-11-06 4:36 ` [PATCH 1/3] ASoC: " Kuninori Morimoto 2018-11-06 17:54 ` Applied "ASoC: audio-graph-card: remove endpoint bidirectional check" to the asoc tree Mark Brown 2018-11-06 4:36 ` [PATCH 2/3] ASoC: audio-graph-scu-card: remove endpoint bidirectional check Kuninori Morimoto 2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove endpoint bidirectional check" to the asoc tree Mark Brown 2018-11-06 4:36 ` [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen Kuninori Morimoto 2018-11-06 17:53 ` Applied "ASoC: audio-graph-scu-card: remove error check which never happen" to the asoc tree Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.