[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Evgeniy Didin]

Building Qt with QtWebKit on configuration step there is
a check which disables QtWebKit build with GCC 6+.
Back in the day nobody thought about building Qt with GCC
version greater than 5.x. And now with modern GCCs like
6.x and 7.x this assumption gets in the way.

Given in Buildroot today we don't have GCC older than 4.9
it should be safe to remove now meaningless check completely
by adding patch to qt.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../qt/0014-Enable-QtWebKit-with-newer-GCC.patch   | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch

diff --git a/package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch b/package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch
new file mode 100644
index 000000000..88d3761a1
--- /dev/null
+++ b/package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch
@@ -0,0 +1,50 @@
+From f566411fb314b7e4ab01f28e25e942cfaf8c59b7 Mon Sep 17 00:00:00 2001
+From: Evgeniy Didin <didin@synopsys.com>
+Date: Fri, 15 Sep 2017 19:43:48 +0300
+Subject: [PATCH] qt: Allow enabling of QtWebKit with GCC 6+
+
+Building Qt with QtWebKit on configuration step there is
+a check which disables QtWebKit build with GCC 6+.
+Back in the day nobody thought about building Qt with GCC
+version greater than 5.x. And now with modern GCCs like
+6.x and 7.x this assumption gets in the way.
+
+Given in Buildroot today we don't have GCC older than 4.9 
+it should be safe to remove now meaningless check completely.
+
+Signed-off-by: Evgeniy Didin <didin@synopsys.com>
+Cc: Alexey Brodkin <abrodkin@synopsys.com>
+Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+
+---
+ configure | 14 --------------
+ 1 file changed, 14 deletions(-)
+
+diff --git a/configure b/configure
+index 10ad7ca0b0..8771144a65 100755
+--- a/configure
++++ b/configure
+@@ -7731,20 +7731,6 @@ case "$XPLATFORM" in
+ 	canBuildWebKit="no"
+ 	canBuildQtXmlPatterns="no"
+ 	;;
+-    *-g++*)
+-	# Check gcc's version
+-	case "$(${QMAKE_CONF_COMPILER} -dumpversion)" in
+-	    5*|4*|3.4*)
+-		;;
+-            3.3*)
+-                canBuildWebKit="no"
+-                ;;
+-	    *)
+-		canBuildWebKit="no"
+-		canBuildQtXmlPatterns="no"
+-		;;
+-	esac
+-	;;
+     solaris-cc*)
+         # Check the compiler version
+         case `${QMAKE_CONF_COMPILER} -V 2>&1 | awk '{print $4}'` in
+-- 
+2.11.0
+
-- 
2.11.0

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Thomas Petazzoni]

Hello,

On Fri, 22 Sep 2017 15:50:03 +0300, Evgeniy Didin wrote:
> Building Qt with QtWebKit on configuration step there is
> a check which disables QtWebKit build with GCC 6+.
> Back in the day nobody thought about building Qt with GCC
> version greater than 5.x. And now with modern GCCs like
> 6.x and 7.x this assumption gets in the way.
> 
> Given in Buildroot today we don't have GCC older than 4.9
> it should be safe to remove now meaningless check completely
> by adding patch to qt.
> 
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  .../qt/0014-Enable-QtWebKit-with-newer-GCC.patch   | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Peter Korsgaard]

>>>>> "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:

 > Building Qt with QtWebKit on configuration step there is
 > a check which disables QtWebKit build with GCC 6+.
 > Back in the day nobody thought about building Qt with GCC
 > version greater than 5.x. And now with modern GCCs like
 > 6.x and 7.x this assumption gets in the way.

 > Given in Buildroot today we don't have GCC older than 4.9
 > it should be safe to remove now meaningless check completely
 > by adding patch to qt.

 > Signed-off-by: Evgeniy Didin <didin@synopsys.com>
 > Cc: Alexey Brodkin <abrodkin@synopsys.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Peter Korsgaard]

>>>>> "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:

 > Building Qt with QtWebKit on configuration step there is
 > a check which disables QtWebKit build with GCC 6+.
 > Back in the day nobody thought about building Qt with GCC
 > version greater than 5.x. And now with modern GCCs like
 > 6.x and 7.x this assumption gets in the way.

 > Given in Buildroot today we don't have GCC older than 4.9
 > it should be safe to remove now meaningless check completely
 > by adding patch to qt.

 > Signed-off-by: Evgeniy Didin <didin@synopsys.com>
 > Cc: Alexey Brodkin <abrodkin@synopsys.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Alexey Brodkin]

Hi Peter, Thomas,

> -----Original Message-----
> From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
> Sent: Tuesday, October 17, 2017 12:02 PM
> To: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
> Cc: buildroot at busybox.net; Thomas Petazzoni <thomas.petazzoni@free-electrons.com>; Alexey Brodkin
> <Alexey.Brodkin@synopsys.com>
> Subject: Re: [PATCH] qt: Allow enabling of QtWebKit with GCC 6+
> 
> >>>>> "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:
> 
>  > Building Qt with QtWebKit on configuration step there is
>  > a check which disables QtWebKit build with GCC 6+.
>  > Back in the day nobody thought about building Qt with GCC
>  > version greater than 5.x. And now with modern GCCs like
>  > 6.x and 7.x this assumption gets in the way.
> 
>  > Given in Buildroot today we don't have GCC older than 4.9
>  > it should be safe to remove now meaningless check completely
>  > by adding patch to qt.
> 
>  > Signed-off-by: Evgeniy Didin <didin@synopsys.com>
>  > Cc: Alexey Brodkin <abrodkin@synopsys.com>
>  > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Committed to 2017.08.x, thanks.

I see that commit was applied on 2 "LTS" branches already which is definitely good.
But my question is are there any formal rules and guidelines for patches to be
cherry-picked onto LTS branches? Something like https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst?

Probably I just missed that as usual :)

-Alexey

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Peter Korsgaard]

>>>>> "Alexey" == Alexey Brodkin <Alexey.Brodkin@synopsys.com> writes:

Hi,

 >> Committed to 2017.08.x, thanks.

 > I see that commit was applied on 2 "LTS" branches already which is definitely good.
 > But my question is are there any formal rules and guidelines for patches to be
 > cherry-picked onto LTS branches? Something like
 > https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst?

As discussed during the dev days, we don't really have any format
rules. If you think specific patches should be backported, please let me
know.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Evgeniy Didin]

Building Qt with QtWebKit on configuration step there is
a check which disables QtWebKit build with GCC 6+.
Back in the day nobody thought about building Qt with GCC
version greater than 5.x. And now with modern GCCs like
6.x and 7.x this assumption gets in the way.

Given in Buildroot today we don't have GCC older than 4.9 
it should be safe to remove now meaningless check completely.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 

---
 configure | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/configure b/configure
index 10ad7ca0b0..8771144a65 100755
--- a/configure
+++ b/configure
@@ -7731,20 +7731,6 @@ case "$XPLATFORM" in
 	canBuildWebKit="no"
 	canBuildQtXmlPatterns="no"
 	;;
-    *-g++*)
-	# Check gcc's version
-	case "$(${QMAKE_CONF_COMPILER} -dumpversion)" in
-	    5*|4*|3.4*)
-		;;
-            3.3*)
-                canBuildWebKit="no"
-                ;;
-	    *)
-		canBuildWebKit="no"
-		canBuildQtXmlPatterns="no"
-		;;
-	esac
-	;;
     solaris-cc*)
         # Check the compiler version
         case `${QMAKE_CONF_COMPILER} -V 2>&1 | awk '{print $4}'` in
-- 
2.11.0

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Thomas Petazzoni]

Hello,

On Tue, 19 Sep 2017 12:14:44 +0300, Evgeniy Didin wrote:
> Building Qt with QtWebKit on configuration step there is
> a check which disables QtWebKit build with GCC 6+.
> Back in the day nobody thought about building Qt with GCC
> version greater than 5.x. And now with modern GCCs like
> 6.x and 7.x this assumption gets in the way.
> 
> Given in Buildroot today we don't have GCC older than 4.9 
> it should be safe to remove now meaningless check completely.
> 
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 
> 
> ---
>  configure | 14 --------------
>  1 file changed, 14 deletions(-)

I am not sure what you expect us to do with this patch: indeed it is
not a Buildroot patch as Buildroot does not have a configure script.

Perhaps you wanted instead to do a patch that adds a patch in
package/qt/ instead ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] qt: Allow enabling of QtWebKit with GCC 6+

[Arnout Vandecappelle]

 Hi Evgeniy,

 In addition to Thomas's comment:

On 19-09-17 11:14, Evgeniy Didin wrote:
> Building Qt with QtWebKit on configuration step there is
> a check which disables QtWebKit build with GCC 6+.
> Back in the day nobody thought about building Qt with GCC
> version greater than 5.x. And now with modern GCCs like
> 6.x and 7.x this assumption gets in the way.
> 
> Given in Buildroot today we don't have GCC older than 4.9 
> it should be safe to remove now meaningless check completely.

 We actually support GCC down to 4.3 in external toolchains. But the check is
only for 3.3 or older, so still OK.

 Regards,
 Arnout
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF