All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] configure: Require Python 2.6
@ 2015-09-04 19:53 Markus Armbruster
  2015-09-04 22:44 ` Peter Maydell
  2015-09-07  8:50 ` Daniel P. Berrange
  0 siblings, 2 replies; 10+ messages in thread
From: Markus Armbruster @ 2015-09-04 19:53 UTC (permalink / raw)
  To: qemu-devel; +Cc: pbonzini, peter.maydell

RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
to 10.6.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 configure | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/configure b/configure
index 21c4089..bce1769 100755
--- a/configure
+++ b/configure
@@ -1157,18 +1157,14 @@ fi
 
 # Note that if the Python conditional here evaluates True we will exit
 # with status 1 which is a shell 'false' value.
-if ! $python -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_info >= (3,))'; then
-  error_exit "Cannot use '$python', Python 2.4 or later is required." \
+if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6) or sys.version_info >= (3,))'; then
+  error_exit "Cannot use '$python', Python 2.6 or later is required." \
       "Note that Python 3 or later is not yet supported." \
       "Use --python=/path/to/python to specify a supported Python."
 fi
 
-# The -B switch was added in Python 2.6.
-# If it is supplied, compiled files are not written.
-# Use it for Python versions which support it.
-if $python -B -c 'import sys; sys.exit(0)' 2>/dev/null; then
-  python="$python -B"
-fi
+# Suppress writing compiled files
+python="$python -B"
 
 case "$cpu" in
     ppc)
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-04 19:53 [Qemu-devel] [PATCH] configure: Require Python 2.6 Markus Armbruster
@ 2015-09-04 22:44 ` Peter Maydell
  2015-09-07  8:49   ` Daniel P. Berrange
  2015-09-29 21:35   ` Eric Blake
  2015-09-07  8:50 ` Daniel P. Berrange
  1 sibling, 2 replies; 10+ messages in thread
From: Peter Maydell @ 2015-09-04 22:44 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: QEMU Developers, Paolo Bonzini

On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
> to 10.6.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I wonder if we're ever going to need to add that Python 3
support the error message alludes to :-)

thanks
-- PMM

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-04 22:44 ` Peter Maydell
@ 2015-09-07  8:49   ` Daniel P. Berrange
  2015-09-09 17:39     ` Steve Ellcey 
  2015-09-29 21:35   ` Eric Blake
  1 sibling, 1 reply; 10+ messages in thread
From: Daniel P. Berrange @ 2015-09-07  8:49 UTC (permalink / raw)
  To: Peter Maydell; +Cc: Paolo Bonzini, Markus Armbruster, QEMU Developers

On Fri, Sep 04, 2015 at 11:44:17PM +0100, Peter Maydell wrote:
> On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
> > RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
> > to 10.6.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> I wonder if we're ever going to need to add that Python 3
> support the error message alludes to :-)

Possibly, but for that to be practical, we'd really need to make Python 2.7
be the min version, so Py3 is probably a good way off in the future yet.
There's no risk of Py2 dieing out any time soon so no rush :-)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-04 19:53 [Qemu-devel] [PATCH] configure: Require Python 2.6 Markus Armbruster
  2015-09-04 22:44 ` Peter Maydell
@ 2015-09-07  8:50 ` Daniel P. Berrange
  1 sibling, 0 replies; 10+ messages in thread
From: Daniel P. Berrange @ 2015-09-07  8:50 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: peter.maydell, qemu-devel, pbonzini

On Fri, Sep 04, 2015 at 09:53:03PM +0200, Markus Armbruster wrote:
> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
> to 10.6.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-07  8:49   ` Daniel P. Berrange
@ 2015-09-09 17:39     ` Steve Ellcey 
  2015-09-09 17:43       ` Peter Maydell
  0 siblings, 1 reply; 10+ messages in thread
From: Steve Ellcey  @ 2015-09-09 17:39 UTC (permalink / raw)
  To: peter.maydell, berrange; +Cc: pbonzini, qemu-devel, armbru


"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Fri, Sep 04, 2015 at 11:44:17PM +0100, Peter Maydell wrote:
> > On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
> > > RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
> > > to 10.6.

I am actually building qemu on CentOS 5.11 with Python 2.4.3.  I can probably
install Python 2.6 on the system if necessary to build.  Is the Python
requirement just a build requirement or is it (libraries?) also needed on the
machine where Qemu is run?

We actually ran into this already with libgmodule where the CentOS 5.11
version was too old.  We installed archive only libgmodule libraries so
that we could build qemu on CentOS 5.11 using the archive libgmodule library
and then users could run Qemu on different Centos 5.11 systems without having
to install a newer libgmodule on their system.

Steve Ellcey
sellcey@imgtec.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-09 17:39     ` Steve Ellcey 
@ 2015-09-09 17:43       ` Peter Maydell
  0 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2015-09-09 17:43 UTC (permalink / raw)
  To: Steve Ellcey; +Cc: Paolo Bonzini, QEMU Developers, Markus Armbruster

On 9 September 2015 at 18:39, Steve Ellcey <sellcey@imgtec.com> wrote:
>
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
>
>> On Fri, Sep 04, 2015 at 11:44:17PM +0100, Peter Maydell wrote:
>> > On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
>> > > RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
>> > > to 10.6.
>
> I am actually building qemu on CentOS 5.11 with Python 2.4.3.  I can probably
> install Python 2.6 on the system if necessary to build.  Is the Python
> requirement just a build requirement or is it (libraries?) also needed on the
> machine where Qemu is run?

Python should just be a build-time requirement.

> We actually ran into this already with libgmodule where the CentOS 5.11
> version was too old.  We installed archive only libgmodule libraries so
> that we could build qemu on CentOS 5.11 using the archive libgmodule library
> and then users could run Qemu on different Centos 5.11 systems without having
> to install a newer libgmodule on their system.

Yes, I'm afraid that Centos 5 and RHEL 5 are no longer on our list
of supported host OSes (support was dropped for QEMU 2.4). So you're
likely to find that you need to provide updated local versions of
various libraries/tools/etc.

thanks
-- PMM

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-04 22:44 ` Peter Maydell
  2015-09-07  8:49   ` Daniel P. Berrange
@ 2015-09-29 21:35   ` Eric Blake
  2015-09-29 22:25     ` Peter Maydell
  2015-10-01  5:32     ` Markus Armbruster
  1 sibling, 2 replies; 10+ messages in thread
From: Eric Blake @ 2015-09-29 21:35 UTC (permalink / raw)
  To: Peter Maydell, Markus Armbruster; +Cc: Paolo Bonzini, QEMU Developers

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

ping

On 09/04/2015 04:44 PM, Peter Maydell wrote:
> On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
>> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
>> to 10.6.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> I wonder if we're ever going to need to add that Python 3
> support the error message alludes to :-)

Which tree will this be going through? I found myself interested in
using python's:

first_expr if cond else second_expr

ternary, until I realized it requires python 2.5 or greater and we
haven't yet flipped the switch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-29 21:35   ` Eric Blake
@ 2015-09-29 22:25     ` Peter Maydell
  2015-10-01 11:06       ` Paolo Bonzini
  2015-10-01  5:32     ` Markus Armbruster
  1 sibling, 1 reply; 10+ messages in thread
From: Peter Maydell @ 2015-09-29 22:25 UTC (permalink / raw)
  To: Eric Blake; +Cc: Paolo Bonzini, Markus Armbruster, QEMU Developers

On 29 September 2015 at 22:35, Eric Blake <eblake@redhat.com> wrote:
> ping
>
> On 09/04/2015 04:44 PM, Peter Maydell wrote:
>> On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
>>> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
>>> to 10.6.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> I wonder if we're ever going to need to add that Python 3
>> support the error message alludes to :-)
>
> Which tree will this be going through?

Random buildsystem stuff usually gets picked up by Paolo.

-- PMM

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-29 21:35   ` Eric Blake
  2015-09-29 22:25     ` Peter Maydell
@ 2015-10-01  5:32     ` Markus Armbruster
  1 sibling, 0 replies; 10+ messages in thread
From: Markus Armbruster @ 2015-10-01  5:32 UTC (permalink / raw)
  To: Eric Blake; +Cc: Peter Maydell, QEMU Developers, Paolo Bonzini

Eric Blake <eblake@redhat.com> writes:

> ping
>
> On 09/04/2015 04:44 PM, Peter Maydell wrote:
>> On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
>>> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
>>> to 10.6.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> 
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>> 
>> I wonder if we're ever going to need to add that Python 3
>> support the error message alludes to :-)
>
> Which tree will this be going through? I found myself interested in
> using python's:
>
> first_expr if cond else second_expr
>
> ternary, until I realized it requires python 2.5 or greater and we
> haven't yet flipped the switch.

Go ahead and depend on it in your QAPI work, just mention it in the
cover letter.  If it isn't in master by the time I request a pull, I'll
stick it in before your series.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Require Python 2.6
  2015-09-29 22:25     ` Peter Maydell
@ 2015-10-01 11:06       ` Paolo Bonzini
  0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2015-10-01 11:06 UTC (permalink / raw)
  To: Peter Maydell, Eric Blake; +Cc: Markus Armbruster, QEMU Developers



On 30/09/2015 00:25, Peter Maydell wrote:
> On 29 September 2015 at 22:35, Eric Blake <eblake@redhat.com> wrote:
>> ping
>>
>> On 09/04/2015 04:44 PM, Peter Maydell wrote:
>>> On 4 September 2015 at 20:53, Markus Armbruster <armbru@redhat.com> wrote:
>>>> RHEL-6 and SLES-11 provide Python 2.6.  It'll also work on OS X back
>>>> to 10.6.
>>>>
>>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>
>>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>>
>>> I wonder if we're ever going to need to add that Python 3
>>> support the error message alludes to :-)
>>
>> Which tree will this be going through?
> 
> Random buildsystem stuff usually gets picked up by Paolo.

I've queued it but I'm a bit busy, so I'm not going to send the next
pull request until I've managed to test the record-replay stuff.  Anyone
can feel free to pick up this patch or others.

Paolo

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2015-10-01 11:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-04 19:53 [Qemu-devel] [PATCH] configure: Require Python 2.6 Markus Armbruster
2015-09-04 22:44 ` Peter Maydell
2015-09-07  8:49   ` Daniel P. Berrange
2015-09-09 17:39     ` Steve Ellcey 
2015-09-09 17:43       ` Peter Maydell
2015-09-29 21:35   ` Eric Blake
2015-09-29 22:25     ` Peter Maydell
2015-10-01 11:06       ` Paolo Bonzini
2015-10-01  5:32     ` Markus Armbruster
2015-09-07  8:50 ` Daniel P. Berrange

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.