* [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
@ 2015-05-05 9:46 Sonika Jindal
2015-05-05 11:39 ` Jani Nikula
2015-05-05 16:52 ` shuang.he
0 siblings, 2 replies; 13+ messages in thread
From: Sonika Jindal @ 2015-05-05 9:46 UTC (permalink / raw)
To: intel-gfx
This provides an option to override the value set by VBT
for selecting edp Vswing Pre-emph setting table.
https://bugs.freedesktop.org/show_bug.cgi?id=89554
Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
drivers/gpu/drm/i915/i915_params.c | 7 +++++++
drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_dp.c | 2 +-
5 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 136d42a..1c3ee66 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1364,7 +1364,6 @@ struct intel_vbt_data {
bool edp_initialized;
bool edp_support;
int edp_bpp;
- bool edp_low_vswing;
struct edp_power_seq edp_pps;
struct {
@@ -1846,6 +1845,8 @@ struct drm_i915_private {
void (*stop_ring)(struct intel_engine_cs *ring);
} gt;
+ bool edp_low_vswing;
+
/*
* NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
* will be rejected. Instead look for a better place.
@@ -2515,6 +2516,7 @@ struct i915_params {
int mmio_debug;
bool verbose_state_checks;
bool nuclear_pageflip;
+ int edp_vswing;
};
extern struct i915_params i915 __read_mostly;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index bb64415..d245ac5 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
.mmio_debug = 0,
.verbose_state_checks = 1,
.nuclear_pageflip = 0,
+ .edp_vswing = 0,
};
module_param_named(modeset, i915.modeset, int, 0400);
@@ -184,3 +185,9 @@ MODULE_PARM_DESC(verbose_state_checks,
module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
MODULE_PARM_DESC(nuclear_pageflip,
"Force atomic modeset functionality; only planes work for now (default: false).");
+
+module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0600);
+MODULE_PARM_DESC(edp_vswing,
+ "Ignore/Override vswing pre-emph table selection from VBT "
+ "(0=use value from vbt [default], 1=low power swing(200mV),"
+ "2=default swing(400mV))");
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index c08368c..cee596d 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
if (bdb->version >= 173) {
uint8_t vswing;
- vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
- dev_priv->vbt.edp_low_vswing = vswing == 0;
+ /* Don't read from VBT if module parameter has valid value*/
+ if (i915.edp_vswing) {
+ dev_priv->edp_low_vswing = i915.edp_vswing == 1;
+ } else {
+ vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
+ dev_priv->edp_low_vswing = vswing == 0;
+ }
}
}
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 9c1e74a..2539f22 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
ddi_translations_fdi = NULL;
ddi_translations_dp = skl_ddi_translations_dp;
n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
- if (dev_priv->vbt.edp_low_vswing) {
+ if (dev_priv->edp_low_vswing) {
ddi_translations_edp = skl_ddi_translations_edp;
n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
} else {
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index bacdec5..5f53666 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
if (IS_BROXTON(dev))
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
else if (INTEL_INFO(dev)->gen >= 9) {
- if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
+ if (dev_priv->edp_low_vswing && port == PORT_A)
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
} else if (IS_VALLEYVIEW(dev))
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-05 9:46 [PATCH] drm/i915/skl: Add module parameter to select edp vswing table Sonika Jindal
@ 2015-05-05 11:39 ` Jani Nikula
2015-05-05 13:00 ` Damien Lespiau
2015-05-05 16:52 ` shuang.he
1 sibling, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2015-05-05 11:39 UTC (permalink / raw)
To: Sonika Jindal, intel-gfx
On Tue, 05 May 2015, Sonika Jindal <sonika.jindal@intel.com> wrote:
> This provides an option to override the value set by VBT
> for selecting edp Vswing Pre-emph setting table.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=89554
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> drivers/gpu/drm/i915/i915_params.c | 7 +++++++
> drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 5 files changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 136d42a..1c3ee66 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1364,7 +1364,6 @@ struct intel_vbt_data {
> bool edp_initialized;
> bool edp_support;
> int edp_bpp;
> - bool edp_low_vswing;
> struct edp_power_seq edp_pps;
>
> struct {
> @@ -1846,6 +1845,8 @@ struct drm_i915_private {
> void (*stop_ring)(struct intel_engine_cs *ring);
> } gt;
>
> + bool edp_low_vswing;
> +
> /*
> * NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
> * will be rejected. Instead look for a better place.
> @@ -2515,6 +2516,7 @@ struct i915_params {
> int mmio_debug;
> bool verbose_state_checks;
> bool nuclear_pageflip;
> + int edp_vswing;
> };
> extern struct i915_params i915 __read_mostly;
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index bb64415..d245ac5 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
> .mmio_debug = 0,
> .verbose_state_checks = 1,
> .nuclear_pageflip = 0,
> + .edp_vswing = 0,
> };
>
> module_param_named(modeset, i915.modeset, int, 0400);
> @@ -184,3 +185,9 @@ MODULE_PARM_DESC(verbose_state_checks,
> module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
> MODULE_PARM_DESC(nuclear_pageflip,
> "Force atomic modeset functionality; only planes work for now (default: false).");
> +
> +module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0600);
> +MODULE_PARM_DESC(edp_vswing,
> + "Ignore/Override vswing pre-emph table selection from VBT "
> + "(0=use value from vbt [default], 1=low power swing(200mV),"
> + "2=default swing(400mV))");
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index c08368c..cee596d 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
> if (bdb->version >= 173) {
> uint8_t vswing;
>
> - vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> - dev_priv->vbt.edp_low_vswing = vswing == 0;
> + /* Don't read from VBT if module parameter has valid value*/
> + if (i915.edp_vswing) {
> + dev_priv->edp_low_vswing = i915.edp_vswing == 1;
> + } else {
> + vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> + dev_priv->edp_low_vswing = vswing == 0;
> + }
Please keep dev_priv->vbt.edp_low_vswing as it is, and check the module
parameter where that is used. If we're adding a module parameter, it
will be immensely useful to be able to change the value at runtime to
check if it makes a difference. What you suggest requires a module
reload.
There's still the question whether we can default to using the vbt value
if that can be broken...
BR,
Jani.
> }
> }
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 9c1e74a..2539f22 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
> ddi_translations_fdi = NULL;
> ddi_translations_dp = skl_ddi_translations_dp;
> n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
> - if (dev_priv->vbt.edp_low_vswing) {
> + if (dev_priv->edp_low_vswing) {
> ddi_translations_edp = skl_ddi_translations_edp;
> n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
> } else {
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index bacdec5..5f53666 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
> if (IS_BROXTON(dev))
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> else if (INTEL_INFO(dev)->gen >= 9) {
> - if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
> + if (dev_priv->edp_low_vswing && port == PORT_A)
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
> } else if (IS_VALLEYVIEW(dev))
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-05 11:39 ` Jani Nikula
@ 2015-05-05 13:00 ` Damien Lespiau
2015-05-05 13:58 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Damien Lespiau @ 2015-05-05 13:00 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote:
> There's still the question whether we can default to using the vbt value
> if that can be broken...
This is a workaround for SDPs loaded with a "default" VBT which doesn't
correspond to the full fleet of SPDs. For actual product, it's really
expected to have a VBT with a correct low vswing bit set, otherwise the
panel won't lit up (even on Windows!).
It's probably a good idea to add a comment saying that's it's a
workaround for early platform with generic-ish VBT. Something that we
should remove in a bit.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-05 13:00 ` Damien Lespiau
@ 2015-05-05 13:58 ` Jani Nikula
2015-05-06 5:43 ` Jindal, Sonika
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2015-05-05 13:58 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Tue, 05 May 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote:
>> There's still the question whether we can default to using the vbt value
>> if that can be broken...
>
> This is a workaround for SDPs loaded with a "default" VBT which doesn't
> correspond to the full fleet of SPDs. For actual product, it's really
> expected to have a VBT with a correct low vswing bit set, otherwise the
> panel won't lit up (even on Windows!).
>
> It's probably a good idea to add a comment saying that's it's a
> workaround for early platform with generic-ish VBT. Something that we
> should remove in a bit.
Thanks for the clarification, Damien. That settles the default then. I'd
still like the module parameter to be effective even if changed runtime.
BR,
Jani.
>
> --
> Damien
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-05 9:46 [PATCH] drm/i915/skl: Add module parameter to select edp vswing table Sonika Jindal
2015-05-05 11:39 ` Jani Nikula
@ 2015-05-05 16:52 ` shuang.he
1 sibling, 0 replies; 13+ messages in thread
From: shuang.he @ 2015-05-05 16:52 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, sonika.jindal
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6319
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK 302/302 302/302
SNB 316/316 316/316
IVB 342/342 342/342
BYT 286/286 286/286
BDW 318/318 318/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-05 13:58 ` Jani Nikula
@ 2015-05-06 5:43 ` Jindal, Sonika
2015-05-06 6:57 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Jindal, Sonika @ 2015-05-06 5:43 UTC (permalink / raw)
To: Jani Nikula, Damien Lespiau; +Cc: intel-gfx
On 5/5/2015 7:28 PM, Jani Nikula wrote:
> On Tue, 05 May 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
>> On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote:
>>> There's still the question whether we can default to using the vbt value
>>> if that can be broken...
>>
>> This is a workaround for SDPs loaded with a "default" VBT which doesn't
>> correspond to the full fleet of SPDs. For actual product, it's really
>> expected to have a VBT with a correct low vswing bit set, otherwise the
>> panel won't lit up (even on Windows!).
>>
>> It's probably a good idea to add a comment saying that's it's a
>> workaround for early platform with generic-ish VBT. Something that we
>> should remove in a bit.
>
> Thanks for the clarification, Damien. That settles the default then. I'd
> still like the module parameter to be effective even if changed runtime.
>
This is used while preparing ddi buffers to program ddi_buf_trans during
driver load. It will not really have any effect at runtime until power
well is disabled/re-enabled.
PLease let me know if you still see the need of moving the check
directly in prepare_ddi_buffers.
Regards,
Sonika
> BR,
> Jani.
>
>
>
>>
>> --
>> Damien
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 5:43 ` Jindal, Sonika
@ 2015-05-06 6:57 ` Jani Nikula
2015-05-06 10:13 ` Sonika Jindal
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2015-05-06 6:57 UTC (permalink / raw)
To: Jindal, Sonika, Damien Lespiau; +Cc: intel-gfx
On Wed, 06 May 2015, "Jindal, Sonika" <sonika.jindal@intel.com> wrote:
> On 5/5/2015 7:28 PM, Jani Nikula wrote:
>> On Tue, 05 May 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
>>> On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote:
>>>> There's still the question whether we can default to using the vbt value
>>>> if that can be broken...
>>>
>>> This is a workaround for SDPs loaded with a "default" VBT which doesn't
>>> correspond to the full fleet of SPDs. For actual product, it's really
>>> expected to have a VBT with a correct low vswing bit set, otherwise the
>>> panel won't lit up (even on Windows!).
>>>
>>> It's probably a good idea to add a comment saying that's it's a
>>> workaround for early platform with generic-ish VBT. Something that we
>>> should remove in a bit.
>>
>> Thanks for the clarification, Damien. That settles the default then. I'd
>> still like the module parameter to be effective even if changed runtime.
>>
> This is used while preparing ddi buffers to program ddi_buf_trans during
> driver load. It will not really have any effect at runtime until power
> well is disabled/re-enabled.
Right, missed that part, sorry.
> PLease let me know if you still see the need of moving the check
> directly in prepare_ddi_buffers.
No, it would be confusing. And I guess we'll remove this parameter
afterwards anyway?
Please just change the module parameter permissions to read only, so
it's not possible to change it dynamically via sysfs.
BR,
Jani.
>
> Regards,
> Sonika
>> BR,
>> Jani.
>>
>>
>>
>>>
>>> --
>>> Damien
>>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 6:57 ` Jani Nikula
@ 2015-05-06 10:13 ` Sonika Jindal
2015-05-06 10:28 ` Jani Nikula
2015-05-07 9:15 ` shuang.he
0 siblings, 2 replies; 13+ messages in thread
From: Sonika Jindal @ 2015-05-06 10:13 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
This provides an option to override the value set by VBT
for selecting edp Vswing Pre-emph setting table.
v2: Adding comment about this being a temporary workaround and
making the parameter read-only (Jani)
https://bugs.freedesktop.org/show_bug.cgi?id=89554
Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
drivers/gpu/drm/i915/i915_params.c | 8 ++++++++
drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_dp.c | 2 +-
5 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 136d42a..1c3ee66 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1364,7 +1364,6 @@ struct intel_vbt_data {
bool edp_initialized;
bool edp_support;
int edp_bpp;
- bool edp_low_vswing;
struct edp_power_seq edp_pps;
struct {
@@ -1846,6 +1845,8 @@ struct drm_i915_private {
void (*stop_ring)(struct intel_engine_cs *ring);
} gt;
+ bool edp_low_vswing;
+
/*
* NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
* will be rejected. Instead look for a better place.
@@ -2515,6 +2516,7 @@ struct i915_params {
int mmio_debug;
bool verbose_state_checks;
bool nuclear_pageflip;
+ int edp_vswing;
};
extern struct i915_params i915 __read_mostly;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index bb64415..e32d3ca 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
.mmio_debug = 0,
.verbose_state_checks = 1,
.nuclear_pageflip = 0,
+ .edp_vswing = 0,
};
module_param_named(modeset, i915.modeset, int, 0400);
@@ -184,3 +185,10 @@ MODULE_PARM_DESC(verbose_state_checks,
module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
MODULE_PARM_DESC(nuclear_pageflip,
"Force atomic modeset functionality; only planes work for now (default: false).");
+
+/* WA to get away with the default setting in VBT for early platforms.Will be removed */
+module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0);
+MODULE_PARM_DESC(edp_vswing,
+ "Ignore/Override vswing pre-emph table selection from VBT "
+ "(0=use value from vbt [default], 1=low power swing(200mV),"
+ "2=default swing(400mV))");
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index c08368c..cee596d 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
if (bdb->version >= 173) {
uint8_t vswing;
- vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
- dev_priv->vbt.edp_low_vswing = vswing == 0;
+ /* Don't read from VBT if module parameter has valid value*/
+ if (i915.edp_vswing) {
+ dev_priv->edp_low_vswing = i915.edp_vswing == 1;
+ } else {
+ vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
+ dev_priv->edp_low_vswing = vswing == 0;
+ }
}
}
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 9c1e74a..2539f22 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
ddi_translations_fdi = NULL;
ddi_translations_dp = skl_ddi_translations_dp;
n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
- if (dev_priv->vbt.edp_low_vswing) {
+ if (dev_priv->edp_low_vswing) {
ddi_translations_edp = skl_ddi_translations_edp;
n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
} else {
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index bacdec5..5f53666 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
if (IS_BROXTON(dev))
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
else if (INTEL_INFO(dev)->gen >= 9) {
- if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
+ if (dev_priv->edp_low_vswing && port == PORT_A)
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
} else if (IS_VALLEYVIEW(dev))
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 10:13 ` Sonika Jindal
@ 2015-05-06 10:28 ` Jani Nikula
2015-05-06 12:05 ` Sonika Jindal
2015-05-07 9:15 ` shuang.he
1 sibling, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2015-05-06 10:28 UTC (permalink / raw)
To: Sonika Jindal, intel-gfx
On Wed, 06 May 2015, Sonika Jindal <sonika.jindal@intel.com> wrote:
> This provides an option to override the value set by VBT
> for selecting edp Vswing Pre-emph setting table.
>
> v2: Adding comment about this being a temporary workaround and
> making the parameter read-only (Jani)
>
> https://bugs.freedesktop.org/show_bug.cgi?id=89554
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> drivers/gpu/drm/i915/i915_params.c | 8 ++++++++
> drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 5 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 136d42a..1c3ee66 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1364,7 +1364,6 @@ struct intel_vbt_data {
> bool edp_initialized;
> bool edp_support;
> int edp_bpp;
> - bool edp_low_vswing;
> struct edp_power_seq edp_pps;
>
> struct {
> @@ -1846,6 +1845,8 @@ struct drm_i915_private {
> void (*stop_ring)(struct intel_engine_cs *ring);
> } gt;
>
> + bool edp_low_vswing;
> +
> /*
> * NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
> * will be rejected. Instead look for a better place.
> @@ -2515,6 +2516,7 @@ struct i915_params {
> int mmio_debug;
> bool verbose_state_checks;
> bool nuclear_pageflip;
> + int edp_vswing;
> };
> extern struct i915_params i915 __read_mostly;
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index bb64415..e32d3ca 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
> .mmio_debug = 0,
> .verbose_state_checks = 1,
> .nuclear_pageflip = 0,
> + .edp_vswing = 0,
> };
>
> module_param_named(modeset, i915.modeset, int, 0400);
> @@ -184,3 +185,10 @@ MODULE_PARM_DESC(verbose_state_checks,
> module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
> MODULE_PARM_DESC(nuclear_pageflip,
> "Force atomic modeset functionality; only planes work for now (default: false).");
> +
> +/* WA to get away with the default setting in VBT for early platforms.Will be removed */
> +module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0);
The mode should be 0400 like in i915.modeset in the context above.
Otherwise LGTM.
Jani.
> +MODULE_PARM_DESC(edp_vswing,
> + "Ignore/Override vswing pre-emph table selection from VBT "
> + "(0=use value from vbt [default], 1=low power swing(200mV),"
> + "2=default swing(400mV))");
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index c08368c..cee596d 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
> if (bdb->version >= 173) {
> uint8_t vswing;
>
> - vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> - dev_priv->vbt.edp_low_vswing = vswing == 0;
> + /* Don't read from VBT if module parameter has valid value*/
> + if (i915.edp_vswing) {
> + dev_priv->edp_low_vswing = i915.edp_vswing == 1;
> + } else {
> + vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> + dev_priv->edp_low_vswing = vswing == 0;
> + }
> }
> }
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 9c1e74a..2539f22 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
> ddi_translations_fdi = NULL;
> ddi_translations_dp = skl_ddi_translations_dp;
> n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
> - if (dev_priv->vbt.edp_low_vswing) {
> + if (dev_priv->edp_low_vswing) {
> ddi_translations_edp = skl_ddi_translations_edp;
> n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
> } else {
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index bacdec5..5f53666 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
> if (IS_BROXTON(dev))
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> else if (INTEL_INFO(dev)->gen >= 9) {
> - if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
> + if (dev_priv->edp_low_vswing && port == PORT_A)
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
> } else if (IS_VALLEYVIEW(dev))
> --
> 1.7.10.4
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 10:28 ` Jani Nikula
@ 2015-05-06 12:05 ` Sonika Jindal
2015-05-06 14:09 ` Daniel Vetter
2015-05-07 12:27 ` shuang.he
0 siblings, 2 replies; 13+ messages in thread
From: Sonika Jindal @ 2015-05-06 12:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
This provides an option to override the value set by VBT
for selecting edp Vswing Pre-emph setting table.
v2: Adding comment about this being a temporary workaround and
making the parameter read-only (Jani)
v3: Changing mode to 0400 instead of 0 (Jani)
https://bugs.freedesktop.org/show_bug.cgi?id=89554
Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
drivers/gpu/drm/i915/i915_params.c | 8 ++++++++
drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_dp.c | 2 +-
5 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 136d42a..1c3ee66 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1364,7 +1364,6 @@ struct intel_vbt_data {
bool edp_initialized;
bool edp_support;
int edp_bpp;
- bool edp_low_vswing;
struct edp_power_seq edp_pps;
struct {
@@ -1846,6 +1845,8 @@ struct drm_i915_private {
void (*stop_ring)(struct intel_engine_cs *ring);
} gt;
+ bool edp_low_vswing;
+
/*
* NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
* will be rejected. Instead look for a better place.
@@ -2515,6 +2516,7 @@ struct i915_params {
int mmio_debug;
bool verbose_state_checks;
bool nuclear_pageflip;
+ int edp_vswing;
};
extern struct i915_params i915 __read_mostly;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index bb64415..8ac5a1b 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
.mmio_debug = 0,
.verbose_state_checks = 1,
.nuclear_pageflip = 0,
+ .edp_vswing = 0,
};
module_param_named(modeset, i915.modeset, int, 0400);
@@ -184,3 +185,10 @@ MODULE_PARM_DESC(verbose_state_checks,
module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
MODULE_PARM_DESC(nuclear_pageflip,
"Force atomic modeset functionality; only planes work for now (default: false).");
+
+/* WA to get away with the default setting in VBT for early platforms.Will be removed */
+module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0400);
+MODULE_PARM_DESC(edp_vswing,
+ "Ignore/Override vswing pre-emph table selection from VBT "
+ "(0=use value from vbt [default], 1=low power swing(200mV),"
+ "2=default swing(400mV))");
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index c08368c..cee596d 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
if (bdb->version >= 173) {
uint8_t vswing;
- vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
- dev_priv->vbt.edp_low_vswing = vswing == 0;
+ /* Don't read from VBT if module parameter has valid value*/
+ if (i915.edp_vswing) {
+ dev_priv->edp_low_vswing = i915.edp_vswing == 1;
+ } else {
+ vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
+ dev_priv->edp_low_vswing = vswing == 0;
+ }
}
}
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 9c1e74a..2539f22 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
ddi_translations_fdi = NULL;
ddi_translations_dp = skl_ddi_translations_dp;
n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
- if (dev_priv->vbt.edp_low_vswing) {
+ if (dev_priv->edp_low_vswing) {
ddi_translations_edp = skl_ddi_translations_edp;
n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
} else {
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index bacdec5..5f53666 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
if (IS_BROXTON(dev))
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
else if (INTEL_INFO(dev)->gen >= 9) {
- if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
+ if (dev_priv->edp_low_vswing && port == PORT_A)
return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
} else if (IS_VALLEYVIEW(dev))
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 12:05 ` Sonika Jindal
@ 2015-05-06 14:09 ` Daniel Vetter
2015-05-07 12:27 ` shuang.he
1 sibling, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2015-05-06 14:09 UTC (permalink / raw)
To: Sonika Jindal; +Cc: jani.nikula, intel-gfx
On Wed, May 06, 2015 at 05:35:48PM +0530, Sonika Jindal wrote:
> This provides an option to override the value set by VBT
> for selecting edp Vswing Pre-emph setting table.
>
> v2: Adding comment about this being a temporary workaround and
> making the parameter read-only (Jani)
> v3: Changing mode to 0400 instead of 0 (Jani)
>
> https://bugs.freedesktop.org/show_bug.cgi?id=89554
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> drivers/gpu/drm/i915/i915_params.c | 8 ++++++++
> drivers/gpu/drm/i915/intel_bios.c | 9 +++++++--
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 5 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 136d42a..1c3ee66 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1364,7 +1364,6 @@ struct intel_vbt_data {
> bool edp_initialized;
> bool edp_support;
> int edp_bpp;
> - bool edp_low_vswing;
> struct edp_power_seq edp_pps;
>
> struct {
> @@ -1846,6 +1845,8 @@ struct drm_i915_private {
> void (*stop_ring)(struct intel_engine_cs *ring);
> } gt;
>
> + bool edp_low_vswing;
> +
> /*
> * NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch
> * will be rejected. Instead look for a better place.
> @@ -2515,6 +2516,7 @@ struct i915_params {
> int mmio_debug;
> bool verbose_state_checks;
> bool nuclear_pageflip;
> + int edp_vswing;
> };
> extern struct i915_params i915 __read_mostly;
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index bb64415..8ac5a1b 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -53,6 +53,7 @@ struct i915_params i915 __read_mostly = {
> .mmio_debug = 0,
> .verbose_state_checks = 1,
> .nuclear_pageflip = 0,
> + .edp_vswing = 0,
> };
>
> module_param_named(modeset, i915.modeset, int, 0400);
> @@ -184,3 +185,10 @@ MODULE_PARM_DESC(verbose_state_checks,
> module_param_named_unsafe(nuclear_pageflip, i915.nuclear_pageflip, bool, 0600);
> MODULE_PARM_DESC(nuclear_pageflip,
> "Force atomic modeset functionality; only planes work for now (default: false).");
> +
> +/* WA to get away with the default setting in VBT for early platforms.Will be removed */
> +module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0400);
> +MODULE_PARM_DESC(edp_vswing,
> + "Ignore/Override vswing pre-emph table selection from VBT "
> + "(0=use value from vbt [default], 1=low power swing(200mV),"
> + "2=default swing(400mV))");
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index c08368c..cee596d 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -672,8 +672,13 @@ parse_edp(struct drm_i915_private *dev_priv, struct bdb_header *bdb)
> if (bdb->version >= 173) {
> uint8_t vswing;
>
> - vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> - dev_priv->vbt.edp_low_vswing = vswing == 0;
> + /* Don't read from VBT if module parameter has valid value*/
> + if (i915.edp_vswing) {
> + dev_priv->edp_low_vswing = i915.edp_vswing == 1;
> + } else {
> + vswing = (edp->edp_vswing_preemph >> (panel_type * 4)) & 0xF;
> + dev_priv->edp_low_vswing = vswing == 0;
> + }
> }
> }
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 9c1e74a..2539f22 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -282,7 +282,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
> ddi_translations_fdi = NULL;
> ddi_translations_dp = skl_ddi_translations_dp;
> n_dp_entries = ARRAY_SIZE(skl_ddi_translations_dp);
> - if (dev_priv->vbt.edp_low_vswing) {
> + if (dev_priv->edp_low_vswing) {
> ddi_translations_edp = skl_ddi_translations_edp;
> n_edp_entries = ARRAY_SIZE(skl_ddi_translations_edp);
> } else {
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index bacdec5..5f53666 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2894,7 +2894,7 @@ intel_dp_voltage_max(struct intel_dp *intel_dp)
> if (IS_BROXTON(dev))
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> else if (INTEL_INFO(dev)->gen >= 9) {
> - if (dev_priv->vbt.edp_low_vswing && port == PORT_A)
> + if (dev_priv->edp_low_vswing && port == PORT_A)
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_3;
> return DP_TRAIN_VOLTAGE_SWING_LEVEL_2;
> } else if (IS_VALLEYVIEW(dev))
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 10:13 ` Sonika Jindal
2015-05-06 10:28 ` Jani Nikula
@ 2015-05-07 9:15 ` shuang.he
1 sibling, 0 replies; 13+ messages in thread
From: shuang.he @ 2015-05-07 9:15 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, sonika.jindal
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6326
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK 302/302 302/302
SNB 316/316 316/316
IVB 342/342 342/342
BYT 286/286 286/286
BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/skl: Add module parameter to select edp vswing table
2015-05-06 12:05 ` Sonika Jindal
2015-05-06 14:09 ` Daniel Vetter
@ 2015-05-07 12:27 ` shuang.he
1 sibling, 0 replies; 13+ messages in thread
From: shuang.he @ 2015-05-07 12:27 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, sonika.jindal
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6330
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK 302/302 302/302
SNB 316/316 316/316
IVB 342/342 342/342
BYT 286/286 286/286
BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-05-07 12:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-05 9:46 [PATCH] drm/i915/skl: Add module parameter to select edp vswing table Sonika Jindal
2015-05-05 11:39 ` Jani Nikula
2015-05-05 13:00 ` Damien Lespiau
2015-05-05 13:58 ` Jani Nikula
2015-05-06 5:43 ` Jindal, Sonika
2015-05-06 6:57 ` Jani Nikula
2015-05-06 10:13 ` Sonika Jindal
2015-05-06 10:28 ` Jani Nikula
2015-05-06 12:05 ` Sonika Jindal
2015-05-06 14:09 ` Daniel Vetter
2015-05-07 12:27 ` shuang.he
2015-05-07 9:15 ` shuang.he
2015-05-05 16:52 ` shuang.he
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.