From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Steve Capper <steve.capper@linaro.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Jerome Marchand <jmarchan@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv4 19/24] thp, mm: use migration entries to freeze page counts on split
Date: Mon, 30 Mar 2015 20:38:08 +0530 [thread overview]
Message-ID: <87h9t2le07.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1425486792-93161-20-git-send-email-kirill.shutemov@linux.intel.com>
....
....
+static void freeze_page(struct anon_vma *anon_vma, struct page *page)
> +{
> + struct anon_vma_chain *avc;
> + struct vm_area_struct *vma;
> + pgoff_t pgoff = page->index << (PAGE_CACHE_SHIFT - PAGE_SHIFT);
So this get called only with head page, We also do
BUG_ON(PageTail(page)) in the caller. But
> + unsigned long addr, haddr;
> + unsigned long mmun_start, mmun_end;
> + pgd_t *pgd;
> + pud_t *pud;
> + pmd_t *pmd;
> + pte_t *start_pte, *pte;
> + spinlock_t *ptl;
......
> +
> +static void unfreeze_page(struct anon_vma *anon_vma, struct page *page)
> +{
> + struct anon_vma_chain *avc;
> + pgoff_t pgoff = page_to_pgoff(page);
Why ? Can this get called for tail pages ?
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Steve Capper <steve.capper@linaro.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Jerome Marchand <jmarchan@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv4 19/24] thp, mm: use migration entries to freeze page counts on split
Date: Mon, 30 Mar 2015 20:38:08 +0530 [thread overview]
Message-ID: <87h9t2le07.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1425486792-93161-20-git-send-email-kirill.shutemov@linux.intel.com>
....
....
+static void freeze_page(struct anon_vma *anon_vma, struct page *page)
> +{
> + struct anon_vma_chain *avc;
> + struct vm_area_struct *vma;
> + pgoff_t pgoff = page->index << (PAGE_CACHE_SHIFT - PAGE_SHIFT);
So this get called only with head page, We also do
BUG_ON(PageTail(page)) in the caller. But
> + unsigned long addr, haddr;
> + unsigned long mmun_start, mmun_end;
> + pgd_t *pgd;
> + pud_t *pud;
> + pmd_t *pmd;
> + pte_t *start_pte, *pte;
> + spinlock_t *ptl;
......
> +
> +static void unfreeze_page(struct anon_vma *anon_vma, struct page *page)
> +{
> + struct anon_vma_chain *avc;
> + pgoff_t pgoff = page_to_pgoff(page);
Why ? Can this get called for tail pages ?
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-30 15:08 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 16:32 [PATCHv4 00/24] THP refcounting redesign Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 01/24] thp: cluster split_huge_page* code together Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 02/24] mm: change PageAnon() and page_anon_vma() to work on tail pages Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 03/24] mm: avoid PG_locked " Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 18:48 ` Christoph Lameter
2015-03-04 18:48 ` Christoph Lameter
2015-03-04 20:56 ` Kirill A. Shutemov
2015-03-04 20:56 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 04/24] rmap: add argument to charge compound page Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 05/24] mm, proc: adjust PSS calculation Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 06/24] mm: store mapcount for compound page separately Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 07/24] mm, thp: adjust conditions when we can reuse the page on WP fault Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 08/24] mm: adjust FOLL_SPLIT for new refcounting Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 09/24] thp, mlock: do not allow huge pages in mlocked area Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 10/24] khugepaged: ignore pmd tables with THP mapped with ptes Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:32 ` [PATCHv4 11/24] thp: rename split_huge_page_pmd() to split_huge_pmd() Kirill A. Shutemov
2015-03-04 16:32 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 12/24] thp: PMD splitting without splitting compound page Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-17 8:32 ` Aneesh Kumar K.V
2015-03-17 8:32 ` Aneesh Kumar K.V
2015-03-29 15:55 ` Aneesh Kumar K.V
2015-03-29 15:55 ` Aneesh Kumar K.V
2015-03-29 17:42 ` Kirill A. Shutemov
2015-03-29 17:42 ` Kirill A. Shutemov
2015-03-29 16:28 ` Aneesh Kumar K.V
2015-03-29 16:28 ` Aneesh Kumar K.V
2015-03-29 17:43 ` Kirill A. Shutemov
2015-03-29 17:43 ` Kirill A. Shutemov
2015-04-01 6:38 ` Aneesh Kumar K.V
2015-04-01 6:38 ` Aneesh Kumar K.V
2015-04-01 13:17 ` Kirill A. Shutemov
2015-04-01 13:17 ` Kirill A. Shutemov
2015-04-01 23:13 ` Hugh Dickins
2015-04-01 23:13 ` Hugh Dickins
2015-04-02 15:39 ` Kirill A. Shutemov
2015-04-02 15:39 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 13/24] mm, vmstats: new THP splitting event Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 18:49 ` Christoph Lameter
2015-03-04 18:49 ` Christoph Lameter
2015-03-04 16:33 ` [PATCHv4 14/24] thp: implement new split_huge_page() Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 15/24] mm, thp: remove infrastructure for handling splitting PMDs Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-29 16:10 ` Aneesh Kumar K.V
2015-03-29 16:10 ` Aneesh Kumar K.V
2015-03-29 17:51 ` Kirill A. Shutemov
2015-03-29 17:51 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 16/24] x86, " Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 17/24] futex, thp: remove special case for THP in get_futex_key Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 18/24] thp, mm: split_huge_page(): caller need to lock page Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-30 14:10 ` Aneesh Kumar K.V
2015-03-30 14:10 ` Aneesh Kumar K.V
2015-03-30 15:20 ` Kirill A. Shutemov
2015-03-30 15:20 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 19/24] thp, mm: use migration entries to freeze page counts on split Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-30 14:19 ` Aneesh Kumar K.V
2015-03-30 14:19 ` Aneesh Kumar K.V
2015-03-30 15:23 ` Kirill A. Shutemov
2015-03-30 15:23 ` Kirill A. Shutemov
2015-03-30 15:08 ` Aneesh Kumar K.V [this message]
2015-03-30 15:08 ` Aneesh Kumar K.V
2015-03-30 15:26 ` Kirill A. Shutemov
2015-03-30 15:26 ` Kirill A. Shutemov
2015-03-30 15:45 ` Aneesh Kumar K.V
2015-03-30 15:45 ` Aneesh Kumar K.V
2015-04-01 13:19 ` Kirill A. Shutemov
2015-04-01 13:19 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 20/24] mm, thp: remove compound_lock Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-31 15:50 ` Aneesh Kumar K.V
2015-03-31 15:50 ` Aneesh Kumar K.V
2015-03-04 16:33 ` [PATCHv4 21/24] thp: introduce deferred_split_huge_page() Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 22/24] memcg: adjust to support new THP refcounting Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 23/24] ksm: split huge pages on follow_page() Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-04 16:33 ` [PATCHv4 24/24] thp: update documentation Kirill A. Shutemov
2015-03-04 16:33 ` Kirill A. Shutemov
2015-03-05 12:55 ` [PATCHv4 00/24] THP refcounting redesign Jerome Marchand
2015-03-05 16:04 ` Kirill A. Shutemov
2015-03-05 16:04 ` Kirill A. Shutemov
2015-03-06 12:18 ` Kirill A. Shutemov
2015-03-06 12:18 ` Kirill A. Shutemov
2015-03-06 15:58 ` Jerome Marchand
2015-03-17 9:42 ` Aneesh Kumar K.V
2015-03-17 9:42 ` Aneesh Kumar K.V
2015-03-19 17:10 ` Kirill A. Shutemov
2015-03-19 17:10 ` Kirill A. Shutemov
2015-03-30 15:40 ` Aneesh Kumar K.V
2015-03-30 15:40 ` Aneesh Kumar K.V
2015-04-01 13:26 ` Kirill A. Shutemov
2015-04-01 13:26 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9t2le07.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=steve.capper@linaro.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.