* [PATCH] OMAP: Voltage: fix typos, compile break
@ 2010-08-09 19:39 mturquette
2010-08-11 20:19 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: mturquette @ 2010-08-09 19:39 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, Mike Turquette
From: Mike Turquette <mturquette@ti.com>
mach-omap/voltage.c incorrectly called omap_get_mpuss_device and
omap_get_l3_device. The correct function names are
omap2_get_mpuss_device and omap2_get_l3_device respectively.
This fixes a compile break. Test on OMAP3430 SDP.
Signed-off-by: Mike Turquette <mturquette@ti.com>
---
This patch is meant to apply to Kevin's pm-srf branch. Without it
compilation for OMAP3 is broken.
arch/arm/mach-omap2/voltage.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
index e7055f6..148e4d4 100644
--- a/arch/arm/mach-omap2/voltage.c
+++ b/arch/arm/mach-omap2/voltage.c
@@ -385,7 +385,7 @@ static void __init omap3_vdd_data_configure(int vdd)
vdd_info[vdd].volt_clk = clk_get(NULL, "dpll1_ck");
WARN(IS_ERR(vdd_info[vdd].volt_clk),
"unable to get clock for VDD%d\n", vdd + 1);
- vdd_info[vdd].opp_dev = omap_get_mpuss_device();
+ vdd_info[vdd].opp_dev = omap2_get_mpuss_device();
vdd_info[vdd].vp_reg.tranxdone_status =
OMAP3430_VP1_TRANXDONE_ST_MASK;
vdd_info[vdd].cmdval_reg = OMAP3_PRM_VC_CMD_VAL_0_OFFSET;
@@ -411,7 +411,7 @@ static void __init omap3_vdd_data_configure(int vdd)
vdd_info[vdd].volt_clk = clk_get(NULL, "l3_ick");
WARN(IS_ERR(vdd_info[vdd].volt_clk),
"unable to get clock for VDD%d\n", vdd + 1);
- vdd_info[vdd].opp_dev = omap_get_l3_device();
+ vdd_info[vdd].opp_dev = omap2_get_l3_device();
vdd_info[vdd].vp_reg.tranxdone_status =
OMAP3430_VP2_TRANXDONE_ST_MASK;
vdd_info[vdd].cmdval_reg = OMAP3_PRM_VC_CMD_VAL_1_OFFSET;
--
1.7.0.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP: Voltage: fix typos, compile break
2010-08-09 19:39 [PATCH] OMAP: Voltage: fix typos, compile break mturquette
@ 2010-08-11 20:19 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2010-08-11 20:19 UTC (permalink / raw)
To: mturquette; +Cc: linux-omap, Mike Turquette
mturquette@gmail.com writes:
> From: Mike Turquette <mturquette@ti.com>
>
> mach-omap/voltage.c incorrectly called omap_get_mpuss_device and
> omap_get_l3_device. The correct function names are
> omap2_get_mpuss_device and omap2_get_l3_device respectively.
>
> This fixes a compile break. Test on OMAP3430 SDP.
>
> Signed-off-by: Mike Turquette <mturquette@ti.com>
> ---
>
> This patch is meant to apply to Kevin's pm-srf branch. Without it
> compilation for OMAP3 is broken.
pm-srf branch is no longer supported (by me anyways)
and this problem is fixed in the pm-sr branch which is included in the
latest PM branch.
Kevin
> arch/arm/mach-omap2/voltage.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> index e7055f6..148e4d4 100644
> --- a/arch/arm/mach-omap2/voltage.c
> +++ b/arch/arm/mach-omap2/voltage.c
> @@ -385,7 +385,7 @@ static void __init omap3_vdd_data_configure(int vdd)
> vdd_info[vdd].volt_clk = clk_get(NULL, "dpll1_ck");
> WARN(IS_ERR(vdd_info[vdd].volt_clk),
> "unable to get clock for VDD%d\n", vdd + 1);
> - vdd_info[vdd].opp_dev = omap_get_mpuss_device();
> + vdd_info[vdd].opp_dev = omap2_get_mpuss_device();
> vdd_info[vdd].vp_reg.tranxdone_status =
> OMAP3430_VP1_TRANXDONE_ST_MASK;
> vdd_info[vdd].cmdval_reg = OMAP3_PRM_VC_CMD_VAL_0_OFFSET;
> @@ -411,7 +411,7 @@ static void __init omap3_vdd_data_configure(int vdd)
> vdd_info[vdd].volt_clk = clk_get(NULL, "l3_ick");
> WARN(IS_ERR(vdd_info[vdd].volt_clk),
> "unable to get clock for VDD%d\n", vdd + 1);
> - vdd_info[vdd].opp_dev = omap_get_l3_device();
> + vdd_info[vdd].opp_dev = omap2_get_l3_device();
> vdd_info[vdd].vp_reg.tranxdone_status =
> OMAP3430_VP2_TRANXDONE_ST_MASK;
> vdd_info[vdd].cmdval_reg = OMAP3_PRM_VC_CMD_VAL_1_OFFSET;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-11 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-09 19:39 [PATCH] OMAP: Voltage: fix typos, compile break mturquette
2010-08-11 20:19 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.