[Buildroot] [PATCH 1/1] package/trace-cmd: needs NPTL

[Buildroot] [PATCH 1/1] package/trace-cmd: needs NPTL

[Fabrice Fontaine]

trace-cmd needs NPTL since bump to version 2.9.1 in commit
0e1231a3c0719269ab3546defe4b1fb0f1f5d7d2 and
https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=08b9d5076455c93c997376c8089ee12b9071785b:

/nvmedata/autobuild/instance-24/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/10.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: /nvmedata/autobuild/instance-24/output-1/build/trace-cmd-2.9.7/lib/trace-cmd/libtracecmd.a(trace-timesync.o): in function `tracecmd_tsync_with_host':
trace-timesync.c:(.text+0x12e1): undefined reference to `pthread_setaffinity_np'

Fixes:
 - http://autobuild.buildroot.org/results/9a88aaf92760b34958ef5b1708de83e46ccdb587

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/trace-cmd/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/trace-cmd/Config.in b/package/trace-cmd/Config.in
index 574541c571..2d0accd7ae 100644
--- a/package/trace-cmd/Config.in
+++ b/package/trace-cmd/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_TRACE_CMD
 	bool "trace-cmd"
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	# pthread_setaffinity_np
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS # dlopen()
 	help
@@ -13,6 +14,6 @@ config BR2_PACKAGE_TRACE_CMD
 
 	  http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
 
-comment "trace-cmd needs a toolchain w/ threads, dynamic library"
+comment "trace-cmd needs a toolchain w/ NPTL, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/trace-cmd: needs NPTL

[Arnout Vandecappelle]

On 04/04/2022 22:50, Fabrice Fontaine wrote:
> trace-cmd needs NPTL since bump to version 2.9.1 in commit
> 0e1231a3c0719269ab3546defe4b1fb0f1f5d7d2 and
> https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=08b9d5076455c93c997376c8089ee12b9071785b:
> 
> /nvmedata/autobuild/instance-24/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/10.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: /nvmedata/autobuild/instance-24/output-1/build/trace-cmd-2.9.7/lib/trace-cmd/libtracecmd.a(trace-timesync.o): in function `tracecmd_tsync_with_host':
> trace-timesync.c:(.text+0x12e1): undefined reference to `pthread_setaffinity_np'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/9a88aaf92760b34958ef5b1708de83e46ccdb587
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/trace-cmd/Config.in | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/trace-cmd/Config.in b/package/trace-cmd/Config.in
> index 574541c571..2d0accd7ae 100644
> --- a/package/trace-cmd/Config.in
> +++ b/package/trace-cmd/Config.in
> @@ -1,6 +1,7 @@
>   config BR2_PACKAGE_TRACE_CMD
>   	bool "trace-cmd"
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	# pthread_setaffinity_np
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>   	depends on BR2_USE_MMU # fork()
>   	depends on !BR2_STATIC_LIBS # dlopen()
>   	help
> @@ -13,6 +14,6 @@ config BR2_PACKAGE_TRACE_CMD
>   
>   	  http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
>   
> -comment "trace-cmd needs a toolchain w/ threads, dynamic library"
> +comment "trace-cmd needs a toolchain w/ NPTL, dynamic library"
>   	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/trace-cmd: needs NPTL

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > trace-cmd needs NPTL since bump to version 2.9.1 in commit
 > 0e1231a3c0719269ab3546defe4b1fb0f1f5d7d2 and
 > https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=08b9d5076455c93c997376c8089ee12b9071785b:

 > /nvmedata/autobuild/instance-24/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/10.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld:
 > /nvmedata/autobuild/instance-24/output-1/build/trace-cmd-2.9.7/lib/trace-cmd/libtracecmd.a(trace-timesync.o):
 > in function `tracecmd_tsync_with_host':
 > trace-timesync.c:(.text+0x12e1): undefined reference to `pthread_setaffinity_np'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/9a88aaf92760b34958ef5b1708de83e46ccdb587

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot