* [PATCH] Documentation: block/diskstats: update function names
@ 2022-02-22 1:27 Naohiro Aota
2022-02-22 8:20 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Naohiro Aota @ 2022-02-22 1:27 UTC (permalink / raw)
To: linux-block, Jens Axboe; +Cc: linux-doc, Jonathan Corbet, Naohiro Aota
__make_request() and end_that_request_last() do no longer exist. Replace
them with the current call-site.
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
Documentation/admin-guide/iostats.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/iostats.rst b/Documentation/admin-guide/iostats.rst
index 9b14b0c2c9c4..609a3201fd4e 100644
--- a/Documentation/admin-guide/iostats.rst
+++ b/Documentation/admin-guide/iostats.rst
@@ -76,7 +76,7 @@ Field 3 -- # of sectors read (unsigned long)
Field 4 -- # of milliseconds spent reading (unsigned int)
This is the total number of milliseconds spent by all reads (as
- measured from __make_request() to end_that_request_last()).
+ measured from blk_mq_alloc_request() to __blk_mq_end_request()).
Field 5 -- # of writes completed (unsigned long)
This is the total number of writes completed successfully.
@@ -89,7 +89,7 @@ Field 7 -- # of sectors written (unsigned long)
Field 8 -- # of milliseconds spent writing (unsigned int)
This is the total number of milliseconds spent by all writes (as
- measured from __make_request() to end_that_request_last()).
+ measured from blk_mq_alloc_request() to __blk_mq_end_request()).
Field 9 -- # of I/Os currently in progress (unsigned int)
The only field that should go to zero. Incremented as requests are
@@ -120,7 +120,7 @@ Field 14 -- # of sectors discarded (unsigned long)
Field 15 -- # of milliseconds spent discarding (unsigned int)
This is the total number of milliseconds spent by all discards (as
- measured from __make_request() to end_that_request_last()).
+ measured from blk_mq_alloc_request() to __blk_mq_end_request()).
Field 16 -- # of flush requests completed
This is the total number of flush requests completed successfully.
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: block/diskstats: update function names
2022-02-22 1:27 [PATCH] Documentation: block/diskstats: update function names Naohiro Aota
@ 2022-02-22 8:20 ` Christoph Hellwig
2022-02-22 14:01 ` Jens Axboe
2022-02-22 14:18 ` Chaitanya Kulkarni
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-02-22 8:20 UTC (permalink / raw)
To: Naohiro Aota; +Cc: linux-block, Jens Axboe, linux-doc, Jonathan Corbet
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: block/diskstats: update function names
2022-02-22 1:27 [PATCH] Documentation: block/diskstats: update function names Naohiro Aota
2022-02-22 8:20 ` Christoph Hellwig
@ 2022-02-22 14:01 ` Jens Axboe
2022-02-22 15:10 ` Jonathan Corbet
2022-02-22 14:18 ` Chaitanya Kulkarni
2 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2022-02-22 14:01 UTC (permalink / raw)
To: Naohiro Aota, linux-block; +Cc: linux-doc, Jonathan Corbet
On 2/21/22 6:27 PM, Naohiro Aota wrote:
> __make_request() and end_that_request_last() do no longer exist. Replace
> them with the current call-site.
Reviwed-by: Jens Axboe <axboe@kernel.dk>
Jon, will you pick this one up?
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: block/diskstats: update function names
2022-02-22 1:27 [PATCH] Documentation: block/diskstats: update function names Naohiro Aota
2022-02-22 8:20 ` Christoph Hellwig
2022-02-22 14:01 ` Jens Axboe
@ 2022-02-22 14:18 ` Chaitanya Kulkarni
2 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2022-02-22 14:18 UTC (permalink / raw)
To: Naohiro Aota; +Cc: linux-doc, Jonathan Corbet, Jens Axboe, linux-block
On 2/21/22 17:27, Naohiro Aota wrote:
> __make_request() and end_that_request_last() do no longer exist. Replace
> them with the current call-site.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation: block/diskstats: update function names
2022-02-22 14:01 ` Jens Axboe
@ 2022-02-22 15:10 ` Jonathan Corbet
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2022-02-22 15:10 UTC (permalink / raw)
To: Jens Axboe, Naohiro Aota, linux-block; +Cc: linux-doc
Jens Axboe <axboe@kernel.dk> writes:
> On 2/21/22 6:27 PM, Naohiro Aota wrote:
>> __make_request() and end_that_request_last() do no longer exist. Replace
>> them with the current call-site.
>
> Reviwed-by: Jens Axboe <axboe@kernel.dk>
>
> Jon, will you pick this one up?
Will do.
Thanks,
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-22 15:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-22 1:27 [PATCH] Documentation: block/diskstats: update function names Naohiro Aota
2022-02-22 8:20 ` Christoph Hellwig
2022-02-22 14:01 ` Jens Axboe
2022-02-22 15:10 ` Jonathan Corbet
2022-02-22 14:18 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.