* [PATCH v2] vfio_pci_core: Make vfio_pci_regops->rw() return ssize_t
@ 2021-07-20 22:51 Jason Gunthorpe
2021-07-21 6:03 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Jason Gunthorpe @ 2021-07-20 22:51 UTC (permalink / raw)
To: Cornelia Huck, kvm; +Cc: Alex Williamson, Yishai Hadas
From: Yishai Hadas <yishaih@nvidia.com>
The only implementation of this in IGD returns a -ERRNO which is
implicitly cast through a size_t and then casted again and returned as a
ssize_t in vfio_pci_rw().
Fix the vfio_pci_regops->rw() return type to be ssize_t so all is
consistent.
Fixes: 28541d41c9e0 ("vfio/pci: Add infrastructure for additional device specific regions")
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
---
drivers/vfio/pci/vfio_pci_igd.c | 10 +++++-----
drivers/vfio/pci/vfio_pci_private.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
v2:
- Diff fixed to be against v5.14-rc1, woops
diff --git a/drivers/vfio/pci/vfio_pci_igd.c b/drivers/vfio/pci/vfio_pci_igd.c
index 228df565e9bc40..aa0a29fd276285 100644
--- a/drivers/vfio/pci/vfio_pci_igd.c
+++ b/drivers/vfio/pci/vfio_pci_igd.c
@@ -25,8 +25,8 @@
#define OPREGION_RVDS 0x3c2
#define OPREGION_VERSION 0x16
-static size_t vfio_pci_igd_rw(struct vfio_pci_device *vdev, char __user *buf,
- size_t count, loff_t *ppos, bool iswrite)
+static ssize_t vfio_pci_igd_rw(struct vfio_pci_device *vdev, char __user *buf,
+ size_t count, loff_t *ppos, bool iswrite)
{
unsigned int i = VFIO_PCI_OFFSET_TO_INDEX(*ppos) - VFIO_PCI_NUM_REGIONS;
void *base = vdev->region[i].data;
@@ -160,9 +160,9 @@ static int vfio_pci_igd_opregion_init(struct vfio_pci_device *vdev)
return ret;
}
-static size_t vfio_pci_igd_cfg_rw(struct vfio_pci_device *vdev,
- char __user *buf, size_t count, loff_t *ppos,
- bool iswrite)
+static ssize_t vfio_pci_igd_cfg_rw(struct vfio_pci_device *vdev,
+ char __user *buf, size_t count, loff_t *ppos,
+ bool iswrite)
{
unsigned int i = VFIO_PCI_OFFSET_TO_INDEX(*ppos) - VFIO_PCI_NUM_REGIONS;
struct pci_dev *pdev = vdev->region[i].data;
diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
index 5a36272cecbf94..bbc56c857ef081 100644
--- a/drivers/vfio/pci/vfio_pci_private.h
+++ b/drivers/vfio/pci/vfio_pci_private.h
@@ -56,7 +56,7 @@ struct vfio_pci_device;
struct vfio_pci_region;
struct vfio_pci_regops {
- size_t (*rw)(struct vfio_pci_device *vdev, char __user *buf,
+ ssize_t (*rw)(struct vfio_pci_device *vdev, char __user *buf,
size_t count, loff_t *ppos, bool iswrite);
void (*release)(struct vfio_pci_device *vdev,
struct vfio_pci_region *region);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] vfio_pci_core: Make vfio_pci_regops->rw() return ssize_t
2021-07-20 22:51 [PATCH v2] vfio_pci_core: Make vfio_pci_regops->rw() return ssize_t Jason Gunthorpe
@ 2021-07-21 6:03 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2021-07-21 6:03 UTC (permalink / raw)
To: Jason Gunthorpe, kvm; +Cc: Alex Williamson, Yishai Hadas
On Tue, Jul 20 2021, Jason Gunthorpe <jgg@nvidia.com> wrote:
> From: Yishai Hadas <yishaih@nvidia.com>
>
> The only implementation of this in IGD returns a -ERRNO which is
> implicitly cast through a size_t and then casted again and returned as a
> ssize_t in vfio_pci_rw().
>
> Fix the vfio_pci_regops->rw() return type to be ssize_t so all is
> consistent.
>
> Fixes: 28541d41c9e0 ("vfio/pci: Add infrastructure for additional device specific regions")
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
This is missing your s-o-b...
> ---
> drivers/vfio/pci/vfio_pci_igd.c | 10 +++++-----
> drivers/vfio/pci/vfio_pci_private.h | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> v2:
> - Diff fixed to be against v5.14-rc1, woops
Could you please also fix the subject prefix?
The change itself looks good to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-21 6:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 22:51 [PATCH v2] vfio_pci_core: Make vfio_pci_regops->rw() return ssize_t Jason Gunthorpe
2021-07-21 6:03 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.