[Buildroot] [PATCH 1/1] package/python-bluezero: select dbus

[Buildroot] [PATCH 1/1] package/python-bluezero: select dbus

[Fabrice Fontaine]

Build is broken since commit
8bdc5e7c4d975193b1e18999ed840507cea63bd6 because BR2_PACKAGE_DBUS_PYTHON
is selected without selecting BR2_PACKAGE_DBUS

Fixes:
 - http://autobuild.buildroot.org/results/378dd714940440b8f9db763479ae929e90e33b80

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/python-bluezero/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-bluezero/Config.in b/package/python-bluezero/Config.in
index 7126b3ca50..c391bfa858 100644
--- a/package/python-bluezero/Config.in
+++ b/package/python-bluezero/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # python-gobject -> gobject-introspection
 	depends on BR2_TOOLCHAIN_USES_GLIBC # python-gobject -> gobject-introspection
 	depends on BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_DBUS # runtime
 	select BR2_PACKAGE_DBUS_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON_GOBJECT # runtime
 	help
-- 
2.30.2

[Buildroot] [PATCH 1/1] package/python-bluezero: select dbus

[Yann E. MORIN]

Fabrice, All,

On 2021-05-24 20:56 +0200, Fabrice Fontaine spake thusly:
> Build is broken since commit
> 8bdc5e7c4d975193b1e18999ed840507cea63bd6 because BR2_PACKAGE_DBUS_PYTHON
> is selected without selecting BR2_PACKAGE_DBUS
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/378dd714940440b8f9db763479ae929e90e33b80
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

But see below for a little comment...

> ---
>  package/python-bluezero/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-bluezero/Config.in b/package/python-bluezero/Config.in
> index 7126b3ca50..c391bfa858 100644
> --- a/package/python-bluezero/Config.in
> +++ b/package/python-bluezero/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # python-gobject -> gobject-introspection
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # python-gobject -> gobject-introspection
>  	depends on BR2_PACKAGE_PYTHON3
> +	select BR2_PACKAGE_DBUS # runtime

This is not propagating the MMU dependency from DBus. It is implied,
because python3 already depends on MMU, but this is confusing...

Anyway. Applied, thanks!

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_DBUS_PYTHON # runtime
>  	select BR2_PACKAGE_PYTHON_GOBJECT # runtime
>  	help
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/python-bluezero: select dbus

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Build is broken since commit
 > 8bdc5e7c4d975193b1e18999ed840507cea63bd6 because BR2_PACKAGE_DBUS_PYTHON
 > is selected without selecting BR2_PACKAGE_DBUS

 > Fixes:
 >  - http://autobuild.buildroot.org/results/378dd714940440b8f9db763479ae929e90e33b80

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard