* [PATCH v2 0/2] HDCP 2.2 DP errata
@ 2021-03-24 11:30 ` Anshuman Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Anshuman Gupta, ankit.k.nautiyal, maarten.lankhorst
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
as well.
Anshuman Gupta (2):
drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
include/drm/drm_hdcp.h | 5 ++-
2 files changed, 36 insertions(+), 14 deletions(-)
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata
@ 2021-03-24 11:30 ` Anshuman Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: maarten.lankhorst
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
as well.
Anshuman Gupta (2):
drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
include/drm/drm_hdcp.h | 5 ++-
2 files changed, 36 insertions(+), 14 deletions(-)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
@ 2021-03-24 11:30 ` Anshuman Gupta
-1 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Anshuman Gupta, ankit.k.nautiyal, maarten.lankhorst
As documented in HDCP 2.2 DP Errata spec transmitter should abort the
authentication protocol in case transmitter has not received the
entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
within {110,7,5} miliseconds.
Adding above msg timeout values and aborting the HDCP authentication
in case it timedout to read entire msg.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
v2:
- Removed redundant variable msg_can_timedout. [Ankit]
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
include/drm/drm_hdcp.h | 3 ++
2 files changed, 35 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index 40c516e90193..8bad4b3d34dd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
bool msg_detectable;
u32 timeout;
u32 timeout2; /* Added for non_paired situation */
+ /* Timeout to read entire msg */
+ u32 msg_read_timeout;
};
static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
- { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
+ { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
{ HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
- false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, 0, 0, 0 },
{ HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, 0, 0, 0 },
{ HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
- HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
+ HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_SEND_PAIRING_INFO,
DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
- HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
- { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
+ HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
+ { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
{ HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
- false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
{ HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
- 0, 0 },
+ 0, 0, 0 },
{ HDCP_2_2_REP_SEND_RECVID_LIST,
DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
- HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
+ HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
{ HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
- 0, 0 },
+ 0, 0, 0 },
{ HDCP_2_2_REP_STREAM_MANAGE,
DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
- 0, 0 },
+ 0, 0, 0},
{ HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
- false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
/* local define to shovel this through the write_2_2 interface */
#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
{ HDCP_2_2_ERRATA_DP_STREAM_TYPE,
@@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
u8 *byte = buf;
ssize_t ret, bytes_to_recv, len;
const struct hdcp2_dp_msg_data *hdcp2_msg_data;
+ ktime_t msg_end;
+ bool msg_expired;
hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
if (!hdcp2_msg_data)
@@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
+ /* Entire msg read timeout since initiate of msg read */
+ if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
+ msg_end = ktime_add_ms(ktime_get_raw(),
+ hdcp2_msg_data->msg_read_timeout);
+
ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
(void *)byte, len);
if (ret < 0) {
@@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
byte += ret;
offset += ret;
}
+
+ if (hdcp2_msg_data->msg_read_timeout > 0) {
+ msg_expired = ktime_after(ktime_get_raw(), msg_end);
+ if (msg_expired) {
+ drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
+ msg_id, hdcp2_msg_data->msg_read_timeout);
+ return -ETIMEDOUT;
+ }
+ }
+
byte = buf;
*byte = msg_id;
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index ac22c246542a..2b165a0f434f 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
/* HDCP2.2 TIMEOUTs in mSec */
#define HDCP_2_2_CERT_TIMEOUT_MS 100
+#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
#define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
#define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
+#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
+#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
@ 2021-03-24 11:30 ` Anshuman Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: maarten.lankhorst
As documented in HDCP 2.2 DP Errata spec transmitter should abort the
authentication protocol in case transmitter has not received the
entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
within {110,7,5} miliseconds.
Adding above msg timeout values and aborting the HDCP authentication
in case it timedout to read entire msg.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
v2:
- Removed redundant variable msg_can_timedout. [Ankit]
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
include/drm/drm_hdcp.h | 3 ++
2 files changed, 35 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index 40c516e90193..8bad4b3d34dd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
bool msg_detectable;
u32 timeout;
u32 timeout2; /* Added for non_paired situation */
+ /* Timeout to read entire msg */
+ u32 msg_read_timeout;
};
static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
- { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
+ { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
{ HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
- false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, 0, 0, 0 },
{ HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, 0, 0, 0 },
{ HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
- HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
+ HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_SEND_PAIRING_INFO,
DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
- HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
- { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
+ HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
+ { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
{ HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
- false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
{ HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
- 0, 0 },
+ 0, 0, 0 },
{ HDCP_2_2_REP_SEND_RECVID_LIST,
DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
- HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
+ HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
{ HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
- 0, 0 },
+ 0, 0, 0 },
{ HDCP_2_2_REP_STREAM_MANAGE,
DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
- 0, 0 },
+ 0, 0, 0},
{ HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
- false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
+ false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
/* local define to shovel this through the write_2_2 interface */
#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
{ HDCP_2_2_ERRATA_DP_STREAM_TYPE,
@@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
u8 *byte = buf;
ssize_t ret, bytes_to_recv, len;
const struct hdcp2_dp_msg_data *hdcp2_msg_data;
+ ktime_t msg_end;
+ bool msg_expired;
hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
if (!hdcp2_msg_data)
@@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
+ /* Entire msg read timeout since initiate of msg read */
+ if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
+ msg_end = ktime_add_ms(ktime_get_raw(),
+ hdcp2_msg_data->msg_read_timeout);
+
ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
(void *)byte, len);
if (ret < 0) {
@@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
byte += ret;
offset += ret;
}
+
+ if (hdcp2_msg_data->msg_read_timeout > 0) {
+ msg_expired = ktime_after(ktime_get_raw(), msg_end);
+ if (msg_expired) {
+ drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
+ msg_id, hdcp2_msg_data->msg_read_timeout);
+ return -ETIMEDOUT;
+ }
+ }
+
byte = buf;
*byte = msg_id;
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index ac22c246542a..2b165a0f434f 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
/* HDCP2.2 TIMEOUTs in mSec */
#define HDCP_2_2_CERT_TIMEOUT_MS 100
+#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
#define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
#define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
+#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
+#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
@ 2021-03-24 11:30 ` Anshuman Gupta
-1 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Anshuman Gupta, ankit.k.nautiyal, maarten.lankhorst
Fix LC_Send_L_Prime message timeout to 16 as documented
in DP HDCP 2.2 errata page 3.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index 2b165a0f434f..0b1111e3228e 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
-#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
+#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
#define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
@ 2021-03-24 11:30 ` Anshuman Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Anshuman Gupta @ 2021-03-24 11:30 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: maarten.lankhorst
Fix LC_Send_L_Prime message timeout to 16 as documented
in DP HDCP 2.2 errata page 3.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index 2b165a0f434f..0b1111e3228e 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
-#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
+#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
#define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata (rev2)
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
` (2 preceding siblings ...)
(?)
@ 2021-03-24 12:08 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-03-24 12:08 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
== Series Details ==
Series: HDCP 2.2 DP errata (rev2)
URL : https://patchwork.freedesktop.org/series/86340/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3cb4056611f6 drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
total: 0 errors, 1 warnings, 0 checks, 99 lines checked
f7ab5bf2f99e drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for HDCP 2.2 DP errata (rev2)
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
` (3 preceding siblings ...)
(?)
@ 2021-03-24 12:13 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-03-24 12:13 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
== Series Details ==
Series: HDCP 2.2 DP errata (rev2)
URL : https://patchwork.freedesktop.org/series/86340/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
/home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 DP errata (rev2)
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
` (4 preceding siblings ...)
(?)
@ 2021-03-24 12:39 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-03-24 12:39 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5674 bytes --]
== Series Details ==
Series: HDCP 2.2 DP errata (rev2)
URL : https://patchwork.freedesktop.org/series/86340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9889 -> Patchwork_19845
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/index.html
Known issues
------------
Here are the changes found in Patchwork_19845 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +26 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][3] ([i915#2283])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@gem_huc_copy@huc-copy:
- fi-byt-j1900: NOTRUN -> [SKIP][6] ([fdo#109271]) +27 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-byt-j1900/igt@gem_huc_copy@huc-copy.html
- fi-skl-guc: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-skl-guc/igt@gem_huc_copy@huc-copy.html
* igt@gem_tiled_blits@basic:
- fi-kbl-8809g: [PASS][8] -> [TIMEOUT][9] ([i915#2502] / [i915#3145])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/fi-kbl-8809g/igt@gem_tiled_blits@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-kbl-8809g/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- fi-kbl-8809g: [PASS][10] -> [TIMEOUT][11] ([i915#3145])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
* igt@kms_chamelium@dp-crc-fast:
- fi-skl-guc: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
- fi-bdw-5557u: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-byt-j1900/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-guc: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#533])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> [SKIP][16] ([fdo#109271]) +25 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-skl-guc/igt@kms_psr@primary_mmap_gtt.html
#### Possible fixes ####
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][17] ([i915#402]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (46 -> 42)
------------------------------
Additional (2): fi-byt-j1900 fi-skl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-icl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9889 -> Patchwork_19845
CI-20190529: 20190529
CI_DRM_9889: c42d2e7296ecebf00ae234a847059cc92e41a86c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6044: 2c2fc6470646eb5e25fc6ea02449ef744f8b70c2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19845: f7ab5bf2f99e03cced8a62378679548e551655b9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f7ab5bf2f99e drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
3cb4056611f6 drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/index.html
[-- Attachment #1.2: Type: text/html, Size: 7408 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for HDCP 2.2 DP errata (rev2)
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
` (5 preceding siblings ...)
(?)
@ 2021-03-24 22:45 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-03-24 22:45 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 27015 bytes --]
== Series Details ==
Series: HDCP 2.2 DP errata (rev2)
URL : https://patchwork.freedesktop.org/series/86340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9889_full -> Patchwork_19845_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19845_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: NOTRUN -> [SKIP][1] ([i915#658])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@feature_discovery@psr2.html
* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-snb5/igt@gem_ctx_persistence@process.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [PASS][3] -> [TIMEOUT][4] ([i915#3063])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-tglb5/igt@gem_eio@in-flight-contexts-immediate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-tglb7/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk4/igt@gem_exec_fair@basic-none@vcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#1610] / [i915#2803])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl4/igt@gem_exec_schedule@u-fairslice@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl4/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#307])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_mmap_offset@clear:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#1888] / [i915#3160])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk6/igt@gem_mmap_offset@clear.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk8/igt@gem_mmap_offset@clear.html
* igt@gem_userptr_blits@process-exit-mmap@wb:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1699]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@gem_userptr_blits@process-exit-mmap@wb.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [INCOMPLETE][16] ([i915#2502] / [i915#2667])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl2/igt@gem_userptr_blits@vma-merge.html
* igt@gen3_render_tiledx_blits:
- shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109289])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@gen3_render_tiledx_blits.html
* igt@i915_selftest@live@client:
- shard-glk: [PASS][18] -> [DMESG-FAIL][19] ([i915#3047])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk6/igt@i915_selftest@live@client.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk8/igt@i915_selftest@live@client.html
* igt@kms_big_joiner@basic:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#2705])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl9/igt@kms_big_joiner@basic.html
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2705])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-c-random-ccs-data:
- shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111304])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl9/igt@kms_ccs@pipe-c-random-ccs-data.html
* igt@kms_chamelium@dp-crc-fast:
- shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +15 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-snb5/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +16 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl2/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: NOTRUN -> [DMESG-WARN][25] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109284] / [fdo#111827])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +8 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +247 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-snb6/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#52] / [i915#54])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#52] / [i915#54])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl9/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl10/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-kbl: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#2628])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
- shard-apl: NOTRUN -> [FAIL][36] ([i915#2641])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#2672])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109280])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1188])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#533]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][43] ([fdo#108145] / [i915#265])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [i915#265]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#2733])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658]) +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109441]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-query-forked-busy:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271]) +89 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@kms_vblank@pipe-d-query-forked-busy.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +203 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl1/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2437])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@kms_writeback@writeback-fb-id.html
* igt@sysfs_clients@sema-10@rcs0:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3026]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@sysfs_clients@sema-10@rcs0.html
#### Possible fixes ####
* igt@gem_ctx_persistence@replace@vcs0:
- shard-iclb: [FAIL][55] ([i915#2410]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb3/igt@gem_ctx_persistence@replace@vcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@gem_ctx_persistence@replace@vcs0.html
* igt@gem_exec_balancer@hang:
- shard-iclb: [INCOMPLETE][57] ([i915#1895] / [i915#3031]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb2/igt@gem_exec_balancer@hang.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb3/igt@gem_exec_balancer@hang.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [FAIL][59] ([i915#2842]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl4/igt@gem_exec_fair@basic-none@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl6/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [FAIL][61] ([i915#2842]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk4/igt@gem_exec_fair@basic-none@vecs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk1/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-skl: [DMESG-WARN][63] ([i915#1610] / [i915#2803]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl9/igt@gem_exec_schedule@u-fairslice@vcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@gem_exec_schedule@u-fairslice@vcs0.html
* igt@gem_exec_schedule@u-fairslice@vcs1:
- shard-kbl: [DMESG-WARN][65] ([i915#1610] / [i915#2803]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl4/igt@gem_exec_schedule@u-fairslice@vcs1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl4/igt@gem_exec_schedule@u-fairslice@vcs1.html
* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [DMESG-WARN][67] ([i915#118] / [i915#95]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk8/igt@gem_exec_whisper@basic-fds-forked.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk9/igt@gem_exec_whisper@basic-fds-forked.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl5/igt@i915_module_load@reload-with-fault-injection.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl2/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][71] ([i915#2574]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
* igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b:
- shard-kbl: [FAIL][73] ([i915#3168]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-kbl3/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-kbl6/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][75] ([i915#2598]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][77] ([i915#180]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][79] ([i915#2122]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][81] ([i915#2122]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk8/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [INCOMPLETE][83] ([i915#198]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][87] ([i915#1542]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-glk7/igt@perf@polling-parameterized.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-glk6/igt@perf@polling-parameterized.html
* igt@sysfs_clients@split-10@bcs0:
- shard-apl: [SKIP][89] ([fdo#109271] / [i915#3026]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl7/igt@sysfs_clients@split-10@bcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl7/igt@sysfs_clients@split-10@bcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][91] ([i915#2684]) -> [WARN][92] ([i915#2681] / [i915#2684]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][93] ([i915#2920]) -> [SKIP][94] ([i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][95] ([i915#658]) -> [SKIP][96] ([i915#2920]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@runner@aborted:
- shard-apl: ([FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100]) ([i915#180] / [i915#3002]) -> ([FAIL][101], [FAIL][102], [FAIL][103]) ([i915#2724] / [i915#3002])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl1/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl6/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl1/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-apl6/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl6/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl2/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-apl2/igt@runner@aborted.html
- shard-skl: ([FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#2426] / [i915#2724] / [i915#3002]) -> ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#2724] / [i915#3002])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl6/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl9/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl4/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl9/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl2/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl2/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9889/shard-skl10/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl6/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl3/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl10/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl3/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl8/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/shard-skl7/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1699]: https://gitlab.freedesktop.org/drm/intel/issues/1699
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1895]: https://gitlab.freedesktop.org/drm/intel/issues/1895
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2574]: https://gitlab.freedesktop.org/drm/intel/issues/2574
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2628]: https://gitlab.freedesktop.org/drm/intel/issues/2628
[i915#2641]: https://gitlab.freedesktop.org/drm/intel/issues/2641
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3026]: https://gitlab.freedesktop.org/drm/intel/issues/3026
[i915#3031]: https://gitlab.freedesktop.org/drm/intel/issues/3031
[i915#3047]: https://gitlab.freedesktop.org/drm/intel/issues/3047
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3160]: https://gitlab.freedesktop.org/drm/intel/issues/3160
[i915#3168]: https://gitlab.freedesktop.org/drm/intel/issues/3168
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9889 -> Patchwork_19845
CI-20190529: 20190529
CI_DRM_9889: c42d2e7296ecebf00ae234a847059cc92e41a86c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6044: 2c2fc6470646eb5e25fc6ea02449ef744f8b70c2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19845: f7ab5bf2f99e03cced8a62378679548e551655b9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19845/index.html
[-- Attachment #1.2: Type: text/html, Size: 33105 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
@ 2021-03-25 6:51 ` Nautiyal, Ankit K
-1 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2021-03-25 6:51 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: maarten.lankhorst
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
On 3/24/2021 5:00 PM, Anshuman Gupta wrote:
> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
> authentication protocol in case transmitter has not received the
> entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
> within {110,7,5} miliseconds.
>
> Adding above msg timeout values and aborting the HDCP authentication
> in case it timedout to read entire msg.
>
> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>
> v2:
> - Removed redundant variable msg_can_timedout. [Ankit]
>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
> include/drm/drm_hdcp.h | 3 ++
> 2 files changed, 35 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index 40c516e90193..8bad4b3d34dd 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
> bool msg_detectable;
> u32 timeout;
> u32 timeout2; /* Added for non_paired situation */
> + /* Timeout to read entire msg */
> + u32 msg_read_timeout;
> };
>
> static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
> - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
> + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
> { HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
> - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, 0, 0, 0 },
> { HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, 0, 0, 0 },
> { HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
> true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
> + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_SEND_PAIRING_INFO,
> DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
> - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
> - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
> + HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
> + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
> { HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
> - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
> { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0 },
> { HDCP_2_2_REP_SEND_RECVID_LIST,
> DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
> - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
> + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
> { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0 },
> { HDCP_2_2_REP_STREAM_MANAGE,
> DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0},
> { HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
> - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
> /* local define to shovel this through the write_2_2 interface */
> #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
> { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
> @@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> u8 *byte = buf;
> ssize_t ret, bytes_to_recv, len;
> const struct hdcp2_dp_msg_data *hdcp2_msg_data;
> + ktime_t msg_end;
> + bool msg_expired;
>
> hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
> if (!hdcp2_msg_data)
> @@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
> DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
>
> + /* Entire msg read timeout since initiate of msg read */
> + if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
> + msg_end = ktime_add_ms(ktime_get_raw(),
> + hdcp2_msg_data->msg_read_timeout);
> +
> ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
> (void *)byte, len);
> if (ret < 0) {
> @@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> byte += ret;
> offset += ret;
> }
> +
> + if (hdcp2_msg_data->msg_read_timeout > 0) {
> + msg_expired = ktime_after(ktime_get_raw(), msg_end);
> + if (msg_expired) {
> + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
> + msg_id, hdcp2_msg_data->msg_read_timeout);
> + return -ETIMEDOUT;
> + }
> + }
> +
> byte = buf;
> *byte = msg_id;
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index ac22c246542a..2b165a0f434f 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
>
> /* HDCP2.2 TIMEOUTs in mSec */
> #define HDCP_2_2_CERT_TIMEOUT_MS 100
> +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
> #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
@ 2021-03-25 6:51 ` Nautiyal, Ankit K
0 siblings, 0 replies; 18+ messages in thread
From: Nautiyal, Ankit K @ 2021-03-25 6:51 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: maarten.lankhorst
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
On 3/24/2021 5:00 PM, Anshuman Gupta wrote:
> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
> authentication protocol in case transmitter has not received the
> entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
> within {110,7,5} miliseconds.
>
> Adding above msg timeout values and aborting the HDCP authentication
> in case it timedout to read entire msg.
>
> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>
> v2:
> - Removed redundant variable msg_can_timedout. [Ankit]
>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
> include/drm/drm_hdcp.h | 3 ++
> 2 files changed, 35 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index 40c516e90193..8bad4b3d34dd 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
> bool msg_detectable;
> u32 timeout;
> u32 timeout2; /* Added for non_paired situation */
> + /* Timeout to read entire msg */
> + u32 msg_read_timeout;
> };
>
> static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
> - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
> + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
> { HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
> - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, 0, 0, 0 },
> { HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, 0, 0, 0 },
> { HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
> true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
> + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_SEND_PAIRING_INFO,
> DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
> - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
> - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
> + HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
> + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
> { HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
> - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
> { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0 },
> { HDCP_2_2_REP_SEND_RECVID_LIST,
> DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
> - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
> + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
> { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0 },
> { HDCP_2_2_REP_STREAM_MANAGE,
> DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
> - 0, 0 },
> + 0, 0, 0},
> { HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
> - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
> + false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
> /* local define to shovel this through the write_2_2 interface */
> #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
> { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
> @@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> u8 *byte = buf;
> ssize_t ret, bytes_to_recv, len;
> const struct hdcp2_dp_msg_data *hdcp2_msg_data;
> + ktime_t msg_end;
> + bool msg_expired;
>
> hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
> if (!hdcp2_msg_data)
> @@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
> DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
>
> + /* Entire msg read timeout since initiate of msg read */
> + if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
> + msg_end = ktime_add_ms(ktime_get_raw(),
> + hdcp2_msg_data->msg_read_timeout);
> +
> ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
> (void *)byte, len);
> if (ret < 0) {
> @@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> byte += ret;
> offset += ret;
> }
> +
> + if (hdcp2_msg_data->msg_read_timeout > 0) {
> + msg_expired = ktime_after(ktime_get_raw(), msg_end);
> + if (msg_expired) {
> + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
> + msg_id, hdcp2_msg_data->msg_read_timeout);
> + return -ETIMEDOUT;
> + }
> + }
> +
> byte = buf;
> *byte = msg_id;
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index ac22c246542a..2b165a0f434f 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
>
> /* HDCP2.2 TIMEOUTs in mSec */
> #define HDCP_2_2_CERT_TIMEOUT_MS 100
> +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
> #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
@ 2021-03-25 13:39 ` Jani Nikula
-1 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-25 13:39 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: Thomas Zimmermann
On Wed, 24 Mar 2021, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
> as well.
>
> Anshuman Gupta (2):
> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
> drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
>
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
> include/drm/drm_hdcp.h | 5 ++-
> 2 files changed, 36 insertions(+), 14 deletions(-)
Maarten, Maxime, Thomas -
Can I get an ack for merging this via drm-intel-next, please?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata
@ 2021-03-25 13:39 ` Jani Nikula
0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-25 13:39 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: Thomas Zimmermann, Maxime Ripard
On Wed, 24 Mar 2021, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
> as well.
>
> Anshuman Gupta (2):
> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
> drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
>
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
> include/drm/drm_hdcp.h | 5 ++-
> 2 files changed, 36 insertions(+), 14 deletions(-)
Maarten, Maxime, Thomas -
Can I get an ack for merging this via drm-intel-next, please?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata
2021-03-25 13:39 ` Jani Nikula
@ 2021-03-31 10:22 ` Jani Nikula
-1 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-31 10:22 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: Thomas Zimmermann
On Thu, 25 Mar 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 24 Mar 2021, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
>> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
>> as well.
>>
>> Anshuman Gupta (2):
>> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
>> drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
>>
>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
>> include/drm/drm_hdcp.h | 5 ++-
>> 2 files changed, 36 insertions(+), 14 deletions(-)
>
> Maarten, Maxime, Thomas -
>
> Can I get an ack for merging this via drm-intel-next, please?
Ping! :)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata
@ 2021-03-31 10:22 ` Jani Nikula
0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-31 10:22 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx, dri-devel; +Cc: Thomas Zimmermann, Maxime Ripard
On Thu, 25 Mar 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 24 Mar 2021, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
>> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
>> as well.
>>
>> Anshuman Gupta (2):
>> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
>> drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
>>
>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
>> include/drm/drm_hdcp.h | 5 ++-
>> 2 files changed, 36 insertions(+), 14 deletions(-)
>
> Maarten, Maxime, Thomas -
>
> Can I get an ack for merging this via drm-intel-next, please?
Ping! :)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-03-25 6:51 ` [Intel-gfx] " Nautiyal, Ankit K
@ 2021-03-31 11:38 ` Jani Nikula
-1 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-31 11:38 UTC (permalink / raw)
To: Nautiyal, Ankit K, Anshuman Gupta, intel-gfx, dri-devel; +Cc: maarten.lankhorst
On Thu, 25 Mar 2021, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> LGTM.
>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Both patches pushed to drm-intel-next with Maxime's irc ack.
BR,
Jani.
>
> On 3/24/2021 5:00 PM, Anshuman Gupta wrote:
>> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
>> authentication protocol in case transmitter has not received the
>> entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
>> within {110,7,5} miliseconds.
>>
>> Adding above msg timeout values and aborting the HDCP authentication
>> in case it timedout to read entire msg.
>>
>> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>>
>> v2:
>> - Removed redundant variable msg_can_timedout. [Ankit]
>>
>> Cc: Ramalingam C <ramalingam.c@intel.com>
>> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
>> include/drm/drm_hdcp.h | 3 ++
>> 2 files changed, 35 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> index 40c516e90193..8bad4b3d34dd 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> @@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
>> bool msg_detectable;
>> u32 timeout;
>> u32 timeout2; /* Added for non_paired situation */
>> + /* Timeout to read entire msg */
>> + u32 msg_read_timeout;
>> };
>>
>> static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
>> - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
>> + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
>> { HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
>> - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
>> { HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
>> - false, 0, 0 },
>> + false, 0, 0, 0 },
>> { HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
>> - false, 0, 0 },
>> + false, 0, 0, 0 },
>> { HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
>> true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
>> - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
>> + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
>> { HDCP_2_2_AKE_SEND_PAIRING_INFO,
>> DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
>> - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
>> - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
>> + HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
>> + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
>> { HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
>> - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
>> { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0 },
>> { HDCP_2_2_REP_SEND_RECVID_LIST,
>> DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
>> - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
>> + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
>> { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0 },
>> { HDCP_2_2_REP_STREAM_MANAGE,
>> DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0},
>> { HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
>> - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
>> /* local define to shovel this through the write_2_2 interface */
>> #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
>> { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
>> @@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> u8 *byte = buf;
>> ssize_t ret, bytes_to_recv, len;
>> const struct hdcp2_dp_msg_data *hdcp2_msg_data;
>> + ktime_t msg_end;
>> + bool msg_expired;
>>
>> hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
>> if (!hdcp2_msg_data)
>> @@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
>> DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
>>
>> + /* Entire msg read timeout since initiate of msg read */
>> + if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
>> + msg_end = ktime_add_ms(ktime_get_raw(),
>> + hdcp2_msg_data->msg_read_timeout);
>> +
>> ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
>> (void *)byte, len);
>> if (ret < 0) {
>> @@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> byte += ret;
>> offset += ret;
>> }
>> +
>> + if (hdcp2_msg_data->msg_read_timeout > 0) {
>> + msg_expired = ktime_after(ktime_get_raw(), msg_end);
>> + if (msg_expired) {
>> + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
>> + msg_id, hdcp2_msg_data->msg_read_timeout);
>> + return -ETIMEDOUT;
>> + }
>> + }
>> +
>> byte = buf;
>> *byte = msg_id;
>>
>> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
>> index ac22c246542a..2b165a0f434f 100644
>> --- a/include/drm/drm_hdcp.h
>> +++ b/include/drm/drm_hdcp.h
>> @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
>>
>> /* HDCP2.2 TIMEOUTs in mSec */
>> #define HDCP_2_2_CERT_TIMEOUT_MS 100
>> +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
>> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
>> #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
>> +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
>> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
>> +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
>> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
>> #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
>> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
@ 2021-03-31 11:38 ` Jani Nikula
0 siblings, 0 replies; 18+ messages in thread
From: Jani Nikula @ 2021-03-31 11:38 UTC (permalink / raw)
To: Nautiyal, Ankit K, Anshuman Gupta, intel-gfx, dri-devel; +Cc: maarten.lankhorst
On Thu, 25 Mar 2021, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> LGTM.
>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Both patches pushed to drm-intel-next with Maxime's irc ack.
BR,
Jani.
>
> On 3/24/2021 5:00 PM, Anshuman Gupta wrote:
>> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
>> authentication protocol in case transmitter has not received the
>> entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
>> within {110,7,5} miliseconds.
>>
>> Adding above msg timeout values and aborting the HDCP authentication
>> in case it timedout to read entire msg.
>>
>> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>>
>> v2:
>> - Removed redundant variable msg_can_timedout. [Ankit]
>>
>> Cc: Ramalingam C <ramalingam.c@intel.com>
>> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++++++++++++++------
>> include/drm/drm_hdcp.h | 3 ++
>> 2 files changed, 35 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> index 40c516e90193..8bad4b3d34dd 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
>> @@ -294,37 +294,39 @@ struct hdcp2_dp_msg_data {
>> bool msg_detectable;
>> u32 timeout;
>> u32 timeout2; /* Added for non_paired situation */
>> + /* Timeout to read entire msg */
>> + u32 msg_read_timeout;
>> };
>>
>> static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
>> - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
>> + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0, 0},
>> { HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
>> - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
>> { HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
>> - false, 0, 0 },
>> + false, 0, 0, 0 },
>> { HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
>> - false, 0, 0 },
>> + false, 0, 0, 0 },
>> { HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
>> true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
>> - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
>> + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
>> { HDCP_2_2_AKE_SEND_PAIRING_INFO,
>> DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
>> - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
>> - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
>> + HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
>> + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0, 0 },
>> { HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
>> - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
>> { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0 },
>> { HDCP_2_2_REP_SEND_RECVID_LIST,
>> DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
>> - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
>> + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
>> { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0 },
>> { HDCP_2_2_REP_STREAM_MANAGE,
>> DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
>> - 0, 0 },
>> + 0, 0, 0},
>> { HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
>> - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
>> + false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
>> /* local define to shovel this through the write_2_2 interface */
>> #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
>> { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
>> @@ -513,6 +515,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> u8 *byte = buf;
>> ssize_t ret, bytes_to_recv, len;
>> const struct hdcp2_dp_msg_data *hdcp2_msg_data;
>> + ktime_t msg_end;
>> + bool msg_expired;
>>
>> hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
>> if (!hdcp2_msg_data)
>> @@ -539,6 +543,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
>> DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
>>
>> + /* Entire msg read timeout since initiate of msg read */
>> + if (bytes_to_recv == size - 1 && hdcp2_msg_data->msg_read_timeout > 0)
>> + msg_end = ktime_add_ms(ktime_get_raw(),
>> + hdcp2_msg_data->msg_read_timeout);
>> +
>> ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
>> (void *)byte, len);
>> if (ret < 0) {
>> @@ -551,6 +560,16 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
>> byte += ret;
>> offset += ret;
>> }
>> +
>> + if (hdcp2_msg_data->msg_read_timeout > 0) {
>> + msg_expired = ktime_after(ktime_get_raw(), msg_end);
>> + if (msg_expired) {
>> + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
>> + msg_id, hdcp2_msg_data->msg_read_timeout);
>> + return -ETIMEDOUT;
>> + }
>> + }
>> +
>> byte = buf;
>> *byte = msg_id;
>>
>> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
>> index ac22c246542a..2b165a0f434f 100644
>> --- a/include/drm/drm_hdcp.h
>> +++ b/include/drm/drm_hdcp.h
>> @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
>>
>> /* HDCP2.2 TIMEOUTs in mSec */
>> #define HDCP_2_2_CERT_TIMEOUT_MS 100
>> +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
>> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
>> #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
>> +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
>> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
>> +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
>> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
>> #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
>> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-03-31 11:38 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 11:30 [PATCH v2 0/2] HDCP 2.2 DP errata Anshuman Gupta
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
2021-03-24 11:30 ` [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
2021-03-25 6:51 ` Nautiyal, Ankit K
2021-03-25 6:51 ` [Intel-gfx] " Nautiyal, Ankit K
2021-03-31 11:38 ` Jani Nikula
2021-03-31 11:38 ` Jani Nikula
2021-03-24 11:30 ` [PATCH v2 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 Anshuman Gupta
2021-03-24 11:30 ` [Intel-gfx] " Anshuman Gupta
2021-03-24 12:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata (rev2) Patchwork
2021-03-24 12:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-24 12:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-24 22:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-25 13:39 ` [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata Jani Nikula
2021-03-25 13:39 ` Jani Nikula
2021-03-31 10:22 ` Jani Nikula
2021-03-31 10:22 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.