* [PATCH] tests/docker: Include 'ccache' in Debian base image
@ 2020-12-13 21:16 Philippe Mathieu-Daudé
2020-12-14 5:44 ` Thomas Huth
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-12-13 21:16 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé,
Philippe Mathieu-Daudé
Include the 'ccache' package to speed up compilation.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/docker/dockerfiles/debian10.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
index 73a3caac9cd..9d42b5a4b81 100644
--- a/tests/docker/dockerfiles/debian10.docker
+++ b/tests/docker/dockerfiles/debian10.docker
@@ -20,6 +20,7 @@ RUN apt update && \
bc \
build-essential \
ca-certificates \
+ ccache \
clang \
dbus \
gdb-multiarch \
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/docker: Include 'ccache' in Debian base image
2020-12-13 21:16 [PATCH] tests/docker: Include 'ccache' in Debian base image Philippe Mathieu-Daudé
@ 2020-12-14 5:44 ` Thomas Huth
2020-12-14 13:39 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2020-12-14 5:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote:
> Include the 'ccache' package to speed up compilation.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/dockerfiles/debian10.docker | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
> index 73a3caac9cd..9d42b5a4b81 100644
> --- a/tests/docker/dockerfiles/debian10.docker
> +++ b/tests/docker/dockerfiles/debian10.docker
> @@ -20,6 +20,7 @@ RUN apt update && \
> bc \
> build-essential \
> ca-certificates \
> + ccache \
> clang \
> dbus \
> gdb-multiarch \
Don't you need some additional setup for this? Like caching the
corresponding directory during CI runs?
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/docker: Include 'ccache' in Debian base image
2020-12-14 5:44 ` Thomas Huth
@ 2020-12-14 13:39 ` Philippe Mathieu-Daudé
2021-01-05 10:59 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-12-14 13:39 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
Hi Thomas,
On 12/14/20 6:44 AM, Thomas Huth wrote:
> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote:
>> Include the 'ccache' package to speed up compilation.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> tests/docker/dockerfiles/debian10.docker | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
>> index 73a3caac9cd..9d42b5a4b81 100644
>> --- a/tests/docker/dockerfiles/debian10.docker
>> +++ b/tests/docker/dockerfiles/debian10.docker
>> @@ -20,6 +20,7 @@ RUN apt update && \
>> bc \
>> build-essential \
>> ca-certificates \
>> + ccache \
>> clang \
>> dbus \
>> gdb-multiarch \
>
> Don't you need some additional setup for this? Like caching the
> corresponding directory during CI runs?
I hadn't looked at CI (too many CI series in fly).
w.r.t. Docker this is in use since 4 years, see:
324027c24cd ("Makefile: Rules for docker testing")
36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")
I suppose we forgot the package when introducing debian10
base image in commit d6db2a1cdf6 ("docker: add
debian-buster-arm64-cross").
Regards,
Phil.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/docker: Include 'ccache' in Debian base image
2020-12-14 13:39 ` Philippe Mathieu-Daudé
@ 2021-01-05 10:59 ` Philippe Mathieu-Daudé
2021-01-05 12:48 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-05 10:59 UTC (permalink / raw)
To: Thomas Huth, Alex Bennée; +Cc: Fam Zheng, qemu-devel
Hi,
On 12/14/20 2:39 PM, Philippe Mathieu-Daudé wrote:
> On 12/14/20 6:44 AM, Thomas Huth wrote:
>> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote:
>>> Include the 'ccache' package to speed up compilation.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> tests/docker/dockerfiles/debian10.docker | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
>>> index 73a3caac9cd..9d42b5a4b81 100644
>>> --- a/tests/docker/dockerfiles/debian10.docker
>>> +++ b/tests/docker/dockerfiles/debian10.docker
>>> @@ -20,6 +20,7 @@ RUN apt update && \
>>> bc \
>>> build-essential \
>>> ca-certificates \
>>> + ccache \
>>> clang \
>>> dbus \
>>> gdb-multiarch \
>>
>> Don't you need some additional setup for this? Like caching the
>> corresponding directory during CI runs?
>
> I hadn't looked at CI (too many CI series in fly).
>
> w.r.t. Docker this is in use since 4 years, see:
> 324027c24cd ("Makefile: Rules for docker testing")
> 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")
>
> I suppose we forgot the package when introducing debian10
> base image in commit d6db2a1cdf6 ("docker: add
> debian-buster-arm64-cross").
Should I do something else with this patch?
Thanks,
Phil.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/docker: Include 'ccache' in Debian base image
2021-01-05 10:59 ` Philippe Mathieu-Daudé
@ 2021-01-05 12:48 ` Alex Bennée
0 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2021-01-05 12:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Fam Zheng, Thomas Huth, qemu-devel
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Hi,
>
> On 12/14/20 2:39 PM, Philippe Mathieu-Daudé wrote:
>> On 12/14/20 6:44 AM, Thomas Huth wrote:
>>> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote:
>>>> Include the 'ccache' package to speed up compilation.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> tests/docker/dockerfiles/debian10.docker | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker
>>>> index 73a3caac9cd..9d42b5a4b81 100644
>>>> --- a/tests/docker/dockerfiles/debian10.docker
>>>> +++ b/tests/docker/dockerfiles/debian10.docker
>>>> @@ -20,6 +20,7 @@ RUN apt update && \
>>>> bc \
>>>> build-essential \
>>>> ca-certificates \
>>>> + ccache \
>>>> clang \
>>>> dbus \
>>>> gdb-multiarch \
>>>
>>> Don't you need some additional setup for this? Like caching the
>>> corresponding directory during CI runs?
>>
>> I hadn't looked at CI (too many CI series in fly).
>>
>> w.r.t. Docker this is in use since 4 years, see:
>> 324027c24cd ("Makefile: Rules for docker testing")
>> 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")
>>
>> I suppose we forgot the package when introducing debian10
>> base image in commit d6db2a1cdf6 ("docker: add
>> debian-buster-arm64-cross").
>
> Should I do something else with this patch?
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-05 12:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-13 21:16 [PATCH] tests/docker: Include 'ccache' in Debian base image Philippe Mathieu-Daudé
2020-12-14 5:44 ` Thomas Huth
2020-12-14 13:39 ` Philippe Mathieu-Daudé
2021-01-05 10:59 ` Philippe Mathieu-Daudé
2021-01-05 12:48 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.