From: Michael Ellerman <mpe@ellerman.id.au>
To: Markus Elfring <Markus.Elfring@web.de>,
Liao Pingfang <liao.pingfang@zte.com.cn>,
linuxppc-dev@lists.ozlabs.org
Cc: Allison Randal <allison@lohutok.net>,
Anton Vorontsov <anton@enomsg.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Colin Cross <ccross@android.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>,
Wang Liang <wang.liang82@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message
Date: Tue, 02 Jun 2020 12:57:11 +1000 [thread overview]
Message-ID: <87imgai394.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <c3d22d89-9133-30aa-8270-c515df214963@web.de>
Markus Elfring <Markus.Elfring@web.de> writes:
>> Please just remove the message instead, it's a tiny allocation that's
>> unlikely to ever fail, and the caller will print an error anyway.
>
> How do you think about to take another look at a previous update suggestion
> like the following?
>
> powerpc/nvram: Delete three error messages for a failed memory allocation
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/linuxppc-dev/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/752720/
> https://lkml.org/lkml/2017/1/19/537
That deleted the messages from nvram_scan_partitions(), but neither of
the callers of nvram_scan_paritions() check its return value or print
anything if it fails. So removing those messages would make those
failures silent which is not what we want.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Markus Elfring <Markus.Elfring@web.de>,
Liao Pingfang <liao.pingfang@zte.com.cn>,
linuxppc-dev@lists.ozlabs.org
Cc: Yi Wang <wang.yi59@zte.com.cn>, Tony Luck <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Wang Liang <wang.liang82@zte.com.cn>,
Anton Vorontsov <anton@enomsg.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
Paul Mackerras <paulus@samba.org>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message
Date: Tue, 02 Jun 2020 02:57:11 +0000 [thread overview]
Message-ID: <87imgai394.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <c3d22d89-9133-30aa-8270-c515df214963@web.de>
Markus Elfring <Markus.Elfring@web.de> writes:
>> Please just remove the message instead, it's a tiny allocation that's
>> unlikely to ever fail, and the caller will print an error anyway.
>
> How do you think about to take another look at a previous update suggestion
> like the following?
>
> powerpc/nvram: Delete three error messages for a failed memory allocation
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/linuxppc-dev/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/752720/
> https://lkml.org/lkml/2017/1/19/537
That deleted the messages from nvram_scan_partitions(), but neither of
the callers of nvram_scan_paritions() check its return value or print
anything if it fails. So removing those messages would make those
failures silent which is not what we want.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Markus Elfring <Markus.Elfring@web.de>,
Liao Pingfang <liao.pingfang@zte.com.cn>,
linuxppc-dev@lists.ozlabs.org
Cc: Yi Wang <wang.yi59@zte.com.cn>, Tony Luck <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Wang Liang <wang.liang82@zte.com.cn>,
Anton Vorontsov <anton@enomsg.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
Paul Mackerras <paulus@samba.org>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message
Date: Tue, 02 Jun 2020 12:57:11 +1000 [thread overview]
Message-ID: <87imgai394.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <c3d22d89-9133-30aa-8270-c515df214963@web.de>
Markus Elfring <Markus.Elfring@web.de> writes:
>> Please just remove the message instead, it's a tiny allocation that's
>> unlikely to ever fail, and the caller will print an error anyway.
>
> How do you think about to take another look at a previous update suggestion
> like the following?
>
> powerpc/nvram: Delete three error messages for a failed memory allocation
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/linuxppc-dev/00845261-8528-d011-d3b8-e9355a231d3a@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/752720/
> https://lkml.org/lkml/2017/1/19/537
That deleted the messages from nvram_scan_partitions(), but neither of
the callers of nvram_scan_paritions() check its return value or print
anything if it fails. So removing those messages would make those
failures silent which is not what we want.
cheers
next prev parent reply other threads:[~2020-06-02 2:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 18:50 [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message Markus Elfring
2020-05-29 18:50 ` Markus Elfring
2020-05-29 18:50 ` Markus Elfring
2020-06-02 2:57 ` Michael Ellerman [this message]
2020-06-02 2:57 ` Michael Ellerman
2020-06-02 2:57 ` Michael Ellerman
2020-06-02 5:01 ` Markus Elfring
2020-06-02 5:01 ` Markus Elfring
2020-06-02 5:01 ` Markus Elfring
2020-06-02 11:23 ` Michael Ellerman
2020-06-02 11:23 ` Michael Ellerman
2020-06-02 11:23 ` Michael Ellerman
2020-06-02 11:41 ` Dan Carpenter
2020-06-02 11:41 ` Dan Carpenter
2020-06-02 11:41 ` Dan Carpenter
2020-06-03 11:37 ` Michael Ellerman
2020-06-03 11:37 ` Michael Ellerman
2020-06-03 11:37 ` Michael Ellerman
2020-06-03 13:18 ` Dan Carpenter
2020-06-03 13:18 ` Dan Carpenter
2020-06-03 13:18 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-05-29 1:02 Yi Wang
2020-05-29 1:02 ` Yi Wang
2020-05-29 4:04 ` Michael Ellerman
2020-05-29 4:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imgai394.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Markus.Elfring@web.de \
--cc=allison@lohutok.net \
--cc=anton@enomsg.org \
--cc=benh@kernel.crashing.org \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.