[PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

[PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

[Rick Veens]

The following:
 bool efuse_re_pg_sec1flag;
 u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.

Signed-off-by: Rick Veens <rickveens92@gmail.com>
---
 drivers/staging/rtlwifi/wifi.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
index a45f0eb..9cb6c79 100644
--- a/drivers/staging/rtlwifi/wifi.h
+++ b/drivers/staging/rtlwifi/wifi.h
@@ -1840,10 +1840,6 @@ struct rtl_efuse {
 	u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
 	u16 efuse_usedbytes;
 	u8 efuse_usedpercentage;
-#ifdef EFUSE_REPG_WORKAROUND
-	bool efuse_re_pg_sec1flag;
-	u8 efuse_re_pg_data[8];
-#endif
 
 	u8 autoload_failflag;
 	u8 autoload_status;
-- 
2.1.4

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

[Joe Perches]

On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> The following:
>  bool efuse_re_pg_sec1flag;
>  u8 efuse_re_pg_data[8];
> are not referenced anywhere in the rtlwifi code.
> 
> Signed-off-by: Rick Veens <rickveens92@gmail.com>
> ---
>  drivers/staging/rtlwifi/wifi.h | 4 ----

Presumably the equivalent uses in
	drivers/net/wireless/realtek/rtlwifi/wifi.h
should be removed as well.

> diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
[]
> @@ -1840,10 +1840,6 @@ struct rtl_efuse {
>  	u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
>  	u16 efuse_usedbytes;
>  	u8 efuse_usedpercentage;
> -#ifdef EFUSE_REPG_WORKAROUND
> -	bool efuse_re_pg_sec1flag;
> -	u8 efuse_re_pg_data[8];
> -#endif
>  
>  	u8 autoload_failflag;
>  	u8 autoload_status;

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

[Kalle Valo]

Joe Perches <joe@perches.com> writes:

> On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
>> The following:
>>  bool efuse_re_pg_sec1flag;
>>  u8 efuse_re_pg_data[8];
>> are not referenced anywhere in the rtlwifi code.
>> 
>> Signed-off-by: Rick Veens <rickveens92@gmail.com>
>> ---
>>  drivers/staging/rtlwifi/wifi.h | 4 ----
>
> Presumably the equivalent uses in
> 	drivers/net/wireless/realtek/rtlwifi/wifi.h
> should be removed as well.

But if it's needed, just do it in separate patch as the patches go via
different trees.

-- 
Kalle Valo

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

[Pkshih]

On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> 
> > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> >> The following:
> >>  bool efuse_re_pg_sec1flag;
> >>  u8 efuse_re_pg_data[8];
> >> are not referenced anywhere in the rtlwifi code.
> >> 
> >> Signed-off-by: Rick Veens <rickveens92@gmail.com>
> >> ---
> >>  drivers/staging/rtlwifi/wifi.h | 4 ----
> >
> > Presumably the equivalent uses in
> > 	drivers/net/wireless/realtek/rtlwifi/wifi.h
> > should be removed as well.
> 
> But if it's needed, just do it in separate patch as the patches go via
> different trees.
> 

I can send this patch.

--
PK