* [PATCH] ath10k: release pre_cal_file while unloading driver
@ 2016-04-26 8:43 ` Rajkumar Manoharan
0 siblings, 0 replies; 4+ messages in thread
From: Rajkumar Manoharan @ 2016-04-26 8:43 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, rmanohar, Rajkumar Manoharan
Failing to release pre_cal_file caldata on deinit causes memory leak.
Fixes: b131129d9657 ("ath10k: fix calibration init sequence of qca99x0")
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 5f846bd4054c..6e37184abab6 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -712,6 +712,9 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar)
if (!IS_ERR(ar->cal_file))
release_firmware(ar->cal_file);
+ if (!IS_ERR(ar->pre_cal_file))
+ release_firmware(ar->pre_cal_file);
+
ath10k_swap_code_seg_release(ar);
ar->otp = NULL;
@@ -723,6 +726,7 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar)
ar->firmware_len = 0;
ar->cal_file = NULL;
+ ar->pre_cal_file = NULL;
}
static int ath10k_fetch_cal_file(struct ath10k *ar)
--
2.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath10k: release pre_cal_file while unloading driver
@ 2016-04-26 8:43 ` Rajkumar Manoharan
0 siblings, 0 replies; 4+ messages in thread
From: Rajkumar Manoharan @ 2016-04-26 8:43 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan, rmanohar
Failing to release pre_cal_file caldata on deinit causes memory leak.
Fixes: b131129d9657 ("ath10k: fix calibration init sequence of qca99x0")
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 5f846bd4054c..6e37184abab6 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -712,6 +712,9 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar)
if (!IS_ERR(ar->cal_file))
release_firmware(ar->cal_file);
+ if (!IS_ERR(ar->pre_cal_file))
+ release_firmware(ar->pre_cal_file);
+
ath10k_swap_code_seg_release(ar);
ar->otp = NULL;
@@ -723,6 +726,7 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar)
ar->firmware_len = 0;
ar->cal_file = NULL;
+ ar->pre_cal_file = NULL;
}
static int ath10k_fetch_cal_file(struct ath10k *ar)
--
2.8.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: release pre_cal_file while unloading driver
2016-04-26 8:43 ` Rajkumar Manoharan
@ 2016-04-26 12:05 ` Valo, Kalle
-1 siblings, 0 replies; 4+ messages in thread
From: Valo, Kalle @ 2016-04-26 12:05 UTC (permalink / raw)
To: Manoharan, Rajkumar; +Cc: ath10k, linux-wireless, rmanohar
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Failing to release pre_cal_file caldata on deinit causes memory leak.
>
> Fixes: b131129d9657 ("ath10k: fix calibration init sequence of qca99x0")
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Doesn't apply, please rebase.
Applying: ath10k: release pre_cal_file while unloading driver
fatal: sha1 information is lacking or useless (drivers/net/wireless/ath/ath10k/core.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 ath10k: release pre_cal_file while unloading driver
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: release pre_cal_file while unloading driver
@ 2016-04-26 12:05 ` Valo, Kalle
0 siblings, 0 replies; 4+ messages in thread
From: Valo, Kalle @ 2016-04-26 12:05 UTC (permalink / raw)
To: Manoharan, Rajkumar; +Cc: linux-wireless, rmanohar, ath10k
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Failing to release pre_cal_file caldata on deinit causes memory leak.
>
> Fixes: b131129d9657 ("ath10k: fix calibration init sequence of qca99x0")
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Doesn't apply, please rebase.
Applying: ath10k: release pre_cal_file while unloading driver
fatal: sha1 information is lacking or useless (drivers/net/wireless/ath/ath10k/core.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 ath10k: release pre_cal_file while unloading driver
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-26 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-26 8:43 [PATCH] ath10k: release pre_cal_file while unloading driver Rajkumar Manoharan
2016-04-26 8:43 ` Rajkumar Manoharan
2016-04-26 12:05 ` Valo, Kalle
2016-04-26 12:05 ` Valo, Kalle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.