All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: gpio: reborn necessary prop
@ 2014-02-13  3:39 ` Kuninori Morimoto
  0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2014-02-13  3:39 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, Lee Jones, Simon, Magnus, Linux-SH, linux-kernel

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

934624d6e9f0b3d41557c4105c286e8daeaadb4e
(regulator: gpio-regulator: do not open-code counting and access of dt array elements)
removed struct property *prop from of_get_gpio_regulator_config()
but, it is still used on
0094050d783bbadffe83effef11a0bda901153ce
(regulator: gpio: add gpios-status for DT)

Compile will fail without this patch

gpio-regulator.c: In function 'of_get_gpio_regulator_config':
gpio-regulator.c:174:2: error: 'prop' undeclared (first use in this function)
gpio-regulator.c:174:2: note: each undeclared identifier is reported \
	only once for each function it appears in

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
This is for latest mark-regulator/topic/gpio branch

 drivers/regulator/gpio-regulator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 9fd5561..20248c1 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -136,6 +136,7 @@ static struct gpio_regulator_config *
 of_get_gpio_regulator_config(struct device *dev, struct device_node *np)
 {
 	struct gpio_regulator_config *config;
+	struct property *prop;
 	const char *regtype;
 	int proplen, gpio, i;
 	int ret;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] regulator: gpio: reborn necessary prop
@ 2014-02-13  3:39 ` Kuninori Morimoto
  0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2014-02-13  3:39 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, Lee Jones, Simon, Magnus, Linux-SH, linux-kernel

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

934624d6e9f0b3d41557c4105c286e8daeaadb4e
(regulator: gpio-regulator: do not open-code counting and access of dt array elements)
removed struct property *prop from of_get_gpio_regulator_config()
but, it is still used on
0094050d783bbadffe83effef11a0bda901153ce
(regulator: gpio: add gpios-status for DT)

Compile will fail without this patch

gpio-regulator.c: In function 'of_get_gpio_regulator_config':
gpio-regulator.c:174:2: error: 'prop' undeclared (first use in this function)
gpio-regulator.c:174:2: note: each undeclared identifier is reported \
	only once for each function it appears in

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
This is for latest mark-regulator/topic/gpio branch

 drivers/regulator/gpio-regulator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 9fd5561..20248c1 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -136,6 +136,7 @@ static struct gpio_regulator_config *
 of_get_gpio_regulator_config(struct device *dev, struct device_node *np)
 {
 	struct gpio_regulator_config *config;
+	struct property *prop;
 	const char *regtype;
 	int proplen, gpio, i;
 	int ret;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: gpio: reborn necessary prop
  2014-02-13  3:39 ` Kuninori Morimoto
  (?)
@ 2014-02-13 19:03 ` Mark Brown
  -1 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-13 19:03 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Liam Girdwood, Lee Jones, Simon, Magnus, Linux-SH, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

On Wed, Feb 12, 2014 at 07:39:07PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> 934624d6e9f0b3d41557c4105c286e8daeaadb4e
> (regulator: gpio-regulator: do not open-code counting and access of dt array elements)
> removed struct property *prop from of_get_gpio_regulator_config()
> but, it is still used on
> 0094050d783bbadffe83effef11a0bda901153ce
> (regulator: gpio: add gpios-status for DT)

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-13 19:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-13  3:39 [PATCH] regulator: gpio: reborn necessary prop Kuninori Morimoto
2014-02-13  3:39 ` Kuninori Morimoto
2014-02-13 19:03 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.