* [PATCH] mtd: Replace the dangerous to_fsl_upm_nand macro with an inline function
@ 2010-03-23 17:08 Ferenc Wagner
2010-04-08 8:32 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Ferenc Wagner @ 2010-03-23 17:08 UTC (permalink / raw)
To: linux-kernel, linux-mtd
The original macro worked only when applied to variables named 'mtd'.
While this could have been fixed by simply renaming the macro argument,
a more type-safe replacement is preferred.
Signed-off-by: Ferenc Wagner <wferi@niif.hu>
---
drivers/mtd/nand/fsl_upm.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd/nand/fsl_upm.c
index 071a60c..02d1688 100644
--- a/drivers/mtd/nand/fsl_upm.c
+++ b/drivers/mtd/nand/fsl_upm.c
@@ -48,7 +48,10 @@ struct fsl_upm_nand {
uint32_t wait_flags;
};
-#define to_fsl_upm_nand(mtd) container_of(mtd, struct fsl_upm_nand, mtd)
+inline struct fsl_upm_nand *to_fsl_upm_nand(struct mtd_info *mtdinfo)
+{
+ return container_of(mtdinfo, struct fsl_upm_nand, mtd);
+}
static int fun_chip_ready(struct mtd_info *mtd)
{
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: Replace the dangerous to_fsl_upm_nand macro with an inline function
2010-03-23 17:08 [PATCH] mtd: Replace the dangerous to_fsl_upm_nand macro with an inline function Ferenc Wagner
@ 2010-04-08 8:32 ` Artem Bityutskiy
0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2010-04-08 8:32 UTC (permalink / raw)
To: Ferenc Wagner; +Cc: linux-kernel, linux-mtd
On Tue, 2010-03-23 at 18:08 +0100, Ferenc Wagner wrote:
> The original macro worked only when applied to variables named 'mtd'.
> While this could have been fixed by simply renaming the macro argument,
> a more type-safe replacement is preferred.
>
> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
Pushed this and the other similar patch of yours to my l2-mtd-2.6.git /
master, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: Replace the dangerous to_fsl_upm_nand macro with an inline function
@ 2010-04-08 8:32 ` Artem Bityutskiy
0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2010-04-08 8:32 UTC (permalink / raw)
To: Ferenc Wagner; +Cc: linux-mtd, linux-kernel
On Tue, 2010-03-23 at 18:08 +0100, Ferenc Wagner wrote:
> The original macro worked only when applied to variables named 'mtd'.
> While this could have been fixed by simply renaming the macro argument,
> a more type-safe replacement is preferred.
>
> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
Pushed this and the other similar patch of yours to my l2-mtd-2.6.git /
master, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-08 8:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-23 17:08 [PATCH] mtd: Replace the dangerous to_fsl_upm_nand macro with an inline function Ferenc Wagner
2010-04-08 8:32 ` Artem Bityutskiy
2010-04-08 8:32 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.