All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] errno.3: ENODATA is an XSI STREAMS extension
@ 2021-03-19 23:57 Alejandro Colomar
  2021-03-20  9:58 ` Jakub Wilk
  0 siblings, 1 reply; 10+ messages in thread
From: Alejandro Colomar @ 2021-03-19 23:57 UTC (permalink / raw)
  To: mtk.manpages; +Cc: Alejandro Colomar, linux-man, Mark Kettenis

Reported-by: Mark Kettenis <kettenis@openbsd.org>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man3/errno.3 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man3/errno.3 b/man3/errno.3
index fe9b7f715..48e3e63f3 100644
--- a/man3/errno.3
+++ b/man3/errno.3
@@ -403,7 +403,8 @@ No buffer space available (POSIX.1 (XSI STREAMS option)).
 .\" ENOCSI is defined but appears to be unused.
 .TP
 .B ENODATA
-No message is available on the STREAM head read queue (POSIX.1-2001).
+No message is available on the STREAM head read queue
+(POSIX.1-2001 (XSI STREAMS option).
 .TP
 .B ENODEV
 No such device (POSIX.1-2001).
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-19 23:57 [PATCH] errno.3: ENODATA is an XSI STREAMS extension Alejandro Colomar
@ 2021-03-20  9:58 ` Jakub Wilk
  2021-03-20 11:41   ` Alejandro Colomar (man-pages)
  0 siblings, 1 reply; 10+ messages in thread
From: Jakub Wilk @ 2021-03-20  9:58 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: Michael Kerrisk, linux-man, Mark Kettenis

* Alejandro Colomar <alx.manpages@gmail.com>, 2021-03-20, 00:57:
>-No message is available on the STREAM head read queue (POSIX.1-2001).
>+No message is available on the STREAM head read queue
>+(POSIX.1-2001 (XSI STREAMS option).

The parentheses are unbalanced.

-- 
Jakub Wilk

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-20  9:58 ` Jakub Wilk
@ 2021-03-20 11:41   ` Alejandro Colomar (man-pages)
  2021-03-20 11:42     ` [PATCH v2] " Alejandro Colomar
  0 siblings, 1 reply; 10+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-03-20 11:41 UTC (permalink / raw)
  To: Jakub Wilk; +Cc: Michael Kerrisk, linux-man, Mark Kettenis



On 3/20/21 10:58 AM, Jakub Wilk wrote:
> * Alejandro Colomar <alx.manpages@gmail.com>, 2021-03-20, 00:57:
>> -No message is available on the STREAM head read queue (POSIX.1-2001).
>> +No message is available on the STREAM head read queue
>> +(POSIX.1-2001 (XSI STREAMS option).
> 
> The parentheses are unbalanced.

D'oh!

Thanks,

Alex

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-20 11:41   ` Alejandro Colomar (man-pages)
@ 2021-03-20 11:42     ` Alejandro Colomar
  2021-03-20 19:08       ` Florian Weimer
  0 siblings, 1 reply; 10+ messages in thread
From: Alejandro Colomar @ 2021-03-20 11:42 UTC (permalink / raw)
  To: mtk.manpages; +Cc: Alejandro Colomar, linux-man, Mark Kettenis

Reported-by: Mark Kettenis <kettenis@openbsd.org>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man3/errno.3 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man3/errno.3 b/man3/errno.3
index fe9b7f715..48e3e63f3 100644
--- a/man3/errno.3
+++ b/man3/errno.3
@@ -403,7 +403,8 @@ No buffer space available (POSIX.1 (XSI STREAMS option)).
 .\" ENOCSI is defined but appears to be unused.
 .TP
 .B ENODATA
-No message is available on the STREAM head read queue (POSIX.1-2001).
+No message is available on the STREAM head read queue
+(POSIX.1-2001 (XSI STREAMS option)).
 .TP
 .B ENODEV
 No such device (POSIX.1-2001).
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-20 11:42     ` [PATCH v2] " Alejandro Colomar
@ 2021-03-20 19:08       ` Florian Weimer
  2021-03-20 19:31         ` Alejandro Colomar (man-pages)
  0 siblings, 1 reply; 10+ messages in thread
From: Florian Weimer @ 2021-03-20 19:08 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: mtk.manpages, linux-man, Mark Kettenis

* Alejandro Colomar:

> Reported-by: Mark Kettenis <kettenis@openbsd.org>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>  man3/errno.3 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man3/errno.3 b/man3/errno.3
> index fe9b7f715..48e3e63f3 100644
> --- a/man3/errno.3
> +++ b/man3/errno.3
> @@ -403,7 +403,8 @@ No buffer space available (POSIX.1 (XSI STREAMS option)).
>  .\" ENOCSI is defined but appears to be unused.
>  .TP
>  .B ENODATA
> -No message is available on the STREAM head read queue (POSIX.1-2001).
> +No message is available on the STREAM head read queue
> +(POSIX.1-2001 (XSI STREAMS option)).
>  .TP
>  .B ENODEV
>  No such device (POSIX.1-2001).

Would it make sense to mention that this error code is reused for
extended attributes?

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-20 19:08       ` Florian Weimer
@ 2021-03-20 19:31         ` Alejandro Colomar (man-pages)
  2021-03-20 19:41           ` Florian Weimer
  0 siblings, 1 reply; 10+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-03-20 19:31 UTC (permalink / raw)
  To: Florian Weimer; +Cc: mtk.manpages, linux-man, Mark Kettenis

Hi Florian,

On 3/20/21 8:08 PM, Florian Weimer wrote:
> 
> Would it make sense to mention that this error code is reused for
> extended attributes?
> 

Hmm, I think so.  In fact, AFAICS in the man-pages, it is only used for
that:

[
$ grep -rn ENODATA man?
man2/setxattr.2:124:.B ENODATA
man2/setxattr.2:129:.\" .BR ENODATA
man2/getxattr.2:118:.B ENODATA
man2/getxattr.2:123:.\" .BR ENODATA
man2/removexattr.2:85:.B ENODATA
man2/removexattr.2:89:.\" .BR ENODATA
man3/errno.3:405:.B ENODATA
]

Proposal:

[
       ENODATA
              The  named  attribute does not exist, or the process
              has no access to this attribute.

              In POSIX.1-2001 (XSI STREAMS option), this error was
              described as  "No message is available on the STREAM
              head read queue".

]

What do you think about it?

Thanks,

Alex


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] errno.3: ENODATA is an XSI STREAMS extension
  2021-03-20 19:31         ` Alejandro Colomar (man-pages)
@ 2021-03-20 19:41           ` Florian Weimer
  2021-03-20 20:01             ` [PATCH v3] errno.3: Fix ENODATA text Alejandro Colomar
  0 siblings, 1 reply; 10+ messages in thread
From: Florian Weimer @ 2021-03-20 19:41 UTC (permalink / raw)
  To: Alejandro Colomar (man-pages); +Cc: mtk.manpages, linux-man, Mark Kettenis

* Alejandro Colomar:

> Proposal:
>
> [
>        ENODATA
>               The  named  attribute does not exist, or the process
>               has no access to this attribute.
>
>               In POSIX.1-2001 (XSI STREAMS option), this error was
>               described as  "No message is available on the STREAM
>               head read queue".
>
> ]
>
> What do you think about it?

Please reference xattr(7), so that it's clear what kind of attributes
are meant here.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v3] errno.3: Fix ENODATA text
  2021-03-20 19:41           ` Florian Weimer
@ 2021-03-20 20:01             ` Alejandro Colomar
  2021-04-04 20:16               ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 10+ messages in thread
From: Alejandro Colomar @ 2021-03-20 20:01 UTC (permalink / raw)
  To: mtk.manpages; +Cc: Alejandro Colomar, linux-man, Mark Kettenis, Florian Weimer

ENODATA is an XSI STREAMS extension (not base POSIX).

Linux reused the name for extended attributes.
The current manual pages don't use ENODATA with its POSIX
meaning, so use the xattr(7) specific text, and leave the POSIX
meaning for a secondary paragraph.

Reported-by: Mark Kettenis <kettenis@openbsd.org>
Reported-by: Florian Weimer <fw@deneb.enyo.de>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man3/errno.3 | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/man3/errno.3 b/man3/errno.3
index fe9b7f715..eeb885823 100644
--- a/man3/errno.3
+++ b/man3/errno.3
@@ -403,7 +403,13 @@ No buffer space available (POSIX.1 (XSI STREAMS option)).
 .\" ENOCSI is defined but appears to be unused.
 .TP
 .B ENODATA
-No message is available on the STREAM head read queue (POSIX.1-2001).
+The named attribute does not exist,
+or the process has no access to this attribute; see
+.BR xattr (7).
+.IP
+In POSIX.1-2001 (XSI STREAMS option),
+this error was described as
+"No message is available on the STREAM head read queue".
 .TP
 .B ENODEV
 No such device (POSIX.1-2001).
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v3] errno.3: Fix ENODATA text
  2021-03-20 20:01             ` [PATCH v3] errno.3: Fix ENODATA text Alejandro Colomar
@ 2021-04-04 20:16               ` Michael Kerrisk (man-pages)
  2021-04-04 20:17                 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-04-04 20:16 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: mtk.manpages, linux-man, Mark Kettenis, Florian Weimer

Hi Alex,

On 3/20/21 9:01 PM, Alejandro Colomar wrote:
> ENODATA is an XSI STREAMS extension (not base POSIX).
> 
> Linux reused the name for extended attributes.
> The current manual pages don't use ENODATA with its POSIX
> meaning, so use the xattr(7) specific text, and leave the POSIX
> meaning for a secondary paragraph.

Thanks. Nice work on improving the patch!

Cheers,

Michael

> 
> Reported-by: Mark Kettenis <kettenis@openbsd.org>
> Reported-by: Florian Weimer <fw@deneb.enyo.de>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>  man3/errno.3 | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/man3/errno.3 b/man3/errno.3
> index fe9b7f715..eeb885823 100644
> --- a/man3/errno.3
> +++ b/man3/errno.3
> @@ -403,7 +403,13 @@ No buffer space available (POSIX.1 (XSI STREAMS option)).
>  .\" ENOCSI is defined but appears to be unused.
>  .TP
>  .B ENODATA
> -No message is available on the STREAM head read queue (POSIX.1-2001).
> +The named attribute does not exist,
> +or the process has no access to this attribute; see
> +.BR xattr (7).
> +.IP
> +In POSIX.1-2001 (XSI STREAMS option),
> +this error was described as
> +"No message is available on the STREAM head read queue".
>  .TP
>  .B ENODEV
>  No such device (POSIX.1-2001).
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v3] errno.3: Fix ENODATA text
  2021-04-04 20:16               ` Michael Kerrisk (man-pages)
@ 2021-04-04 20:17                 ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 10+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-04-04 20:17 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: mtk.manpages, linux-man, Mark Kettenis, Florian Weimer

On 4/4/21 10:16 PM, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
> 
> On 3/20/21 9:01 PM, Alejandro Colomar wrote:
>> ENODATA is an XSI STREAMS extension (not base POSIX).
>>
>> Linux reused the name for extended attributes.
>> The current manual pages don't use ENODATA with its POSIX
>> meaning, so use the xattr(7) specific text, and leave the POSIX
>> meaning for a secondary paragraph.
> 
> Thanks. Nice work on improving the patch!

Sorry -- and I meant to say: Patch applied.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-04 20:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 23:57 [PATCH] errno.3: ENODATA is an XSI STREAMS extension Alejandro Colomar
2021-03-20  9:58 ` Jakub Wilk
2021-03-20 11:41   ` Alejandro Colomar (man-pages)
2021-03-20 11:42     ` [PATCH v2] " Alejandro Colomar
2021-03-20 19:08       ` Florian Weimer
2021-03-20 19:31         ` Alejandro Colomar (man-pages)
2021-03-20 19:41           ` Florian Weimer
2021-03-20 20:01             ` [PATCH v3] errno.3: Fix ENODATA text Alejandro Colomar
2021-04-04 20:16               ` Michael Kerrisk (man-pages)
2021-04-04 20:17                 ` Michael Kerrisk (man-pages)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.